Remove unsupported option /arch:IA32 from x64 & ARM64 Release for Notepad++ project.
Define _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING for
SciLexer project to ignore a specific warning in third-party code.
Now the solution builds without warnings in all configurations.
Fix#10033, close#10034
Now Open dialog shows Open label on the button instead of Save.
Don't change any button labels.
Instead, get the leftmost button when overriding the window procedure.
Fix#9966, close#9973
In some cases, checkbox was found instead of OK button and window procedure was overriden for it. Now, the OK button is identified using style and label checks.
Also, in some cases IFileDialog::GetFileTypeIndex() returns the old value. To fix that, always remember the file type selected.
Fix#9939, close#9945
Resolves issue #4401 "Spanish translation: Search dialog items do not fit (translated texts too long)". Now the text fits the search dialog
Before:
<Item id="1703" name="&. se ajusta a línea nueva"/>
Now:
<Item id="1703" name="&. para nueva línea"/>
Fix#4401, close#9898
As at commit f7a04ca of this repo.
View of shortcuts:
Original: Display all shortcuts in form of `Example(X)`
Now: Display the shortcuts in English word, if any.
i.e. `E&xample`
Originally it is to follow the pattern of Taiwan translation.
However, the previous commit had added a lot of shortcuts.
It is better to adapt new strategy for the UI.
Close#9920
Usage:
void NPPM_ADDTOOLBARICON_FORDARKMODE(UINT funcItem[X]._cmdID, toolbarIconsWithDarkMode iconHandles)
This new API NPPM_ADDTOOLBARICON_FORDARKMODE is for replacing obsolete NPPM_ADDTOOLBARICON which doesn't support the dark mode.
2 formats / 3 icons are needed: 1 * BMP + 2 * ICO
All 3 handles below should be set so the icon will be displayed correctly if toolbar icon sets are changed by users, also in dark mode.
struct toolbarIconsWithDarkMode {
HBITMAP hToolbarBmp;
HICON hToolbarIcon;
HICON hToolbarIconDarkMode;
};
Close#9928
NPPM_ADDTOOLBARICON take structure
struct toolbarIcons {
HBITMAP hToolbarBmp;
HICON hToolbarIcon;
};
as argument, both hToolbarBmp & hToolbarIcon should not be null to take effect.
This reverts commit f249fc5902 due to a regression.
To reproduce the regression:
1. Ctrl+f and set to "Regular expression" as Search mode.
2. Press Shift+Ctrl+f to bring up "Find in Files".
3. Note that "Match whole word only" checkbox is missing, and cannot be made to appear.
Ref: #9766 & #9792
Functions defined at the top of the file or below a class with nothing in between would not show in the Function List.
This changes the function regex to fix this. A small unit test that the old regex won't pass but the new will included.
Close#9844
1. Add default dark theme.
2. Switch to default dark theme when dark mode is enabled considering both situations:
Style Configurator is or ont launched.
Close#9847
Make selected text with syntax highlighting as default behaviour.
To override the default behaviour, user can add an empty xml file named "enableSelectFgColor.xml" (beside of "config.xml") to set the select foreground color in Style Configurator.
Toolbar, status bar, tab bar, menu bar, dark scrollbar, handle switching between light and dark, docking splitters and headers, flicker fixes. Minor tweaks to DarkMode.h. Mostly handles the dark mode request for the main interface for #7692 and also follows the windows system theme settings like #9183.
Fix#9183, fix#7692, close#9587
IFileDialog doesn't modify the current directory unlike the old file
dialog. Now the last used directory is remembered each time the user
changes directory and then set as working directory if needed.
Fix#9767, close#9775
Add "Append extension" checkbox to Save As dialog for replacing option "Save dialog file extension filter to *.*" in Preferences dialog.
Fix#9515, close#9732
- added missing unittest for c
- added further function lists for ada, fortran, fortran77, haskell from previous PR of MAPJe71_functionlist_update3
- added simple rust function list
- unittest files from the internet probably no complex ones
- added to installer
Fix#9698, close#3393, close#9727
The workaround is: in case of UDL, "-lLANG" argument part is ignored.
We let new instance detect the user lang type via file extension - it works in the most of case, except if user applies an UDL manually.
For example, this workaround won't work under the following situation:
user applies Markdown to a file named "myMarkdown.abc".
Fix#3451
Added Edge to the same case as the other browsers, which substitutes spaces for %20, and opens the files as expected and add legacy edge as a backup in case the new edge isn't found.
Fix#9313, close#9677
Remove a workaround for double backslash that leads to problems.
Originally, the double backslash workaround was needed to address #5368.
But now, the app isn't stuck when such path is used, so the problem is gone.
Fix#9582, close#9666
Follow-up to these commits:
* Add an option to mute all sounds in preferences dialog (6e43ba6ea5)
* Make tab splitter menu and incremental search translatable (35584b379f)
Close#9559
This reverts commit 1364b199b4.
3 ways we can choose:
1. PerMonitorV2: it would be the ideal solution if there were no custom control in Notepad++ : some part of the custom controls like panels and Find dialog are not rendered properly in PerMonitorV2 mode.
2. PerMonitor: in v7.9.3 WM_DPICHANGED message was not processed and that makes Notepad++ unusable under a high resolution monitor.
3. Without "PerMonitor" feature: (as in v7.9.2), it will be a little bit blurry, but at least the system resizes all parts of application correctly
This commit revert the modification in v7.9.3 and go back to the way in v7.9.2 (Without "PerMonitor" feature).
It's not easy to solve this issue, all I can do is choose the "less worst" way, just like people in world-wide vote for choosing their political leader.
Fix#9513, fix#9579
During the installation, GUP localization file will be synchronized with Notepad++ chosen localization.
So updater will show the same installed language of Notepad++ in the dialogs if the language is avalable in GUP.
Improve file name parsing.
Use the absolute path to check if a file name is a directory.
Expand environment variables if they are part of the file name.
Avoid unnecessary calls to onPreFileOk().
Close#9467
Follow up to these commits:
* Make find/replace in files progress translatable (d6c941034d)
* Improve option for setting save dialog filter to All Types (d5ad02521e)
* Make 1 section name of Preferences more explicit (e26199ab51)
* Make "Save Folder as Workspace" in Save Session dialog translatable (41c4180b2e)
* Fix spelling inconsistencies
Close#9376
Rename ScitillaComponent -> ScintillaComponent.
Git history should be kept because `git mv` was used.
Also change paths in source code.
This was noted in scope of #9403Close#9450
And use modern CustomFileDialog istead of old FileDialog in Notepad++.
In the file dialog, override window procedure for "OK" button and
file name edit box to check for input.
Transform forward slash file name to a Window path after input.
Fix#9374, close#9403
Save snapshot session immediately when needed (without incuring delay by using ::PostMessage).
Fix#7839 and latest user reported problems in #6133.
Close#9427
When any of the Find window comboboxes are dropped and an entry is highlighted, pressing the Delete key will remove the highlighted entry from the following comboboxes:
1. Find what combobox
2. Replace with combobox
3. Directory combobox
4. Filters combobox
No method is provided for clearing all entries at once, but as the "depth" of the comboboxes is limited to a small amount, clearing one entry at a time (when one wants to clear all) is not overly burdensome.
Fix#9366, close#9396
Implements a fix whereby the RIGHTMOST user specified value in the vertical edge box is the column to split by, e.g. 60 in the following example: [15, 40, 60]
If the contents of the box were instead [15, 60, 40], the split-by column would be 40, as that is the RIGHTMOST value.
Fix#8262, close#9387
Add new methods to CustomFileDialog:
- setTitle() sets the dialog title
- setFolder() sets an initial directory
- pickFolder() shows a file open dialog to select a folder
Use CustomFileDialog in folderBrowser().
Affected areas:
- Search > Find in Files
- File > Open Folder as Workspace
- Preferences > Default Directory
- Preferences > Backup > Custom Backup
- Preferences > Cloud & Link
Fix#8513, close#9378
Save FileBrowser root folders if it is visible.
When loading a session file (from menu or via the command line),
launch a FileBrowser from scratch and add folders from the file to it.
When loading an auto-saved session, ignore saved FileBrowser folders.
Store roots and selected item of FileBrowser in a Session class.
Add "FileBrowser" node to session XML.
It containts "latestSelectedItem" attribute and "root" child nodes.
This structure corresponds to the one from "config.xml".
Current save session behavior for Folder as Workspace (FaW) is like this:
1. FaW isn't opened, checkbox is greyed-out -> FaW info is not saved in session
2. FaW is opened, checkbox isn't checked -> FaW info isn't saved in session
3. FaW is opened, checkbox is checked -> FaW info is saved in session
Load session behavior:
1. FaW isn't open, session without FaW info -> FaW isn't shown after loading
2. FaW isn't open, session with FaW info -> FaW is shown after loading
3. FaW is open, session without FaW info -> FaW is kept as is without changes
4. FaW is open, session with FaW info -> FaW is shown with new directories from session
Fix#9165, close#9286
1. Added xml syntax check via python script just for the win32 debug build because there already the functionlist check happens.
2. Fixed an issue found for perl.
Fix#9330, close#9339
Follow-up for these commits:
* Make UI text consistent regarding search results (f5dcfc196a)
Note: Diff of this PR is smaller than the commit above, but it's OK. Japanese translation was already translated correctly.
* Add ellipsis to Rename and Print on tab bar context menu (1961f708c1)
* Add tooltips for Folderas Workspace 3 commands (070630a243)
* Prevent names of untitled tabs from duplication (f75f8b8d40)
* Update English file with missing strings (a7f866b89e)
* Add context menu with "Copy link" ability (d155f0326a)
* Add GUI in preferences dialog for adding URI customized schemes (4b29971168)
* Create new Margin/Border/Edge sub-page in Preferences (053266c706)
* Add an option for displying constant line number width (c9c2d1e376)
* Make "Line" preceding each line number on Search Results translatable (e3455a0f7e)
* Make "total documents number" feature in Window dialog translatable (0546f75a71)
Close#9111
Enhance ghost typing command line argument feature by changing its format:
With it's new format -qX="string contains white space" (where X is 't', 'n' or 'f'), the white spaces can be contained between double quote, so no need to use %20 anymore for substituting white spacees.
Currently the settings directory could be:
1. Notepad++ installation dir if doLocalConf.xml is present.
2. %APPDATA%\Notepad++ if doLocalConf.xml is absent.
3. The path defined in \cloud\choice in Notepad++ installation or in %APPDATA%\Notepad++, it depends on the existence of doLocalConf.xml.
In this PR "-settingsDir" argument is added for overriding above settings paths:
4. Overrided by command line argument -settingsDir="E:\my NppSettings\" : All the above configurations will be ignored, Notepad++ will load (and write) config.xml and the other configuration xml files from (into) "E:\my NppSettings\". Note that double quotes is not necessary if there's no white space in the given path.
The priorities are: 1. -settingsDir 2. Cloud 3. %APPDATA%\Notepad++ or Notepad++ installation dir.
If the given path "E:\my NppSettings\" is not a valid directory (it doesn't exist or it's a file), this argument is ignored and the settings dir will fall back to Cloud (or to %APPDATA%\Notepad++ or Notepad++ installation dir, if settings on Cloud is not defined).
Close#4696, close#9287
1. Add an option for displying constant line number width in Preferences dialog.
This option set the line number constant width according the total line number in the document (minimun 4 digits).
It ensures no unexpected visual effect while scrolling content vertically.
If the document content is modified and the total number of lines is increased or decreased, more digits will be added or removed according the number of digits in total number of lines.
2. Add new plugin messages NPPM_GETLINENUMBERWIDTHMODE & NPPM_SETLINENUMBERWIDTHMODE for getting or setting LINENUMWIDTH_DYNAMIC / LINENUMWIDTH_CONSTANT.
So plugins may send NPPM_SETLINENUMBERWIDTHMODE message with LINENUMWIDTH_CONSTANT to Notepad++ for avoiding some unexpected visual effect (while scrolling).
Fix#5670
Folder images are changed in FileBrowser::notified() when TVN_ITEMEXPANDED
is recieved. This works fine when e.g. expand/collapse using "+" button.
However, when foldAll() or expandAll() are called on a TreeView,
the TVN_ITEMEXPANDED is not sent. The reason is that TVIS_EXPANDEDONCE flag
is set. To reset that flag, it would be needed to pass TVE_COLLAPSERESET
to TreeView_Expand that also removes all child items which is unwanted.
Resolve the problem by notifying TreeView parent manually when recieve
TVM_EXPAND and TVIS_EXPANDEDONCE is set.
Fix#8912
The new behaviour of loading function list will be:
1. For the installer package:
Try to load from %APPDATA%\Notepad++\functionList\, if it failed, then load from %PROGRAMFILES%\Notepad++\functionList\.
In this way, users can override function list in %APPDATA%\Notepad++\functionList\ manually. Otherwise, function list won't be empty.
2. For the portable package:
- with doLocalConf.xml : Load always from <Notepad++ Dir>\functionList\
- without doLocalConf.xml : Try to load from %APPDATA%\Notepad++\functionList\, if it failed, then load from <Notepad++ Dir>\functionList\
Fix#9134
#define NPPM_GETSETTINGSONCLOUDPATH (NPPMSG + 98)
// INT NPPM_GETSETTINGSCLOUDPATH(size_t strLen, TCHAR *settingsOnCloudPath)
// Get settings on cloud path. It's useful if plugins want to store its settings on Cloud, if this path is set.
// Returns the number of TCHAR copied/to copy. If the return value is 0, then this path is not set, or the "strLen" is not enough to copy the path.
// Users should call it with settingsCloudPath be NULL to get the required number of TCHAR (not including the terminating nul character),
// allocate settingsCloudPath buffer with the return value + 1, then call it again to get the path.
Close#9168
Use SCI_SETVISIBLEPOLICY and SCI_ENSUREVISIBLEENFORCEPOLICY to replace SCI_SETYCARETPOLICY.
X and Y caret policy should be user-configurable for document navigation and the VISIBLE / ENSUREVISIBLE could be used for application / auto navigation (like re-centering a search result).
Fix#8961, close#8962
The XML file is updated from v2.x to v3.2.0
in the commit: Edditoria/markdown-plus-plus@c137918
Also rename it shorter and starting with "m".
So users can sort their UDL file-list in tidy.
Close#9058
Close#8978
Follow up for these commits:
* Fix a shortcut causing a bug in Column editor dialog (55d671719c)
* Add "Open Containing Folder as Workspace" command (320aca73be)
* Add case insensitive lines sorting (61bf9bd3c4)
* Add alternative icon set for tab bar (79cf60f498)
* Make alternate icons of Tab bar changing dynamically (285172e36b)
* Add ability to copy marked text to the clipboard (9ab554a129)
* Add preference for save type of normal text files (bbde64c308)
* Add copy styled text to clipboard commands to menu (013305f306)
* Remove an obsolete command and its translation (9eecb1da13)
* Add ability to remove any duplicate lines... (77d4606967)
New "functionList" will be added beside of notepad++.exe or "%APPDATA%\Notepad++\", according the installation mode. If the portable package is used, after removing "doLocalConf.xml", the "functionList" folder should be copied manually from Notepad++ installed directory to "%APPDATA%\Notepad++\" to make function list work again.
All splited files are localized in this folder with the explicit language name.
"overrideMap.xml" is optional for overriding the default functionList parse rule files, and for adding UDL parse rule files.
Close#4896
Improve URL update on resize
The reason for the effect is, that the addHotSpot calls for resizing are in the WM_SIZE of the application. This works, as long as the size of the whole application changes, but not, when the application size remains constant and only the size of the document window inside the application changes.
The solution for this is, to remove the addHotSpot calls from the WM_SIZE of the application and add them to the DocTabView::reSizeTo function instead. Since addHotSpot cannot be called directly from this function, I took the detour over NPPM_INTERNAL_UPDATECLICKABLELINKS.
Fix#9032, close#9034
"wstring::length()" returns less needed byte number because this methode consider 2 bytes character as 1 character, whereas "strlen(char*)" returns the total byte number in the char*.
Since SCI_ADDTEXT uses UTF8 char* as argument, it'll be more accurate to count the length (total byte number) with char* directly.
Fix#9009, fix#8525, close#9014
This is an enhancement of PR #8475 which fixed (and still fixes) #8466.
It takes into account, that `WM_ACTIVATE` is not called only, when the window is being activated, but also, when the window is being **de**activated. In the latter case it is not necessary to do the activation actions.
This was pointed out to me by @Predelnik, who had a problem with the additional `SCN_UPDATEUI/SC_UPDATE_H_SCROLL` notification occurring when the window is being deactivated, see https://github.com/Predelnik/DSpellCheck/issues/221#issuecomment-696652074 for details.
The shortcut "&Format" in Column editor dialog is unecessary.
Furthermore, some characters 'o' are inserted in colomn mode when Alt-F is triggered (and Column editor dialog is closed).
- run unitTestLauncher.ps1 on win32 debug builds (release is not possible due to missing scintilla crypto signing)
- SciLexer.dll needs to be taken from an official build, because boost is required for functionlist to be functional
- slightly optimized test script, added timing traces
It's for #8762Close#8816
No selection:
Example: Pos : 1,234
Meaning: Single caret is at position 1233 in document (user position 1234)
Single stream selection (no change to existing behavior):
Example: Sel : 27 | 2
Meaning: 27 characters selected on 2 lines
Multiple stream selections (this PR behavior):
Example: Sel 3 : 72 | 6
Meaning: 3 selections of 72 characters on 6 lines
Rectangular selection with no virtual space in column block (this PR behavior):
Example: Sel : 2x4 = 8
Meaning: selection of 2 rows(lines) by 4 columns; 8 characters in that selection
Rectangular selection with some virtual space in column block (this PR behavior):
Example: Sel : 2x4 🡢 6
Meaning: selection of 2 rows(lines) by 4 columns; 6 real characters in that selection
Close#8524, close#8780
Ashfaaq18