prometheus

Commit Graph

Author	SHA1	Message	Date
Filip Petkovski	acb6c1ae4b	Fix decoding buckets for native histograms in binops The optimizer which detects cases where histogram buckets can be skipped does not take into account binary expressions. This can lead to buckets not being decoded if a metric is used with both histogram_fraction/quantile and histogram_sum/count in the same expression. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	5 months ago
beorn7	b5b04ddbe3	promql: add avg aggregation benchmark Signed-off-by: beorn7 <beorn@grafana.com>	5 months ago
beorn7	44d8c1d182	nit: add period at end of sentence Signed-off-by: beorn7 <beorn@grafana.com>	5 months ago
beorn7	9a837b7f3c	promql: Make groupedAggregation.groupCount a float64 It's always used as such. Let's avoid the countless conversions. Signed-off-by: beorn7 <beorn@grafana.com>	5 months ago
JuanJo Ciarlante	c94c5b64c3	feat: add limitk() and limit_ratio() operators (#12503 ) * rebase 2024-07-01, picks previous renaming to `limitk()` and `limit_ratio()` Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * gofumpt -d -extra Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * more lint fixes Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * more lint fixes+ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * put limitk() and limit_ratio() behind --enable-feature=promql-experimental-functions Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * EnableExperimentalFunctions for TestConcurrentRangeQueries() also Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * use testutil.RequireEqual to fix tests, WIP equivalent thingie for require.Contains Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * lint fix Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * moar linting Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * rebase 2024-06-19 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * re-add limit(2, metric) testing for N=2 common series subset Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move `ratio = param` to default switch case, for better readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * gofumpt -d -extra util/testutil/cmp.go Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * early break when reaching k elems in limitk(), should have always been so (!) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * small typo fix Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change small break-loop rearrange for readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove IsNan(ratio) condition in switch-case, already handled as input validation Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change adding some comments Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change simplify fullMatrix() helper functions used for tests Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add `limitk(-1, metric)` testcase, which is handled as any k < 1 case Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * engine_test.go: no-change create `requireCommonSeries() helper func (moving code into it) for readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * rebase 2024-06-21 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * engine_test.go: HAPPY NOW about its code -> reorg, create and use simpleRangeQuery() function, less lines and more readable ftW \o/ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move limitk(), limit_ratio() testing to promql/promqltest/testdata/limit.test Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove stale leftover after moving tests from engine_test.go to testdata/ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix flaky `limit_ratio(0.5, ...)` test case Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix AddRatioSample() implementation to use a single conditional (instead of switch/case + fallback return) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * docs/querying/operators.md: document r < 0 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add negative limit_ratio() example to docs/querying/examples.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move more extensive docu examples to docs/querying/operators.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * typo Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * small docu fix for poor-mans-normality-check, add it to limit.test ;) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * limit.test: expand "Poor man's normality check" to whole eval range Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * restore mistakenly removed existing small comment Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * expand poors-man-normality-check case(s) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Revert "expand poors-man-normality-check case(s)" This reverts commit f69e1603b2ebe69c0a100197cfbcf6f81644b564, indeed too flaky 0:) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove humor from docs/querying/operators.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix signoff Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add web/ui missing changes Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * expand limit_ratio test cases, cross-fingering they'll not be flaky Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove flaky test Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add missing warnings.Merge(ws) in instant-query return shortcut Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add missing LimitK\|\|LimitRatio case to codemirror-promql/src/parser/parser.ts Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix ui-lint Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * actually fix returned warnings :] Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> --------- Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> Co-authored-by: Julius Volz <julius.volz@gmail.com>	5 months ago
Ganesh Vernekar	3d54bcc018	Merge pull request #14362 from charleskorn/charleskorn/sum-infinity	5 months ago
Charles Korn	fd6bdf5230	Fix issue where summation of +/- infinity returns NaN instead of infinity Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Björn Rabenstein	2e58d46522	Merge pull request #13662 from prometheus/nhcb Native histograms custom buckets storage	5 months ago
Björn Rabenstein	19da579799	Merge pull request #12821 from rexagod/12769 parser: support underscores	5 months ago
Pranshu Srivastava	3c9e3ee552	parser: support underscores Support underscores in numbers, namely, decimals, hexadecimals, and exponentials. Fixes #12769 Signed-off-by: Pranshu Srivastava <rexagod@gmail.com> Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>	5 months ago
Bryan Boreham	b6aba4ff14	Merge pull request #14074 from bboreham/kahan-sum-sum [ENHANCEMENT] PromQL: use Kahan summation for sum()	5 months ago
🌲 Harry 🌊 John 🏔	d5f6887294	Pass limit param as hint to storage.Querier Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>	5 months ago
Jeanette Tan	dda5f48c9e	Merge branch 'main' into nhcb-review-2	5 months ago
Jeanette Tan	fc9dc72028	remove eval_with_nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Jeanette Tan	a6d788b1be	update missed suggested change from code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Bryan Boreham	84602bbace	Merge branch 'main' into fix-matcher-string-with-empty-label-name	5 months ago
Charles Korn	aeec30f082	Convert `TestTimestampFunction_StepsMoreOftenThanSamples` Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Charles Korn	987fa5c6a2	Convert range query test cases to test scripting language Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Oleg Zaytsev	03cf6141d4	Fix Matcher.String() with empty label name When the label name is empty, which can happen now with quoted label name, it should be quoted when printed as a string again. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	5 months ago
Björn Rabenstein	08621bebe9	Merge pull request #14269 from prometheus/beorn7/histogram-test promql: Add tests for histogram counter reset only in bucket	6 months ago
Jeanette Tan	b8cb12b989	rename hist to histogram according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	4c2aa872d4	update readme for testing framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	14f8dded39	Merge branch 'main' into nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	b0e320425c	refine test rewriting regex and add validation Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	9adc1699c3	fix according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Charles Korn	1f988f77ff	promql: extend test scripting language to support asserting on expected error message (#14038 ) Add ability to assert that a query fails with a particular error message This also adds documentation for the test scripting language in general, including the new feature. Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	6 months ago
beorn7	c7fdfe8004	promql: Add tests for histogram counter reset only in bucket This also exercises the "fast path" (only decoding count and sum), i.e. where the counter reset isn't visible at all in the decoded data. Signed-off-by: beorn7 <beorn@grafana.com>	6 months ago
Filip Petkovski	6e68046c25	Implement histogram statistics decoder (#14097 ) Implement histogram statistics decoder This commit speeds up histogram_count and histogram_sum functions on native histograms. The idea is to have separate decoders which can be used by the engine to only read count/sum values from histogram objects. This should help with reducing allocations when decoding histograms, as well as with speeding up aggregations like sum since they will be done on floats and not on histogram objects. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>	6 months ago
Charles Korn	24ef000025	Merge branch 'main' into sort-matrix-series # Conflicts: # promql/engine_test.go	6 months ago
Arve Knudsen	f3b8750339	Join errors Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	6 months ago
Arve Knudsen	7b56353090	Merge remote-tracking branch 'prometheus/main' into arve/query-logger-munmap	6 months ago
Björn Rabenstein	114dc5c393	Merge pull request #13638 from NeerajGartia21/promql-test Converts existing native histogram unit tests to the PromQL testing framework	6 months ago
Arve Knudsen	0f01d4b336	Fix flaky test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	6 months ago
Arve Knudsen	bf8d88f326	Merge remote-tracking branch 'origin/main' into arve/query-logger-munmap	6 months ago
Oleksandr Redko	f10c3454e9	Enable perfsprint linter and fix up code Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>	6 months ago
Björn Rabenstein	e6be4240be	Merge pull request #14068 from colega/quote-label-name-in-matchers-when-needed Bugfix: quote label name in matchers when needed	6 months ago
Jeanette Tan	f028496133	Merge branch 'main' into nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Neeraj Gartia	661856cb65	removes the added tests from engine_test.go Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	6119124d0e	some nits Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	adf5a36c1e	adds test for sum, count, stddev, stdvar, quantile and fraction func to promql testing framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	8b838a05d9	adds test for native histogram rate func in promql testing framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	548bd9d6fb	adds TestNativeHistogramRate func to promql test framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Charles Korn	0e934dba8e	Capture timing information while sorting Signed-off-by: Charles Korn <charles.korn@grafana.com>	6 months ago
Charles Korn	036c87223c	Ensure series in matrix values returned for instant queries are always sorted Signed-off-by: Charles Korn <charles.korn@grafana.com>	7 months ago
Charles Korn	a4381608a0	Add failing test case Signed-off-by: Charles Korn <charles.korn@grafana.com>	7 months ago
Bryan Boreham	ea82b49c33	[ENHANCEMENT] PromQL: use Kahan summation for sum() This can give a more precise result, by keeping a separate running compensation value to accumulate small errors. See https://en.wikipedia.org/wiki/Kahan_summation_algorithm Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Arve Knudsen	aabe4d6e4a	promql.ActiveQueryTracker: Unmap mmapped file when done Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	7 months ago
Bryan Boreham	3fd24d1cd7	Merge pull request #13999 from bboreham/extract-promqltest [Test] Extract most PromQL test code into separate packages	7 months ago
Bryan Boreham	786e0e706c	test: PromQL: stop using internal fields of engine * set enablePerStepStats and lookback duration via `NewTestEngine` parameters. * check maxSamples by recreating query engine * check lookback without modifying internals Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	0dbfd20b69	test: move most PromQL tests into separate test package So that they can import promqltest which imports promql. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	4a72607c4a	refactor: extract some PromQL Engine tests which use unexported structs Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	e7c77f7b40	promql: export NewTestQuery So that tests can call it from another package. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	babfcfdd91	refactor: Move NewTestEngine into promqltest And export `DefaultMaxSamplesPerQuery` so callers can replicate previous behaviour. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Oleg Zaytsev	dabd789fd5	Quote label name in matchers when needed When the label name of a matcher contains non-standard characters, like a dot, or starts with a digit, it should be quoted. If it's not quoted, then `VectorSelector.String()` isn't a valid PromQL. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
Bryan Boreham	b3c15d2246	test: clean up promqltest package references So it nearly compiles. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	9aa321d672	test: make field initializers explicit Lint started complaining after I moved the file. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	ccf73266f0	test: move promqltest tests together with the implementation Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	11b27d5d22	test: move test files into new promqltest package So that promql package does not bring in test-only dependencies. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	a6e427660a	test: check for @-modifier without using engine internals Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	2b0c87b1b6	test: turn TestKahanSum into scripted test This saves having a function solely to call kahanSumInc. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
Bryan Boreham	a1af3c27d4	refactor: extract almost.Equal() to new package To avoid a circular reference between promql and promqltest. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago
zenador	545a7e48f9	[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009 ) * process custom values in histogram unit test framework * check for warnings when evaluating in unit test framework * add test cases for custom buckets in test framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	7 months ago
Jeanette Tan	796b1bbfde	Merge branch 'main' into nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	7 months ago
Arve Knudsen	a25160e6a4	[REFACTOR] PromQL: simplify rangeEvalTimestampFunctionOverVectorSelector (#14021 ) The function `rangeEvalTimestampFunctionOverVectorSelector` appeared to be checking histogram size, however the value it used was always 0 due to subtle variable shadowing. However we don't need to pass sample values to the `timestamp` function, since the latter only cares about timestamps. This also affects peak sample count in statistics, since we are no longer copying histogram samples. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	7 months ago
Oleg Zaytsev	4b7a44c7a0	Fix `parser.VectorSelector.String()` with empty name matcher (#14015 ) The check fell into "this matcher equals vector selector's name" case when vector selector doesn't have a name and the matcher is an explicit matcher for an empty __name__ label. To provide some context about why this is important: some downstream projects use the promql.Parse(expr.String()) to clone an expression's AST, and with this bug that matcher disappears in the cloning. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>	7 months ago
guangwu	9fda9443d4	fix(promql/query_logger): close file in error handling (#13948 ) Signed-off-by: guoguangwu <guoguangwug@gmail.com>	7 months ago
György Krajcsovits	bcafa5f1f9	Merge remote-tracking branch 'upstream/main' into update-nhcb	7 months ago
zenador	81862aabd7	[nhcb branch] Add basic unit tests for native histograms with custom buckets converted from classic histograms (#13794 ) * modify unit test framework to automatically generate native histograms with custom buckets from classic histogram series * add very basic tests for classic histogram converted into native histogram with custom bounds * fix histogram_quantile for native histograms with custom buckets * make loading with nhcb explicit * evaluate native histograms with custom buckets on queries with explicit keyword * use regex replacer * use temp histogram struct for automatically loading converted nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	7 months ago
Owen Williams	4a6f8704ef	parser: remake generated_parser output (#13923 ) In a previous PR, the generated parser was created using an old version of goyacc. Also adds -l to disable line directives, which fixes debug processing and reduces diffs at the expense of making it more difficult to reason about the generated output. Signed-off-by: Owen Williams <owen.williams@grafana.com>	7 months ago
Neeraj Gartia	612de026da	Adds Inf and NaN as Numbers to Histogram in Promql Testing Framework (#13916 ) includes Inf and NaN as numbers to histogram --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	8 months ago
Matthieu MOREL	6f595c6762	golangci-lint: enable whitespace linter (#13905 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	8 months ago
Bryan Boreham	12961c6a37	promql: refactor: eliminate one 'else' Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	0ac927515b	promql: move group-seen into group struct Save allocating an auxilliary array. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	7499d90913	promql: remove pointer to aggregation groups Just allocate in one slice. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	cfbeb6681b	promql: re-use one heap for topk and bottomk Slightly ugly casting saves memory. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	5e3914a27c	promql: remove histogramMean from groupedAggregation Re-use histogramValue since we don't need them separately. Tidy up initialization. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	2cf3c9de8f	promql: store labels per-group only for count_values This saves memory in other kinds of aggregation. We don't need `orderedResult` in `aggregationCountValues`; the ordering is not guaranteed. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	185290a0d2	promql: pull checking of q and k out of loop Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	4584f67e17	promql: inline nextSample function Move Sample out of loop to reduce allocations, otherwise it escapes to the heap. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	526ce4ee7a	promql: simplify data collection in aggregations We don't need a Sample, just the float and histogram values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	2f03acbafc	promql: refactor: split topk/bottomk from sum/avg/etc They aggregate results in different ways. topk/bottomk don't consider histograms so can simplify data collection. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	74eed67ef6	promql: refactor: pull fetching input data out of rangeEvalAgg This is a cleaner split of responsibilities. We now check the sample count after calling rangeEvalAgg. Changed re-use of samples to use `Clone` and `defer`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	602eb69edf	promql: refactor: extract function nextSample With sub-function nextValues which we shall use shortly. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	eb41e770b7	promql: refactor: extract function addToSeries Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	53a3138eeb	promql aggregations: pre-generate mapping from inputs to outputs So we don't have to re-create it on every time step. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	cb6c4b3092	promql: simplify k/q parameter to topk/bottomk/quantile Pass it as a float64 not as interface{}. Make k a simple int, since that is the parameter to make(). Pull invalid quantile warning out of the loop. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	b3bda7df4b	promql: aggregations: skip copying input to a Vector We can work directly from the inputMatrix on each timestep. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	c9b6c4c55a	promql: aggregations: output directly to matrix for instant queries Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	3851b74db1	promql: aggregations: skip result vector in range queries Adjust test to match the lower count, since samples in the vector are no longer counted. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	59548b8a0b	promql: refactor: move collection of results into aggregation() We don't need to check for duplicates as aggregation cannot generate them. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	bd9bdccb22	promql: refactor: simplify internal data structures Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	5f10d17cef	promql: refactor: split out aggregations over range The new function `rangeEvalAgg` is mostly a copy of `rangeEval`, but without `initSeries` which we don't need and inlining the callback to `aggregation()`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	e5f667537c	promql: refactor: initialize aggregation before storing in map This seems more consistent to me. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	29244fb841	promql: refactor: extract count_values implementation The existing aggregation function is very long and covers very different cases. `aggregationCountValues` is just for `count_values`, which differs from other aggregations in that it outputs as many series per group as there are values in the input. Remove the top-level switch on string parameter type; use the same `Op` check there as elswehere. Pull checking parameters out to caller, where it is only executed once. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	8e04ab6dd4	promql: refactor: extract generateGroupingLabels function Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	7c28521451	[TESTS] Truncate some long test names, for readability The strings produced by these tests can run to thousands of characters, which makes test logs difficult to read. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Charles Korn	cd72ebb05f	promql: include more details in error message when creating test query fails or an unexpected series is returned (#13847 ) * promql: include more details in error message when creating test query fails Signed-off-by: Charles Korn <charles.korn@grafana.com> * Include more details when an unexpected metric is returned Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	8 months ago
Julius Volz	9b7de47787	Remove unused Dmn field on EvalNodeHelper (#13877 ) https://github.com/prometheus/prometheus/pull/13446 removed the last usage of this field, but didn't remove the field. Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
beorn7	65b4696b88	promql: Remove leftover debug output Signed-off-by: beorn7 <beorn@grafana.com>	8 months ago
beorn7	2c1f9558b2	promql: Fix histogram comparison in test framework The definition of histograms in the test framework may create histograms in a non-compact form. Since histogram comparison relies on exact equality of the bucket layout, we have to compact the histograms created by the test framework language before comparing them to histograms returned from the PromQL engine. Signed-off-by: beorn7 <beorn@grafana.com>	8 months ago

1 2 3 4 5 ...

1057 Commits (0f760f63dd5137ad406e0bc9f08676898e04ac97)