prometheus

Commit Graph

Author	SHA1	Message	Date
Björn Rabenstein	7fad1ec8ee	Merge pull request #14655 from suntala/suntala/sort-by-label-enhancement promql: Fall back to full label sets when sorting by label	3 months ago
Charles Korn	52818a97e2	Merge branch 'main' into sum-and-avg-over-mixed-custom-exponential-histograms # Conflicts: # promql/promqltest/testdata/native_histograms.test	3 months ago
György Krajcsovits	386fc8b9f6	Update from review comments. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	3 months ago
György Krajcsovits	6aee5b4b38	fix typo Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	3 months ago
György Krajcsovits	06a8886b94	Native histograms: define behavior when rate is null. Histogram quantile returns NaN in this case, which might be surprising, so add a unit test that clarifies that this is intentional. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>	3 months ago
suntala	fd2f44af7f	Fall back to comparing by label set when sorting by label desc Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com> Signed-off-by: suntala <arati.rana@grafana.com>	3 months ago
suntala	94ad489328	Fall back to comparing by label set when sorting by label Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com> Signed-off-by: suntala <arati.rana@grafana.com>	3 months ago
Charles Korn	f992f81bd0	Merge branch 'main' into sum-and-avg-over-mixed-custom-exponential-histograms Signed-off-by: Charles Korn <charleskorn@users.noreply.github.com>	4 months ago
Charles Korn	5cfdde327c	Address PR feedback: add extra test case Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Charles Korn	82bb35fabb	Address PR feedback: fix typo and rename variable Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Charles Korn	f07b3ae67b	Fix issue where `avg` over mixed exponential and custom buckets, or incompatible custom buckets, produces incorrect results or panics Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Charles Korn	5ee94f49a2	Fix issue where `sum` over mixed exponential and custom buckets, or incompatible custom buckets, produces incorrect results Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Charles Korn	424cefcf5e	Fix "cannot reduce resolution to custom buckets schema" panic in `rate` over native histograms with mix of custom and exponential buckets Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Charles Korn	f6e4b775e2	Check for errors first Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Björn Rabenstein	ee5bba07c0	Merge pull request #14413 from prometheus/beorn7/promql promql: more Kahan summation (avg) and less incremental mean calculation (avg, avg_over_time)	4 months ago
Charles Korn	aadec25faf	promql: Fix issue where some native histogram-related annotations are not emitted by `rate` (#14575 ) Signed-off-by: Charles Korn <charles.korn@grafana.com>	4 months ago
Björn Rabenstein	ca7062cf49	Merge pull request #14464 from prometheus/beorn7/histogram promql: Add NHCB tests	4 months ago
beorn7	c39776c5b5	promql: Add NHCB tests This adds equivalent NHCB tests to the existing classic histogram tests. Signed-off-by: beorn7 <beorn@grafana.com>	4 months ago
Filip Petkovski	cb8b6d7504	Allow built-in tests to be customized The RunBuiltinTests function accepts a concrete type which makes it hard to exclude certain tests from the suite. It would be great if we could skip tests which might not be critical in order to unblock updates. By accepting an interface instead, we can inject a custom implementation which would skips select test cases. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	5 months ago
beorn7	cff0429b1a	promql: make avg_over_time faster and more precise Same idea as for the avg aggregator before: Most of the time, there is no overflow, so we don't have to revert to the more expensive and less precise incremental calculation of the mean value. Signed-off-by: beorn7 <beorn@grafana.com>	5 months ago
beorn7	c46074f4dd	promql: make avg aggregation more precise and less expensive The basic idea here is that the previous code was always doing incremental calculation of the mean value, which is more costly and can be less precise. It protects against overflows, but in most cases, an overflow doesn't happen anyway. The other idea applied here is to expand on #14074, where Kahan summation was applied to sum(). With this commit, the average is calculated in a conventional way (adding everything up and divide in the end) as long as the sum isn't overflowing float64. This is combined with Kahan summation so that the avg aggregation, in most cases, is really equivalent to the sum aggregation with a following division (which is the user's expectation as avg is supposed to be syntactic sugar for sum with a following divison). If the sum hits ±Inf, the calculation reverts to incremental calculation of the mean value. Kahan summation is also applied here, although it cannot fully compensate for the numerical errors introduced by the incremental mean calculation. (The tests added in this commit would fail if incremental mean calculation was always used.) Signed-off-by: beorn7 <beorn@grafana.com>	5 months ago
darshanime	bd4ea118e9	Allow durations for number rule Signed-off-by: darshanime <deathbullet@gmail.com>	5 months ago
darshanime	cfad8ff3b2	Deprecate duration token Signed-off-by: darshanime <deathbullet@gmail.com>	5 months ago
darshanime	8c8860d2d6	Allow number literals as duration Signed-off-by: darshanime <deathbullet@gmail.com>	5 months ago
Filip Petkovski	acb6c1ae4b	Fix decoding buckets for native histograms in binops The optimizer which detects cases where histogram buckets can be skipped does not take into account binary expressions. This can lead to buckets not being decoded if a metric is used with both histogram_fraction/quantile and histogram_sum/count in the same expression. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	5 months ago
JuanJo Ciarlante	c94c5b64c3	feat: add limitk() and limit_ratio() operators (#12503 ) * rebase 2024-07-01, picks previous renaming to `limitk()` and `limit_ratio()` Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * gofumpt -d -extra Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * more lint fixes Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * more lint fixes+ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * put limitk() and limit_ratio() behind --enable-feature=promql-experimental-functions Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * EnableExperimentalFunctions for TestConcurrentRangeQueries() also Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * use testutil.RequireEqual to fix tests, WIP equivalent thingie for require.Contains Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * lint fix Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * moar linting Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * rebase 2024-06-19 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * re-add limit(2, metric) testing for N=2 common series subset Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move `ratio = param` to default switch case, for better readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * gofumpt -d -extra util/testutil/cmp.go Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * early break when reaching k elems in limitk(), should have always been so (!) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * small typo fix Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change small break-loop rearrange for readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove IsNan(ratio) condition in switch-case, already handled as input validation Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change adding some comments Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * no-change simplify fullMatrix() helper functions used for tests Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add `limitk(-1, metric)` testcase, which is handled as any k < 1 case Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * engine_test.go: no-change create `requireCommonSeries() helper func (moving code into it) for readability Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * rebase 2024-06-21 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * engine_test.go: HAPPY NOW about its code -> reorg, create and use simpleRangeQuery() function, less lines and more readable ftW \o/ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move limitk(), limit_ratio() testing to promql/promqltest/testdata/limit.test Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove stale leftover after moving tests from engine_test.go to testdata/ Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix flaky `limit_ratio(0.5, ...)` test case Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Update promql/engine.go Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix AddRatioSample() implementation to use a single conditional (instead of switch/case + fallback return) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * docs/querying/operators.md: document r < 0 Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add negative limit_ratio() example to docs/querying/examples.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * move more extensive docu examples to docs/querying/operators.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * typo Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * small docu fix for poor-mans-normality-check, add it to limit.test ;) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * limit.test: expand "Poor man's normality check" to whole eval range Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * restore mistakenly removed existing small comment Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * expand poors-man-normality-check case(s) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * Revert "expand poors-man-normality-check case(s)" This reverts commit f69e1603b2ebe69c0a100197cfbcf6f81644b564, indeed too flaky 0:) Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove humor from docs/querying/operators.md Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix signoff Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add web/ui missing changes Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * expand limit_ratio test cases, cross-fingering they'll not be flaky Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * remove flaky test Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add missing warnings.Merge(ws) in instant-query return shortcut Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * add missing LimitK\|\|LimitRatio case to codemirror-promql/src/parser/parser.ts Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * fix ui-lint Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> * actually fix returned warnings :] Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> --------- Signed-off-by: JuanJo Ciarlante <juanjosec@gmail.com> Co-authored-by: Julius Volz <julius.volz@gmail.com>	5 months ago
Ganesh Vernekar	3d54bcc018	Merge pull request #14362 from charleskorn/charleskorn/sum-infinity	5 months ago
Charles Korn	fd6bdf5230	Fix issue where summation of +/- infinity returns NaN instead of infinity Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Björn Rabenstein	2e58d46522	Merge pull request #13662 from prometheus/nhcb Native histograms custom buckets storage	5 months ago
Bryan Boreham	b6aba4ff14	Merge pull request #14074 from bboreham/kahan-sum-sum [ENHANCEMENT] PromQL: use Kahan summation for sum()	5 months ago
Jeanette Tan	dda5f48c9e	Merge branch 'main' into nhcb-review-2	5 months ago
Jeanette Tan	fc9dc72028	remove eval_with_nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Jeanette Tan	a6d788b1be	update missed suggested change from code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	5 months ago
Charles Korn	aeec30f082	Convert `TestTimestampFunction_StepsMoreOftenThanSamples` Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Charles Korn	987fa5c6a2	Convert range query test cases to test scripting language Signed-off-by: Charles Korn <charles.korn@grafana.com>	5 months ago
Björn Rabenstein	08621bebe9	Merge pull request #14269 from prometheus/beorn7/histogram-test promql: Add tests for histogram counter reset only in bucket	6 months ago
Jeanette Tan	b8cb12b989	rename hist to histogram according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	4c2aa872d4	update readme for testing framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	14f8dded39	Merge branch 'main' into nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	b0e320425c	refine test rewriting regex and add validation Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Jeanette Tan	9adc1699c3	fix according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Charles Korn	1f988f77ff	promql: extend test scripting language to support asserting on expected error message (#14038 ) Add ability to assert that a query fails with a particular error message This also adds documentation for the test scripting language in general, including the new feature. Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	6 months ago
beorn7	c7fdfe8004	promql: Add tests for histogram counter reset only in bucket This also exercises the "fast path" (only decoding count and sum), i.e. where the counter reset isn't visible at all in the decoded data. Signed-off-by: beorn7 <beorn@grafana.com>	6 months ago
Jeanette Tan	f028496133	Merge branch 'main' into nhcb Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
Neeraj Gartia	661856cb65	removes the added tests from engine_test.go Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	6119124d0e	some nits Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	adf5a36c1e	adds test for sum, count, stddev, stdvar, quantile and fraction func to promql testing framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	8b838a05d9	adds test for native histogram rate func in promql testing framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Neeraj Gartia	548bd9d6fb	adds TestNativeHistogramRate func to promql test framework Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>	6 months ago
Bryan Boreham	ea82b49c33	[ENHANCEMENT] PromQL: use Kahan summation for sum() This can give a more precise result, by keeping a separate running compensation value to accumulate small errors. See https://en.wikipedia.org/wiki/Kahan_summation_algorithm Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	7 months ago

1 2

56 Commits (0f760f63dd5137ad406e0bc9f08676898e04ac97)