Arthur Silva Sens
c5a832b394
Close resources after failing to startup TSDB ( #8031 )
...
* Close resources after failing to startup TSDB
Signed-off-by: arthursens <arthursens2005@gmail.com>
* Return close error instead of logging
Signed-off-by: arthursens <arthursens2005@gmail.com>
* Change named return's name
Signed-off-by: arthursens <arthursens2005@gmail.com>
4 years ago
Brian Brazil
fdf1c29224
Fix metric description of prometheus_tsdb_symbol_table_size_bytes. ( #8080 )
...
This is how much memory we use to load in the on-disk
symbol tables, not the size of the tables themselves.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
4 years ago
Ganesh Vernekar
ce4b3ac282
Simplify TestHeadReadWriter_Truncate ( #7437 )
...
* Simplify TestHeadReadWriter_Truncate
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix review comments
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Ganesh Vernekar
2624d827fa
Read repair empty last file in chunks_head ( #8061 )
...
* Read repair empty file in chunks_head
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Refactor and introduce repairLastChunkFile
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Attempt windows test fix
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix review comments
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix review comments
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Frederic Branczyk
3b08b2dabe
Merge pull request #8083 from metalmatze/mixin-jsonnet-absolute-import-paths
...
Use absolute jsonnet import paths
4 years ago
Ricky Pai
fa8722be4a
add link to circleci config in README ( #8089 )
...
Signed-off-by: Ricky Pai <rickyp999+github@gmail.com>
4 years ago
Matthias Loibl
13ba013a24
Use absolute jsonnet import paths
...
This should be the way forward when importing libraries in jsonnet. It's
closer to how Go imports look and makes it more obvious where packages
live.
This is not breaking anything, as the old imports were already symlinks
to the now directly used directories.
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
4 years ago
Bartlomiej Plotka
2fe1e9fa93
Create a checkpoint only at the end of Compact call ( #8067 )
...
* Create a checkpoint only at the end of Compact call
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix review comments
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix Bartek's offline reviews
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Introduce TruncateInMemory and TruncateWAL
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Small enhancements and test fixing attempts
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Fix tests
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Add TestOneCheckpointPerCompactCall
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Don't truncate WAL on block compaction
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Simplified the algo.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Better protection around calling truncateWAL, truncate WAL on Head compaction error
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Co-authored-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Ganesh Vernekar
d9cd913219
Add links to TSDB blog post series in tsdb/README.md ( #8078 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Julien Pivotto
59733b1a26
TSDB: use `blocks` instead of db.blocks in condition ( #8068 )
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Ganesh Vernekar
5de7d15879
Consistent naming and better names for fields in TSDB format docs ( #8077 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Julien Pivotto
8c9850c2bb
Remote: Do not collect non-initialized timestamp metrics ( #8060 )
...
* Remote: Do not collect non-initialized timestamp metrics
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Bartlomiej Plotka
9981b3f3ee
labels: Reduce allocated memory and latency of Hash method; Added tests. ( #8025 )
...
* labels: Reduce allocated memory by Hash method in edge cases; Added tests.
Old:
/tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$
goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/pkg/labels
BenchmarkLabels_Hash
BenchmarkLabels_Hash/typical_labels_under_1KB
BenchmarkLabels_Hash/typical_labels_under_1KB-12 5366161 259 ns/op 0 B/op 0 allocs/op
BenchmarkLabels_Hash/bigger_labels_over_1KB
BenchmarkLabels_Hash/bigger_labels_over_1KB-12 1700371 767 ns/op 2048 B/op 1 allocs/op
BenchmarkLabels_Hash/extremely_large_label_value_10MB
BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 356 3743115 ns/op 10523442 B/op 1 allocs/op
PASS
New:
/tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$
goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/pkg/labels
BenchmarkLabels_Hash
BenchmarkLabels_Hash/typical_labels_under_1KB
BenchmarkLabels_Hash/typical_labels_under_1KB-12 4758883 259 ns/op 0 B/op 0 allocs/op
BenchmarkLabels_Hash/bigger_labels_over_1KB
BenchmarkLabels_Hash/bigger_labels_over_1KB-12 3324492 357 ns/op 80 B/op 1 allocs/op
BenchmarkLabels_Hash/extremely_large_label_value_10MB
BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 1087 1083949 ns/op 9734 B/op 1 allocs/op
PASS
Process finished with exit code 0
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Addressed Kemal's comment.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Moved to v2 xxhash for improvements.
New:
/tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$ -test.benchtime 10s
goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/pkg/labels
BenchmarkLabels_Hash
BenchmarkLabels_Hash/typical_labels_under_1KB
BenchmarkLabels_Hash/typical_labels_under_1KB-12 53447894 221 ns/op 0 B/op 0 allocs/op
BenchmarkLabels_Hash/bigger_labels_over_1KB
BenchmarkLabels_Hash/bigger_labels_over_1KB-12 42341754 326 ns/op 0 B/op 0 allocs/op
BenchmarkLabels_Hash/extremely_large_label_value_10MB
BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 10000 1248546 ns/op 0 B/op 0 allocs/op
PASS
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Removed old xxhash package.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
* Pined minor version.
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
4 years ago
Björn Rabenstein
d49f267f76
Merge pull request #8054 from simonpasquier/improve-not-ingesting-samples-alert
...
documentation/prometheus-mixin: improve PrometheusNotIngestingSamples
4 years ago
Simon Pasquier
f381d8a9bd
documentation/prometheus-mixin: improve PrometheusNotIngestingSamples
...
The alert shouldn't fire when there's no target and no rule configured.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
4 years ago
Tobias Schmidt
77c1da8f9d
Reflect automatic docs publishing in the release process ( #8056 )
...
No more need to do anything manually for release docs.
Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
4 years ago
Ganesh Vernekar
4ed3ec7b46
More info in mmap error message ( #8058 )
...
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
4 years ago
Julien Pivotto
4596abee4d
Mixin: Ignore unset remote write timestamp ( #8046 )
...
* Mixin: Ignore unset remote write timestamp
This pull request ignores the zero value of highest_sent_timestamp_seconds
in Highest Timestamp In vs. Highest Timestamp Sent which just show that
remote write has not been successful yet.
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
frbimo
260cd84d8f
log on empty head compaction result ( #8037 )
...
Signed-off-by: frbimo <fr.bimo@gmail.com>
4 years ago
Gayathri Venkatesh
73e2ce1bd6
Do not ignore reload errors in compactHead ( #8051 )
...
* Modified unknownRefs to unknownRefs.Load()
Signed-off-by: GayathriVenkatesh <gayaa2010@gmail.com>
* Modified db.go
Signed-off-by: GayathriVenkatesh <gayaa2010@gmail.com>
* Revert "Modified unknownRefs to unknownRefs.Load()"
This reverts commit 79caf595fa9b9193878dc0dd9dec17d58851ae42.
Signed-off-by: GayathriVenkatesh <gayaa2010@gmail.com>
* Made changes to reload error in db.go
Signed-off-by: GayathriVenkatesh <gayaa2010@gmail.com>
4 years ago
Goutham Veeramachaneni
1cc02930b6
Implement series API query hint to not hit chunks ( #8050 )
...
Fixes https://github.com/prometheus/prometheus/issues/5547
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
4 years ago
Ling Jin
9145200842
tsdb: fix unkown ref in log ( #8048 )
...
Signed-off-by: JinLingChristopher <jinl1037@hotmail.com>
4 years ago
Bartlomiej Plotka
dee6ac274e
labels: Extra tests and comment for WithoutLabels method. ( #8024 )
...
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
4 years ago
Björn Rabenstein
71577e45eb
Merge pull request #8044 from prometheus/beorn7/metrics
...
Instrumentation: Report valid configs in the respective metrics from the beginning
4 years ago
Arthur Silva Sens
4f45e201cc
Promtool tsdb list now prints block sizes ( #7993 )
...
* promtool tsdb list now prints blocks' size
Signed-off-by: arthursens <arthursens2005@gmail.com>
4 years ago
beorn7
0f3c1bf6cf
Report valid configs in the respective metrics from the beginning
...
In #7399 , an early validity check of the config was introduced to
prevent the scenario where an invalid config is only detected after a
possibly very long startup procedure. However, the respective success
metrics are not updated after the initial validation so that the
success metrics suggest an invalid config. If the startup procedure,
like replaying the WAL, really takes very long, alerts about invalid
config will trigger.
This commit sets the succes metrics after initial validation. They
will be set again after the "real" config (re-)load, but that
shouldn't be a problem. The metric now truthfully represents whenever
the config was successfully loaded, no matter if the result was then
thrown away (because it was just for validation) or actually used.
Signed-off-by: beorn7 <beorn@grafana.com>
4 years ago
Jess G
90680b092c
Add a tsdb writer interface ( #7950 )
...
* add a tsdb writer interface
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* use block writer in tsdbutil block creator
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* pass thru context
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* use block writer in blockutil and also in tests
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* fix link err
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* add err handling for defer
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* add blockwriter test
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* mv initHead into NewBlockWriter, update tests
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
* use blocksize arg, make test more concise
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
4 years ago
Brian Brazil
cf273f21bb
Add a testcase for #8040 ( #8042 )
...
This was already fixed by #8013 , but add a test case anyway
in case the regexp engine changes in future.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
4 years ago
Frederic Branczyk
3240cf83f0
Merge pull request #8020 from brancz/cut-2.22.0-rc.0
...
*: Cut v2.22.0-rc.0
4 years ago
Frederic Branczyk
be137435be
*: Cut v2.22.0-rc.0
...
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
4 years ago
Frederic Branczyk
8703bc88cd
Merge pull request #8027 from brancz/v2.22-go-dep-update
...
*: Update dependencies
4 years ago
Frederic Branczyk
21a2e8c320
storage/remote/intern_test.go: Fix linting errors
...
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
4 years ago
Frederic Branczyk
b97a1bb7d1
web/ui/react-app/yarn.lock: Update UI dependencies
...
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
4 years ago
Frederic Branczyk
a58489857d
*: Update go dependencies
...
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
4 years ago
Frederic Branczyk
da3ea43242
Merge pull request #7976 from roidelapluie/tolerance
...
Introduce timestamp tolerance in scrapes
4 years ago
Siddhant Sinha
d9dcf2c90f
Fixes #7982 . Increase maxErrMsgLen value remote_write api ( #8017 )
...
Signed-off-by: Siddhant Sinha <sid.sinha94@gmail.com>
4 years ago
Julien Pivotto
be5ba1a62d
Fix wordings
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
4617d16b4b
Specify the removal
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
e2a2bf3c06
Add context
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
671f7c66e5
Adjust comment
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
627ff84599
Adjust flag
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
garanews
c38816828f
fix few typo ( #8023 )
...
Signed-off-by: garanews <puntogtg@tiscali.it>
4 years ago
Julien Pivotto
6b618ecf02
Better description
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
536dfb6234
Add an experimental, hidden flag
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Harold Dost
bf7c771f54
promql: Organize legacy tests into appropriate files ( #7989 )
...
* Separate tests into:
** Aggregators
** Functions
** Operators
** Selectors
* Remove simple files and place tests into other files.
* Eliminate some of the _over_time tests since there are already plenty of
edge cases present in the functions.test file.
Relates to #740
Signed-off-by: Harold Dost <harolddost@gmail.com>
4 years ago
Frederic Branczyk
6be3ebdfe7
Merge pull request #8015 from simonpasquier/bump-k8s-deps
...
Bump k8s dependencies + support k8s.io/klog/v2
4 years ago
Julien Pivotto
946819e16e
cmd/prometheus: Issue a warning on 32 bit archs ( #8012 )
...
* cmd/prometheus: Issue a warning on 32 bit archs
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Julien Pivotto
b90c7a55da
Simplify logic
...
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
4 years ago
Simon Pasquier
9bb3555fe4
cmd/prometheus: support k8s.io/klog/v2
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
4 years ago
Simon Pasquier
52c4da161f
Bump Kubernetes dependencies
...
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
4 years ago