prometheus

Commit Graph

Author	SHA1	Message	Date
Owen Williams	4a6f8704ef	parser: remake generated_parser output (#13923 ) In a previous PR, the generated parser was created using an old version of goyacc. Also adds -l to disable line directives, which fixes debug processing and reduces diffs at the expense of making it more difficult to reason about the generated output. Signed-off-by: Owen Williams <owen.williams@grafana.com>	8 months ago
Neeraj Gartia	612de026da	Adds Inf and NaN as Numbers to Histogram in Promql Testing Framework (#13916 ) includes Inf and NaN as numbers to histogram --------- Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	8 months ago
Matthieu MOREL	6f595c6762	golangci-lint: enable whitespace linter (#13905 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	8 months ago
Bryan Boreham	12961c6a37	promql: refactor: eliminate one 'else' Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	0ac927515b	promql: move group-seen into group struct Save allocating an auxilliary array. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	7499d90913	promql: remove pointer to aggregation groups Just allocate in one slice. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	cfbeb6681b	promql: re-use one heap for topk and bottomk Slightly ugly casting saves memory. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	5e3914a27c	promql: remove histogramMean from groupedAggregation Re-use histogramValue since we don't need them separately. Tidy up initialization. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	2cf3c9de8f	promql: store labels per-group only for count_values This saves memory in other kinds of aggregation. We don't need `orderedResult` in `aggregationCountValues`; the ordering is not guaranteed. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	185290a0d2	promql: pull checking of q and k out of loop Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	4584f67e17	promql: inline nextSample function Move Sample out of loop to reduce allocations, otherwise it escapes to the heap. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	526ce4ee7a	promql: simplify data collection in aggregations We don't need a Sample, just the float and histogram values. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	2f03acbafc	promql: refactor: split topk/bottomk from sum/avg/etc They aggregate results in different ways. topk/bottomk don't consider histograms so can simplify data collection. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	74eed67ef6	promql: refactor: pull fetching input data out of rangeEvalAgg This is a cleaner split of responsibilities. We now check the sample count after calling rangeEvalAgg. Changed re-use of samples to use `Clone` and `defer`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	602eb69edf	promql: refactor: extract function nextSample With sub-function nextValues which we shall use shortly. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	eb41e770b7	promql: refactor: extract function addToSeries Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	53a3138eeb	promql aggregations: pre-generate mapping from inputs to outputs So we don't have to re-create it on every time step. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	cb6c4b3092	promql: simplify k/q parameter to topk/bottomk/quantile Pass it as a float64 not as interface{}. Make k a simple int, since that is the parameter to make(). Pull invalid quantile warning out of the loop. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	b3bda7df4b	promql: aggregations: skip copying input to a Vector We can work directly from the inputMatrix on each timestep. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	c9b6c4c55a	promql: aggregations: output directly to matrix for instant queries Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	3851b74db1	promql: aggregations: skip result vector in range queries Adjust test to match the lower count, since samples in the vector are no longer counted. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	59548b8a0b	promql: refactor: move collection of results into aggregation() We don't need to check for duplicates as aggregation cannot generate them. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	bd9bdccb22	promql: refactor: simplify internal data structures Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	5f10d17cef	promql: refactor: split out aggregations over range The new function `rangeEvalAgg` is mostly a copy of `rangeEval`, but without `initSeries` which we don't need and inlining the callback to `aggregation()`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	e5f667537c	promql: refactor: initialize aggregation before storing in map This seems more consistent to me. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	29244fb841	promql: refactor: extract count_values implementation The existing aggregation function is very long and covers very different cases. `aggregationCountValues` is just for `count_values`, which differs from other aggregations in that it outputs as many series per group as there are values in the input. Remove the top-level switch on string parameter type; use the same `Op` check there as elswehere. Pull checking parameters out to caller, where it is only executed once. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	8e04ab6dd4	promql: refactor: extract generateGroupingLabels function Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Bryan Boreham	7c28521451	[TESTS] Truncate some long test names, for readability The strings produced by these tests can run to thousands of characters, which makes test logs difficult to read. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	8 months ago
Charles Korn	cd72ebb05f	promql: include more details in error message when creating test query fails or an unexpected series is returned (#13847 ) * promql: include more details in error message when creating test query fails Signed-off-by: Charles Korn <charles.korn@grafana.com> * Include more details when an unexpected metric is returned Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	8 months ago
Julius Volz	9b7de47787	Remove unused Dmn field on EvalNodeHelper (#13877 ) https://github.com/prometheus/prometheus/pull/13446 removed the last usage of this field, but didn't remove the field. Signed-off-by: Julius Volz <julius.volz@gmail.com>	8 months ago
beorn7	65b4696b88	promql: Remove leftover debug output Signed-off-by: beorn7 <beorn@grafana.com>	8 months ago
beorn7	2c1f9558b2	promql: Fix histogram comparison in test framework The definition of histograms in the test framework may create histograms in a non-compact form. Since histogram comparison relies on exact equality of the bucket layout, we have to compact the histograms created by the test framework language before comparing them to histograms returned from the PromQL engine. Signed-off-by: beorn7 <beorn@grafana.com>	8 months ago
Björn Rabenstein	b9a2a4e329	Merge pull request #13852 from prometheus/fix-hist-std-dev-var-negative Fix hist std dev var negative	8 months ago
Jeanette Tan	4f2df329bd	improve handling of empty buckets with infinite bounds in histogram std dev/var Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	8 months ago
Jeanette Tan	22d0f4f114	improve handling of negative bounds in histogram std dev/var Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	8 months ago
Domantas	435f330d0b	[BUGFIX] labels: don't modify original labels in DropMetricName (#13845 ) Restrict the capacity of first argument to `append()` to force an allocation. This is for the slice implementation only. Signed-off-by: Domantas Jadenkus <djadenkus@gmail.com>	8 months ago
Charles Korn	5cc97a1820	[tests]: extend test scripting language to support range queries (#13825 ) * Extract method to make it easier to test. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Remove superfluous interface definition. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add test cases for existing instant query functionality. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add support for testing range queries Signed-off-by: Charles Korn <charles.korn@grafana.com> * Expand test coverage for instant queries and clarify error when a float is returned but a histogram is expected (or vice versa) Signed-off-by: Charles Korn <charles.korn@grafana.com> * Improve error message formatting Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add test case for instant query command with invalid timestamp Signed-off-by: Charles Korn <charles.korn@grafana.com> * Fix linting warning. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Remove superfluous print statement and expected result Signed-off-by: Charles Korn <charles.korn@grafana.com> * Fix linting warning. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Add note about ordered range eval commands. Signed-off-by: Charles Korn <charles.korn@grafana.com> * Check that matrix results are always sorted by labels. Signed-off-by: Charles Korn <charles.korn@grafana.com> --------- Signed-off-by: Charles Korn <charles.korn@grafana.com>	8 months ago
Bryan Boreham	080d440bf8	Merge remote-tracking branch 'origin/main' into pr/13461	8 months ago
Bryan Boreham	773170f372	Merge pull request #13822 from dgl/promtool-test-errors promtool: Avoid using testify for user rule tests	8 months ago
Jeanette Tan	9d32754bc0	add unit tests with all negative values for histogram_stddev and var Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	8 months ago
David Leadbeater	7ec4a11472	promtool: Avoid using testify for user rule tests Using testify outside of unit tests results in panics rather than a useful error for the user. Fixes #13703 Signed-off-by: David Leadbeater <dgl@dgl.cx>	8 months ago
tdakkota	f6834c347a	promql: validate `label_join` destination label Signed-off-by: tdakkota <tanc13@yandex.ru>	8 months ago
Bartlomiej Plotka	312e3fd728	Merge pull request #13713 from charleskorn/query-engine-interface rules: allow using alternative PromQL engines for rule evaluation by callers using Prometheus as a lib.	9 months ago
Björn Rabenstein	af3618fd35	Merge pull request #13667 from prometheus/beorn7/promql Improve TestQueryStatistics and fix bugs exposed by it	9 months ago
Charles Korn	26262a1eb7	Remove unnecessary `SetQueryLogger` method on `QueryEngine` interface Signed-off-by: Charles Korn <charles.korn@grafana.com>	9 months ago
carrychair	856f6e49c8	fix function and struct name Signed-off-by: carrychair <linghuchong404@gmail.com>	9 months ago
beorn7	7f912db15a	promql: Fix limiting of extrapolation to negative values This is a bit tough to explain, but I'll try: `rate` & friends have a sophisticated extrapolation algorithm. Usually, we extrapolate the result to the total interval specified in the range selector. However, if the first sample within the range is too far away from the beginning of the interval, or if the last sample within the range is too far away from the end of the interval, we assume the series has just started half a sampling interval before the first sample or after the last sample, respectively, and shorten the extrapolation interval correspondingly. We calculate the sampling interval by looking at the average time between samples within the range, and we define "too far away" as "more than 110% of that sampling interval". However, if this algorithm leads to an extrapolated starting value that is negative, we limit the start of the extrapolation interval to the point where the extrapolated starting value is zero. At least that was the intention. What we actually implemented is the following: If extrapolating all the way to the beginning of the total interval would lead to an extrapolated negative value, we would only extrapolate to the zero point as above, even if the algorithm above would have selected a starting point that is just half a sampling interval before the first sample and that starting point would not have an extrapolated negative value. In other word: What was meant as a _limitation_ of the extrapolation interval yielded a _longer_ extrapolation interval in this case. There is an exception to the case just described: If the increase of the extrapolation interval is more than 110% of the sampling interval, we suddenly drop back to only extrapolate to half a sampling interval. This behavior can be nicely seen in the testcounter_zero_cutoff test, where the rate goes up all the way to 0.7 and then jumps back to 0.6. This commit changes the behavior to what was (presumably) intended from the beginning: The extension of the extrapolation interval is only limited if actually needed to prevent extrapolation to negative values, but the "limitation" never leads to _more_ extrapolation anymore. The difference is subtle, and probably it never bothered anyone. However, if you calculate a rate of a classic histograms, the old behavior might create non-monotonic histograms as a result (because of the jumps you can see nicely in the old version of the testcounter_zero_cutoff test). With this fix, that doesn't happen anymore. Signed-off-by: beorn7 <beorn@grafana.com>	9 months ago
Charles Korn	4e77e8e5ef	Allow using alternative PromQL engines for rule evaluation Signed-off-by: Charles Korn <charles.korn@grafana.com>	9 months ago
beorn7	f48c7a5503	promql: Add histograms to TestQueryStatistics Also, fix the bugs exposed by the tests. Signed-off-by: beorn7 <beorn@grafana.com>	9 months ago
beorn7	f46dd34982	promql: Add code comment Signed-off-by: beorn7 <beorn@grafana.com>	9 months ago

1 2 3 4 5 ...

935 Commits (7aacef9b42a275f7ad8f60a707abb6de2a5d1448)