2783 Commits (0b05dbeb216f878ab08aa6267c1a23eeaab240ce)

 

All Branches   

Search

Author	SHA1	Message	Date
James Phillips	0b05dbeb21	Merge pull request #1235 from wuub/master ... fix conflict between handleReload and antiEntropy critical sections	9 years ago
Wojciech Bederski	c4537ed26f	panic when unbalanced localState.Resume() is detected	9 years ago
Ryan Breen	1282a6ff95	Merge pull request #1242 from dwijnand/fix-typos ... Fix a bunch of typos.	9 years ago
Dale Wijnand	5a28ebcaa3	Fix a bunch of typos.	9 years ago
James Phillips	e029702e39	Merge pull request #1240 from hashicorp/sethvargo/link_warnings ... Fix link warnings	9 years ago
Seth Vargo	7b4dcad487	Fix link warnings	9 years ago
James Phillips	2f9ebdb135	Merge pull request #1187 from sfncook/enable_tag_drift_03 ... Enable tag drift 03	9 years ago
Shawn Cook	1f330add02	Doc changes in response to review.	9 years ago
Shawn Cook	598526eba2	Docs - add verbage to anti-entropy page.	9 years ago
Ryan Breen	0722c1521a	Merge pull request #1236 from scalp42/typos ... remove various typos	9 years ago
Anthony Scalisi	10e028d599	remove various typos	9 years ago
Shawn Cook	4caf049c4c	Update documentation for service definition	9 years ago
Ryan Breen	e347f20790	Merge pull request #1234 from jovandeginste/quote-variable ... Add quotes to locations in case pwd contains spaces	9 years ago
Wojciech Bederski	b014c0f91b	make Pause()/Resume()/isPaused() behave more like a semaphore ... see: https://github.com/hashicorp/consul/issues/1173 #1173 Reasoning: somewhere during consul development Pause()/Resume() and PauseSync()/ResumeSync() were added to protect larger changes to agent's localState. A few of the places that it tries to protect are: - (a *Agent) AddService(...) # part of the method - (c *Command) handleReload(...) # almost the whole method - (l *localState) antiEntropy(...)# isPaused() prevents syncChanges() The main problem is, that in the middle of handleReload(...)'s critical section it indirectly (loadServices()) calls AddService(...). AddService() in turn calls Pause() to protect itself against syncChanges(). At the end of AddService() a defered call to Resume() is made. With the current implementation, this releases isPaused() "lock" in the middle of handleReload() allowing antiEntropy to kick in while configuration reload is still in progress. Specifically almost all services and probably all check are unloaded when syncChanges() is allowed to run. This in turn can causes massive service/check de-/re-registration, and since checks are by default registered in the critical state, a majority of services on a node can be marked as failing. It's made worse with automation, often calling `consul reload` in close proximity on many nodes in the cluster. This change basically turns Pause()/Resume() into P()/V() of a garden-variety semaphore. Allowing Pause() to be called multiple times, and releasing isPaused() only after all matching/defered Resumes() are called as well. TODO/NOTE: as with many semaphore implementations, it might be reasonable to panic() if l.paused ever becomes negative.	9 years ago
Jo Vandeginste	a626ae1892	Add quotes to locations in case pwd contains spaces	9 years ago
Wojciech Bederski	24bc17eaa1	failing test showing that nested Pause()/Resume() release too early ... see: #1173 / https://github.com/hashicorp/consul/issues/1173	9 years ago
Shawn Cook	66fd8fb2a0	Rename EnableTagOverride and update formatting	9 years ago
Shawn Cook	d7ce0b3c6b	Remove debug lines	9 years ago
James Phillips	f5d7397a2a	Merge pull request #1233 from hashicorp/b-maint-test ... Adds missing token to maint unit test.	9 years ago
Shawn Cook	0b3faf6e4a	Merge remote-tracking branch 'hashicorp/master' into enable_tag_drift_03	9 years ago
James Phillips	27c59f7b30	Adds missing token to maint unit test.	9 years ago
Shawn Cook	35f276f25d	Add test cases TestAgentAntiEntropy_EnableTagDrift	9 years ago
Ryan Uber	897f8a3ed5	Update CHANGELOG.md	9 years ago
Ryan Uber	1908c16f53	Merge pull request #1230 from hashicorp/f-maintfix ... Respect tokens in maintenance mode	9 years ago
Ryan Uber	039938a7e0	agent: testing node/service maintenance using tokens	9 years ago
Ryan Uber	125d7fd4ee	agent: thread tokens through for maintenance mode	9 years ago
Ryan Breen	34f98f7bdf	Merge pull request #1222 from 42wim/node-aaaa-queries ... Allow AAAA queries for nodeLookup	9 years ago
Wim	0bc4d9322e	Allow AAAA queries for nodeLookup	9 years ago
Ryan Breen	446c640c17	Merge pull request #1217 from 42wim/fix-rfc2308-part3 ... No NXDOMAIN when the answer is empty	9 years ago
Ryan Breen	9d244051fc	Merge pull request #1218 from hashicorp/b-typo ... Fixes a typo in the telemetry docs.	9 years ago
James Phillips	1387aba91b	Fixes a typo in the telemetry docs.	9 years ago
Armon Dadgar	5cb6ab625e	Merge pull request #1214 from zendesk/fix_lock_race_2 ... lock.go: fix another race condition	9 years ago
James Phillips	69fc672938	Merge pull request #1216 from hashicorp/sethvargo/update_middleman ... Update Middleman	9 years ago
Seth Vargo	5da996067e	Update Middleman	9 years ago
Wim	2701bb5cc2	No NXDOMAIN when the answer is empty	9 years ago
Ryan Breen	80d26f9156	Merge pull request #1167 from railsguru/master ... Add -http-port option to change the HTTP API port	9 years ago
Ryan Uber	4e664da433	Merge pull request #1215 from hashicorp/f-ui-endpoint ... agent: Always enable the UI endpoints	9 years ago
Andy Lo-A-Foe	bb5422af14	Position it alphabetically	9 years ago
Andy Lo-A-Foe	00b906774b	Update agent options section on the website	9 years ago
Armon Dadgar	52a8a95af9	agent: Always enable the UI endpoints	9 years ago
Ryan Breen	1e5aa54ca3	Merge pull request #1194 from 42wim/fix-maxServiceResponses ... Limit the DNS responses after getting the NodeRecords (fixes 0 A/AAAA responses)	9 years ago
Michael S. Fischer	43ab372a18	lock.go: fix another race condition ... The previous fix to `consul lock` (commit 6875e8d) didn't completely eliminate the race that could occur if the lock was acquired around the same time SIGTERM was received: It was still possible for Run() to spawn the process via startChild() after killChild() had released the shared mutex. Now, when SIGTERM is received, we acquire a mutex that prevents spawning a new process and never release it. We've tested this fix pretty thoroughly and believe it completely resolves the issue.	9 years ago
Wim	4a1dc90cba	Limit the DNS responses after getting the NodeRecords	9 years ago
Ryan Breen	f41b79eff2	Merge pull request #1195 from 42wim/fix-rfc2308-part2 ... Return SOA/NXDOMAIN when the answer is empty	9 years ago
Ryan Breen	ae128ef30f	Merge pull request #1211 from kikitux/master ... add consul-do to community tools	9 years ago
Alvaro Miranda	54c9fd8403	Update downloads_tools.html.erb	9 years ago
Wim	369982270d	Return SOA/not found when the answer is empty	9 years ago
Ryan Breen	f3d6fef82b	Merge pull request #1213 from mainframe/nodefabric-patch-1 ... Adding NodeFabric reference to Community Tools	9 years ago
Andres Toomsalu	3e46d8a7fe	Adding NodeFabric reference to Community Tools	9 years ago
Alvaro Miranda	13b9ff6330	add consul-do to community tools ... adding consul-do Do something based on leadership status https://github.com/zeroXten/consul-do From README.md Useful for running cronjobs in HA mode. Run something like this on two or more servers: * * * * * /usr/bin/consul-do JOB-1 $(/bin/hostname) && /path/to/job1 */10 * * * * /usr/bin/consul-do JOB-2 $(/bin/hostname) && /path/to/job2 Only one of the servers will be elected leader and will therefore run the job. Should the leader fail, a follower will take over.	9 years ago