You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

beorn7 0f760f63dd lint: Revamp our linting rules, mostly around doc comments ... Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>		3 months ago
..
fuzz-data	textparse: Add fuzzing and fix bug caught	7 years ago
parser	lint: Revamp our linting rules, mostly around doc comments	3 months ago
promqltest	Merge pull request #14655 from suntala/suntala/sort-by-label-enhancement	3 months ago
bench_test.go	promql: add avg aggregation benchmark	5 months ago
engine.go	lint: Revamp our linting rules, mostly around doc comments	3 months ago
engine_internal_test.go	refactor: extract some PromQL Engine tests which use unexported structs	7 months ago
engine_test.go	Add unit test	4 months ago
functions.go	Merge pull request #14655 from suntala/suntala/sort-by-label-enhancement	3 months ago
functions_internal_test.go	Fix issue where summation of +/- infinity returns NaN instead of infinity	5 months ago
functions_test.go	test: move most PromQL tests into separate test package	7 months ago
fuzz.go	textparse: Implement `CreatedTimestamp()` in `openmetricsparse.go` (#14356)	4 months ago
fuzz_test.go	remove obsolete build tag	10 months ago
histogram_stats_iterator.go	Use CopyTo when resetting histogram in stats iterator	4 months ago
histogram_stats_iterator_test.go	Add more test cases	4 months ago
promql_test.go	feat: add limitk() and limit_ratio() operators (#12503)	5 months ago
quantile.go	Merge branch 'main' into nhcb	6 months ago
quantile_test.go	PromQL: ignore small errors for bucketQuantile (#13153)	1 year ago
query_logger.go	Join errors	6 months ago
query_logger_test.go	promql.ActiveQueryTracker: Unmap mmapped file when done	7 months ago
value.go	Optimize histogram iterators (#13340)	10 months ago
value_test.go	test: move most PromQL tests into separate test package	7 months ago