prometheus

Commit Graph

Author	SHA1	Message	Date
Bryan Boreham	fee61fbcbd	Merge pull request #15434 from tjhop/fix/query-logger-compounding-keys fix!: stop unbounded memory usage from query log	1 day ago
TJ Hoplock	3e24e84172	fix!: stop unbounded memory usage from query log Resolves: #15433 When I converted prometheus to use slog in #14906, I update both the `QueryLogger` interface, as well as how the log calls to the `QueryLogger` were built up in `promql.Engine.exec()`. The backing logger for the `QueryLogger` in the engine is a `util/logging.JSONFileLogger`, and it's implementation of the `With()` method updates the logger the logger in place with the new keyvals added onto the underlying slog.Logger, which means they get inherited onto everything after. All subsequent calls to `With()`, even in later queries, would continue to then append on more and more keyvals for the various params and fields built up in the logger. In turn, this causes unbounded growth of the logger, leading to increased memory usage, and in at least one report was the likely cause of an OOM kill. More information can be found in the issue and the linked slack thread. This commit does a few things: - It was referenced in feedback in #14906 that it would've been better to not change the `QueryLogger` interface if possible, this PR proposes changes that bring it closer to alignment with the pre-3.0 `QueryLogger` interface contract - reverts `promql.Engine.exec()`'s usage of the query logger to the pattern of building up an array of args to pass at once to the end log call. Avoiding the repetitious calls to `.With()` are what resolve the issue with the logger growth/memory usage. - updates the scrape failure logger to use the update `QueryLogger` methods in the contract. - updates tests accordingly - cleans up unused methods Builds and passes tests successfully. Tested locally and confirmed I could no longer reproduce the issue/it resolved the issue. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	2 days ago
Björn Rabenstein	bafb4d68de	Merge pull request #15431 from prometheus/beorn7/promql2 promql: Fix subqueries to be really left-open	4 days ago
beorn7	4b573e0521	promql: Fix subqueries to be really left-open Previously, we managed to get rid of the sample on the left bound later, so the problem didn't show up in the framework tests. But the subqueries were still evaluation with the sample on the left bound, taking space and showing up if returning the subquery result directly (without further processing through PromQL like in all the framework tests). Signed-off-by: beorn7 <beorn@grafana.com>	4 days ago
Bryan Boreham	c5d009d57f	Merge pull request #15393 from jan--f/prep-release-3.0.0 Prep release 3.0.0	2 weeks ago
Jan Fajerski	d541b3bbeb	prepare release 3.0.0 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Jan Fajerski	84396bf636	migration: add removal of AM v1 api Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Bryan Boreham	57a7a2939a	Merge pull request #15389 from jan--f/fix-appender-race-3.0 [BUGFIX] TSDB: Fix race on stale values in headAppender (#15322)	2 weeks ago
Julien	af2d67d28e	Merge pull request #15388 from roidelapluie/cpfixreload [cherry pick] Fix auto reload when a config file with a syntax error is reverted	2 weeks ago
Bryan Boreham	003a2270e9	[BUGFIX] TSDB: Fix race on stale values in headAppender (#15322 ) * [BUGFIX] TSDB: Fix race on stale values in headAppender Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Simplify Signed-off-by: Bryan Boreham <bjboreham@gmail.com> --------- Signed-off-by: Bryan Boreham <bjboreham@gmail.com> (cherry picked from commit `f42b37ff2f`)	2 weeks ago
Bryan Boreham	32e28a25bc	Merge pull request #15379 from fionaliao/fix-migration-guide docs: additional formatting fixes to 3.0 migration guide	2 weeks ago
Julien	b93aec077c	Fix auto reload when a config file with a syntax error is reverted When we had a syntax error but restored the old file, we did not re-trigger the config reload, so the config reload metric was showing that config reload was unsucessful. I made magic to handle logs in cmd/prometheus. For now it is a separate file so we can backport this easily. I will generalize the helper in another PR. Signed-off-by: Julien <roidelapluie@o11y.eu>	2 weeks ago
Fiona Liao	928e691bc6	Merge branch 'release-3.0' into fix-migration-guide Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	2 weeks ago
Bartlomiej Plotka	14f7a8e6ba	Merge pull request #15375 from jan--f/prep-release-3.0.0-rc.1 Prep release 3.0.0 rc.1	2 weeks ago
bwplotka	22eec4a390	Updated CHANGELOG.md Signed-off-by: bwplotka <bwplotka@gmail.com>	2 weeks ago
Bartlomiej Plotka	7311ce3c00	Update CHANGELOG.md Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	2 weeks ago
Jan Fajerski	60489308a1	Prepare v3.0.0-rc.1 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Jan Fajerski	3067d0bc2f	update CHANGELOG and migration guide Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	2 weeks ago
Bartlomiej Plotka	f4a26f8d83	Merge pull request #15384 from prometheus/otlp-utf8-from-main 3.0 Port: Allow UTF-8 characters in metric and label names as opt-in feature (plus config entry)	2 weeks ago
bwplotka	e08794c53f	Added config entry. Signed-off-by: bwplotka <bwplotka@gmail.com>	2 weeks ago
Arthur Silva Sens	55e34c8c5f	Allow UTF-8 characters in metric and label names as opt-in feature (#15258 ) * Allow UTF-8 characters in metric and label names as opt-in feature --------- Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	2 weeks ago
Bartlomiej Plotka	9df69049a1	Merge pull request #15382 from prometheus/bwplotka-patch-1 Update migration.md for TSDB storage upgrade	2 weeks ago
Bartlomiej Plotka	99cbdc113c	Update migration.md for TSDB storage upgrade Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	2 weeks ago
Fiona Liao	67764d7cfd	Better spacing for flags Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	2 weeks ago
Fiona Liao	b2fd5b7e45	Format PromQL section, replace table Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	2 weeks ago
Fiona Liao	962a3cd6be	Add backticks to fallback_scrape_protocol Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	2 weeks ago
Fiona Liao	ad8138a65d	Add newlines before code blocks Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	2 weeks ago
Ben Kochie	f701f4e236	Enable auto-gomaxprocs by default (#15376 ) Enable the `auto-gomaxprocs` feature flag by default. * Add command line flag `--no-auto-gomaxprocs` to disable. Signed-off-by: SuperQ <superq@gmail.com>	2 weeks ago
Ben Kochie	fb69a38e67	Enable auto-gomemlimit by default (#15373 ) * Enable auto-gomemlimit by default Enable the `auto-gomemlimit` feature flag by default. * Add command line flag `--no-auto-gomemlimit` to disable. --------- Signed-off-by: SuperQ <superq@gmail.com>	2 weeks ago
Alex Greenbank	d40b671cfe	Merge pull request #15357 from prometheus/alexg/fix-fallback-scrape-release-3.0 scrape: stop erroring on empty scrapes	2 weeks ago
alexgreenbank	e7c0d21a8b	add CHANGELOG entry Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>	3 weeks ago
alexgreenbank	6b09f094e1	scrape: stop erroring on empty scrapes Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>	3 weeks ago
Björn Rabenstein	704071d4c3	Merge pull request #15355 from roidelapluie/update-common-3 Update prometheus/common	3 weeks ago
Bryan Boreham	1ea35578ca	Merge pull request #15353 from fionaliao/fl/update-docs docs: formatting and typo fixes to 3.0 migration guide	3 weeks ago
Julien	5c05c89b8b	Update prometheus/common Signed-off-by: Julien <roidelapluie@o11y.eu>	3 weeks ago
Fiona Liao	54a3f5054c	docs: formatting and typo fixes to 3.0 migration guide Signed-off-by: Fiona Liao <fiona.liao@grafana.com>	3 weeks ago
Julius Volz	8bd1d73e53	Merge pull request #15341 from prometheus/fix/empty-metric-name-formatting-2 Fix selector / series formatting for empty metric names	3 weeks ago
Julius Volz	d19e749dc6	Fix selector / series formatting for empty metric names Fixes https://github.com/prometheus/prometheus/issues/15335 Signed-off-by: Julius Volz <julius.volz@gmail.com>	3 weeks ago
Jan Fajerski	1b2defa7a2	Merge pull request #15256 from jan--f/prep-release-3.0.0-rc.0 Release 3.0.0 rc.0	3 weeks ago
Jan Fajerski	1ac3ca9528	Release 3.0.0-rc.0 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>	3 weeks ago
Jan Fajerski	60da9b88a0	Merge pull request #15325 from prometheus/merge-main-into-3.0 Merge main into 3.0	3 weeks ago
Julius Volz	51866b9fee	Merge pull request #15244 from prometheus/utf8-web-ui-support Support UTF-8 metric names and labels in web UI	3 weeks ago
Alban Hurtaud	4b56af7eb8	Add hidden flag for the delayed compaction random time window (#14919 ) * Add hidden flag for the delayed compaction random time window Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * Update cmd/prometheus/main.go Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Alban Hurtaud <alban.hurtaud@amadeus.com> * Update cmd/prometheus/main.go Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Alban Hurtaud <alban.hurtaud@amadeus.com> * Update tsdb/db.go Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com> Signed-off-by: Alban Hurtaud <alban.hurtaud@amadeus.com> * Fix flag name according to review - add test for delay Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * Fix afer main rebase Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * Implement review comments Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> * Update generatedelaytest to try with limit values Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> --------- Signed-off-by: Alban HURTAUD <alban.hurtaud@amadeus.com> Signed-off-by: Alban Hurtaud <alban.hurtaud@amadeus.com> Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>	3 weeks ago
Bryan Boreham	a1a78a151d	Merge pull request #15316 from bboreham/revert-15141 Revert "Fix `MemPostings.Add` and `MemPostings.Get` data race (#15141)"	3 weeks ago
Arve Knudsen	7c4f877881	otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules. (#15314 ) * otlptranslator: Harmonize non-UTF8 sanitization w/ naming rules. Harmonize non-UTF8 sanitization w/ Prometheus naming rules. --------- Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	3 weeks ago
Bryan Boreham	2fbbfc3da8	Revert "Fix `MemPostings.Add` and `MemPostings.Get` data race (#15141 )" This reverts commit `50ef0dc954`. Memory allocation goes so high in Prombench that the system is unusable. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 weeks ago
Bryan Boreham	9700933d18	Merge pull request #15311 from prometheus/remove-55-rc [BUILD] React-app: replace 0.55.0-rc.0 with 0.55.0	3 weeks ago
Arthur Silva Sens	1a22b1d846	bugfix: Fix otlp translator switching colons to undescores (#15251 ) Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	3 weeks ago
Arthur Silva Sens	034d2b24bc	Fix typos in tests (#15312 ) Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>	3 weeks ago
Bryan Boreham	adcc873d51	[BUILD] React-app: replace 0.55.0-rc.0 with 0.55.0 Try to stop build errors. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 weeks ago

1 2 3 4 5 ...

14432 Commits (fee61fbcbd17b23895e7b768c889e20933c23d04) All Branches Search

14432 Commits (fee61fbcbd17b23895e7b768c889e20933c23d04)

All Branches