326 Commits (9fe8bcf4be00a7ebd73932df0cf39cc837cbb993)

Author	SHA1	Message	Date
Goutham Veeramachaneni	507790a357	Rework logging to use explicitly passed logger ... Mostly cleaned up the global logger use. Still some uses in discovery package. Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>	8 years ago
Goutham Veeramachaneni	baf5b0f0fc	Fix error where we look into the future. (#2829) ... * Fix error where we look into the future. So currently we are adding values that are in the future for an older timestamp. For example, if we have [(1, 1), (150, 2)] we will end up showing [(1, 1), (2,2)]. Further it is not advisable to call .At() after Next() returns false. Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in> * Retuen early if done Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in> * Handle Seek() where we reach the end of iterator Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in> * Simplify code Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>	8 years ago
Brian Brazil	220e78b9c3	Consider a series stale after 4.1 intervals with no data. ... To cover the cases where stale markers may not be available, we need to infer the interval and mark series stale based on that. As we're lacking stale markers this is less accurate, however it should be good enough for these cases. We need 4 intervals as if say we had data at t=0 and t=10, coming via federation. The next data point should be at t=20 however it could take up to t=30 for it actually to be ingested, t=40 for it to be scraped via federation and t=50 for it to be ingested. We then add 10% on to that for slack, as we do elsewhere.	8 years ago
Brian Brazil	c02c25d5ba	Allow peeking back further in buffer.	8 years ago
Brian Brazil	a5cf25743c	Move stalness check into a function	8 years ago
Brian Brazil	80b40e6d91	Add initial staleness handing to promql. ... For instant vectors, if "stale" is the newest sample ignore the timeseries. For range vectors, filter out "stale" samples. Make it possible to inject "stale" samples in promql tests.	8 years ago
Fabian Reinartz	6e804b3497	Merge branch 'master' into dev-2.0	8 years ago
Brian Brazil	fcc88f0e1e	query/query_range should return eval timestamp ... Query and query_range should return the timestamp at which an evaluation is performed, not the timestamp of the data. This is as that's what query range asked for, and we need to keep query consistent with that. Query for a matrix remains unchanged, returning the literal matrix.	8 years ago
Brian Brazil	517b81f927	Add timestamp() function. ... Make the timestamp of instant vectors be the timestamp of the sample rather than the evaluation. We were not using this anywhere, so this is safe. Add a function to return the timestamp of samples in an instant vector. Fixes #1557	8 years ago
Tom Wilkie	4d9b917d11	Instrument Prometheus with OpenTracing (#2554) ... * Use request.Context() instead of a global map of contexts. * Add some basic opentracing instrumentation on the query path. * Remove tracehandler endpoint.	8 years ago
Fabian Reinartz	0f3110487d	Merge remote-tracking branch 'origin/dev-2.0' into dev-2.0	8 years ago
Fabian Reinartz	73b8ff0ddc	Merge branch 'master' into dev-2.0	8 years ago
Brian Brazil	5c9a6ce747	Add license to files. ... This should fix CI for dev-2.0.	8 years ago
Jack Neely	896f951e68	Force buckets in a histogram to be monotonic for quantile estimation (#2610) ... * Force buckets in a histogram to be monotonic for quantile estimation The assumption that bucket counts increase monotonically with increasing upperBound may be violated during: * Recording rule evaluation of histogram_quantile, especially when rate() has been applied to the underlying bucket timeseries. * Evaluation of histogram_quantile computed over federated bucket timeseries, especially when rate() has been applied This is because scraped data is not made available to RR evalution or federation atomically, so some buckets are computed with data from the N most recent scrapes, but the other buckets are missing the most recent observations. Monotonicity is usually guaranteed because if a bucket with upper bound u1 has count c1, then any bucket with a higher upper bound u > u1 must have counted all c1 observations and perhaps more, so that c >= c1. Randomly interspersed partial sampling breaks that guarantee, and rate() exacerbates it. Specifically, suppose bucket le=1000 has a count of 10 from 4 samples but the bucket with le=2000 has a count of 7, from 3 samples. The monotonicity is broken. It is exacerbated by rate() because under normal operation, cumulative counting of buckets will cause the bucket counts to diverge such that small differences from missing samples are not a problem. rate() removes this divergence.) bucketQuantile depends on that monotonicity to do a binary search for the bucket with the qth percentile count, so breaking the monotonicity guarantee causes bucketQuantile() to return undefined (nonsense) results. As a somewhat hacky solution until the Prometheus project is ready to accept the changes required to make scrapes atomic, we calculate the "envelope" of the histogram buckets, essentially removing any decreases in the count between successive buckets. * Fix up comment docs for ensureMonotonic * ensureMonotonic: Use switch statement Use switch statement rather than if/else for better readability. Process the most frequent cases first.	8 years ago
Tom Wilkie	f0e8a5f37c	Add promql.ErrStorage, which is interpreted by the API as a 500.	8 years ago
Fabian Reinartz	c389193b37	Merge branch 'master' into dev-2.0	8 years ago
Fabian Reinartz	0ecd205794	promql: Use buffer pool for matrix allocations	8 years ago
Fabian Reinartz	b09b90a940	Correctly close querier on error, revendor tsdb	8 years ago
Goutham Veeramachaneni	6634984a38	Comments and Typo Fixes	8 years ago
Fabian Reinartz	9304179ef7	Merge branch 'master' into dev-2.0	8 years ago
Alex Somesan	18cd7246b5	Instrument query engine timings (#2418) ... * Instrument query engine statistics	8 years ago
Fabian Reinartz	5772f1a7ba	retrieval/storage: adapt to new interface ... This simplifies the interface to two add methods for appends with labels or faster reference numbers.	8 years ago
Fabian Reinartz	1d3cdd0d67	Merge branch 'master' into dev-2.0-rebase	8 years ago
Fabian Reinartz	035976b275	retrieval: handle not found error correctly	8 years ago
Fabian Reinartz	ad9bc62e4c	storage: extend appender and adapt it	8 years ago
André Carvalho	c43dfaba1c	Add max concurrent and current queries engine metrics (#2326) ... * Add max concurrent and current queries engine metrics This commit adds two metrics to the promql/engine: the number of max concurrent queries, as configured by the flag, and the number of current queries being served+blocked in the engine.	8 years ago
Fabian Reinartz	bc20d93f0a	storage: rename iterator value getters to At()	8 years ago
Fabian Reinartz	28f547bcc7	api/v1: fix tests, restore series queries	8 years ago
Fabian Reinartz	e94b0899ee	rules: fix tests, remove model types	8 years ago
Fabian Reinartz	f8fc1f5bb2	*: migrate ingestion to new batch Appender	8 years ago
Fabian Reinartz	71fe0c58a8	promql: misc fixes	8 years ago
Fabian Reinartz	fecf9532b9	*: fix misc compile errors	8 years ago
Fabian Reinartz	0492ddbd4d	*: fully decouple tsdb, add new storage interfaces	8 years ago
Fabian Reinartz	9ea10d5265	promql: use labels.Builder to modify labels	8 years ago
Fabian Reinartz	c6cd998905	promql: use local labels, add conversion	8 years ago
Fabian Reinartz	ff504af2aa	promql: undo accidental exports	8 years ago
Fabian Reinartz	6dedf89cc3	promql: rename SampleStream to Series	8 years ago
Fabian Reinartz	c5f225b920	promql: export Sample	8 years ago
Fabian Reinartz	65581a3d46	promql: export SmapleStream	8 years ago
Fabian Reinartz	6315d00942	promql: export String value	8 years ago
Fabian Reinartz	ac5d3bc05e	promql: scalar T/V and Point	8 years ago
Fabian Reinartz	09666e2e2a	promql: make scalar public	8 years ago
Fabian Reinartz	b3f71df350	promql: make matrix exported	8 years ago
Fabian Reinartz	a62df87022	promql: rename vector	8 years ago
Fabian Reinartz	15a931dbdb	promql: migrate model types, use tsdb interfaces	8 years ago
Tristan Colgate	ab60bc3929	Fix export of grouping modifier	8 years ago
Tristan Colgate	68fc15fe4e	Report type names in the form used in documentation	8 years ago
beorn7	4e3abc6cbf	Simply use `math.Mod(float64, float64)` after all ... This circumvents all the problems with int overflow, plus it is what was originally intended.	8 years ago
beorn7	5cf5bb427a	Check for int64 overflow when converting from float64	8 years ago
beorn7	92c0ef1a92	Merge branch 'release-1.2' into beorn7/release	8 years ago
beorn7	07f1bdfe94	Fix MOD binop for scalars and vectors ... Previously, a floating point number that would round down to 0 would cause a "division by zero" panic.	8 years ago
Brian Brazil	e1cfc994f7	Correctly handle on() in alerts. (#2096) ... Fixes #2082	8 years ago
Brian Brazil	c4b4a58e3a	Correctly handle on() in alerts. (#2096) ... Fixes #2082	8 years ago
Fabian Reinartz	8fa18d564a	storage: enhance Querier interface usage ... This extracts Querier as an instantiateable and closeable object rather than just defining extending methods of the storage interface. This improves composability and allows abstracting query transactions, which can be useful for transaction-level caches, consistent data views, and encapsulating teardown.	8 years ago
Fabian Reinartz	ccbce0c51f	promql: handle NaN in changes() correctly	8 years ago
Julius Volz	c187308366	storage: Contextify storage interfaces. ... This is based on https://github.com/prometheus/prometheus/pull/1997. This adds contexts to the relevant Storage methods and already passes PromQL's new per-query context into the storage's query methods. The immediate motivation supporting multi-tenancy in Frankenstein, but this could also be used by Prometheus's normal local storage to support cancellations and timeouts at some point.	8 years ago
Julius Volz	ed5a0f0abe	promql: Allow per-query contexts. ... For Weaveworks' Frankenstein, we need to support multitenancy. In Frankenstein, we initially solved this without modifying the promql package at all: we constructed a new promql.Engine for every query and injected a storage implementation into that engine which would be primed to only collect data for a given user. This is problematic to upstream, however. Prometheus assumes that there is only one engine: the query concurrency gate is part of the engine, and the engine contains one central cancellable context to shut down all queries. Also, creating a new engine for every query seems like overkill. Thus, we want to be able to pass per-query contexts into a single engine. This change gets rid of the promql.Engine's built-in base context and allows passing in a per-query context instead. Central cancellation of all queries is still possible by deriving all passed-in contexts from one central one, but this is now the responsibility of the caller. The central query context is now created in main() and passed into the relevant components (web handler / API, rule manager). In a next step, the per-query context would have to be passed to the storage implementation, so that the storage can implement multi-tenancy or other features based on the contextual information.	8 years ago
Tobias Schmidt	29ced0090f	Fix common english misspellings	8 years ago
Matt Bostock	a0201036fa	PromQL: Add tests for time/date funcs with arg ... Add tests for the date and time functions where an argument is specified. Suggested by @grobie: https://github.com/prometheus/prometheus/pull/1984#issuecomment-246508286 `1136239445` is the reference time used by Go: https://golang.org/src/time/format.go	8 years ago
Matt Bostock	9628eb5998	PromQL: Add minute() function ... Returns the minutes from the current time in UTC. Related to the `hour()` function. Fixes #1983.	8 years ago
Tobias Schmidt	04ae6196f2	Fix parsing of label names which are also keywords ... The current separation between lexer and parser is a bit fuzzy when it comes to operators, aggregators and other keywords. The lexer already tries to determine the type of a token, even though that type might change depending on the context. This led to the problematic behavior that no tokens known to the lexer could be used as label names, including operators (and, by, ...), aggregators (count, quantile, ...) or other keywords (for, offset, ...). This change additionally checks whether an identifier is one of these types. We might want to check whether the specific item identification should be moved from the lexer to the parser.	8 years ago
Fabian Reinartz	ab88057063	Merge pull request #1908 from prometheus/on-dates ... Add various time and date functions	8 years ago
Brian Brazil	4680daf237	Default date functions to current time.	8 years ago
Fabian Reinartz	23ddbd64aa	Merge pull request #1925 from hashmap/1898-test-race ... Fix data race in lexer and lexer test	8 years ago
Alexey Miroshkin	bf0e441576	Instantiate lexer inline for the test ... Don't use the lex constructor, remove the constructor introduced in the prevous commit.	8 years ago
Alexey Miroshkin	485f7dde08	Fix data race in lexer and lexer test ... As described in #1898 'go test -race' detects a race in lexer code. This pacth fixes it and also add '-race' option to test target to prevent regression.	8 years ago
beorn7	71571a8ec4	promql: Fix (and simplify) populating iterators ... This was only relevant so far for the benchmark suite as it would recycle Expr for repetitions. However, the append is unnecessary as each node is only inspected once when populating iterators, and population must always start from scratch. This also introduces error checking during benchmarks and fixes the so far undetected test errors during benchmarking. Also, remove a style nit (two golint warnings less…).	8 years ago
Brian Brazil	ea1318f38b	Short names of some date related functions	8 years ago
Brian Brazil	d2ca2b496a	Add days_in_month function.	8 years ago
Brian Brazil	0ed31c8c47	Sort list of functions.	8 years ago
Brian Brazil	fd7822829c	Add date related functions. ... Add day_of_month, day_of_week, hour_of_day, month_of_year and year. This only work for UTC, and ignore leap seconds the same as Go.	8 years ago
Fabian Stäber	08b6556ee6	Assume counters start at zero after reset.	8 years ago
Fabian Reinartz	98c0d33567	Merge pull request #1875 from brancz/idelta-function ... add idelta function	8 years ago
Frederic Branczyk	f02df4138c	refactor duplication of irate and idelta functions implementations	8 years ago
Frederic Branczyk	dbf83666bb	add idelta function ... similar to the irate function the idelta function calculates the delta function with the last two values	8 years ago
Frederic Branczyk	0ce5e7fe6d	move legacy test for delta function	8 years ago
Julius Volz	3bfec97d46	Make the storage interface higher-level. ... See discussion in https://groups.google.com/forum/#!topic/prometheus-developers/bkuGbVlvQ9g The main idea is that the user of a storage shouldn't have to deal with fingerprints anymore, and should not need to do an individual preload call for each metric. The storage interface needs to be made more high-level to not expose these details. This also makes it easier to reuse the same storage interface for remote storages later, as fewer roundtrips are required and the fingerprint concept doesn't work well across the network. NOTE: this deliberately gets rid of a small optimization in the old query Analyzer, where we dedupe instants and ranges for the same series. This should have a minor impact, as most queries do not have multiple selectors loading the same series (and at the same offset).	8 years ago
Brian Brazil	0303ccc6a7	Add quantile aggregator.	8 years ago
Brian Brazil	15f9fe0a45	Factor out quantile fucntion.	8 years ago
Brian Brazil	b0342ba9ec	Add quantile_over_time function	8 years ago
beorn7	fc6737b7fb	storage: improve index lookups ... tl;dr: This is not a fundamental solution to the indexing problem (like tindex is) but it at least avoids utilizing the intersection problem to the greatest possible amount. In more detail: Imagine the following query: nicely:aggregating:rule{job="foo",env="prod"} While it uses a nicely aggregating recording rule (which might have a very low cardinality), Prometheus still intersects the low number of fingerprints for `{__name__="nicely:aggregating:rule"}` with the many thousands of fingerprints matching `{job="foo"}` and with the millions of fingerprints matching `{env="prod"}`. This totally innocuous query is dead slow if the Prometheus server has a lot of time series with the `{env="prod"}` label. Ironically, if you make the query more complicated, it becomes blazingly fast: nicely:aggregating:rule{job=~"foo",env=~"prod"} Why so? Because Prometheus only intersects with non-Equal matchers if there are no Equal matchers. That's good in this case because it retrieves the few fingerprints for `{__name__="nicely:aggregating:rule"}` and then starts right ahead to retrieve the metric for those FPs and checking individually if they match the other matchers. This change is generalizing the idea of when to stop intersecting FPs and go into "retrieve metrics and check them individually against remaining matchers" mode: - First, sort all matchers by "expected cardinality". Matchers matching the empty string are always worst (and never used for intersections). Equal matchers are in general consider best, but by using some crude heuristics, we declare some better than others (instance labels or anything that looks like a recording rule). - Then go through the matchers until we hit a threshold of remaining FPs in the intersection. This threshold is higher if we are already in the non-Equal matcher area as intersection is even more expensive here. - Once the threshold has been reached (or we have run out of matchers that do not match the empty string), start with "retrieve metrics and check them individually against remaining matchers". A beefy server at SoundCloud was spending 67% of its CPU time in index lookups (fingerprintsForLabelPairs), serving mostly a dashboard that is exclusively built with recording rules. With this change, it spends only 35% in fingerprintsForLabelPairs. The CPU usage dropped from 26 cores to 18 cores. The median latency for query_range dropped from 14s to 50ms(!). As expected, higher percentile latency didn't improve that much because the new approach is _occasionally_ running into the worst case while the old one was _systematically_ doing so. The 99th percentile latency is now about as high as the median before (14s) while it was almost twice as high before (26s).	8 years ago
Brian Brazil	40f8da699e	Merge pull request #1815 from prometheus/stddev ... Add stddev_over_time and stdvar_over_time.	8 years ago
Brian Brazil	1edd6875f5	Add stddev_over_time and stdvar_over_time.	8 years ago
Fabian Reinartz	f8bb0ee91f	Merge pull request #1793 from prometheus/count_values ... Add count_values() aggregator.	9 years ago
Brian Brazil	875818d060	Clean out old keywords	9 years ago
Brian Brazil	16690736ab	Add count_values() aggregator. ... This is useful for counting how many instances of a job are running a particular version/build. Fixes #622	9 years ago
Brian Brazil	7f23a4a099	Add type check on topk/bottomk parameter.	9 years ago
Brian Brazil	fa9cc15573	Add topk/bottomk tests for multiple buckets.	9 years ago
Brian Brazil	3b0c182eee	Move topk/bottomk unittests over to aggregators.	9 years ago
Brian Brazil	3e5136e36d	Make topk/bottomk aggregators.	9 years ago
Fabian Reinartz	4d1985e405	Merge pull request #1778 from mattbostock/fix_annotations ... promql: Fix annotations conflated with labels	9 years ago
Matt Bostock	cc98e164d3	promql: Fix annotations conflated with labels ... When converting `AlertStmt` to a string, the alert rule labels were printed as `ANNOTATIONS` instead of the annotations themselves. Fix and add a test to catch future regressions.	9 years ago
Brian Brazil	3b89616d82	Allow on, ignoring, by and without wit empty laberls. ... This offers new semantics in allowing on() for matching two single-element vectors with no known common labels. Previosuly this was often done using on(dummy). This also allows making it explict that you meant to do an aggregation without labels via by(). Fixes #1597.	9 years ago
Brian Brazil	246a817300	Flip vector matching to be ignoring by default. ... This is a noop semantically.	9 years ago
Julius Volz	b7b6717438	Separate query interface out of local.Storage. ... PromQL only requires a much narrower interface than local.Storage in order to run queries. Narrower interfaces are easier to replace and test, too. We could also change the web interface to use local.Querier, except that we'll probably use appending functions from there in the future.	9 years ago
Fabian Reinartz	0e281f5500	Merge pull request #1687 from royels/issue-1629 ... Added power binop	9 years ago
royels	2fdc5717a3	promql: add power binary operation	9 years ago
Fatih Arslan	362e44501a	promql: fix printing annotations of an *AlertStmt ... Currently the printer doesn't print the annotations of an `*AlertStmt` declaration. I've added a test case as well, which fails for the current master.	9 years ago
beorn7	e3ec8fa83b	Merge branch 'release-0.19'	9 years ago
beorn7	5408666387	Correctly stringify GROUP_x modifiers without labels ... Since rule evaluations work via String(), this fixes evaluation of rules containing GROUP_x modifiers without labels. This change is the minimal bugfix (so that we can release a fixed version without risk). It does not intend to implement any additional features (like allowing `GROUP_LEFT()` or `ON()` or even `ON` - see discussion in https://github.com/prometheus/prometheus/issues/1597 ).	9 years ago