prometheus

Commit Graph

Author	SHA1	Message	Date
Chris Marchbanks	6508df8f57	Merge pull request #10395 from prometheus/csmarchbanks/fix-rw-deadlock-append Fix deadlock between adding to queue and getting batch	3 years ago
Chris Marchbanks	e970acb085	Fix deadlock between adding to queue and getting batch Do not block when trying to write a batch to the queue. This can cause appends to lock forever if the only thing reading from the queue needs the mutex to write. Instead, if batchQueue is full pop the sample that was just added from the partial batch and return false. The code doing the appending already handles retries with backoff. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	3 years ago
Chris Marchbanks	afdc1decac	Write a test that reproduces the deadlock Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	3 years ago
Björn Rabenstein	231dd0866e	Merge pull request #10401 from prometheus/beorn7/release Update containerd dependency	3 years ago
beorn7	5bf9a33651	Update containerd dependency Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Ganesh Vernekar	83032011a5	Cut v2.33.4 (#10337 ) Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	3 years ago
Ganesh Vernekar	24827782cb	Fix panics when m-mapping head chunks (#10316 ) * Fix panics when m-mapping head chunks Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix review comments Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix reviews Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	3 years ago
Julien Pivotto	56e14463bc	Release 2.33.3 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Julien Pivotto	002ceb7232	Fix panic in Azure SD when no public interface is set. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Julien Pivotto	b4714db0a6	Release 2.33.2 (#10286 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Chris Marchbanks	bfb1500a38	Fix deadlock when stopping a shard (#10279 ) If a queue is stopped and one of its shards happens to hit the batch_send_deadline at the same time a deadlock can occur where stop holds the mutex and will not release it until the send is finished, but the send needs the mutex to retrieve the most recent batch. This is fixed by using a second mutex just for writing. In addition, the test I wrote exposed a case where during shutdown a batch could be sent twice due to concurrent calls to queue.Batch() and queue.FlushAndShutdown(). Protect these with a mutex as well. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	3 years ago
Levi Harrison	1b3443ede1	Azure: Fix panic when IP Address isn't set (#10280 )	3 years ago
Björn Rabenstein	4e08110891	Merge pull request #10246 from prometheus/beorn7/release Cut v2.33.1	3 years ago
beorn7	7f57110fd0	Cut v2.33.1 Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Björn Rabenstein	1ba40dd4ec	Merge pull request #10235 from roidelapluie/ownnamespace Followup on k8s' "own namespace" feature	3 years ago
Julien Pivotto	9d63502204	k8s: improve 'own_namespace' Fail configuration unmarshalling if kubeconfig or api url are set with "own namespace" Only read namespace file if needed. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Georg Gadinger	c85efa02d9	Fix k8s target discovery when not running inside k8s When using Kubernetes service discovery on a Prometheus instance that's not running inside Kubernetes, the creation of the service discovery fails with a "no such file or directory" error as the special `/var/run/secrets/kubernetes.io/serviceaccount/namespace` file is not there. This commit moves the code that reads this file into the if-branch where no `APIServer.URL` is given (that one basically makes Prometheus assume it is running inside of a Kubernetes cluster). Signed-off-by: Georg Gadinger <nilsding@nilsding.org>	3 years ago
Björn Rabenstein	344a13d960	Merge pull request #10223 from prometheus/beorn7/release Cut v2.33.0	3 years ago
beorn7	ae8603ce34	Cut v2.33.0 Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	d27e7666cc	Bump client_golang to 1.12.1 This pulls in a data-race fix and reduces the excessive number of histogram buckets in the Go runtime metrics. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Björn Rabenstein	eb6022fbca	Merge pull request #10183 from prometheus/beorn7/release Cut v2.33.0-rc.1	3 years ago
beorn7	e00eefa376	Cut v2.33.0-rc.1 Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	ef5815f6f4	Bump github.com/prometheus/client_golang to v1.12.0 Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Björn Rabenstein	d38bb1cfec	Merge pull request #10182 from prometheus/nexucis/bump-kvsearch bump @nexucis/kvsearch to v0.4.0	3 years ago
Augustin Husson	b9f05e15f7	bump @nexucis/kvsearch to v0.4.0 Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Robert Fratto	b71a6dbbd1	tsdb/agent: Fix deadlock from simultaneous GC and write (#10166 ) * tsdb/agent: Fix deadlock from simultaneous GC and write This commit fixes a potential deadlock where storing in-memory series references could deadlock with a WAL GC cycle. Signed-off-by: Robert Fratto <robertfratto@gmail.com> * add missing license header Signed-off-by: Robert Fratto <robertfratto@gmail.com> * order local imports Signed-off-by: Robert Fratto <robertfratto@gmail.com> * align deadlock testing with discovery/manager_test.go method Also prevents GCs from running concurrently, which could also cause a deadlock (even though it's currently impossible for two GCs to run concurrently). Signed-off-by: Robert Fratto <robertfratto@gmail.com>	3 years ago
Mauro Stettler	bf959b36cb	Nits after PR 10051 merge (#10159 ) Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>	3 years ago
Björn Rabenstein	7e74557998	Merge pull request #10157 from prometheus/nexucis/debounce-search create a component to handle the search bar with debounce	3 years ago
Augustin Husson	74f497ac18	Update web/ui/react-app/src/pages/serviceDiscovery/Services.tsx Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Björn Rabenstein	de51e98128	Merge pull request #10156 from prometheus/beorn7/release Cut v2.33-rc.0	3 years ago
beorn7	c19e75f725	Cut v2.33-rc.0 Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Augustin Husson	b9bc8e7c33	create a component to handle the search bar with debounce Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Björn Rabenstein	933f50bcda	Merge pull request #10121 from prometheus/beorn7/promql PromQL: Promote negative offset and @ modifer to stable	3 years ago
Abhishek	2f4289a3bf	add limit to the rules api (#10152 )	3 years ago
Chris Marchbanks	eb7c10dbbd	Merge pull request #9274 from bboreham/improve-rw-sharding remote_write: shard up more when backlogged	3 years ago
beorn7	c2b80d8643	PromQL: Test negative offset in PromQL tests Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	b39f2739e5	PromQL: Always enable negative offset and @ modifier This follows the line of argument that the invariant of not looking ahead of the query time was merely emerging behavior and not a documented stable feature. Any query that looks ahead of the query time was simply invalid before the introduction of the negative offset and the @ modifier. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
dependabot[bot]	076109fa19	build(deps): bump github.com/aws/aws-sdk-go from 1.42.28 to 1.42.31 (#10146 ) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.42.28 to 1.42.31. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.42.28...v1.42.31) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 years ago
Ganesh Vernekar	129ed4ec8b	Fix Example() function in TSDB (#10153 ) * Fix Example() function in TSDB Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	3 years ago
beorn7	61509fc840	PromQL: Promote negative offset and @ modifer to stable Following the argument that breaking the invariant that PromQL does not look ahead of the evaluation time implies a breaking change, we still need to keep the feature flag around, but at least we can communicate that the feature is considered stable, and that the feature flags will be ignored from v3 on. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
dependabot[bot]	714bc3ff29	build(deps): bump google.golang.org/api from 0.63.0 to 0.64.0 (#10135 ) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.63.0 to 0.64.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](https://github.com/googleapis/google-api-go-client/compare/v0.63.0...v0.64.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	3 years ago
Augustin Husson	dd02675467	move dependabot frequency running to monthly (#10144 ) Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Augustin Husson	bff9d06874	Service Discovery Page rework (#10131 ) * rework the target page Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * put back the URL of the endpoint Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * replace old code by the new one and change function style Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * align filter and search bar on the same row Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * remove unnecessary return Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * upgrade kvsearch to v0.3.0 Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix unit test Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * add missing style on column Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * add placeholder and autofocus Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * put back the previous table design Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix issue relative to the position of the tooltip Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix health filter Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix test on label tooltip Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * simplify filter condition Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * rework service discovery page Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * introduced generic custom infinite scroll component Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * adjust the placeholder in discovery page Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * ignore returning type missing Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * apply fix required by the review Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * index discoveredLabels Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Björn Rabenstein	0f4a1e6eac	Merge pull request #10119 from prometheus/beorn7/remote API: Promote remote-write-receiver to stable	3 years ago
Augustin Husson	dd9f96b893	rework the target page (#10103 ) * rework the target page Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * put back the URL of the endpoint Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * replace old code by the new one and change function style Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * align filter and search bar on the same row Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * remove unnecessary return Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * upgrade kvsearch to v0.3.0 Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix unit test Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * add missing style on column Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * add placeholder and autofocus Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * put back the previous table design Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix issue relative to the position of the tooltip Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix health filter Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * fix test on label tooltip Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * simplify filter condition Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	3 years ago
Mauro Stettler	0df3489275	Write chunks via queue, predicting the refs (#10051 ) * Write chunks via queue, predicting the refs Our load tests have shown that there is a latency spike in the remote write handler whenever the head chunks need to be written, because chunkDiskMapper.WriteChunk() blocks until the chunks are written to disk. This adds a queue to the chunk disk mapper which makes the WriteChunk() method non-blocking unless the queue is full. Reads can still be served from the queue. Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * address PR feeddback Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * initialize metrics without .Add(0) Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * change isRunningMtx to normal lock Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * do not re-initialize chunkrefmap Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * update metric outside of lock scope Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * add benchmark for adding job to chunk write queue Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * remove unnecessary "success" var Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * gofumpt -extra Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * avoid WithLabelValues call in addJob Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * format comments Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * addressing PR feedback Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * rename cutExpectRef to cutAndExpectRef Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * use head.Init() instead of .initTime() Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * address PR feedback Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * PR feedback Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * update test according to PR feedback Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * replace callbackWg -> awaitCb Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * better test of truncation with empty files Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * replace callbackWg -> awaitCb Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	3 years ago
Bryan Boreham	954c0e8020	remote_write: round desired shards up before check Previously we would reject an increase from 2 to 2.5 as being within 30%; by rounding up first we see this as an increase from 2 to 3. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	6d01ce8c4d	remote_write: shard up more when backlogged Change the coefficient from 1% to 5%, so instead of targetting to clear the backlog in 100s we target 20s. Update unit test to reflect the new behaviour. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	d588b14d9c	remote_write: detailed test for shard calculation Drive the input parameters to `calculateDesiredShards()` very precisely, to illustrate some questionable behaviour marked with `?!`. See https://github.com/prometheus/prometheus/issues/9178, https://github.com/prometheus/prometheus/issues/9207, Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
chenlujjj	2ce94ac196	Add '--weight' flag to 'promtool check metrics' command (#10045 )	3 years ago

1 2 3 4 5 ...

9713 Commits (6508df8f5795a8b2ba97b93aa460c791349f54a3) All Branches Search

9713 Commits (6508df8f5795a8b2ba97b93aa460c791349f54a3)

All Branches