minor fixes

Fix lint errors.
No need to pre-allocate exemplars.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
pull/14978/head
György Krajcsovits 2 months ago
parent fbbf10baad
commit f3c8ed2947

@ -28,7 +28,7 @@ import (
"github.com/prometheus/prometheus/util/convertnhcb" "github.com/prometheus/prometheus/util/convertnhcb"
) )
var labelsMismatchError = errors.New("labels mismatch") var errLabelsMismatch = errors.New("labels mismatch")
type NHCBParser struct { type NHCBParser struct {
// The parser we're wrapping. // The parser we're wrapping.
@ -82,7 +82,6 @@ func NewNHCBParser(p Parser, keepClassicHistograms bool) Parser {
parser: p, parser: p,
keepClassicHistograms: keepClassicHistograms, keepClassicHistograms: keepClassicHistograms,
tempNHCB: convertnhcb.NewTempHistogram(), tempNHCB: convertnhcb.NewTempHistogram(),
tempExemplars: make([]exemplar.Exemplar, 0, 1),
} }
} }
@ -212,7 +211,7 @@ func (p *NHCBParser) compareLabels() bool {
} else { } else {
p.lastBaseHistLabels = labels.EmptyLabels() p.lastBaseHistLabels = labels.EmptyLabels()
} }
return labelsMismatchError return errLabelsMismatch
} }
case l.Value != p.lastBaseHistLabels.Get(l.Name): case l.Value != p.lastBaseHistLabels.Get(l.Name):
// Different label value. // Different label value.
@ -221,11 +220,11 @@ func (p *NHCBParser) compareLabels() bool {
} else { } else {
p.lastBaseHistLabels = labels.EmptyLabels() p.lastBaseHistLabels = labels.EmptyLabels()
} }
return labelsMismatchError return errLabelsMismatch
} }
return nil return nil
}) })
return err == labelsMismatchError return errors.Is(err, errLabelsMismatch)
} }
// Save the label set of the classic histogram without suffix and bucket `le` label. // Save the label set of the classic histogram without suffix and bucket `le` label.

Loading…
Cancel
Save