Browse Source

storage/remote: document why two benchmarks are skipped

One was silently doing nothing; one was doing something but the work
didn't go up linearly with iteration count.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
pull/13499/head
Bryan Boreham 10 months ago
parent
commit
b9fdf3dad1
  1. 2
      storage/remote/queue_manager_test.go
  2. 1
      storage/remote/write_handler_test.go

2
storage/remote/queue_manager_test.go

@ -924,7 +924,7 @@ func BenchmarkSampleSend(b *testing.B) {
func BenchmarkStartup(b *testing.B) { func BenchmarkStartup(b *testing.B) {
dir := os.Getenv("WALDIR") dir := os.Getenv("WALDIR")
if dir == "" { if dir == "" {
return b.Skip("WALDIR env var not set")
} }
// Find the second largest segment; we will replay up to this. // Find the second largest segment; we will replay up to this.

1
storage/remote/write_handler_test.go

@ -204,6 +204,7 @@ func TestCommitErr(t *testing.T) {
} }
func BenchmarkRemoteWriteOOOSamples(b *testing.B) { func BenchmarkRemoteWriteOOOSamples(b *testing.B) {
b.Skip("Not a valid benchmark (does not count to b.N)")
dir := b.TempDir() dir := b.TempDir()
opts := tsdb.DefaultOptions() opts := tsdb.DefaultOptions()

Loading…
Cancel
Save