Merge pull request #5146 from tariq1890/ineff

fix ineffectual assignment in dns.go
6 years ago · a2ef8cf2f5
parent 63f375e80a b173de0c26
commit a2ef8cf2f5
1 changed files with 1 additions and 1 deletions
--- a/discovery/dns/dns.go
+++ b/discovery/dns/dns.go
@ -178,7 +178,7 @@ func (d *Discovery) refresh(ctx context.Context, name string, ch chan<- []*targe
 	}

 	for _, record := range response.Answer {
-		target := model.LabelValue("")
+		var target model.LabelValue
 		switch addr := record.(type) {
 		case *dns.SRV:
 			// Remove the final dot from rooted DNS names to make them look more usual.