Browse Source

otlp translator: Add test showing bugs

Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
pull/15249/head
Arthur Silva Sens 3 weeks ago
parent
commit
8588289c24
No known key found for this signature in database
  1. 45
      storage/remote/otlptranslator/prometheus/normalize_label_test.go
  2. 1
      storage/remote/otlptranslator/prometheus/normalize_name_test.go

45
storage/remote/otlptranslator/prometheus/normalize_label_test.go

@ -0,0 +1,45 @@
// Copyright 2024 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package prometheus
import (
"fmt"
"testing"
"github.com/stretchr/testify/require"
)
func TestNormalizeLabel(t *testing.T) {
tests := []struct {
label string
expected string
}{
{"", ""},
{"label:with:colons", "label_with_colons"}, // Without UTF-8 support, colons are only allowed in metric names
{"LabelWithCapitalLetters", "LabelWithCapitalLetters"},
{"label!with&special$chars)", "label_with_special_chars_"},
{"label_with_foreign_characteres_字符", "label_with_foreign_characteres___"},
{"label.with.dots", "label_with_dots"},
{"123label", "key_123label"},
{"_label_starting_with_underscore", "key_label_starting_with_underscore"},
{"__label_starting_with_2underscores", "__label_starting_with_2underscores"},
}
for i, test := range tests {
t.Run(fmt.Sprintf("test_%d", i), func(t *testing.T) {
result := NormalizeLabel(test.label)
require.Equal(t, test.expected, result)
})
}
}

1
storage/remote/otlptranslator/prometheus/normalize_name_test.go

@ -202,4 +202,5 @@ func TestBuildCompliantNameWithoutSuffixes(t *testing.T) {
require.Equal(t, ":foo::bar", BuildCompliantName(createCounter(":foo::bar", ""), "", false))
require.Equal(t, "foo_bar", BuildCompliantName(createGauge("foo.bar", "1"), "", false))
require.Equal(t, "system_io", BuildCompliantName(createCounter("system.io", "foo/bar"), "", false))
require.Equal(t, "metric_with___foreign_characteres", BuildCompliantName(createCounter("metric_with_字符_foreign_characteres", ""), "", false))
}

Loading…
Cancel
Save