|
|
|
// Copyright 2017 The Prometheus Authors
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package tsdb
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"crypto/rand"
|
|
|
|
"fmt"
|
|
|
|
"io"
|
|
|
|
"math"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"sort"
|
|
|
|
"time"
|
|
|
|
|
|
|
|
"github.com/go-kit/kit/log"
|
|
|
|
"github.com/go-kit/kit/log/level"
|
|
|
|
"github.com/oklog/ulid"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
|
|
"github.com/prometheus/prometheus/pkg/labels"
|
|
|
|
"github.com/prometheus/prometheus/storage"
|
|
|
|
"github.com/prometheus/prometheus/tsdb/chunkenc"
|
|
|
|
"github.com/prometheus/prometheus/tsdb/chunks"
|
|
|
|
tsdb_errors "github.com/prometheus/prometheus/tsdb/errors"
|
|
|
|
"github.com/prometheus/prometheus/tsdb/fileutil"
|
|
|
|
"github.com/prometheus/prometheus/tsdb/index"
|
|
|
|
"github.com/prometheus/prometheus/tsdb/tombstones"
|
|
|
|
)
|
|
|
|
|
|
|
|
// ExponentialBlockRanges returns the time ranges based on the stepSize.
|
|
|
|
func ExponentialBlockRanges(minSize int64, steps, stepSize int) []int64 {
|
|
|
|
ranges := make([]int64, 0, steps)
|
|
|
|
curRange := minSize
|
|
|
|
for i := 0; i < steps; i++ {
|
|
|
|
ranges = append(ranges, curRange)
|
|
|
|
curRange = curRange * int64(stepSize)
|
|
|
|
}
|
|
|
|
|
|
|
|
return ranges
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compactor provides compaction against an underlying storage
|
|
|
|
// of time series data.
|
|
|
|
type Compactor interface {
|
|
|
|
// Plan returns a set of directories that can be compacted concurrently.
|
|
|
|
// The directories can be overlapping.
|
|
|
|
// Results returned when compactions are in progress are undefined.
|
|
|
|
Plan(dir string) ([]string, error)
|
|
|
|
|
|
|
|
// Write persists a Block into a directory.
|
|
|
|
// No Block is written when resulting Block has 0 samples, and returns empty ulid.ULID{}.
|
|
|
|
Write(dest string, b BlockReader, mint, maxt int64, parent *BlockMeta) (ulid.ULID, error)
|
|
|
|
|
|
|
|
// Compact runs compaction against the provided directories. Must
|
|
|
|
// only be called concurrently with results of Plan().
|
|
|
|
// Can optionally pass a list of already open blocks,
|
|
|
|
// to avoid having to reopen them.
|
|
|
|
// When resulting Block has 0 samples
|
|
|
|
// * No block is written.
|
|
|
|
// * The source dirs are marked Deletable.
|
|
|
|
// * Returns empty ulid.ULID{}.
|
|
|
|
Compact(dest string, dirs []string, open []*Block) (ulid.ULID, error)
|
|
|
|
}
|
|
|
|
|
|
|
|
// LeveledCompactor implements the Compactor interface.
|
|
|
|
type LeveledCompactor struct {
|
|
|
|
metrics *compactorMetrics
|
|
|
|
logger log.Logger
|
|
|
|
ranges []int64
|
|
|
|
chunkPool chunkenc.Pool
|
|
|
|
ctx context.Context
|
|
|
|
}
|
|
|
|
|
|
|
|
type compactorMetrics struct {
|
|
|
|
ran prometheus.Counter
|
|
|
|
populatingBlocks prometheus.Gauge
|
|
|
|
overlappingBlocks prometheus.Counter
|
|
|
|
duration prometheus.Histogram
|
|
|
|
chunkSize prometheus.Histogram
|
|
|
|
chunkSamples prometheus.Histogram
|
|
|
|
chunkRange prometheus.Histogram
|
|
|
|
}
|
|
|
|
|
|
|
|
func newCompactorMetrics(r prometheus.Registerer) *compactorMetrics {
|
|
|
|
m := &compactorMetrics{}
|
|
|
|
|
|
|
|
m.ran = prometheus.NewCounter(prometheus.CounterOpts{
|
|
|
|
Name: "prometheus_tsdb_compactions_total",
|
|
|
|
Help: "Total number of compactions that were executed for the partition.",
|
|
|
|
})
|
|
|
|
m.populatingBlocks = prometheus.NewGauge(prometheus.GaugeOpts{
|
|
|
|
Name: "prometheus_tsdb_compaction_populating_block",
|
|
|
|
Help: "Set to 1 when a block is currently being written to the disk.",
|
|
|
|
})
|
|
|
|
m.overlappingBlocks = prometheus.NewCounter(prometheus.CounterOpts{
|
|
|
|
Name: "prometheus_tsdb_vertical_compactions_total",
|
|
|
|
Help: "Total number of compactions done on overlapping blocks.",
|
|
|
|
})
|
|
|
|
m.duration = prometheus.NewHistogram(prometheus.HistogramOpts{
|
|
|
|
Name: "prometheus_tsdb_compaction_duration_seconds",
|
|
|
|
Help: "Duration of compaction runs",
|
|
|
|
Buckets: prometheus.ExponentialBuckets(1, 2, 10),
|
|
|
|
})
|
|
|
|
m.chunkSize = prometheus.NewHistogram(prometheus.HistogramOpts{
|
|
|
|
Name: "prometheus_tsdb_compaction_chunk_size_bytes",
|
|
|
|
Help: "Final size of chunks on their first compaction",
|
|
|
|
Buckets: prometheus.ExponentialBuckets(32, 1.5, 12),
|
|
|
|
})
|
|
|
|
m.chunkSamples = prometheus.NewHistogram(prometheus.HistogramOpts{
|
|
|
|
Name: "prometheus_tsdb_compaction_chunk_samples",
|
|
|
|
Help: "Final number of samples on their first compaction",
|
|
|
|
Buckets: prometheus.ExponentialBuckets(4, 1.5, 12),
|
|
|
|
})
|
|
|
|
m.chunkRange = prometheus.NewHistogram(prometheus.HistogramOpts{
|
|
|
|
Name: "prometheus_tsdb_compaction_chunk_range_seconds",
|
|
|
|
Help: "Final time range of chunks on their first compaction",
|
|
|
|
Buckets: prometheus.ExponentialBuckets(100, 4, 10),
|
|
|
|
})
|
|
|
|
|
|
|
|
if r != nil {
|
|
|
|
r.MustRegister(
|
|
|
|
m.ran,
|
|
|
|
m.populatingBlocks,
|
|
|
|
m.overlappingBlocks,
|
|
|
|
m.duration,
|
|
|
|
m.chunkRange,
|
|
|
|
m.chunkSamples,
|
|
|
|
m.chunkSize,
|
|
|
|
)
|
|
|
|
}
|
|
|
|
return m
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewLeveledCompactor returns a LeveledCompactor.
|
|
|
|
func NewLeveledCompactor(ctx context.Context, r prometheus.Registerer, l log.Logger, ranges []int64, pool chunkenc.Pool) (*LeveledCompactor, error) {
|
|
|
|
if len(ranges) == 0 {
|
|
|
|
return nil, errors.Errorf("at least one range must be provided")
|
|
|
|
}
|
|
|
|
if pool == nil {
|
|
|
|
pool = chunkenc.NewPool()
|
|
|
|
}
|
|
|
|
if l == nil {
|
|
|
|
l = log.NewNopLogger()
|
|
|
|
}
|
|
|
|
return &LeveledCompactor{
|
|
|
|
ranges: ranges,
|
|
|
|
chunkPool: pool,
|
|
|
|
logger: l,
|
|
|
|
metrics: newCompactorMetrics(r),
|
|
|
|
ctx: ctx,
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
type dirMeta struct {
|
|
|
|
dir string
|
|
|
|
meta *BlockMeta
|
|
|
|
}
|
|
|
|
|
|
|
|
// Plan returns a list of compactable blocks in the provided directory.
|
|
|
|
func (c *LeveledCompactor) Plan(dir string) ([]string, error) {
|
|
|
|
dirs, err := blockDirs(dir)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
if len(dirs) < 1 {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var dms []dirMeta
|
|
|
|
for _, dir := range dirs {
|
|
|
|
meta, _, err := readMetaFile(dir)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
dms = append(dms, dirMeta{dir, meta})
|
|
|
|
}
|
|
|
|
return c.plan(dms)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *LeveledCompactor) plan(dms []dirMeta) ([]string, error) {
|
|
|
|
sort.Slice(dms, func(i, j int) bool {
|
|
|
|
return dms[i].meta.MinTime < dms[j].meta.MinTime
|
|
|
|
})
|
|
|
|
|
|
|
|
res := c.selectOverlappingDirs(dms)
|
|
|
|
if len(res) > 0 {
|
|
|
|
return res, nil
|
|
|
|
}
|
|
|
|
// No overlapping blocks, do compaction the usual way.
|
|
|
|
// We do not include a recently created block with max(minTime), so the block which was just created from WAL.
|
|
|
|
// This gives users a window of a full block size to piece-wise backup new data without having to care about data overlap.
|
|
|
|
dms = dms[:len(dms)-1]
|
|
|
|
|
|
|
|
for _, dm := range c.selectDirs(dms) {
|
|
|
|
res = append(res, dm.dir)
|
|
|
|
}
|
|
|
|
if len(res) > 0 {
|
|
|
|
return res, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compact any blocks with big enough time range that have >5% tombstones.
|
|
|
|
for i := len(dms) - 1; i >= 0; i-- {
|
|
|
|
meta := dms[i].meta
|
|
|
|
if meta.MaxTime-meta.MinTime < c.ranges[len(c.ranges)/2] {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
if float64(meta.Stats.NumTombstones)/float64(meta.Stats.NumSeries+1) > 0.05 {
|
|
|
|
return []string{dms[i].dir}, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// selectDirs returns the dir metas that should be compacted into a single new block.
|
|
|
|
// If only a single block range is configured, the result is always nil.
|
|
|
|
func (c *LeveledCompactor) selectDirs(ds []dirMeta) []dirMeta {
|
|
|
|
if len(c.ranges) < 2 || len(ds) < 1 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
highTime := ds[len(ds)-1].meta.MinTime
|
|
|
|
|
|
|
|
for _, iv := range c.ranges[1:] {
|
|
|
|
parts := splitByRange(ds, iv)
|
|
|
|
if len(parts) == 0 {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
Outer:
|
|
|
|
for _, p := range parts {
|
|
|
|
// Do not select the range if it has a block whose compaction failed.
|
|
|
|
for _, dm := range p {
|
|
|
|
if dm.meta.Compaction.Failed {
|
|
|
|
continue Outer
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mint := p[0].meta.MinTime
|
|
|
|
maxt := p[len(p)-1].meta.MaxTime
|
|
|
|
// Pick the range of blocks if it spans the full range (potentially with gaps)
|
|
|
|
// or is before the most recent block.
|
|
|
|
// This ensures we don't compact blocks prematurely when another one of the same
|
|
|
|
// size still fits in the range.
|
|
|
|
if (maxt-mint == iv || maxt <= highTime) && len(p) > 1 {
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// selectOverlappingDirs returns all dirs with overlapping time ranges.
|
|
|
|
// It expects sorted input by mint and returns the overlapping dirs in the same order as received.
|
|
|
|
func (c *LeveledCompactor) selectOverlappingDirs(ds []dirMeta) []string {
|
|
|
|
if len(ds) < 2 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
var overlappingDirs []string
|
|
|
|
globalMaxt := ds[0].meta.MaxTime
|
|
|
|
for i, d := range ds[1:] {
|
|
|
|
if d.meta.MinTime < globalMaxt {
|
|
|
|
if len(overlappingDirs) == 0 { // When it is the first overlap, need to add the last one as well.
|
|
|
|
overlappingDirs = append(overlappingDirs, ds[i].dir)
|
|
|
|
}
|
|
|
|
overlappingDirs = append(overlappingDirs, d.dir)
|
|
|
|
} else if len(overlappingDirs) > 0 {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
if d.meta.MaxTime > globalMaxt {
|
|
|
|
globalMaxt = d.meta.MaxTime
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return overlappingDirs
|
|
|
|
}
|
|
|
|
|
|
|
|
// splitByRange splits the directories by the time range. The range sequence starts at 0.
|
|
|
|
//
|
|
|
|
// For example, if we have blocks [0-10, 10-20, 50-60, 90-100] and the split range tr is 30
|
|
|
|
// it returns [0-10, 10-20], [50-60], [90-100].
|
|
|
|
func splitByRange(ds []dirMeta, tr int64) [][]dirMeta {
|
|
|
|
var splitDirs [][]dirMeta
|
|
|
|
|
|
|
|
for i := 0; i < len(ds); {
|
|
|
|
var (
|
|
|
|
group []dirMeta
|
|
|
|
t0 int64
|
|
|
|
m = ds[i].meta
|
|
|
|
)
|
|
|
|
// Compute start of aligned time range of size tr closest to the current block's start.
|
|
|
|
if m.MinTime >= 0 {
|
|
|
|
t0 = tr * (m.MinTime / tr)
|
|
|
|
} else {
|
|
|
|
t0 = tr * ((m.MinTime - tr + 1) / tr)
|
|
|
|
}
|
|
|
|
// Skip blocks that don't fall into the range. This can happen via mis-alignment or
|
|
|
|
// by being the multiple of the intended range.
|
|
|
|
if m.MaxTime > t0+tr {
|
|
|
|
i++
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add all dirs to the current group that are within [t0, t0+tr].
|
|
|
|
for ; i < len(ds); i++ {
|
|
|
|
// Either the block falls into the next range or doesn't fit at all (checked above).
|
|
|
|
if ds[i].meta.MaxTime > t0+tr {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
group = append(group, ds[i])
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(group) > 0 {
|
|
|
|
splitDirs = append(splitDirs, group)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return splitDirs
|
|
|
|
}
|
|
|
|
|
|
|
|
func compactBlockMetas(uid ulid.ULID, blocks ...*BlockMeta) *BlockMeta {
|
|
|
|
res := &BlockMeta{
|
|
|
|
ULID: uid,
|
|
|
|
MinTime: blocks[0].MinTime,
|
|
|
|
}
|
|
|
|
|
|
|
|
sources := map[ulid.ULID]struct{}{}
|
|
|
|
// For overlapping blocks, the Maxt can be
|
|
|
|
// in any block so we track it globally.
|
|
|
|
maxt := int64(math.MinInt64)
|
|
|
|
|
|
|
|
for _, b := range blocks {
|
|
|
|
if b.MaxTime > maxt {
|
|
|
|
maxt = b.MaxTime
|
|
|
|
}
|
|
|
|
if b.Compaction.Level > res.Compaction.Level {
|
|
|
|
res.Compaction.Level = b.Compaction.Level
|
|
|
|
}
|
|
|
|
for _, s := range b.Compaction.Sources {
|
|
|
|
sources[s] = struct{}{}
|
|
|
|
}
|
|
|
|
res.Compaction.Parents = append(res.Compaction.Parents, BlockDesc{
|
|
|
|
ULID: b.ULID,
|
|
|
|
MinTime: b.MinTime,
|
|
|
|
MaxTime: b.MaxTime,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
res.Compaction.Level++
|
|
|
|
|
|
|
|
for s := range sources {
|
|
|
|
res.Compaction.Sources = append(res.Compaction.Sources, s)
|
|
|
|
}
|
|
|
|
sort.Slice(res.Compaction.Sources, func(i, j int) bool {
|
|
|
|
return res.Compaction.Sources[i].Compare(res.Compaction.Sources[j]) < 0
|
|
|
|
})
|
|
|
|
|
|
|
|
res.MaxTime = maxt
|
|
|
|
return res
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compact creates a new block in the compactor's directory from the blocks in the
|
|
|
|
// provided directories.
|
|
|
|
func (c *LeveledCompactor) Compact(dest string, dirs []string, open []*Block) (uid ulid.ULID, err error) {
|
|
|
|
var (
|
|
|
|
blocks []BlockReader
|
|
|
|
bs []*Block
|
|
|
|
metas []*BlockMeta
|
|
|
|
uids []string
|
|
|
|
)
|
|
|
|
start := time.Now()
|
|
|
|
|
|
|
|
for _, d := range dirs {
|
|
|
|
meta, _, err := readMetaFile(d)
|
|
|
|
if err != nil {
|
|
|
|
return uid, err
|
|
|
|
}
|
|
|
|
|
|
|
|
var b *Block
|
|
|
|
|
|
|
|
// Use already open blocks if we can, to avoid
|
|
|
|
// having the index data in memory twice.
|
|
|
|
for _, o := range open {
|
|
|
|
if meta.ULID == o.Meta().ULID {
|
|
|
|
b = o
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if b == nil {
|
|
|
|
var err error
|
|
|
|
b, err = OpenBlock(c.logger, d, c.chunkPool)
|
|
|
|
if err != nil {
|
|
|
|
return uid, err
|
|
|
|
}
|
|
|
|
defer b.Close()
|
|
|
|
}
|
|
|
|
|
|
|
|
metas = append(metas, meta)
|
|
|
|
blocks = append(blocks, b)
|
|
|
|
bs = append(bs, b)
|
|
|
|
uids = append(uids, meta.ULID.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
uid = ulid.MustNew(ulid.Now(), rand.Reader)
|
|
|
|
|
|
|
|
meta := compactBlockMetas(uid, metas...)
|
|
|
|
err = c.write(dest, meta, blocks...)
|
|
|
|
if err == nil {
|
|
|
|
if meta.Stats.NumSamples == 0 {
|
|
|
|
for _, b := range bs {
|
|
|
|
b.meta.Compaction.Deletable = true
|
|
|
|
n, err := writeMetaFile(c.logger, b.dir, &b.meta)
|
|
|
|
if err != nil {
|
|
|
|
level.Error(c.logger).Log(
|
|
|
|
"msg", "Failed to write 'Deletable' to meta file after compaction",
|
|
|
|
"ulid", b.meta.ULID,
|
|
|
|
)
|
|
|
|
}
|
|
|
|
b.numBytesMeta = n
|
|
|
|
}
|
|
|
|
uid = ulid.ULID{}
|
|
|
|
level.Info(c.logger).Log(
|
|
|
|
"msg", "compact blocks resulted in empty block",
|
|
|
|
"count", len(blocks),
|
|
|
|
"sources", fmt.Sprintf("%v", uids),
|
|
|
|
"duration", time.Since(start),
|
|
|
|
)
|
|
|
|
} else {
|
|
|
|
level.Info(c.logger).Log(
|
|
|
|
"msg", "compact blocks",
|
|
|
|
"count", len(blocks),
|
|
|
|
"mint", meta.MinTime,
|
|
|
|
"maxt", meta.MaxTime,
|
|
|
|
"ulid", meta.ULID,
|
|
|
|
"sources", fmt.Sprintf("%v", uids),
|
|
|
|
"duration", time.Since(start),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
return uid, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var merr tsdb_errors.MultiError
|
|
|
|
merr.Add(err)
|
|
|
|
if err != context.Canceled {
|
|
|
|
for _, b := range bs {
|
|
|
|
if err := b.setCompactionFailed(); err != nil {
|
|
|
|
merr.Add(errors.Wrapf(err, "setting compaction failed for block: %s", b.Dir()))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return uid, merr
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *LeveledCompactor) Write(dest string, b BlockReader, mint, maxt int64, parent *BlockMeta) (ulid.ULID, error) {
|
|
|
|
start := time.Now()
|
|
|
|
|
|
|
|
uid := ulid.MustNew(ulid.Now(), rand.Reader)
|
|
|
|
|
|
|
|
meta := &BlockMeta{
|
|
|
|
ULID: uid,
|
|
|
|
MinTime: mint,
|
|
|
|
MaxTime: maxt,
|
|
|
|
}
|
|
|
|
meta.Compaction.Level = 1
|
|
|
|
meta.Compaction.Sources = []ulid.ULID{uid}
|
|
|
|
|
|
|
|
if parent != nil {
|
|
|
|
meta.Compaction.Parents = []BlockDesc{
|
|
|
|
{ULID: parent.ULID, MinTime: parent.MinTime, MaxTime: parent.MaxTime},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
err := c.write(dest, meta, b)
|
|
|
|
if err != nil {
|
|
|
|
return uid, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if meta.Stats.NumSamples == 0 {
|
|
|
|
return ulid.ULID{}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
level.Info(c.logger).Log(
|
|
|
|
"msg", "write block",
|
|
|
|
"mint", meta.MinTime,
|
|
|
|
"maxt", meta.MaxTime,
|
|
|
|
"ulid", meta.ULID,
|
|
|
|
"duration", time.Since(start),
|
|
|
|
)
|
|
|
|
return uid, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// instrumentedChunkWriter is used for level 1 compactions to record statistics
|
|
|
|
// about compacted chunks.
|
|
|
|
type instrumentedChunkWriter struct {
|
|
|
|
ChunkWriter
|
|
|
|
|
|
|
|
size prometheus.Histogram
|
|
|
|
samples prometheus.Histogram
|
|
|
|
trange prometheus.Histogram
|
|
|
|
}
|
|
|
|
|
|
|
|
func (w *instrumentedChunkWriter) WriteChunks(chunks ...chunks.Meta) error {
|
|
|
|
for _, c := range chunks {
|
|
|
|
w.size.Observe(float64(len(c.Chunk.Bytes())))
|
|
|
|
w.samples.Observe(float64(c.Chunk.NumSamples()))
|
|
|
|
w.trange.Observe(float64(c.MaxTime - c.MinTime))
|
|
|
|
}
|
|
|
|
return w.ChunkWriter.WriteChunks(chunks...)
|
|
|
|
}
|
|
|
|
|
|
|
|
// write creates a new block that is the union of the provided blocks into dir.
|
|
|
|
// It cleans up all files of the old blocks after completing successfully.
|
|
|
|
func (c *LeveledCompactor) write(dest string, meta *BlockMeta, blocks ...BlockReader) (err error) {
|
|
|
|
dir := filepath.Join(dest, meta.ULID.String())
|
|
|
|
tmp := dir + ".tmp"
|
|
|
|
var closers []io.Closer
|
|
|
|
defer func(t time.Time) {
|
|
|
|
var merr tsdb_errors.MultiError
|
|
|
|
merr.Add(err)
|
|
|
|
merr.Add(closeAll(closers))
|
|
|
|
err = merr.Err()
|
|
|
|
|
|
|
|
// RemoveAll returns no error when tmp doesn't exist so it is safe to always run it.
|
|
|
|
if err := os.RemoveAll(tmp); err != nil {
|
|
|
|
level.Error(c.logger).Log("msg", "removed tmp folder after failed compaction", "err", err.Error())
|
|
|
|
}
|
|
|
|
c.metrics.ran.Inc()
|
|
|
|
c.metrics.duration.Observe(time.Since(t).Seconds())
|
|
|
|
}(time.Now())
|
|
|
|
|
|
|
|
if err = os.RemoveAll(tmp); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err = os.MkdirAll(tmp, 0777); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Populate chunk and index files into temporary directory with
|
|
|
|
// data of all blocks.
|
|
|
|
var chunkw ChunkWriter
|
|
|
|
|
|
|
|
chunkw, err = chunks.NewWriter(chunkDir(tmp))
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "open chunk writer")
|
|
|
|
}
|
|
|
|
closers = append(closers, chunkw)
|
|
|
|
// Record written chunk sizes on level 1 compactions.
|
|
|
|
if meta.Compaction.Level == 1 {
|
|
|
|
chunkw = &instrumentedChunkWriter{
|
|
|
|
ChunkWriter: chunkw,
|
|
|
|
size: c.metrics.chunkSize,
|
|
|
|
samples: c.metrics.chunkSamples,
|
|
|
|
trange: c.metrics.chunkRange,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
indexw, err := index.NewWriter(c.ctx, filepath.Join(tmp, indexFilename))
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "open index writer")
|
|
|
|
}
|
|
|
|
closers = append(closers, indexw)
|
|
|
|
|
|
|
|
if err := c.populateBlock(blocks, meta, indexw, chunkw); err != nil {
|
|
|
|
return errors.Wrap(err, "write compaction")
|
|
|
|
}
|
|
|
|
|
|
|
|
select {
|
|
|
|
case <-c.ctx.Done():
|
|
|
|
return c.ctx.Err()
|
|
|
|
default:
|
|
|
|
}
|
|
|
|
|
|
|
|
// We are explicitly closing them here to check for error even
|
|
|
|
// though these are covered under defer. This is because in Windows,
|
|
|
|
// you cannot delete these unless they are closed and the defer is to
|
|
|
|
// make sure they are closed if the function exits due to an error above.
|
|
|
|
var merr tsdb_errors.MultiError
|
|
|
|
for _, w := range closers {
|
|
|
|
merr.Add(w.Close())
|
|
|
|
}
|
|
|
|
closers = closers[:0] // Avoid closing the writers twice in the defer.
|
|
|
|
if merr.Err() != nil {
|
|
|
|
return merr.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
// Populated block is empty, so exit early.
|
|
|
|
if meta.Stats.NumSamples == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, err = writeMetaFile(c.logger, tmp, meta); err != nil {
|
|
|
|
return errors.Wrap(err, "write merged meta")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create an empty tombstones file.
|
|
|
|
if _, err := tombstones.WriteFile(c.logger, tmp, tombstones.NewMemTombstones()); err != nil {
|
|
|
|
return errors.Wrap(err, "write new tombstones file")
|
|
|
|
}
|
|
|
|
|
|
|
|
df, err := fileutil.OpenDir(tmp)
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "open temporary block dir")
|
|
|
|
}
|
|
|
|
defer func() {
|
|
|
|
if df != nil {
|
|
|
|
df.Close()
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
if err := df.Sync(); err != nil {
|
|
|
|
return errors.Wrap(err, "sync temporary dir file")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Close temp dir before rename block dir (for windows platform).
|
|
|
|
if err = df.Close(); err != nil {
|
|
|
|
return errors.Wrap(err, "close temporary dir")
|
|
|
|
}
|
|
|
|
df = nil
|
|
|
|
|
|
|
|
// Block successfully written, make visible and remove old ones.
|
|
|
|
if err := fileutil.Replace(tmp, dir); err != nil {
|
|
|
|
return errors.Wrap(err, "rename block dir")
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// populateBlock fills the index and chunk writers with new data gathered as the union
|
|
|
|
// of the provided blocks. It returns meta information for the new block.
|
|
|
|
// It expects sorted blocks input by mint.
|
|
|
|
func (c *LeveledCompactor) populateBlock(blocks []BlockReader, meta *BlockMeta, indexw IndexWriter, chunkw ChunkWriter) (err error) {
|
|
|
|
if len(blocks) == 0 {
|
|
|
|
return errors.New("cannot populate block from no readers")
|
|
|
|
}
|
|
|
|
|
|
|
|
var (
|
|
|
|
set storage.ChunkSeriesSet
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
symbols index.StringIter
|
|
|
|
closers = []io.Closer{}
|
|
|
|
overlapping bool
|
|
|
|
)
|
|
|
|
defer func() {
|
|
|
|
var merr tsdb_errors.MultiError
|
|
|
|
merr.Add(err)
|
|
|
|
merr.Add(closeAll(closers))
|
|
|
|
err = merr.Err()
|
|
|
|
c.metrics.populatingBlocks.Set(0)
|
|
|
|
}()
|
|
|
|
c.metrics.populatingBlocks.Set(1)
|
|
|
|
|
|
|
|
globalMaxt := blocks[0].Meta().MaxTime
|
|
|
|
for i, b := range blocks {
|
|
|
|
select {
|
|
|
|
case <-c.ctx.Done():
|
|
|
|
return c.ctx.Err()
|
|
|
|
default:
|
|
|
|
}
|
|
|
|
|
|
|
|
if !overlapping {
|
|
|
|
if i > 0 && b.Meta().MinTime < globalMaxt {
|
|
|
|
c.metrics.overlappingBlocks.Inc()
|
|
|
|
overlapping = true
|
|
|
|
level.Warn(c.logger).Log("msg", "found overlapping blocks during compaction", "ulid", meta.ULID)
|
|
|
|
}
|
|
|
|
if b.Meta().MaxTime > globalMaxt {
|
|
|
|
globalMaxt = b.Meta().MaxTime
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
indexr, err := b.Index(math.MinInt64, globalMaxt)
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrapf(err, "open index reader for block %s", b)
|
|
|
|
}
|
|
|
|
closers = append(closers, indexr)
|
|
|
|
|
|
|
|
chunkr, err := b.Chunks()
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrapf(err, "open chunk reader for block %s", b)
|
|
|
|
}
|
|
|
|
closers = append(closers, chunkr)
|
|
|
|
|
|
|
|
tombsr, err := b.Tombstones()
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrapf(err, "open tombstone reader for block %s", b)
|
|
|
|
}
|
|
|
|
closers = append(closers, tombsr)
|
|
|
|
|
Reduce memory used by postings offset table.
Rather than keeping the offset of each postings list, instead
keep the nth offset of the offset of the posting list. As postings
list offsets have always been sorted, we can then get to the closest
entry before the one we want an iterate forwards.
I haven't done much tuning on the 32 number, it was chosen to try
not to read through more than a 4k page of data.
Switch to a bulk interface for fetching postings. Use it to avoid having
to re-read parts of the posting offset table when querying lots of it.
For a index with what BenchmarkHeadPostingForMatchers uses RAM
for r.postings drops from 3.79MB to 80.19kB or about 48x.
Bytes allocated go down by 30%, and suprisingly CPU usage drops by
4-6% for typical queries too.
benchmark old ns/op new ns/op delta
BenchmarkPostingsForMatchers/Block/n="1"-4 35231 36673 +4.09%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 563380 540627 -4.04%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 536782 534186 -0.48%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 533990 541550 +1.42%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 113374598 117969608 +4.05%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 146329884 139651442 -4.56%
BenchmarkPostingsForMatchers/Block/i=~""-4 50346510 44961127 -10.70%
BenchmarkPostingsForMatchers/Block/i!=""-4 41261550 35356165 -14.31%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 112544418 116904010 +3.87%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 112487086 116864918 +3.89%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 41094758 35457904 -13.72%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 41906372 36151473 -13.73%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 147262414 140424800 -4.64%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 28615629 27872072 -2.60%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 147117177 140462403 -4.52%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 175096826 167902298 -4.11%
benchmark old allocs new allocs delta
BenchmarkPostingsForMatchers/Block/n="1"-4 4 6 +50.00%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 7 11 +57.14%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 7 11 +57.14%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 15 17 +13.33%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 100010 100012 +0.00%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 200069 200040 -0.01%
BenchmarkPostingsForMatchers/Block/i=~""-4 200072 200045 -0.01%
BenchmarkPostingsForMatchers/Block/i!=""-4 200070 200041 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 100013 100017 +0.00%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 100017 100023 +0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 200073 200046 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 200075 200050 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 200074 200049 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 111165 111150 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 200078 200055 -0.01%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 311282 311238 -0.01%
benchmark old bytes new bytes delta
BenchmarkPostingsForMatchers/Block/n="1"-4 264 296 +12.12%
BenchmarkPostingsForMatchers/Block/n="1",j="foo"-4 360 424 +17.78%
BenchmarkPostingsForMatchers/Block/j="foo",n="1"-4 360 424 +17.78%
BenchmarkPostingsForMatchers/Block/n="1",j!="foo"-4 520 552 +6.15%
BenchmarkPostingsForMatchers/Block/i=~".*"-4 1600461 1600482 +0.00%
BenchmarkPostingsForMatchers/Block/i=~".+"-4 24900801 17259077 -30.69%
BenchmarkPostingsForMatchers/Block/i=~""-4 24900836 17259151 -30.69%
BenchmarkPostingsForMatchers/Block/i!=""-4 24900760 17259048 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",j="foo"-4 1600557 1600621 +0.00%
BenchmarkPostingsForMatchers/Block/n="1",i=~".*",i!="2",j="foo"-4 1600717 1600813 +0.01%
BenchmarkPostingsForMatchers/Block/n="1",i!=""-4 24900856 17259176 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i!="",j="foo"-4 24900952 17259304 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",j="foo"-4 24900993 17259333 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~"1.+",j="foo"-4 3788311 3142630 -17.04%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!="2",j="foo"-4 24901137 17259509 -30.69%
BenchmarkPostingsForMatchers/Block/n="1",i=~".+",i!~"2.*",j="foo"-4 28693086 20405680 -28.88%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
k, v := index.AllPostingsKey()
|
|
|
|
all, err := indexr.Postings(k, v)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
all = indexr.SortedPostings(all)
|
|
|
|
|
|
|
|
s := newCompactionSeriesSet(indexr, chunkr, tombsr, all)
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
syms := indexr.Symbols()
|
|
|
|
|
|
|
|
if i == 0 {
|
|
|
|
set = s
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
symbols = syms
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
set, err = newCompactionMerger(set, s)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
symbols = newMergedStringIter(symbols, syms)
|
|
|
|
}
|
|
|
|
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
for symbols.Next() {
|
|
|
|
if err := indexw.AddSymbol(symbols.At()); err != nil {
|
|
|
|
return errors.Wrap(err, "add symbol")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if symbols.Err() != nil {
|
|
|
|
return errors.Wrap(symbols.Err(), "next symbol")
|
|
|
|
}
|
|
|
|
|
|
|
|
delIter := &deletedIterator{}
|
|
|
|
ref := uint64(0)
|
|
|
|
for set.Next() {
|
|
|
|
select {
|
|
|
|
case <-c.ctx.Done():
|
|
|
|
return c.ctx.Err()
|
|
|
|
default:
|
|
|
|
}
|
|
|
|
|
|
|
|
lset, chks, dranges := set.At() // The chunks here are not fully deleted.
|
|
|
|
if overlapping {
|
|
|
|
// If blocks are overlapping, it is possible to have unsorted chunks.
|
|
|
|
sort.Slice(chks, func(i, j int) bool {
|
|
|
|
return chks[i].MinTime < chks[j].MinTime
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// Skip the series with all deleted chunks.
|
|
|
|
if len(chks) == 0 {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
for i, chk := range chks {
|
|
|
|
// Re-encode head chunks that are still open (being appended to) or
|
|
|
|
// outside the compacted MaxTime range.
|
|
|
|
// The chunk.Bytes() method is not safe for open chunks hence the re-encoding.
|
|
|
|
// This happens when snapshotting the head block.
|
|
|
|
//
|
|
|
|
// Block time range is half-open: [meta.MinTime, meta.MaxTime) and
|
|
|
|
// chunks are closed hence the chk.MaxTime >= meta.MaxTime check.
|
|
|
|
//
|
|
|
|
// TODO think how to avoid the typecasting to verify when it is head block.
|
|
|
|
if _, isHeadChunk := chk.Chunk.(*safeChunk); isHeadChunk && chk.MaxTime >= meta.MaxTime {
|
|
|
|
dranges = append(dranges, tombstones.Interval{Mint: meta.MaxTime, Maxt: math.MaxInt64})
|
|
|
|
|
|
|
|
} else
|
|
|
|
// Sanity check for disk blocks.
|
|
|
|
// chk.MaxTime == meta.MaxTime shouldn't happen as well, but will brake many users so not checking for that.
|
|
|
|
if chk.MinTime < meta.MinTime || chk.MaxTime > meta.MaxTime {
|
|
|
|
return errors.Errorf("found chunk with minTime: %d maxTime: %d outside of compacted minTime: %d maxTime: %d",
|
|
|
|
chk.MinTime, chk.MaxTime, meta.MinTime, meta.MaxTime)
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(dranges) > 0 {
|
|
|
|
// Re-encode the chunk to not have deleted values.
|
|
|
|
if !chk.OverlapsClosedInterval(dranges[0].Mint, dranges[len(dranges)-1].Maxt) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
newChunk := chunkenc.NewXORChunk()
|
|
|
|
app, err := newChunk.Appender()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
delIter.it = chk.Chunk.Iterator(delIter.it)
|
|
|
|
delIter.intervals = dranges
|
|
|
|
|
|
|
|
var (
|
|
|
|
t int64
|
|
|
|
v float64
|
|
|
|
)
|
|
|
|
for delIter.Next() {
|
|
|
|
t, v = delIter.At()
|
|
|
|
app.Append(t, v)
|
|
|
|
}
|
|
|
|
if err := delIter.Err(); err != nil {
|
|
|
|
return errors.Wrap(err, "iterate chunk while re-encoding")
|
|
|
|
}
|
|
|
|
|
|
|
|
chks[i].Chunk = newChunk
|
|
|
|
chks[i].MaxTime = t
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mergedChks := chks
|
|
|
|
if overlapping {
|
|
|
|
mergedChks, err = chunks.MergeOverlappingChunks(chks)
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "merge overlapping chunks")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if err := chunkw.WriteChunks(mergedChks...); err != nil {
|
|
|
|
return errors.Wrap(err, "write chunks")
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := indexw.AddSeries(ref, lset, mergedChks...); err != nil {
|
|
|
|
return errors.Wrap(err, "add series")
|
|
|
|
}
|
|
|
|
|
|
|
|
meta.Stats.NumChunks += uint64(len(mergedChks))
|
|
|
|
meta.Stats.NumSeries++
|
|
|
|
for _, chk := range mergedChks {
|
|
|
|
meta.Stats.NumSamples += uint64(chk.Chunk.NumSamples())
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, chk := range mergedChks {
|
|
|
|
if err := c.chunkPool.Put(chk.Chunk); err != nil {
|
|
|
|
return errors.Wrap(err, "put chunk")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ref++
|
|
|
|
}
|
|
|
|
if set.Err() != nil {
|
|
|
|
return errors.Wrap(set.Err(), "iterate compaction set")
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
type compactionSeriesSet struct {
|
|
|
|
p index.Postings
|
|
|
|
index IndexReader
|
|
|
|
chunks ChunkReader
|
|
|
|
tombstones tombstones.Reader
|
|
|
|
|
|
|
|
l labels.Labels
|
|
|
|
c []chunks.Meta
|
|
|
|
intervals tombstones.Intervals
|
|
|
|
err error
|
|
|
|
}
|
|
|
|
|
|
|
|
func newCompactionSeriesSet(i IndexReader, c ChunkReader, t tombstones.Reader, p index.Postings) *compactionSeriesSet {
|
|
|
|
return &compactionSeriesSet{
|
|
|
|
index: i,
|
|
|
|
chunks: c,
|
|
|
|
tombstones: t,
|
|
|
|
p: p,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionSeriesSet) Next() bool {
|
|
|
|
if !c.p.Next() {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
var err error
|
|
|
|
|
|
|
|
c.intervals, err = c.tombstones.Get(c.p.At())
|
|
|
|
if err != nil {
|
|
|
|
c.err = errors.Wrap(err, "get tombstones")
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
if err = c.index.Series(c.p.At(), &c.l, &c.c); err != nil {
|
|
|
|
c.err = errors.Wrapf(err, "get series %d", c.p.At())
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// Remove completely deleted chunks.
|
|
|
|
if len(c.intervals) > 0 {
|
|
|
|
chks := make([]chunks.Meta, 0, len(c.c))
|
|
|
|
for _, chk := range c.c {
|
|
|
|
if !(tombstones.Interval{Mint: chk.MinTime, Maxt: chk.MaxTime}.IsSubrange(c.intervals)) {
|
|
|
|
chks = append(chks, chk)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
c.c = chks
|
|
|
|
}
|
|
|
|
|
|
|
|
for i := range c.c {
|
|
|
|
chk := &c.c[i]
|
|
|
|
|
|
|
|
chk.Chunk, err = c.chunks.Chunk(chk.Ref)
|
|
|
|
if err != nil {
|
|
|
|
c.err = errors.Wrapf(err, "chunk %d not found", chk.Ref)
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionSeriesSet) Err() error {
|
|
|
|
if c.err != nil {
|
|
|
|
return c.err
|
|
|
|
}
|
|
|
|
return c.p.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionSeriesSet) At() (labels.Labels, []chunks.Meta, tombstones.Intervals) {
|
|
|
|
return c.l, c.c, c.intervals
|
|
|
|
}
|
|
|
|
|
|
|
|
type compactionMerger struct {
|
|
|
|
a, b storage.ChunkSeriesSet
|
|
|
|
|
|
|
|
aok, bok bool
|
|
|
|
l labels.Labels
|
|
|
|
c []chunks.Meta
|
|
|
|
intervals tombstones.Intervals
|
|
|
|
}
|
|
|
|
|
|
|
|
func newCompactionMerger(a, b storage.ChunkSeriesSet) (*compactionMerger, error) {
|
|
|
|
c := &compactionMerger{
|
|
|
|
a: a,
|
|
|
|
b: b,
|
|
|
|
}
|
|
|
|
// Initialize first elements of both sets as Next() needs
|
|
|
|
// one element look-ahead.
|
|
|
|
c.aok = c.a.Next()
|
|
|
|
c.bok = c.b.Next()
|
|
|
|
|
|
|
|
return c, c.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionMerger) compare() int {
|
|
|
|
if !c.aok {
|
|
|
|
return 1
|
|
|
|
}
|
|
|
|
if !c.bok {
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
a, _, _ := c.a.At()
|
|
|
|
b, _, _ := c.b.At()
|
|
|
|
return labels.Compare(a, b)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionMerger) Next() bool {
|
|
|
|
if !c.aok && !c.bok || c.Err() != nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
// While advancing child iterators the memory used for labels and chunks
|
|
|
|
// may be reused. When picking a series we have to store the result.
|
|
|
|
var lset labels.Labels
|
|
|
|
var chks []chunks.Meta
|
|
|
|
|
|
|
|
d := c.compare()
|
|
|
|
if d > 0 {
|
|
|
|
lset, chks, c.intervals = c.b.At()
|
|
|
|
c.l = append(c.l[:0], lset...)
|
|
|
|
c.c = append(c.c[:0], chks...)
|
|
|
|
|
|
|
|
c.bok = c.b.Next()
|
|
|
|
} else if d < 0 {
|
|
|
|
lset, chks, c.intervals = c.a.At()
|
|
|
|
c.l = append(c.l[:0], lset...)
|
|
|
|
c.c = append(c.c[:0], chks...)
|
|
|
|
|
|
|
|
c.aok = c.a.Next()
|
|
|
|
} else {
|
|
|
|
// Both sets contain the current series. Chain them into a single one.
|
|
|
|
l, ca, ra := c.a.At()
|
|
|
|
_, cb, rb := c.b.At()
|
|
|
|
|
|
|
|
for _, r := range rb {
|
|
|
|
ra = ra.Add(r)
|
|
|
|
}
|
|
|
|
|
|
|
|
c.l = append(c.l[:0], l...)
|
|
|
|
c.c = append(append(c.c[:0], ca...), cb...)
|
|
|
|
c.intervals = ra
|
|
|
|
|
|
|
|
c.aok = c.a.Next()
|
|
|
|
c.bok = c.b.Next()
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionMerger) Err() error {
|
|
|
|
if c.a.Err() != nil {
|
|
|
|
return c.a.Err()
|
|
|
|
}
|
|
|
|
return c.b.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *compactionMerger) At() (labels.Labels, []chunks.Meta, tombstones.Intervals) {
|
|
|
|
return c.l, c.c, c.intervals
|
|
|
|
}
|
Stream symbols during compaction. (#6468)
Rather than buffer up symbols in RAM, do it one by one
during compaction. Then use the reader's symbol handling
for symbol lookups during the rest of the index write.
There is some slowdown in compaction, due to having to look through a file
rather than a hash lookup. This is noise to the overall cost of compacting
series with thousands of samples though.
benchmark old ns/op new ns/op delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 539917175 675341565 +25.08%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 2441815993 2477453524 +1.46%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3978543559 3922909687 -1.40%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 8430219716 8586610007 +1.86%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 1786424591 1909552782 +6.89%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 5328998202 6020839950 +12.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 10085059958 11085278690 +9.92%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 25497010155 27018079806 +5.97%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 2427391406 2817217987 +16.06%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 2592965497 2538805050 -2.09%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 2437388343 2668012858 +9.46%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 2317095324 2787423966 +20.30%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 2600239857 2096973860 -19.35%
benchmark old allocs new allocs delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 500851 470794 -6.00%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 821527 791451 -3.66%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 1141562 1111508 -2.63%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 2141576 2111504 -1.40%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 871466 841424 -3.45%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 1941428 1911415 -1.55%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 3071573 3041510 -0.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 6771648 6741509 -0.45%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 731493 824888 +12.77%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 793918 887311 +11.76%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 811842 905204 +11.50%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 832244 925081 +11.16%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 921553 1019162 +10.59%
benchmark old bytes new bytes delta
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 40532648 35698276 -11.93%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 60340216 53409568 -11.49%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 81087336 72065552 -11.13%
BenchmarkCompaction/type=normal,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 142485576 120878544 -15.16%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=101-4 208661368 203831136 -2.31%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=1001-4 347345904 340484696 -1.98%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=2001-4 585185856 576244648 -1.53%
BenchmarkCompaction/type=vertical,blocks=4,series=10000,samplesPerSeriesPerBlock=5001-4 1357641792 1358966528 +0.10%
BenchmarkCompactionFromHead/labelnames=1,labelvalues=100000-4 126486664 119666744 -5.39%
BenchmarkCompactionFromHead/labelnames=10,labelvalues=10000-4 122323192 115117224 -5.89%
BenchmarkCompactionFromHead/labelnames=100,labelvalues=1000-4 126404504 119469864 -5.49%
BenchmarkCompactionFromHead/labelnames=1000,labelvalues=100-4 119047832 112230408 -5.73%
BenchmarkCompactionFromHead/labelnames=10000,labelvalues=10-4 136576016 116634800 -14.60%
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
5 years ago
|
|
|
|
|
|
|
func newMergedStringIter(a index.StringIter, b index.StringIter) index.StringIter {
|
|
|
|
return &mergedStringIter{a: a, b: b, aok: a.Next(), bok: b.Next()}
|
|
|
|
}
|
|
|
|
|
|
|
|
type mergedStringIter struct {
|
|
|
|
a index.StringIter
|
|
|
|
b index.StringIter
|
|
|
|
aok, bok bool
|
|
|
|
cur string
|
|
|
|
}
|
|
|
|
|
|
|
|
func (m *mergedStringIter) Next() bool {
|
|
|
|
if (!m.aok && !m.bok) || (m.Err() != nil) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
if !m.aok {
|
|
|
|
m.cur = m.b.At()
|
|
|
|
m.bok = m.b.Next()
|
|
|
|
} else if !m.bok {
|
|
|
|
m.cur = m.a.At()
|
|
|
|
m.aok = m.a.Next()
|
|
|
|
} else if m.b.At() > m.a.At() {
|
|
|
|
m.cur = m.a.At()
|
|
|
|
m.aok = m.a.Next()
|
|
|
|
} else if m.a.At() > m.b.At() {
|
|
|
|
m.cur = m.b.At()
|
|
|
|
m.bok = m.b.Next()
|
|
|
|
} else { // Equal.
|
|
|
|
m.cur = m.b.At()
|
|
|
|
m.aok = m.a.Next()
|
|
|
|
m.bok = m.b.Next()
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
func (m mergedStringIter) At() string { return m.cur }
|
|
|
|
func (m mergedStringIter) Err() error {
|
|
|
|
if m.a.Err() != nil {
|
|
|
|
return m.a.Err()
|
|
|
|
}
|
|
|
|
return m.b.Err()
|
|
|
|
}
|