openvpn-gui

Commit Graph

Author	SHA1	Message	Date
Selva Nair	9417991168	Use a list instead of array for connections list Currently we use an array of connection pointers which needs to be reallocated when space runs out. But, that happens from the main thread while the status thread may be referring to those pointers. Its very hard to fence against possible invalid memory access. Instead, use a list so that connection pointer never changes once created. The connection list is no longer recreated from scratch even when no connections are active. This means configs added while GUI is running will always appear at the bottom of the root group listing until the GUI is restarted. TODO: This behaviour could be improved by scanning through the groups to graft new configs at the right branch in the config-group tree. v2: removed unused references to SetMenuStatusById() Signed-off-by: Selva Nair <selva.nair@gmail.com>	2 years ago
Heiko Hund	3046f8a345	convert files to unix style end-of-line	13 years ago
Heiko Hund	fd9e4ae6db	import of openvpn-gui-1.0.3.zip git-svn-id: https://openvpn-gui.svn.sourceforge.net/svnroot/openvpn-gui/trunk@2 43a1345a-9c20-4331-951f-9845fc178312	16 years ago

Author

SHA1

Message

Date

Selva Nair

9417991168

Use a list instead of array for connections list

Currently we use an array of connection pointers which needs
to be reallocated when space runs out. But, that happens from
the main thread while the status thread may be referring to those
pointers. Its very hard to fence against possible invalid memory
access. Instead, use a list so that connection pointer never
changes once created.

The connection list is no longer recreated from scratch even when
no connections are active. This means configs added while GUI is
running will always appear at the bottom of the root group listing
until the GUI is restarted.

TODO: This behaviour could be improved by scanning through the groups to
graft new configs at the right branch in the config-group tree.

v2: removed unused references to SetMenuStatusById()

Signed-off-by: Selva Nair <selva.nair@gmail.com>

Heiko Hund

3046f8a345

convert files to unix style end-of-line

Heiko Hund

fd9e4ae6db

import of openvpn-gui-1.0.3.zip

git-svn-id: https://openvpn-gui.svn.sourceforge.net/svnroot/openvpn-gui/trunk@2 43a1345a-9c20-4331-951f-9845fc178312

3 Commits (72a4bb84bfaa069cf4a97c5658d04f5a5bb0972b)