Commit Graph

577 Commits (273322efb066a0b5e04ee160e0eeda6272fe9c00)

Author SHA1 Message Date
Selva Nair 874d0890dd Document sending commands to a running instance
Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-22 00:31:11 -05:00
Selva Nair 688f41878f More helpful message if already running
Why: The current message assumes the balloon to appear attached
to the icon which is not the case in Windows 10.

Based on feedback from larson0815 and Deantwo here:
https://github.com/selvanair/openvpn-gui/issues/5

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-20 11:43:02 -05:00
Selva Nair 10f34584ea In '--connect profile-name' make the extension (.ovpn) optional
Treat '--connect foo.ovpn' and '--connect foo' as the same. This matches
with the behaviour of '--command connect foo'.

Note: the argument is first compared against config file names and then
against config names.

Based on comment by larson0815 here:
https://github.com/selvanair/openvpn-gui/issues/5

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-20 11:42:24 -05:00
Selva Nair eb52950f7a Treat --connect as --command connect in case GUI is already running
- This makes the behaviour more intuitive for those used to the
  auto connect option (--connect xxx). Note: this will work only for
  the first occurrence of --connect as --command allows only one profile
  to be speciifed.
- Also make '--command connect' behave as '--connect' if the GUI is not
  already running.

Based on comment by larson0815 here:
https://github.com/selvanair/openvpn-gui/issues/5

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-20 11:42:23 -05:00
Selva Nair 0f21030774 Support sending commands to running instance
- New option --command <action> <params> to send commands to
  a running instance of openvpn-gui.exe
  Supported actions are
      connect, disconnect, reconnect
  each of which takes the name of the config (with or without the
  extension .ovpn) as a parameter;
      disconnect_all, exit
  which take no parameter and
      silent_connection
  which takes an optional parameter = 0 or 1 (1 is the default)

  Examples: with the gui running, start a new instance as

  openvpn-gui.exe --command disconnect myvpn : ask running instance
                        to disconnect myvpn if connected
  openvpn-gui.exe --command status myvpn     : ask running instance
                        to show the status window for myvpn if available
  openvpn-gui.exe --command disconnect_all   : ask running instance
                        to disconnect all active connections

- The second instance exits after issuing a SendMessage to the
  already running instance. If no action is specified, the running
  instance is notified to show a balloon to alert the user

- These messages may also be sent from scripts as COPYDATA messages
  with the wData element specifying the action to execute and lpData
  a pointer to the parameter. The dwData param must be one of
  WM_OVPN_xxx with xxx = START, STOP, RESTART, STOPALL, EXIT or
  SILENT. See main.h for their values.

v2: Bug fixes based on test reports from larson0815
here: https://github.com/selvanair/openvpn-gui/issues/5
and cron410 here: https://github.com/OpenVPN/openvpn-gui/issues/104

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-20 11:42:23 -05:00
Selva Nair 31896ce33b Add restart button to connection menus
- This works the same way as restart button in the status window
  but is more conveniently accessible from the tray menu.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-20 11:41:19 -05:00
Ilya Shipitsin 8418bc7f45 travis-ci: add openssl-1.1.0 support 2018-01-18 18:00:10 +05:00
Samuli Seppänen 4055f86206
Merge pull request #202 from selvanair/auto-submit-fix
Do not auto submit username/password after an auth failure
2018-01-11 20:49:28 +02:00
Samuli Seppänen 5233f81fdc
Merge pull request #204 from chipitsine/better_align
better alignment of warning message
2018-01-11 20:47:37 +02:00
Ilya Shipitsin 0642cb8fe5 better alignment of warning message 2018-01-06 21:14:11 +05:00
Samuli Seppänen 1c1bf2045b
Merge pull request #201 from chipitsine/russian
russian localization for "no-auth-prompt" branch
2018-01-06 16:51:15 +02:00
Selva Nair 185b571d6e Do not auto submit username/password after an auth failure
- This case was missed by commit 5fb23f6ad9 that introduced
  automatic username/password submission.
- Also avoid auto submit if the recalled password is an empty
  string.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2018-01-03 21:38:40 -05:00
Ilya Shipitsin 52219fcebf russian localization for "no-auth-prompt" branch 2017-12-29 01:27:52 +05:00
Selva Nair 702251327c
Merge pull request #186 from selvanair/no-auth-prompt
Use saved password with no prompt if silent_connection is on

Acked by: Илья Шипицин <chipitsine@gmail.com>
2017-12-26 14:41:17 -05:00
Selva Nair 5fb23f6ad9 Auto submit saved auth-user-pass credentials after a brief delay
- Effective only when username and password are saved.
- The user may interrupt auto submission and edit the username/password.
- If silent_connection is on the dialog is bypassed without any delay.

v2 changes:
- Display message in normal text color and show remaining time

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-12-26 13:41:55 -05:00
Selva Nair d98ad55467 Change OK button style to BS_DEFPUSHBUTTON in auth-user-pass dialog
- Make the OK button appear highlighted as the default action so that
  the user can press enter and submit the form. This also gives a clearer
  indication of the default action when automatic submission of saved
  username/password activates.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-12-26 13:41:55 -05:00
Selva Nair cf2d1a8632
Merge pull request #197 from selvanair/registry-optional
Add a default for openvpnpath

Acked-by: Илья Шипицин <chipitsine@gmail.com>
Acked-by: Samuli Seppänen <samuli@openvpn.net>
2017-12-05 10:12:21 -05:00
Selva Nair 7b57cd1ac8
Merge pull request #194 from selvanair/validate-input
Validate user input

Acked-by: Gert Doering  <gert@greenie.muc.de>
2017-12-04 23:49:00 -05:00
Selva Nair daef688990 Add a default for openvpnpath
Allow the GUI to run without any registry keys present:
the location of openvpn installation defaults to
C:\Program Files\OpenVPN if not found in registry.

Useful for testing builds or to display --help etc.

See also: PR #147

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-12-03 13:57:33 -05:00
Selva Nair 301a5e5644 Check for invalid characters in user inputs
- Flag password and username input if these contain an invalid character
  (currently only embedded '\n' is disallowed). Shows a popup when OK
  is pressed so that the user can correct the input and resubmit.

- Add an error message to the log when the management i/f returns
  ERROR for incorrectly parsed commands. Otherwise such errors go
  unnoticed.

Note: IDS_ERR_INVALID_USERNAME/PASSWORD need translations.

Reported and tested by: Florian Beier (H4ndl3 on github)
Fixes Trac: #958

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-11-20 09:53:31 -05:00
Selva Nair 8eb06fa697 Correct parsing of the process ID returned by interatcive service
Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-11-20 09:53:31 -05:00
Samuli Seppänen 82812df1a8
Merge pull request #196 from chipitsine/fix_appveyor
AppVeyor: use proper way to resolve project path
2017-11-20 10:48:22 +02:00
Samuli Seppänen d0105369b5
Merge pull request #195 from chipitsine/modernize_mingw
switch travis-ci mingw to ubuntu 16.04
2017-11-20 10:37:25 +02:00
Ilya Shipitsin 4d75ca9bd6 travis-ci: switch mingw to ubuntu 16.04 2017-11-20 10:23:31 +05:00
Ilya Shipitsin e76c69ac81 AppVeyor: use proper way to resolve project path
APPVEYOR_PROJECT_SLUG point to project path properly, when
repo is cloned, deleted and cloned again
2017-11-19 12:22:51 +05:00
Selva Nair fd0fda5480
Merge pull request #151 from chipitsine/silence_mingw
change "%S" to "%ls" to silence mingw warning

Acked-by: Selva Nair <selva.nair@gmail.com>
2017-11-18 21:58:05 -05:00
MaxXor 6fa818dcb0 Update german translation 2017-10-11 15:05:34 +02:00
Samuli Seppänen de777b8fb1 Merge pull request #184 from bubuleur/patch-1
Update of the French version of Open Vpn GUI
2017-10-07 13:53:31 +03:00
bubuleur 7c5ce7bcba Update openvpn-gui-res-fr.rc 2017-10-05 13:30:36 +02:00
Samuli Seppänen d162894d43 Merge pull request #182 from ffes/editorconfig
Add EditorConfig file
2017-09-26 15:59:31 +03:00
Samuli Seppänen 63c4211414 Bump version to 11.9.0.0
Signed-off-by: Samuli Seppänen <samuli.seppanen@gmail.com>
2017-09-26 12:28:24 +03:00
Selva Nair 2e388f5b84 Merge pull request #187 from selvanair/highlight-logs
Highlight warning and error messages in status window

Acked-by: Gert Doering <gert@greenie.muc.de>
2017-09-23 12:32:28 -04:00
Selva Nair 23ac3c00bb Highlight warning and error messages in status window
- Change text color of log lines with flags = W, N, F

v2: replace strchr with memchr to avoid modifying line

Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-09-23 12:19:55 -04:00
bubuleur c8e825ca28 Update openvpn-gui-res-fr.rc 2017-08-29 11:30:12 +02:00
bubuleur bf826353d1 Update openvpn-gui-res-fr.rc 2017-08-29 09:53:09 +02:00
Samuli Seppänen e71d993cc3 Merge pull request #181 from ffes/msys2-build-instructions
Add instruction how to build using MSYS2
2017-08-28 14:49:33 +03:00
Samuli Seppänen 77b877de6e Merge pull request #180 from ffes/dutch-translation
Updated Dutch translation
2017-08-27 20:53:52 +03:00
bubuleur c1237891ae Update of the French version of Open Vpn GUI
Hello,
I just put my contribution for the French translation of OpenVpn Gui
Can you put it in the next update
In thanking you
(The next update is for when?)
2017-08-27 14:59:55 +02:00
Frank Fesevur d0579b1b0d Fix use of backticks 2017-08-16 10:23:04 +02:00
Frank Fesevur cd8f1c8ee6 Update header to be consistent with the others 2017-08-15 10:21:32 +02:00
Frank Fesevur 133cee76da Add EditorConfig file 2017-08-14 23:44:24 +02:00
Frank Fesevur 99d5dbd228 Add instruction how to build using MSYS2 2017-08-14 22:58:56 +02:00
Frank Fesevur 735f4761b5 Give text the space it needs 2017-08-14 22:57:51 +02:00
Frank Fesevur cfdfb2d096 Translate title of tab 2017-08-14 22:57:15 +02:00
Samuli Seppänen f38441e3bf Merge pull request #178 from mattock/master
Bump version to 11.8.0.0
2017-07-25 18:48:06 +03:00
Samuli Seppänen 02bffb4a5d Bump version to 11.8.0.0
Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
2017-07-14 16:11:40 +03:00
Selva Nair 3010d78410 Merge pull request #171 from selvanair/warn-auth-failure-v2
Warn on auth failure

Acked by: Gert Doering <gert@greenie.muc.de>
2017-06-27 16:51:31 -04:00
Pavel Zhovner 9c7a8af3d3 Ukranian translation for auth failure warnings
- Text width increased to avoid clipped text during commit
  by Selva Nair
2017-06-27 16:05:07 -04:00
Selva Nair d127bab27f Fix buttons overlapping with text in auth dialog for Korean
Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-06-27 16:05:07 -04:00
Selva Nair 29a8bba38c Resize private key password dialog to avoid clipped text
Signed-off-by: Selva Nair <selva.nair@gmail.com>
2017-06-27 16:05:07 -04:00