Browse Source

Add TCPSynRetrans to netstat default filter (#1143)

Tcp SYN packet retransmits are a very useful signal as they affect
network performance disproportionately to regular TCP retransmits.

Signed-off-by: Ben Kochie <superq@gmail.com>
pull/1150/head
Ben Kochie 6 years ago committed by GitHub
parent
commit
b1eec66640
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      CHANGELOG.md
  2. 2
      collector/netstat_linux.go

2
CHANGELOG.md

@ -5,7 +5,7 @@
### Changes ### Changes
* [BUGFIX] * [BUGFIX]
* [CHANGE] * [CHANGE] Add TCPSynRetrans to netstat default filter #1143
* [ENHANCEMENT] Add Infiniband counters #1120 * [ENHANCEMENT] Add Infiniband counters #1120
* [FEATURE] * [FEATURE]

2
collector/netstat_linux.go

@ -33,7 +33,7 @@ const (
) )
var ( var (
netStatFields = kingpin.Flag("collector.netstat.fields", "Regexp of fields to return for netstat collector.").Default("^(.*_(InErrors|InErrs)|Ip_Forwarding|Ip(6|Ext)_(InOctets|OutOctets)|Icmp6?_(InMsgs|OutMsgs)|TcpExt_(Listen.*|Syncookies.*)|Tcp_(ActiveOpens|PassiveOpens|RetransSegs|CurrEstab)|Udp6?_(InDatagrams|OutDatagrams|NoPorts))$").String() netStatFields = kingpin.Flag("collector.netstat.fields", "Regexp of fields to return for netstat collector.").Default("^(.*_(InErrors|InErrs)|Ip_Forwarding|Ip(6|Ext)_(InOctets|OutOctets)|Icmp6?_(InMsgs|OutMsgs)|TcpExt_(Listen.*|Syncookies.*|TCPSynRetrans)|Tcp_(ActiveOpens|PassiveOpens|RetransSegs|CurrEstab)|Udp6?_(InDatagrams|OutDatagrams|NoPorts))$").String()
) )
type netStatCollector struct { type netStatCollector struct {

Loading…
Cancel
Save