Commit Graph

35201 Commits (f5077ff80622443ea77ca31537b7e7e42069532f)

Author SHA1 Message Date
Kubernetes Submit Queue f5077ff806 Merge pull request #31990 from girishkalele/esipp_portleaks
Automatic merge from submit-queue

Fix service health check node port leaks

Fixed #31757
2016-09-09 15:36:38 -07:00
Kubernetes Submit Queue a69752c81f Merge pull request #31944 from m1093782566/m109-master-fix-found
Automatic merge from submit-queue

[Pet Set] Clean up code

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

Clean code of petset, from:

```
func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, bool, error)
```

to:

```
func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, error) 
```

I think the 2nd(bool type) return value of [getPVC](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L228) is unnecessary, as the caller can be responsible for checking the error type and tell if it exists via the [error type](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L231-L233).

So, I remove the 2nd return value of `getPVC()`.

The benefit of this change is that we can simplify the code of `getPVC()` while don't increase the caller's code.
2016-09-09 15:00:22 -07:00
Kubernetes Submit Queue 9d06efb2d1 Merge pull request #31606 from wojtek-t/scheuler_map_reduce
Automatic merge from submit-queue

POC: MapReduce-like scheduler priority functions

Ref #24246
2016-09-09 14:24:05 -07:00
Kubernetes Submit Queue 7536eb2691 Merge pull request #32351 from caesarxuchao/fix-finalizer
Automatic merge from submit-queue

Make sure finalizers prevent deletion on storage that supports graceful deletion

Fixing bug:
Non-empty Finalizers fails to prevent a pod from being deleted, if deleteOptions.GracefulPeriod=0. See https://github.com/kubernetes/kubernetes/issues/32157#issuecomment-245778483

We didn't hit any issue with orphan finalizer because all our tests set finalizers on RC or RS, whose storage doesn't support graceful deletion.

cc @thockin @lavalamp
2016-09-09 13:47:47 -07:00
Kubernetes Submit Queue 65f3fa9caf Merge pull request #31828 from girishkalele/esipp_toggle
Automatic merge from submit-queue

Service behaviour not correct when ESIPP annotation is toggled or deleted

Fixes #31649 

GCE controller: Correctly add/remove http health checks based on whether the annotation was added or removed

kube-proxy: Create/Delete XLB local-endpoints balancer chain and change jump actions from KUBE-FW- chain based on the annotation.
2016-09-09 13:09:59 -07:00
Kubernetes Submit Queue e317af87cc Merge pull request #31819 from mtaufen/plumb-feature-gates
Automatic merge from submit-queue

Plumb --feature-gates from TEST_ARGS to components in node e2e tests

This means you can set `TEST_ARGS` on the command line, in a `.properties` config for a Jenkins job, etc, to toggle gated features. For example:

`TEST_ARGS='--feature-gates=DynamicKubeletConfig=true'`

/cc @vishh @jlowdermilk
2016-09-09 12:31:00 -07:00
Kubernetes Submit Queue ba4dba8be2 Merge pull request #31607 from jsafrane/describe-storageclass
Automatic merge from submit-queue

Add kubectl describe storageclass.

Sample output:

```
Name:		fast
Annotations:	storage.beta.kubernetes.io/default-class=true
Provisioner:	kubernetes.io/aws-ebs
Parameters:	type=gp2
No events.

Name:		slow
Annotations:	<none>
Provisioner:	kubernetes.io/aws-ebs
Parameters:	type=sc1
No events.
```
(it looks nicely aligned in terminal)

Proposing 1.4, it's bugfix, not a feature.
2016-09-09 11:52:42 -07:00
Kubernetes Submit Queue 1d0404466d Merge pull request #32396 from adityakali/cleanup
Automatic merge from submit-queue

Update Container-VM Image product name in docs
2016-09-09 11:11:15 -07:00
Kubernetes Submit Queue bdb44671da Merge pull request #32327 from Kashomon/hazelcast
Automatic merge from submit-queue

Update the hazelcast version to 0.6.1 fix some flakiness.

**What this PR does / why we need it**:

Should fix flaky test

**Which issue this PR fixes**

https://github.com/kubernetes/kubernetes/issues/30672

**Special notes for your reviewer**:

Note: I manually updated the readme because mungedocs was having
trouble.

**Release note**:
NONE
2016-09-09 11:11:10 -07:00
Kubernetes Submit Queue 3ddd39cd97 Merge pull request #32239 from zmerlynn/aws-bringup-fail
Automatic merge from submit-queue

AWS: Change default networking for kube-up to kubenet

**What this PR does / why we need it**: Fixes AWS bring-up. Again.

There's a kubelet bug that prevents NETWORK_PROVIDER=none from working right now, and we should migrate AWS to `kubenet` anyways.

Working on reproing the `none` issue on GCE, then I'll file a bug on the main issue. But this fixes AWS, so quick tactical fix.
2016-09-09 10:32:20 -07:00
Aditya Kali d5e4cfa2c0 Update Container-VM Image product name in docs 2016-09-09 10:08:56 -07:00
Kubernetes Submit Queue f535aea7fd Merge pull request #32359 from wojtek-t/rollback_etcd
Automatic merge from submit-queue

Use etcd 2.3.7

This will switch to etcd 2.3.7 for release 1.4, to resolve issues rolling back from 1.4 to 1.3 (while preventing those same issues rolling back to 1.4.0 from a release including etcd 3.0.x).

Fixes #32253.

See #32253 (comment) for etcd roadmap.
2016-09-09 09:53:02 -07:00
Kubernetes Submit Queue cd30526b44 Merge pull request #32379 from wojtek-t/allow_for_notready_nodes_in_scalability
Automatic merge from submit-queue

Allow for not-ready nodes in WaitForAllNodesSchedulable

Ref #31215
2016-09-09 06:47:36 -07:00
Kubernetes Submit Queue 603212f33e Merge pull request #32201 from soltysh/audit_namespace
Automatic merge from submit-queue

Fix namespace in audit logs

@sttts apparently previous logic was not good enough to read the namespace, which I haven't noticed on time. ptal
2016-09-09 06:47:31 -07:00
Wojciech Tyczynski dc3dcc27d2 Allow for not-ready nodes in WaitForAllNodesSchedulable 2016-09-09 14:56:43 +02:00
Wojciech Tyczynski 80f56d831c Merge pull request #32376 from deads2k/storage-04-re-disable-test
skip dynamic provisision test on gke until gke enables it
2016-09-09 13:53:48 +02:00
deads2k 786879aa9b skip dynamic provisision test on gke until gke enables it 2016-09-09 07:45:40 -04:00
Kubernetes Submit Queue 0e7f8f9f02 Merge pull request #32298 from wojtek-t/hwm_in_cacher
Automatic merge from submit-queue

Log water mark for incoming queue in cacher

Ref #32257
2016-09-09 04:06:57 -07:00
Kubernetes Submit Queue d139177529 Merge pull request #32317 from sdodson/master
Automatic merge from submit-queue

Fix 127.0.01 typo

**What this PR does / why we need it**:
Fixes a small typo, though typo seems inconsequential

**Release note**:
none
2016-09-09 04:06:52 -07:00
Kubernetes Submit Queue 61f321fc12 Merge pull request #32363 from gmarek/limits
Automatic merge from submit-queue

Remove explicit limits from manifest files

Current setting make those addons OOM in 2k Node clusters.

cc @piosz @mwielgus @bprashanth
2016-09-09 04:06:48 -07:00
Maciej Szulik b19fcdce29 Fix namespace in audit logs 2016-09-09 11:43:28 +02:00
Kubernetes Submit Queue dfb6c5c3ba Merge pull request #31946 from thockin/dont-assign-to-sami
Automatic merge from submit-queue

Don't assign anything to Sami anymore

@pwittrock anything new to do to tag for cherry pick to 1.4?
2016-09-09 02:36:45 -07:00
Kubernetes Submit Queue a0fed361e0 Merge pull request #32200 from deads2k/storage-03-enable-test
Automatic merge from submit-queue

re-enable provisioning test

Reverts https://github.com/kubernetes/kubernetes/pull/32199 for when the gke control plane is updated.  This should be merged AFTER gke is ready.

@kubernetes/sig-storage @wojtek-t
2016-09-09 02:36:41 -07:00
Wojciech Tyczynski 03a23aed09 Log water mark for incoming queue in cacher 2016-09-09 11:35:05 +02:00
gmarek c304fa1f06 Remove explicit limits from manifest files 2016-09-09 11:19:54 +02:00
Kubernetes Submit Queue ff9e1daf33 Merge pull request #32358 from wojtek-t/fix_nodes_checking
Automatic merge from submit-queue

Fix checking for allowed not-ready nodes in test framework

Ref #31215
2016-09-09 01:37:49 -07:00
Kubernetes Submit Queue 95771b12e9 Merge pull request #32340 from lavalamp/serveralloctest
Automatic merge from submit-queue

add more details to TestServiceAlloc failure

To debug #32028
2016-09-09 01:37:45 -07:00
Kubernetes Submit Queue dceb33d120 Merge pull request #32097 from brendandburns/dev
Automatic merge from submit-queue

Don't return an error if a file doesn't exist for IsPathDevice(...)

Fixes https://github.com/kubernetes/kubernetes/issues/30455

@saad-ali @thockin fyi, since linux devices and storage.
2016-09-09 01:37:40 -07:00
Wojciech Tyczynski ccb61d86a4 Comment migration test after rollback to 2.2.1 etcd 2016-09-09 09:50:48 +02:00
Kubernetes Submit Queue 08b6eaff92 Merge pull request #30321 from fejta/check-resources
Automatic merge from submit-queue

Convert bool to error, helper func for cd to skew

Switch from various functions returning `False` when something bad happens to returning an `error`
Encapsulate logic to switch to the skew directory inside chdirSkew

Also add a TODO for using `hyphen-flags` instead of `underscore_flags`
2016-09-09 00:48:19 -07:00
Kubernetes Submit Queue 8780961e94 Merge pull request #32112 from soltysh/test_owners
Automatic merge from submit-queue

Updated test owners and assigned ScheduledJobs to soltysh

I've updated test owners by running `hack/update_owners.py` and assigned all ScheduledJob related issues to myself. 

@fejta ptal
2016-09-09 00:48:14 -07:00
Daniel Smith 279219ca89 Use etcd 2.3.7 (container already pushed) 2016-09-09 09:45:53 +02:00
Wojciech Tyczynski c517811fc8 Fix checking for allowed not-ready nodes in test framework 2016-09-09 09:38:47 +02:00
Kubernetes Submit Queue 884e32c8fd Merge pull request #31299 from duglin/addFeature
Automatic merge from submit-queue

add pointer to feature repo

Add a pointer to the "features" repo so people know that they shouldn't just open up a new 'issue' in this one.

Signed-off-by: Doug Davis <dug@us.ibm.com>
2016-09-08 22:22:21 -07:00
Kubernetes Submit Queue 3651765077 Merge pull request #31714 from smarterclayton/sync
Automatic merge from submit-queue

Allow missing keys in jsonpath
2016-09-08 22:22:16 -07:00
Kubernetes Submit Queue bed9f4d36c Merge pull request #31320 from feiskyer/kuberuntime-sandboxid
Automatic merge from submit-queue

Kubelet: implement GetPodContainerID for new runtime API

Add implements of `GetPodContainerID` interface for new runtime API.

CC @yujuhong @kubernetes/sig-node @kubernetes/sig-rktnetes
2016-09-08 21:41:03 -07:00
Chao Xu fcf8853dd7 make sure finalizer prevents deletion on storage that supports graceful deletion 2016-09-08 21:00:49 -07:00
Kubernetes Submit Queue 5512104d36 Merge pull request #31559 from bprashanth/kubeproxy_test
Automatic merge from submit-queue

Networking test rewrite

Decomposes the old kubeproxy tests into (tcp, udp) tests for each of the following: 
* intra-pod
* node-pod
* pod-Service
* node-Service
* endpoint-Service
* delete endpoints, confirm unreachability
* delete nodeport, confirm unreachability
* kube-proxy /proxymode, /healthz

Also gets rid of the old network conformance test that used apiserver proxy to check reported peer count of a webserver in a container (the netexec pod used in this test does the same thing without apiserver proxy). 

Fixes https://github.com/kubernetes/kubernetes/issues/26490, https://github.com/kubernetes/kubernetes/issues/14204
2016-09-08 19:37:32 -07:00
Kubernetes Submit Queue 99493570c3 Merge pull request #32268 from mdshuai/imagefs-inodes
Automatic merge from submit-queue

correct imagefs inodes value in kubelet summary stats

Fix https://github.com/kubernetes/kubernetes/issues/31501
Correct get imagefs inodes value from imageFsInfo.Inodes in kubelet summary stats api. 

@derekwaynecarr
2016-09-08 17:19:21 -07:00
Daniel Smith 2d6dd159d2 add more details to failure 2016-09-08 17:14:59 -07:00
Kubernetes Submit Queue e4909db6a3 Merge pull request #32144 from nikhiljindal/freshDebugNs
Automatic merge from submit-queue

Updating federation api ref docs

Updating API ref docs to include changes from https://github.com/kubernetes/kubernetes/pull/31925.

PR generated by running `hack/update-federation-api-reference-docs.sh`

cc @kubernetes/sig-cluster-federation
2016-09-08 15:54:20 -07:00
Josh Hoak 0d36aaca45 Update the hazelcast version to 0.6.1 fix some flakiness.
Note: I manually updated the readme because mungedocs was having
trouble.
2016-09-08 15:44:55 -07:00
Kubernetes Submit Queue 0037b67cdf Merge pull request #32245 from aaronlevy/bump-kube-cross
Automatic merge from submit-queue

Fix `make release` breaking due to incorrect etcd version

`make release` fails with `etcd version 3.0.4 or greater required` when attempting to run integration tests.

Looks like etcd version was bumped in: https://github.com/kubernetes/kubernetes/pull/30508 (also once prior to that as well), but the kube-cross image version was not bumped in `build/build-image/cross/VERSION`

I did a manual check and and it looks like a `gcr.io/google_containers/kube-cross:v1.6.3-3` already exists and it does contain etcd v3.0.4
2016-09-08 15:04:31 -07:00
Matt Liggett fc3ef9320e Merge pull request #32314 from dims/fix-external-lb-source-ip-preservation-doc
Fix external-lb-source-ip-preservation.md
2016-09-08 14:21:54 -07:00
Scott Dodson 36d3dfcf9b Fix 127.0.01 typo 2016-09-08 16:45:50 -04:00
Davanum Srinivas 59798ed239 Fix external-lb-source-ip-preservation.md
Fixes #32313
2016-09-08 15:39:29 -04:00
Kubernetes Submit Queue 93f8b87d2b Merge pull request #32235 from david-mcmahon/push-build
Automatic merge from submit-queue

Change push-ci-build.sh to push-build.sh.
2016-09-08 11:53:42 -07:00
Kubernetes Submit Queue 986fe3bf0e Merge pull request #32302 from derekwaynecarr/tpr-flaky
Automatic merge from submit-queue

Mark ThirdParty e2e tests flaky

The root issue:
Fixes https://github.com/kubernetes/kubernetes/issues/32296

The other related side-effect issues that this should resolve:

Fixes https://github.com/kubernetes/kubernetes/issues/32237
Fixes https://github.com/kubernetes/kubernetes/issues/32168
Fixes https://github.com/kubernetes/kubernetes/issues/32132
Fixes https://github.com/kubernetes/kubernetes/issues/32122
Fixes https://github.com/kubernetes/kubernetes/issues/32087
Fixes https://github.com/kubernetes/kubernetes/issues/32054
Fixes https://github.com/kubernetes/kubernetes/issues/32053
Fixes https://github.com/kubernetes/kubernetes/issues/32045
Fixes https://github.com/kubernetes/kubernetes/issues/32043
Fixes https://github.com/kubernetes/kubernetes/issues/32025

@lavalamp @pwittrock @ncdc @kubernetes/sig-api-machinery @brendandburns @smarterclayton
2016-09-08 11:53:36 -07:00
Kubernetes Submit Queue 36bc5b11c3 Merge pull request #32232 from Random-Liu/avoid-syncpod-when-no-mirrorpod
Automatic merge from submit-queue

Avoid unnecessary status update when there is no corresponding mirror pod

Fixes https://github.com/kubernetes/kubernetes/issues/32191.

This PR changes status manager to skip update when there is no mirror pod for a static pod.
We need this because:
1) When static pod terminates and mirror pod is deleted, this will avoid extra `syncPod`.
2) During mirror pod creation and recreation, this will avoid unnecessary `syncPod`.

Mark P1 to match the original issue.

@wojtek-t @yujuhong 
/cc @kubernetes/sig-node
2016-09-08 11:53:31 -07:00
Girish Kalele 02754547fb Fix service health check node port leaks 2016-09-08 11:36:06 -07:00