Automatic merge from submit-queue
CRI: Symlink docker logs to CRI defined log path.
This PR symlink docker logs to the CRI defined log path.
I manually test myself, and it works. We still need some more unit test and a node e2e test.
@resouer is working on a node e2e test https://github.com/kubernetes/kubernetes/issues/34661.
For the unit test, the current `MakeFakePodSandbox` and `MakeFakeContainer` is not enough for unit test, because I need to create multiple instances for one container and sandbox to test garbage collection.
I'll send a separate PR to refactor the unit test framework in kuberuntime and finish the unit test.
@yujuhong @feiskyer
/cc @kubernetes/sig-node
Automatic merge from submit-queue
kubeadm: added unit tests for app/images pkg
Added unit tests for kubeadm/app/images package testing functionality of images.go.
This PR is part of the ongoing effort to add tests (#35025)
/cc @pires @jbeda
Automatic merge from submit-queue
Add verbose mode to boilerplate
hack/verify-boilerplate.sh -v will now print out why the file does
not match along with a diff if possible.
Automatic merge from submit-queue
Refactor some functions in kube-dns to reduce surface area
- Moves federation query path out to its own method
- Creates dns/util and moves some trivial methods to that package
This is just moving of code.
hack/verify-boilerplate.sh -v will now print out why the file does
not match along with a diff if possible.
Note: boilerplate.py now has a unit test that is run along with
hack/verify-boilerplate.sh.
Automatic merge from submit-queue
enhance join arguments generation logic using template
**What this PR does / why we need it**:
this PR enhances kubeadm join arguments generation logic using template, this makes code more readable and adding arguments more easier.
**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
**Special notes for your reviewer**:
**Release note**:
<!-- Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access)
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.
-->
```release-note
```
Signed-off-by: 欧阳钦华10079130 <ouyang.qinhua@zte.com.cn>
Automatic merge from submit-queue
Add authentication to openapi Spec
We need authentication definition in OpenAPI spec to be able to generate a client with authorization.
Automatic merge from submit-queue
Kubelet getting node from apiserver cache before update.
This is blocked on #35218 (however it's ready for review).
It seems to visibly reduce the apiserver metrics (and I didn't observe higher number of conflicts even in 2000-node kubemark).
Automatic merge from submit-queue
service e2e: remove TODO and subtle changes in logging
Removes the stale `TODO` for external source IP preservation as the e2e test of ESIPP was added.
Changes logging in create service functions: namespace/namespace -> namespace/serviceName.
@bprashanth
Automatic merge from submit-queue
ignore default.etcd directory
When using `hack/install-etcd.sh`, `/default.etcd` is created for the data directory. Add that to `.gitignore`.
```release-note
NONE
```
Automatic merge from submit-queue
proposals: Add Volume Hostpath "type" proposal
This is a continuation of #31384. It's related to #26816 as well.
The discussion in #31384 is worth reading and this proposal largely derives from my comments there.
cc @thockin @pmorie @saad-ali @kubernetes/sig-storage
cc @yujuhong since it talks briefly about kubelet doing more
cc @calebamiles I think we might need a "Feature" for this since it's an api change, though a minor one?
Automatic merge from submit-queue
Create restclient interface
Refactoring of code to allow replace *restclient.RESTClient with any RESTClient implementation that implements restclient.RESTClientInterface interface.
Automatic merge from submit-queue
Eliminate half-baked multi-architecture support
**What this PR does / why we need it**:
We have release `kubeadm` with half-baked support for clusters with nodes of different CPU architectures. The problem with the code as it stand is that user will notice pending daemonsets of `kube-proxy` for machines with architectures that they don't have. At the same time, the code as it stand did not pick up correct images for architectures it wanted to allow. Additionally, it only treated `kube-proxy` in such a way, but didn't do anything about `kube-dns`. This removes multiple daemonesets, but ensures that whichever resources we deploy have node affinity set to the architecture native to the master. Users wishing to use mixed architectures can still create extra daemonsets via the API.
**Which issue this PR fixes**: fixes#33916
**Release note**:
```release-note
Remove support for multi-architecture code in `kubeadm`, which was released untested.
```
Maciej Szulik