Brendan Burns
72db883b90
Merge pull request #11050 from marekbiskup/dns-example-e2e
...
e2e test for dns example
2015-07-29 13:10:26 -07:00
Mike Danese
e864569f80
Merge pull request #11003 from jayunit100/prom-push
...
[contrib + e2e] prometheus: add pushgateway functionality to prometheus allinone deployment along w/ runRC Gauge reporting.
2015-07-29 11:12:02 -07:00
Mike Danese
b1730b35e4
Merge pull request #11785 from timstclair/tests
...
Use prometheus extraction library for metric parsing in e2e tests
2015-07-29 10:53:19 -07:00
jayunit100
739e79dd9f
Modularized implementation of prompush json with e2e running pending push gateway gauges.
2015-07-28 09:29:57 -04:00
Marek Biskup
860822431b
e2e test for dns example
2015-07-28 08:34:38 +02:00
Marek Biskup
eb43cbb5dc
e2e: reading stdin in kubectl
2015-07-28 08:30:59 +02:00
Jeff Lowdermilk
69166f17ad
e2e test for `kubectl proxy`
2015-07-27 09:57:33 -07:00
Marek Grabowski
7b9e2ac63b
Merge pull request #11734 from thockin/cleanup-deprecated-rest-alias
...
Remove deprecated 'se' resource alias
2015-07-27 12:56:43 +02:00
Marek Grabowski
831827b4bb
Merge pull request #11056 from wojtek-t/rewrite_services_in_go
...
Rewrite services shell test in Go.
2015-07-27 09:21:44 +02:00
Mike Danese
6ca0151ff1
Merge pull request #11807 from mwielgus/scale_rc_fix
...
Add scale retry in ScaleRC in test/e2e/util.go
2015-07-24 15:25:48 -07:00
Janet Kuo
565a13e8db
E2E tests for kubectl run command
2015-07-24 11:23:07 -07:00
Tim St. Clair
a244357ccd
Use prometheus extraction library for metric parsing in e2e tests
2015-07-24 10:28:46 -07:00
Marcin Wielgus
561dd7d18b
Add scale retry in ScaleRC in test/e2e/util.go
2015-07-24 14:12:55 +02:00
Jerzy Szczepkowski
496895d610
Revert "Improve SSH logging for debugging"
2015-07-24 13:36:16 +02:00
Jerzy Szczepkowski
0be5405afd
Merge pull request #11685 from piosz/autoscaling_e2e
...
Added cluster size autoscaling e2e test
2015-07-24 10:26:33 +02:00
Max Forbes
e24ab02f05
Move e2e SSH utils to e2e/ssh package; improve SSH logging.
2015-07-23 17:57:46 -07:00
Tim Hockin
c4b707192d
Remove deprecated 'se' resource alias
2015-07-23 12:04:01 -07:00
Wojciech Tyczynski
fdd7f1e4b2
Rewrite services shell test in Go.
2015-07-23 16:16:45 +02:00
Wojciech Tyczynski
959477463f
Migrate tests to non-default namespaces
2015-07-23 12:04:10 +02:00
Piotr Szczesniak
6b6d2c6aef
Added cluster size autoscaling e2e test
2015-07-22 17:26:07 +02:00
Janet Kuo
b2e8936d1c
Fix the bug that some waits don't actually happen
2015-07-14 10:45:56 -07:00
Satnam Singh
910603bba9
Fix reboot test to use system namespace
2015-07-11 09:05:05 -07:00
Rohit Jnagal
6dc16f9442
Merge pull request #11005 from mbforbes/upgradePickVersion
...
Allow upgrade target version to be specified
2015-07-10 15:20:29 -07:00
Rohit Jnagal
e3b8ad945b
Merge pull request #11019 from caesarxuchao/e2e_waitforallpods
...
ignore pods that are failed but controlled by a rc when start e2e tests
2015-07-10 12:22:01 -07:00
Max Forbes
3d9de02b78
Move code to prepare for e2e/restart transition
2015-07-09 16:02:27 -07:00
Chao Xu
3db73bbe8c
ignore pods that are failed but controlled by a rc when start e2e tests
2015-07-09 15:44:55 -07:00
Max Forbes
7cfabea2d3
E2E upgrade test: allow upgrade target version to be specified via command line.
2015-07-09 14:28:58 -07:00
Victor Marmol
fbc6e7f5f5
Merge pull request #11008 from krousey/nodesflake
...
Adding polling to all node readiness
2015-07-09 14:23:29 -07:00
Kris Rousey
3058ddad19
Adding polling to all node readiness
2015-07-09 12:26:16 -07:00
Piotr Szczesniak
3fb39542d0
Added load test with pods doing real works
2015-07-08 11:01:41 +02:00
saadali
e89f3375f2
Fix "Docker Containers should be able to override the image's default commmand" tests
2015-07-07 15:52:01 -07:00
Wojciech Tyczynski
54f2305dec
Check whether all nodes are healthy in e2e framework
2015-07-07 13:53:03 +02:00
Prashanth Balasubramanian
b0bbd5b8d5
Don't ignore containers restarting during tests
2015-07-06 18:36:59 -07:00
Yu-Ju Hong
c8f8e5f333
Merge pull request #10649 from mesosphere/service-test-timeout
...
Add timeout to service endpoint resolution e2e test
2015-07-06 15:05:36 -07:00
Prashanth Balasubramanian
7bc32b5a47
Use gcloud to list nodes so we know their ips
2015-07-05 13:44:18 -07:00
Prashanth Balasubramanian
f2b687d53f
Density logging
2015-07-05 13:28:36 -07:00
Justin Santa Barbara
fca7822800
Misc (non-code) spelling fixes
2015-07-04 10:39:37 -04:00
Karl Isenberg
f1d6439c2e
Add timeout to service endpoint resolution e2e test
2015-07-01 14:58:37 -07:00
Jeff Lowdermilk
4b36b421aa
e2e test for kubectl exec, port-forward
2015-07-01 10:56:10 -07:00
Jordan Liggitt
ecebac9395
Add option to require API tokens to exist in admission
2015-06-30 16:12:45 -04:00
Alex Robinson
450d36f7af
Merge pull request #10301 from satnam6502/e2e
...
Retry namespace creation for e2e tests
2015-06-29 14:32:32 -07:00
Marek Biskup
01e1d3710a
add description to timeout messages
2015-06-29 10:25:39 +02:00
Robert Bailey
198b334227
Merge pull request #10197 from mesosphere/ginkgo-skip
...
Use ginkgo's new Skip()
2015-06-26 10:44:34 -07:00
Satnam Singh
59ee8c24ea
Retry namespace creation for e2e tests
2015-06-25 12:18:42 -07:00
Maxwell Forbes
d0eeb98e27
Merge pull request #10215 from ZJU-SEL/enhance-testContainerOutput
...
Enhance test api to support test cases involved multiple containers
2015-06-25 10:56:13 -07:00
Maxwell Forbes
8b0efe8b85
Merge pull request #10345 from wojtek-t/increase_rc_timeout
...
Increase timeout for waiting for pods running in load test
2015-06-25 10:00:05 -07:00
Karl Isenberg
32a09cfcee
Use Ginkgo Skip() to avoid failing when tests are skipped
...
- Added util methods: Skipf, SkipUnlessNodeCountIsAtLeast, SkipIfProviderIs,
and SkipUnlessProviderIs
2015-06-25 09:50:25 -07:00
Wojciech Tyczynski
c151f6bc1f
Increase timeout for waiting for RC in load test
2015-06-25 12:11:01 +02:00
He Simei
912e54789e
Enhance test api to support test cases involved multiple containers
2015-06-25 09:29:19 +08:00
Maxwell Forbes
26d3a4429d
Merge pull request #9816 from erictune/conformance
...
Revive conformance test.
2015-06-24 13:20:46 -07:00
Wojciech Tyczynski
8ca4d10026
Fix logging in scalability tests
2015-06-24 11:40:08 +02:00
Wojciech Tyczynski
5b4dc4edaa
Merge pull request #10225 from wojtek-t/increase_deleting_namespace_timeout
...
Increase timeout for namespace deletion.
2015-06-24 08:35:02 +02:00
Wojciech Tyczynski
6b6b409814
Increase timeout for namespace deletion.
2015-06-24 08:05:26 +02:00
Wojciech Tyczynski
2a1834f7ed
Reset metrics in tests
2015-06-24 08:04:21 +02:00
Eric Tune
c5efb12a62
Revive conformance test.
...
Use KUBE_CONFIG_FILE instead of AUTH_CONFIG (and CERT_DIR).
Pass GINKGO_TEST_ARGS for a subset of e2e tests which
@erictune has deemed initially sufficient for conformance.
Allow GINKGO_TEST_ARGS to pass through hack/ginkgo-e2e.sh.
Set NUM_MINIONS (need better way to handle this).
Remove use of "KUBERNETES_CONFORMANCE_TEST" variable
and use of KUBERNETES_PROVIDER="conformance_test" convention,
both of which have no apparent purpose.
Allow unset testContext.provider in test/e2e/e2e_test.go
Allow testContext.Provider to be unset in providerIs().
2015-06-22 22:29:02 -07:00
Jeff Lowdermilk
bec793119b
Merge pull request #10175 from wojtek-t/wait_for_namespaces
...
In scalability tests wait until terminating namespaces are deleted
2015-06-22 13:21:52 -07:00
Wojciech Tyczynski
47b6e6a84e
Wait for terminating namespaces deletion
2015-06-22 14:53:05 +02:00
Justin Santa Barbara
efdd03a6a9
Don't assume we always SSH as the current user
...
This works on gcloud (where the user is dynamically created by the tool),
but doesn't hold on other clouds (e.g. AWS).
The function in pkg/util now takes a user arg, and it is called only
from the e2e tests, which now check for env-var KUBE_SSH_USER, and then
fall back to the existing behaviour of env-var USER.
I am using this from Jenkins by directly setting the env-var:
export KUBE_SSH_USER=jenkins
...
hack/jenkins/e2e.sh
2015-06-20 18:18:38 -04:00
Max Forbes
434f968715
GKE upgrade tests
2015-06-20 09:44:19 -07:00
Max Forbes
2803fbe343
Node upgrade tests.
2015-06-18 15:59:51 -07:00
Marek Biskup
a02752ad12
stabilization of Network.should survive network partition
2015-06-18 16:39:27 +02:00
Justin Santa Barbara
b4150dc928
AWS: e2e: Add support for getSigner for AWS
2015-06-17 00:35:47 -04:00
Marek Biskup
dcc4034d57
e2e test for addon update
2015-06-15 17:37:24 +02:00
Marek Grabowski
01f0eac2bd
Merge pull request #9714 from fgrzadkowski/debug_scalability
...
Fix printing deleted pods from RC during e2e tests
2015-06-15 13:29:59 +02:00
Daniel Smith
e29245f710
add proxy tester
2015-06-12 17:17:43 -07:00
Filip Grzadkowski
4ffb4b2895
Fix printing deleted pods from RC during e2e tests
2015-06-12 16:15:29 +02:00
Marek Biskup
d89e1293a2
skip not ready nodes in networking test
2015-06-12 09:29:42 +02:00
Abhi Shah
bd6db7b175
Merge pull request #8793 from jayunit100/minpods
...
Parameterize minStartupPods
2015-06-11 11:22:44 -07:00
Marek Grabowski
0bee4aa76b
Merge pull request #9571 from fgrzadkowski/fix_load_test
...
Simplify e2e.RunRC method and wait up to 10 minutes for pods to start
2015-06-11 15:19:55 +02:00
Filip Grzadkowski
03f161def2
Simplify e2e.RunRC method and wait up to 10 minutes for pods to start
2015-06-11 14:22:47 +02:00
jayunit100
19b3017fb5
Parameterization of minStartupPods
2015-06-10 19:37:06 -04:00
Abhi Shah
547b3a7ef2
Merge pull request #9409 from lavalamp/e2eTestFix
...
switch to generateName for namespace creation
2015-06-10 13:31:10 -07:00
krousey
43a423f6fc
Merge pull request #9440 from brendandburns/ssh
...
Add an initial test for SSH.
2015-06-09 12:08:26 -07:00
krousey
cf4b4a313b
Merge pull request #9335 from swagiaal/e2e-test-prefix
...
Add a prefix option to e2e for use with resources
2015-06-09 11:50:02 -07:00
krousey
9740105a99
Merge pull request #8837 from mbforbes/rollingTest
...
E2E test node upgrade (to same version)
2015-06-09 10:42:17 -07:00
Sami Wagiaalla
899cf360ba
Add a prefix option to e2e for use with resources
...
This is helpful when cleaning manually up after a failed test in
shared a gce environment.
Signed-off-by: Sami Wagiaalla <swagiaal@redhat.com>
2015-06-09 13:29:41 -04:00
Filip Grzadkowski
ea7a615ce6
Refactor load test and reduce the load during the test.
2015-06-09 16:44:23 +02:00
Brendan Burns
2240486110
Add an initial test for SSH.
2015-06-08 20:53:05 -07:00
krousey
2bb0fc00e5
Merge pull request #9392 from jszczepkowski/e2e-net
...
Added e2e test case for network partition.
2015-06-08 11:35:28 -07:00
Daniel Smith
ace6e9d186
switch to generateName for namespace creation
2015-06-08 10:53:06 -07:00
Sami Wagiaalla
28d501d332
Fix createTestingNS function name in godoc
...
Signed-off-by: Sami Wagiaalla <swagiaal@redhat.com>
2015-06-08 11:15:58 -04:00
Jerzy Szczepkowski
445ae0f576
Added e2e test case for network partition.
...
Added e2e test case which verifies if a node can return to cluster after longer network partition. Valid for gce.
2015-06-08 14:08:32 +02:00
jayunit100
e93d317437
Add a --e2e-output-dir for use in e2e tests (default is /tmp/)
2015-06-05 19:15:50 -04:00
Quinton Hoole
4b84782e64
Merge pull request #9322 from liggitt/e2e_service_account_wait
...
Wait for default serviceaccount in e2e createTestingNS
2015-06-05 12:54:27 -07:00
Quinton Hoole
8b01ecb53a
Merge pull request #9024 from markturansky/recyc_controllers
...
PersistentVolumeRecycler controller
2015-06-05 11:39:08 -07:00
Jordan Liggitt
4754a6aea1
Wait for default serviceaccount in e2e createTestingNS
2015-06-05 13:33:23 -04:00
markturansky
b9d7b27bd0
Added watch to e2e instead of sleep, used GenerateName for objs
2015-06-04 23:08:46 -04:00
Chao Xu
d3664957b1
replace v1beta3 with v1 in e2e tests
2015-06-04 17:42:00 -07:00
Brian Grant
e7788771d6
Merge pull request #9030 from brendandburns/kubectl
...
Add a custom timeout flag for stop/delete.
2015-06-03 21:14:50 -07:00
Max Forbes
a6c47a07de
E2E test node upgrade (to same version)
2015-06-03 17:05:45 -07:00
Robert Rati
a248d0ccf9
Default RunRC to check every 10 seconds if an internval isn't provided. #7572
2015-06-03 15:00:28 -04:00
Robert Rati
4f9046332d
Minor fixes and clarifications. #7572
2015-06-03 15:00:27 -04:00
Robert Rati
4e05d85413
Fixed issue reading empty response from a get in getDebugInfo. #7572
2015-06-03 15:00:27 -04:00
Robert Rati
13b8d947fc
Revert "Revert "Added metrics/debug gathering methods to utils and used them in density ...""
...
This reverts commit 70500a64a7
.
2015-06-03 15:00:27 -04:00
Brendan Burns
ab0c9b8e1e
Add a custom timeout flag for stop/delete. Also try to be smarter about setting the timeout.
2015-06-03 11:21:30 -07:00
Brian Grant
43cc6ed3ed
Revert "Added e2e test case for network partition."
2015-06-03 07:04:41 -07:00
Piotr Szczesniak
f71baba64f
Increased failCount param in RunRC function for e2e tests.
...
The previous value was 10 (equivalent of 50sec) current is 24 (2min).
Time in brackets mean: how long should I wait for the next pod of RC to be created.
While we are creating 3000 pods for scalability tests it tends to fail.
2015-06-03 13:50:51 +02:00
Filip Grzadkowski
98115facfd
Revert "Gracefully delete pods from the Kubelet"
2015-06-02 23:40:05 +02:00
Brian Grant
464224f50d
Merge pull request #8862 from jszczepkowski/e2e-net
...
Added e2e test case for network partition.
2015-06-02 13:07:46 -07:00
Brian Grant
b7ae48eb1e
Merge pull request #8641 from smarterclayton/gracefully_delete_pods
...
Gracefully delete pods from the Kubelet
2015-06-02 10:36:27 -07:00
Jerzy Szczepkowski
44f11ea662
Added e2e test case for network partition.
...
Added e2e test case which verifies if a node can return to cluster after longer network partition. Valid for gce. Finally fixes to #7051 .
2015-06-02 13:09:21 +02:00
Filip Grzadkowski
d7f242b8b0
Merge pull request #8873 from piosz/load_generator
...
Re-enabled load e2e test for Jenkins scalability suite
2015-06-02 04:05:23 -07:00
Piotr Szczesniak
a2116f2bc1
Re-enabled load e2e test for Jenkins scalability suite
...
Also increased next pod startup waiting time from 100s to 200s
to eliminate flakiness by incresing failCount param.
2015-06-02 11:26:42 +02:00
Filip Grzadkowski
7580006771
Merge pull request #9059 from fgrzadkowski/watch_density
...
Use watch-based cache in density e2e tests.
2015-06-02 02:00:26 -07:00
Clayton Coleman
f1eaa8a27b
Delete resources immediately from e2e tests
2015-06-01 19:24:02 -04:00
Filip Grzadkowski
7814297acc
Use watch-based cache in density e2e tests.
2015-06-01 17:18:56 +02:00
Justin Santa Barbara
1e99426d5b
Support for AWS ELB
2015-05-29 18:53:35 -04:00
Rohit Jnagal
233ce46b83
Merge pull request #8923 from caesarxuchao/TerminationToTerminated
...
Update ContainerState.Termination to ContainerState.Terminated
2015-05-29 14:51:09 -07:00
Rohit Jnagal
d34d00c288
Merge pull request #8898 from brendandburns/tunnel
...
Move SSH code into a common util package. Add support for SSH tunnels.
2015-05-29 14:48:37 -07:00
Rohit Jnagal
38c1fe112f
Merge pull request #9006 from GoogleCloudPlatform/revert-8927-revert-8822-fifo_rc
...
Revert "Revert "Wake up rcs when pods get DeletionFinalStateUnknown t…
2015-05-29 11:11:38 -07:00
Rohit Jnagal
2c4ceca1cf
Merge pull request #8974 from lavalamp/networkTimeout
...
Use spew for more informative debug output
2015-05-29 09:33:54 -07:00
Rohit Jnagal
ff51f0b2e1
Merge pull request #8696 from derekwaynecarr/force_namespace_creation
...
Force explicit namespace provision, update e2e for failures
2015-05-29 09:28:47 -07:00
Prashanth B
6c209ec193
Revert "Revert "Wake up rcs when pods get DeletionFinalStateUnknown tombstones""
2015-05-29 09:24:39 -07:00
Daniel Smith
02b1331512
Use spew for more informative debug output
2015-05-28 17:20:42 -07:00
Chao Xu
2f6e5e2e08
Update ContainerState.Termination to ContainerState.Terminated in pkg/api/types.go and pkg/api/v1/types.go
2015-05-28 17:18:24 -07:00
Tim Hockin
081ab3abac
Merge pull request #8853 from caesarxuchao/HostToNodeName
...
update PodSpec.Host to PodSpec.NodeName
2015-05-28 15:50:12 -07:00
Chao Xu
9c1153322e
update PodSpec.Host to PodSpec.NodeName in /pkg/api/types.go and /pkg/api/v1beta3/types.go
2015-05-28 14:10:06 -07:00
derekwaynecarr
3e8b1d5e01
Update all salt providers to force explicit namespace creation; update e2e
2015-05-28 13:45:49 -04:00
Tim Hockin
b69fad211e
Revert "Wake up rcs when pods get DeletionFinalStateUnknown tombstones"
2015-05-28 10:23:55 -07:00
Wojciech Tyczynski
6ffe46a9e0
Merge pull request #8822 from bprashanth/fifo_rc
...
Wake up rcs when pods get DeletionFinalStateUnknown tombstones
2015-05-28 10:50:28 +02:00
Brendan Burns
a51747f941
Move SSH code into a common util package. Add support for SSH tunnels.
2015-05-27 16:58:52 -07:00
Prashanth Balasubramanian
8fa66bd962
Delta fifo includes objects in DeleteFinalStateUnknow, rcs stop faster
2015-05-27 16:45:51 -07:00
Daniel Smith
fe58bf16e8
Give up waiting for failed pods + print status
2015-05-27 16:07:39 -07:00
Anastasis Andronidis
9e3a540940
rename resize to scale
2015-05-27 19:08:06 +02:00
jayunit100
6e4160eeb0
Set option for KubectlPath (kubectl-path) for E2E tests.
2015-05-26 21:46:59 -04:00
Filip Grzadkowski
39483ffa90
Merge pull request #8779 from wojtek-t/failing_rc_delete
...
Increase timeout for deleting RC in e2e tests.
2015-05-26 01:43:34 -07:00
Filip Grzadkowski
892ce56cec
Print top 5 latency metrics even if they are below threshold
2015-05-25 14:58:23 +02:00
Wojciech Tyczynski
ff8c772fe0
Increase timeout for deleting RC in e2e tests.
2015-05-25 11:51:11 +02:00
Wojciech Tyczynski
abc24fa65c
Ignore /proxy from performance metrics
2015-05-25 09:21:26 +02:00
Dawn Chen
4cad3b568f
Merge pull request #8644 from mbforbes/e2eLogBetter
...
Better logging for e2e start (debug failing pods)
2015-05-22 16:01:34 -07:00
Filip Grzadkowski
70500a64a7
Revert "Added metrics/debug gathering methods to utils and used them in density ..."
2015-05-22 13:00:46 -07:00
Dawn Chen
7c80f3d985
Merge pull request #7573 from rrati/performance-gathering-7572
...
Added metrics/debug gathering methods to utils and used them in density ...
2015-05-22 10:17:15 -07:00
Jerzy Szczepkowski
ef965a60f2
Implementation of e2e test that resizes cluster (works on GCE).
2015-05-22 02:59:25 +02:00
Max Forbes
40ba1e3043
Better logging for e2e start (debug failing pods)
2015-05-21 16:48:30 -07:00
Dawn Chen
df6c670639
Merge pull request #8500 from rrati/e2e-host-option-fix-8499
...
The e2e tests will re-honor --host option. #8499
2015-05-21 09:17:44 -07:00
Robert Rati
3191b26bc6
Only sleep 1.1*interval. #7572
2015-05-19 18:40:21 -04:00
Jeff Grafton
e968b6be81
Merge pull request #8442 from mbforbes/e2ePodsReady
...
Ensure pods both running and ready before starting e2e tests
2015-05-19 13:40:08 -07:00
Quinton Hoole
14665119b4
Revert "improve e2e retry logic with standard wait.Poll()"
2015-05-19 11:17:32 -07:00
Robert Rati
b7486b0ca2
The e2e tests will re-honor --host option. #8499
2015-05-19 14:13:11 -04:00
Max Forbes
1da46ca3d0
Ensure pods both running and ready before starting e2e tests
2015-05-19 10:53:02 -07:00
Maxwell Forbes
b963307496
Merge pull request #8473 from ixdy/native-ginkgo-runner
...
Use native Ginkgo test runner instead of cmd/e2e (attempt N+1)
2015-05-19 10:48:14 -07:00
Robert Rati
7361f751a6
Create a config struct for RunRC and allow polling interval to be
...
configurable. #7572
2015-05-19 13:37:37 -04:00
Robert Rati
9e06132ed3
Minor cleanup. #7572
2015-05-19 13:22:20 -04:00
Jeff Grafton
bf1de72f4a
Revert "Revert "Use native Ginkgo test runner instead of cmd/e2e (attempt N)""
...
This reverts commit f4bb6aa37d
.
2015-05-19 09:13:08 -07:00
Robert Rati
9caee9ad16
Moved FifoQueue to separate file and minor cleanup. #7572
2015-05-19 10:25:02 -04:00
Robert Rati
b78576386f
Use getMetrics in ReadLatencyMetrics. #7572
2015-05-19 10:23:17 -04:00
Robert Rati
ac282bd50a
Cleaned up the output files. #7572
2015-05-19 10:23:17 -04:00
Robert Rati
ec5e7093b6
Created a fifo queue containing results from listing pods and checks
...
from from the queue to generate finer granularity #7572
2015-05-19 10:23:17 -04:00
Robert Rati
bd3306c845
Moved writePerfData to utils. #7572
2015-05-19 10:14:47 -04:00
Robert Rati
a89121cb70
Added metrics/debug gathering methods to utils and used them in density #7572
2015-05-19 10:14:47 -04:00