Ananya Kumar
ef1e576810
Add support for request
2015-08-05 19:00:19 -07:00
Mike Danese
8e33cbfa28
rewrite go imports
2015-08-05 17:30:03 -07:00
Manan Saraf
b2ebfeef25
Fixed empty name error and also changed tests
2015-08-04 14:09:42 -07:00
Chao Xu
18d32751fd
improve the error message of update pod
2015-08-02 13:41:53 -07:00
deads2k
d73faa8272
expose common name validation methods
2015-07-27 13:12:28 -04:00
markturansky
0a0af48e51
added validation for AccessModes
2015-07-27 13:02:16 -04:00
Brendan Burns
a8f02e5472
Automatically open a firewall when creating a GCE load balancer.
2015-07-10 14:35:29 -07:00
nikhiljindal
274792d7bb
Stop exposing v1beta3 by default
2015-07-01 14:38:02 -07:00
Robert Bailey
54a3ebef3c
Merge pull request #10315 from nikhiljindal/invalidValue
...
Updating the "invalid value" error message to include the list of valid values
2015-06-26 10:46:59 -07:00
Robert Bailey
0048eae8eb
Merge pull request #9965 from stevekuznetsov/skuznets/allow-https
...
Allowing for HTTPS Probes
2015-06-26 10:43:37 -07:00
Steve Kuznetsov
3008ff6150
Changed HTTPGetAction to allow user-defined schemes
2015-06-25 16:59:12 -04:00
nikhiljindal
3b3ee0ed77
Improving an error message
2015-06-25 13:08:09 -07:00
Salvatore Dario Minonne
4b13faa346
To add validation for service ports when defined as string (fixing issue #9734 )
2015-06-22 17:21:51 +02:00
Satnam Singh
3591a543d1
Merge pull request #9919 from liggitt/port_protocol_validation
...
Validate port protocol case strictly
2015-06-19 15:18:03 -07:00
Jordan Liggitt
68a8a25494
Rename pod.spec.serviceAccount -> pod.spec.serviceAccountName for v1
2015-06-18 22:38:00 -04:00
Satnam Singh
59a96f1028
Merge pull request #9688 from liggitt/validate_pod_spec
...
Validate service account name in pod spec
2015-06-18 17:18:09 -07:00
derekwaynecarr
2518d8c0fc
Add LimitRange range validation
2015-06-17 10:24:31 -04:00
Jordan Liggitt
2b840279d9
Validate service account name in pod spec
2015-06-16 21:09:01 -04:00
Jordan Liggitt
ee4cd972e0
Validate port protocol case strictly
2015-06-16 20:28:11 -04:00
Jason Sommer
d59a8ff7f8
Improve signature consistency for ValidateObjectMetaUpdate
...
Fixes #9340
Signed-off-by: Jason Sommer <jsdirv@gmail.com>
2015-06-08 02:56:38 -05:00
Tim Hockin
1aa9b0b86a
Don't allow link-local Endpoints
2015-06-03 11:40:04 -07:00
Tim Hockin
4318ca5a8b
Rename 'portal IP' to 'cluster IP' most everywhere
...
This covers obvious transforms, but not --portal_net, $PORTAL_NET and
similar.
2015-05-28 16:10:44 -07:00
Chao Xu
9c1153322e
update PodSpec.Host to PodSpec.NodeName in /pkg/api/types.go and /pkg/api/v1beta3/types.go
2015-05-28 14:10:06 -07:00
Justin Santa Barbara
7346cc8042
Add ServiceType = NodePort; wire everything up
2015-05-22 19:14:28 -04:00
Justin Santa Barbara
e49ad95462
Mark PublicIPs as deprecated & rename to DeprecatedPublicIPs in the latest API
...
We need to keep them in the API so that we can round-trip between versions.
2015-05-22 19:14:27 -04:00
Justin Santa Barbara
2197c8da5a
Add NodePort to ServicePort
...
We prevent it from being set by validation
2015-05-22 19:14:27 -04:00
Justin Santa Barbara
973c2e4819
Add Type to ServiceSpec: ClusterIP or LoadBalancer
2015-05-22 19:14:21 -04:00
Huamin Chen
4a800fd10e
add rados block device(rbd) volume plugin
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2015-05-21 14:51:31 -04:00
Dawn Chen
0710976d43
Merge pull request #8490 from thockin/diff-proto
...
Allow same-hostport-different-protocol
2015-05-21 09:16:16 -07:00
Tim Hockin
cb49843ccb
Merge pull request #8140 from vishh/namespace
...
Update Namespace names to follow DNS label format
2015-05-19 11:25:32 -07:00
Vishnu Kannan
d10af89493
Updating namespaces to be DNS labels instead of DNS names.
2015-05-19 11:09:09 -07:00
Tim Hockin
c7bf373d98
Allow same-hostport-different-protocol
2015-05-19 10:00:35 -07:00
Tim Hockin
65833e42c4
rename CapabilityType Capability
2015-05-18 17:21:30 -07:00
Tim Hockin
f66ca25d9f
Rename AccessMode to PersistentVolumeAccessMode
2015-05-18 17:21:30 -07:00
deads2k
be0f2d2930
add dockercfg secret types
2015-05-18 08:25:27 -04:00
deads2k
d404a17f0a
allow leading dots in secret keys
2015-05-18 08:17:58 -04:00
derekwaynecarr
8216332611
Kubelet kills a pod that exceeds ActiveDeadlineSeconds
2015-05-15 16:33:37 -04:00
Tim Hockin
2f59aa4f25
Somewhat better error messages for common formats
...
Clearer strings with examples.
2015-05-13 13:59:16 -07:00
markturansky
0191574f7e
Bi-directional bind between pv.Spec.ClaimRef and pvc.Spec.VolumeName
2015-05-13 14:05:21 -04:00
Nikhil Jindal
d75bd8bf2a
Merge pull request #7101 from liggitt/service_account
...
ServiceAccounts
2015-05-12 10:23:41 -07:00
feihujiang
4bb594b34d
Duplicate service port name can't be validated
...
Duplicate service port name can't be validated
Duplicate service port name can't be validated
Duplicate service port name can't be validated
2015-05-12 15:18:27 +08:00
Jordan Liggitt
6e1e7dbb24
Add ServiceAccountToken SecretType
2015-05-11 17:18:05 -04:00
Tim Hockin
3aa39d54b6
Service port names are required for multi-port
...
There is no provision for the first port to be unnamed. I think I
initially allowed that, but then the Subset struct became a sorted
struct, so the first-ness of the port got lost. If you have a Service
with one named and one unnamed port, what happens is that the
EndpointController fails to create Endpoints (validation error).
2015-05-09 20:11:48 -07:00
Zach Loafman
875e83a741
Revert "Revert "Security context - types, kubelet, admission""
2015-05-05 16:02:13 -07:00
Zach Loafman
f48904fd5e
Revert "Security context - types, kubelet, admission"
2015-05-05 15:20:39 -07:00
Paul Weil
982bf19c20
security context initial implementation - squash
2015-05-05 13:46:13 -04:00
Paul Morie
e949a623ff
Change EnvVarSource.FieldPath -> FieldRef and add example
2015-05-04 18:41:09 -04:00
Eric Paris
6b3a6e6b98
Make copyright ownership statement generic
...
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
Paul Morie
7d30f09ebf
Add downward API for environment vars
2015-04-27 14:13:11 -04:00
Deyuan Deng
c73ce1db34
Validate Node IPs; clean up validation code
2015-04-23 21:08:18 -04:00
Clayton Coleman
e6e034af4f
Rename PodTemplate.Spec to PodTemplate.Template
2015-04-22 12:54:27 -04:00
derekwaynecarr
5036289b5e
Improve container resource requirements validation
2015-04-20 15:08:18 -04:00
Alex Robinson
9a351e3670
Move validation of load balancers only supporting TCP ports to validation.go.
2015-04-14 18:56:51 +00:00
Justin Santa Barbara
9711e771c5
Rename AWSPersistentDisk -> AWSElasticBlockStore, aws-pd -> aws-ebs
...
Per comments from @markturansky - thanks!
2015-04-10 13:25:43 -07:00
Justin Santa Barbara
edf0292d4a
Add initial support for Volumes to AWS
2015-04-10 13:25:42 -07:00
derekwaynecarr
8364055f0f
Improve validation and fix not throwing an error during ns delete
2015-04-10 11:41:28 -04:00
gmarek
c20efb6bae
Add validation for Endpoints
2015-04-08 20:12:07 +02:00
Huamin Chen
a278ceeb0a
implement glusterfs volume plugin
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2015-04-07 09:14:39 -04:00
Huamin Chen
7a82af31de
add iscsi volume plugin
...
Signed-off-by: Huamin Chen <hchen@redhat.com>
2015-04-06 16:20:28 -04:00
markturansky
a5ebacb043
changed claimed validation from length check to specific storage check
2015-04-06 08:46:44 -04:00
markturansky
c4a53a23bd
Added validation to prevent mutating Claim.Spec after binding
2015-04-06 08:46:44 -04:00
Rohit Jnagal
e0ff139279
Remove validation for Capacity as it got moved from Spec to Status.
...
Also fix breakage from ExternalID validation: Default ExternalID to node name when not specified.
2015-04-02 00:51:52 +00:00
Clayton Coleman
dec3209229
Merge pull request #6246 from derekwaynecarr/finalize_fix
...
Fix Namespace Termination
2015-04-01 17:34:56 -04:00
derekwaynecarr
b745f51c65
Client must specifiy a resource version on finalize
2015-04-01 11:16:45 -04:00
Tim Hockin
e19f4939b1
fix tests broken by stronger validation
2015-03-31 11:13:44 -07:00
Tim Hockin
186818d787
WIP: Implement multi-port Services
2015-03-30 19:28:11 -07:00
Tim Hockin
8ae203825b
Implement multi-port endpoints
...
Instead of endpoints being a flat list, it is now a list of "subsets"
where each is a struct of {Addresses, Ports}. To generate the list of
endpoints you need to take union of the Cartesian products of the
subsets. This is compact in the vast majority of cases, yet still
represents named ports and corner cases (e.g. each pod has a different
port number).
This also stores subsets in a deterministic order (sorted by hash) to
avoid spurious updates and comparison problems.
This is a fully compatible change - old objects and clients will
keepworking as long as they don't need the new functionality.
This is the prep for multi-port Services, which will add API to produce
endpoints in this new structure.
2015-03-27 12:36:32 -07:00
Brian Grant
a4bf91c8c0
Merge pull request #5690 from satnam6502/failputnover
...
Give better error message for PUTs with no resource version
2015-03-27 07:12:56 -07:00
gmarek
5a11748018
Move Capacity from NodeSpec to NodeStatus
2015-03-26 15:28:48 +01:00
Satnam Singh
cd05c8b9bc
Give better error message for PUTs with no resource version
2015-03-25 15:52:48 -07:00
Rohit Jnagal
49ff04765b
Add validation for node creation.
2015-03-25 21:55:03 +00:00
markturansky
f762b303ad
PersistentVolume & PersistentVolumeClaim API types
2015-03-25 10:09:25 -04:00
Filip Grzadkowski
7085a0cb44
Merge pull request #5508 from fgrzadkowski/validate_ips
...
Validate Service.Spec.publicIPs to be a valid IP that is not a localhost
2015-03-25 12:11:29 +01:00
Abhi Shah
f1872d36cf
Merge pull request #5814 from vmarmol/net-host
...
Add HostNetworking container option to API.
2015-03-24 15:55:27 -07:00
Victor Marmol
2a0793c155
Add HostNetworking container option to API.
...
This allows a container to run within the same networking namespace as
the host. This will be locked down by default using a flag on the master
and nodes (similar to how privileged is handled today).
2015-03-24 14:40:28 -07:00
Tim Hockin
064b7dec42
Merge pull request #5807 from pmorie/secret_volume_ref
...
Change secret volume plugin reference to name
2015-03-24 14:18:35 -07:00
Paul Morie
e40ba109a1
Change SecretVolumeSource to use a secret name instead of ObjRef
2015-03-24 13:58:41 -04:00
derekwaynecarr
29c491ef2e
Namespace.Spec.Finalizer support
2015-03-24 10:36:06 -04:00
Filip Grzadkowski
24eb1a08f3
Validate Service.Spec.publicIPs to be a valid IP that is not a localhost
2015-03-24 10:48:46 +01:00
Clayton Coleman
65425f690c
Move field errors to pkg/util/fielderrors
...
Allows pkg/api to take a reference to labels.Selector and fields.Selector
2015-03-22 17:43:34 -04:00
Dawn Chen
7a6490f572
Merge pull request #5729 from thockin/plural_endpoints_30_restart
...
Rename Service.ContainerPort to TargetPort in v1b3
2015-03-20 14:37:46 -07:00
Tim Hockin
4375376e9c
Rename Service.ContainerPort to TargetPort in v1b3
...
Fix all callers and examples. Part of multi-port service cleanup.
2015-03-20 13:50:06 -07:00
Abhishek Gupta
b0c23c1046
Headless Services: Adding option to specify None for PortalIP
2015-03-20 12:10:03 -07:00
Filip Grzadkowski
f89f91b7bd
Validate that there is at least one container in the pod
2015-03-19 12:31:53 +01:00
gmarek
a3b137ce8e
Cleanup of validation.go
2015-03-18 08:59:35 +01:00
Wojciech Tyczynski
e6d188fca8
Remove BoundPod structure
2015-03-17 10:27:41 +01:00
Dawn Chen
34e9c82c70
Convert RestartPolicy to string for v1beta3.
...
Fixed #3607 and spiritually support #5475
2015-03-13 18:38:07 -07:00
Nikhil Jindal
d9249a26e0
Merge pull request #5175 from thockin/plural_services_10
...
Make testing service validation easier
2015-03-12 15:48:37 -07:00
Ravi Sankar Penta
f6ecec5880
Allow admin user to explicitly unschedule the node
...
Setting Unschedulable on the node will not touch any existing pods
on the node but will block scheduling of new pods on the node.
2015-03-12 14:27:27 -07:00
Clayton Coleman
d016f478e0
Ignore changes to creation timestamp from clients on update
...
CreationTimestamp is not an authoritative field (like UID) so mismatches
can be safely ignored.
2015-03-09 12:04:35 -04:00
Tim Hockin
0b888e8673
Make testing service validation easier
...
Part of multi-port services.
If people like this, we could start to apply this pattern elsewhere.
TL;DR: don't redefine objects over and over changing one thing each
time. Instead provide a func that mutates a base object to test facets
of validation. Much easier to read and to update.
2015-03-08 21:41:37 -07:00
gmarek
bb8a4f5ed3
apply comments
2015-03-06 08:23:22 +01:00
gmarek
726a5af075
Loosen label and annotation validation and related tests
2015-03-06 08:23:22 +01:00
Deyuan Deng
9b0af8df63
Node addresses
2015-03-04 16:47:31 -05:00
Brendan Burns
fb90b56bf6
Embed VolumeSource in v1beta3 and internal.
2015-03-04 02:25:40 -08:00
Clayton Coleman
0ac49d77a0
TCPSocket could not be used as it was not checked in validation
...
Attempting to use it gave the error "must register one handler".
Added more tests for it.
2015-03-02 15:27:11 -05:00
Zach Loafman
4937008ae0
Revert "TCPSocket could not be used as it was not checked in validation"
2015-03-02 11:14:27 -08:00
Brendan Burns
c7cbc5c991
Merge pull request #4883 from smarterclayton/fix_tcpsocket_validation
...
TCPSocket could not be used as it was not checked in validation
2015-03-02 10:53:48 -08:00
Brendan Burns
fe973461f5
Merge pull request #4916 from thockin/plural_21_endpoints
...
Rename type Port to ContainerPort
2015-03-02 10:53:32 -08:00
Tim Hockin
532c39c336
Add defaults for HTTGetAction.Path & test actions
...
The comment says optional - this makes it optional. Test handler actions.
2015-03-01 21:23:18 -08:00
Clayton Coleman
d3a5a48d00
TCPSocket could not be used as it was not checked in validation
...
Attempting to use it gave the error "must register one handler".
Added more tests for it.
2015-03-01 22:31:57 -05:00
Tim Hockin
ea548b8260
Rename type Port to ContainerPort
...
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
2015-02-27 21:05:59 -08:00
Daniel Smith
650f6cb826
Revert "Multi-port Endpoints"
2015-02-23 13:53:21 -08:00
Tim Hockin
eed36455a7
Merge pull request #4653 from thockin/secret_fixups
...
Secrets fixups
2015-02-23 13:49:19 -08:00
Tim Hockin
607b736a3f
Rename volume source types to be consistent.
2015-02-23 12:39:57 -08:00
Tim Hockin
8bdfc352ce
minor fixups as I review secrets
2015-02-23 12:39:47 -08:00
Tim Hockin
e0fd83096c
Rename type Port to ContainerPort
...
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
2015-02-21 22:26:38 -08:00
Paul Morie
a42ff94c8f
Add secret volume plugin and e2e test
2015-02-18 16:27:44 -05:00
Paul Morie
fb001ada21
Secret API resource
2015-02-18 11:54:56 -05:00
Mike Danese
f7df9b9d37
add validation for api.Probe
2015-02-16 21:56:03 -08:00
derekwaynecarr
0bd0e12bbc
Add support for Namespace as Kind
...
Add example for using namespaces
2015-02-10 09:50:50 -05:00
Vishnu Kannan
d0524d4778
Rename ResourceRequirementSpec to ResourceRequirements.
2015-02-09 23:19:38 +00:00
Marek Grabowski
72a066a992
Add more information to Validator error messages.
2015-02-09 18:07:09 +01:00
Brendan Burns
31ce2a9411
Adjust replication controller validation to be more flexible about
...
read/write volumes.
Update docs to reflect reality as it is implemented.
2015-02-06 14:58:21 -08:00
Brendan Burns
50e855953f
Merge pull request #4131 from a-robinson/validate
...
Add a few extra test cases for API validation of labels
2015-02-05 15:37:45 -08:00
Yu-Ju Hong
283919e8b1
Fix tests in validation_test
...
Some tests expect the error cases to fail for a specific reason, but they could
fail for other reasons and still pass. This caused some changes to break the
tests without noticing the breakage. Example are the recent defaulting PR
This change fixes such tests and also updates some obsolete tests.
2015-02-04 15:44:46 -08:00
Alex Robinson
6bb374ca54
Add a few extra test cases for API validation of labels that would have
...
caught a bug that was in past versions. Also, copy the label key format
requirements from the API types.go comments into the labels doc.
2015-02-04 22:24:46 +00:00
Yu-Ju Hong
4a72addaeb
Factor out API defaulting from validation logic
...
Currently, the validation logic validates fields in an object and supply default
values wherever applies. This change factors out defaulting to a set of
defaulting callback functions for decoding (see #1502 for more discussion).
* This change is based on pull request 2587.
* Most defaulting has been migrated to defaults.go where the defaulting
functions are added.
* validation_test.go and converter_test.go have been adapted to not testing the
default values.
* Fixed all tests with that create invalid objects with the absence of
defaulting logic.
2015-02-03 00:55:42 -08:00
Clayton Coleman
a7c9a12286
Add name generation and normalize common create flows
...
Adds `ObjectMeta.GenerateName`, an optional string field that defines
name generation behavior if a Name is not provided.
Adds `pkg/api/rest`, which defines the default Kubernetes API pattern
for creation (and will cover update as well). Will allow registries
and REST objects to be merged by moving logic on api out of those places.
Add `pkg/api/rest/resttest`, which will be the test suite that verifies
a RESTStorage object follows the Kubernetes API conventions and begin
reducing our duplicated tests.
2015-02-02 14:44:53 -05:00
Brian Grant
6e415f760b
Merge pull request #4017 from smarterclayton/relax_annotation_validations
...
Slightly relax annotation validation
2015-02-02 11:42:38 -08:00
Clayton Coleman
b30173658f
Slightly relax annotation validation
...
The more aggressive validation on annotations broke openshift (and
backwards compat for our data). This change relaxes to allow mixed
case so we can continue working in the short term, try to see if we
can agree on relaxation, and if we can't, apply the stronger
validation here.
2015-02-01 19:03:04 -05:00
Vishnu Kannan
5e36f63f8b
Adding ResourceRequirementSpec to v1beta1, v1beta2, and v1beta3 APIs. The old resource
...
quantities 'CPU' and 'Memory' will be preserved until support for v1beta1 and v1beta2 APIs are
dropped.
Improved resource validation in the process.
2015-02-01 02:19:55 +00:00
Deyuan Deng
c793c4f0ab
Sync node status from node controller to master.
2015-01-29 23:17:15 -05:00
Tim Hockin
d01ea11a6e
Merge pull request #3856 from smarterclayton/validation_logic_needs_cleanup
...
Validation of ObjectMeta is inconsistently applied
2015-01-29 14:12:44 -08:00
derekwaynecarr
829fa69527
Introduce a ResourceQuota object
2015-01-28 15:03:19 -05:00
Clayton Coleman
a0356bca96
Unify validation logic for create and update paths
...
Ensure ObjectMeta is consistently validated on both create and update
Make PortalIP uncleareable
2015-01-28 13:10:37 -05:00
derekwaynecarr
74f368f50e
Modified LimitRangeItem.Kind to LimitRangeItem.Type, added example files
2015-01-27 16:41:28 -05:00
derekwaynecarr
091cbe5fa2
Add a limit range resource
2015-01-27 16:41:27 -05:00
Brendan Burns
99583fc8c5
Fix a bug in validation that was leftover from the previous way of externalizing services.
2015-01-26 13:19:27 -08:00
markturansky
131ce993c4
Added validation for annotations
2015-01-26 09:32:09 -05:00
Vishnu Kannan
c32295a180
Adding a 'Typename' strongtype for representing all compute resource types.
2015-01-23 22:17:56 +00:00
Tim Hockin
30219f8dfa
Merge pull request #3664 from thockin/pull-if
...
Pull if
2015-01-21 13:05:28 -08:00
Tim Hockin
81343aac63
Change PullPolicy constants to match
2015-01-21 12:48:56 -08:00
Tim Hockin
819803b79f
Make VolumeSource not be a pointer
...
There's no reason for it to be a pointer.
2015-01-20 17:54:04 -08:00
Brian Grant
dd45246150
Merge pull request #3587 from dchen1107/image
...
Clean up Kubernetes PullPolicy
2015-01-20 17:18:26 -08:00
Tim Hockin
60ec08db93
Rename HostDir to HostPath in v1beta3
2015-01-20 15:56:44 -08:00
Dawn Chen
aec4594a8d
Introduce validatePullPolicyWithDefault to validation.
2015-01-20 11:54:22 -08:00
Tim Hockin
6ff26d924c
Merge pull request #3619 from smarterclayton/expose_validate_labels
...
Expose ValidateLabels in validation.go for reuse by other components
2015-01-20 09:11:08 -08:00
Clayton Coleman
48146e01cd
Expose ValidateLabels in validation.go for reuse by other components
...
Label validation is common to anyone building kube resources.
2015-01-19 22:33:52 -05:00
Andrew Seidl
6dee1d7fa4
Fix typos in user-facing strings
2015-01-18 01:32:34 -06:00
Paul Morie
fd834ae84d
Pods should see services only from their own ns
2015-01-14 17:06:36 -05:00
Tim Hockin
4fcd496d59
change everything to use new util/errors
2015-01-08 22:10:03 -08:00
Daniel Smith
2050131b9a
ParseOrDie -> MustParse; stop returning pointer
2015-01-07 15:21:35 -08:00
Daniel Smith
7f49ba0dcf
Put quantity into packages
...
kubelet, GCE, validation, client
2015-01-07 15:21:34 -08:00
Tim Hockin
1ec3457fc9
Beef up validation tests
2015-01-06 13:02:42 -08:00
Brendan Burns
9884142061
Clear node status before the validation check.
2014-12-22 11:57:31 -08:00
Brendan Burns
36bc3604b9
Merge pull request #2893 from brendandburns/pd3
...
Make it easier to update nodes, make it possible to update capacity.
2014-12-18 10:18:54 -08:00
Brendan Burns
cf0b41535f
Make it easier to update nodes, make it possible to update capacity.
2014-12-17 21:50:26 -08:00
George Kuan
5e1fc1f4e0
Fixes #1605 : make ErrorList introspectable by replacing ErrorList and
...
ErrorList#ToError with []error and util.SliceToError() respectively
2014-12-12 10:56:31 -08:00
Clayton Coleman
19379b5a38
Internal rename api.Minion -> api.Node
2014-12-10 12:08:18 -05:00