55dac4804f
Fix some typos
...
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2019-03-05 17:58:09 +08:00
baf4eb67ac
Merge pull request #74257 from ipuustin/lib-util-sh
...
Fix shellcheck-reported errors in hack/lib/util.sh.
2019-03-04 23:11:59 -08:00
f5574bf62a
Merge pull request #74603 from stevesloka/e2eImageList
...
Refactor to allow for a way to get list of e2e images
2019-03-04 19:27:47 -08:00
9d0baa75f2
Merge pull request #74563 from vanduc95/fix-error-string
...
fix error string should not be capitalized
2019-03-04 19:27:36 -08:00
35c9624fd6
Merge pull request #74500 from sandeeppsunny/fix-e2e-tests
...
Change to unblock e2e tests for vsphere provider
2019-03-04 19:27:25 -08:00
e2f42845d1
Merge pull request #74487 from danielqsj/window
...
Fix golint failures for e2e/windows
2019-03-04 19:27:11 -08:00
dba8300e52
Merge pull request #74391 from cofyc/fix71237-update-old
...
Update old local tests to use general host executor and local test resource manager
2019-03-04 19:27:00 -08:00
95cd1d59e4
Merge pull request #74209 from monotek/fluentd-helm-readme
...
added production note about EFK stack to the readme
2019-03-04 17:55:12 -08:00
feb0937fa4
Merge pull request #74902 from liggitt/regen-proto
...
Update generated protobuf files
2019-03-04 15:52:03 -08:00
79e8a29544
Merge pull request #74852 from dims/expand-reviewers-approvers-add-label
...
Expand reviewers/approvers and add labels for conformance image
2019-03-04 13:25:50 -08:00
dddb13c690
Merge pull request #74711 from SataQiu/fix-golint-2019022802
...
Fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-03-04 13:25:38 -08:00
5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228
...
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-03-04 13:25:26 -08:00
f7e1058c98
shellcheck failures: remove hack/lib/util.sh
2019-03-04 23:23:20 +02:00
1e34d9df7d
hack/lib/util.sh: replace sed with bash replace.
...
Test script:
#!/bin/bash
rev1="foo"
rev2="\"bar\""
rev3="'bar'"
newrev1="${rev1//[\'\"]}"
newrev2="${rev2//[\'\"]}"
newrev3="${rev3//[\'\"]}"
oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")
echo "$newrev1 vs. $oldrev1"
echo "$newrev2 vs. $oldrev2"
echo "$newrev3 vs. $oldrev3"
expected output:
foo vs. foo
bar vs. bar
bar vs. bar
2019-03-04 23:23:20 +02:00
0078fce5bd
hack/lib/util.sh: don't implicitly convert "find" results into array.
...
Also fix array item comparison. Test script for the comparison change:
#!/bin/bash
staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)
for group_version in ${group_versions[@]}; do
# original code
if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
# new code
for api in ${staging_apis[@]}; do
if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
done
done
Expected output:
orig: vendor/k8s.io/api/extensions/v1beta1
new: vendor/k8s.io/api/extensions/v1beta1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
2019-03-04 23:23:20 +02:00
edd806330a
hack/lib/util.sh: mark variables to be used in a sourcing context.
...
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
2019-03-04 23:23:20 +02:00
24b5c67723
hack/lib/util.sh: various shellcheck-reported cleanups.
...
Use "command -v" instead of "which". Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.
However, one shellcheck error is ignored in trap mechanism. The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.
An alternative to ignoring could be tricking shellcheck with:
trap ''"${new_cmd}" "${trap_add_name}"
2019-03-04 23:18:54 +02:00
f6f1d5abf5
Update generated protobuf files
...
Change-Id: Ie01ce38d25d05e90d79ddc6e80584a21cf7ff299
2019-03-04 20:14:55 +00:00
d0c3b70802
Merge pull request #74804 from sttts/sttts-crd-validation-nullable
...
apiextensions: add nullable support to OpenAPI v3 validations
2019-03-04 10:43:30 -08:00
8770e0cd39
Merge pull request #74664 from dims/prepare-publishing-bot-for-1.14-branch
...
Add 1.14 branches for the publishing-bot
2019-03-04 09:01:21 -08:00
5616e23b75
Add 1.14 branches for the publishing-bot
...
Change-Id: Id34d1f12361e587e02f7dba077a9600618737878
2019-03-04 08:43:41 -05:00
b1d4d40679
Merge pull request #74668 from sttts/sttts-kube-apiserver-endpoints-when-ready
...
kube-apiserver: don't create endpoints before being ready
2019-03-04 01:57:41 -08:00
3b4a9e4e71
Merge pull request #74869 from neolit123/fix-reset-fetch
...
kubeadm-reset: fetch init config only if client is non-nil
2019-03-04 00:25:57 -08:00
269a07c077
kubeadm-reset: fetch init config only if client is non-nil
2019-03-04 04:14:51 +02:00
37f0138278
Merge pull request #71874 from neolit123/fix-kubeconfig-path
...
kubeadm: use DefValue for the --kubeconfig flag
2019-03-03 17:28:44 -08:00
1f6ea0455b
Merge pull request #74780 from pytimer/kubeadm-reduce
...
kubeadm: reduce some functions number of parameters
2019-03-03 04:23:24 -08:00
d62de16fbe
Merge pull request #74857 from andyzhangx/azure-disk-lib
...
make some functions in azure cloud provider as public
2019-03-03 01:36:18 -08:00
f600348006
kubeadm: reduce some functions number of parameters
2019-03-03 15:16:19 +08:00
c54978a6cf
Merge pull request #74806 from mxinden/increase-bucket-resolution
...
src/k8s.io/apiserver: Increase cert expiration histogram resolution
2019-03-02 21:13:03 -08:00
125410aedc
Merge pull request #74834 from fabriziopandini/join-phases-texts
...
Improve join phases labels and help messages
2019-03-02 18:16:12 -08:00
38f0908597
make funcs in azure cloud provider as public
2019-03-03 01:58:59 +00:00
79ce30cc6a
Merge pull request #74851 from dims/apparently-conformance-tests-have-run-run-serially
...
Apparently conformance tests have to run serially
2019-03-02 12:59:11 -08:00
a3ed9f0c2c
join-phases-texts
2019-03-02 21:52:04 +01:00
e1b79abfec
Merge pull request #74831 from fabriziopandini/remove-discovery-flags
...
Remove discovery flags from kubeadm join phases (when possible)
2019-03-02 11:16:12 -08:00
b3adf5bd0d
Expand reviewers/approvers and add labels for conformance image
...
Change-Id: I6e13d262a8bf97ada89227a853debe58876c212a
2019-03-02 13:46:27 -05:00
87e87dd25b
Apparently conformance tests have to run serially
...
There are 10+ conformance tests marked [Serial], So we can't run things
in parallel by default.
Change-Id: I58afbb356899fb38caf4f9f6704bfb47f745b338
2019-03-02 13:30:00 -05:00
5ecd74afbe
remove-discovery-flags
2019-03-02 18:31:32 +01:00
a81b351670
Update persistent_volumes-local.go to use utils.HostExec/utils.LocalTestResourceManager.
...
This simplifies the code and makes it more maintainable.
2019-03-02 20:38:20 +08:00
6b2882738b
Merge pull request #74805 from HotelsDotCom/feature/remove-kubectl-binary
...
VolumeSubpathEnvExpansion alpha tests - change kubectl references to API calls
2019-03-02 03:41:15 -08:00
cfe4ca8012
Merge pull request #73934 from bsalamat/num_cpu
...
Use runtime.NumCPU() instead of a fixed value for parallel scheduler threads
2019-03-01 23:04:17 -08:00
f16035600a
Merge pull request #73807 from dekkagaijin/discovery-hardening
...
harden the default RBAC discovery clusterrolebindings
2019-03-01 21:49:30 -08:00
e001276b1d
Merge pull request #74836 from yujuhong/update-win-cni-config
...
GCE/Windows: exclude gateways from the IPAM subnet
2019-03-01 20:35:03 -08:00
3bb22edef8
Merge pull request #74808 from dims/showcase-the-available-options-in-manifest
...
Showcase conformance images options in the manifest
2019-03-01 20:34:53 -08:00
cb89d8028a
Merge pull request #74769 from msau42/local-pv-ga
...
move local PV to GA
2019-03-01 19:14:34 -08:00
738d29b96c
Merge pull request #74767 from yuwenma/rebase-image
...
Rebase etcd-version-monitor base image to distroless.
2019-03-01 19:14:24 -08:00
d8d260a09d
Merge pull request #74755 from liggitt/kubelet-watch
...
Revert kubelet to default to ttl cache secret/configmap behavior
2019-03-01 19:14:14 -08:00
ced9e30990
Merge pull request #74576 from datuanmac/trivial_fix_typos
...
Trivial fix typo
2019-03-01 19:14:03 -08:00
65b7a430f3
Merge pull request #74287 from qingsenLi/k8s190220-delete-const
...
delete some unused const in test/e2e_node
2019-03-01 19:13:53 -08:00
9c7d31928d
harden the default RBAC discovery clusterrolebindings
2019-03-01 18:45:05 -08:00
9b8c58644a
Merge pull request #74418 from danielqsj/duration
...
convert latency/latencies in metrics name to duration
2019-03-01 17:58:12 -08:00
PingWang