Commit Graph

65 Commits (458eb5284abd6933c620ba8ea383032f225e0885)

Author SHA1 Message Date
k8s-merge-robot 20b4fa6fbd Merge pull request #18494 from brendandburns/perf3
Auto commit by PR queue bot
2015-12-16 15:01:10 -08:00
k8s-merge-robot 91ef756bea Merge pull request #18423 from tombenner/improve_label_validation_error_messages
Auto commit by PR queue bot
2015-12-16 14:08:21 -08:00
Brendan Burns beda3fd92d Switch to index rather than copy indexing.
This was 17% of all allocations on a recent profile.
2015-12-14 20:17:02 -08:00
David Oppenheimer 725a84ffe0 Merge pull request #18157 from sdminonne/LabelSelector_internalSelector
renaming labels.LabelSelector to labels.internalSelector
2015-12-13 20:03:49 -08:00
Tom Benner c354c12712 Improve label selector validations' error messages 2015-12-09 00:45:31 -08:00
Salvatore Dario Minonne 3288ce0dcb renaming labels.LabelSelector to labels.internalSelector 2015-12-04 09:21:33 +01:00
Tim Hockin e6df0b1a24 Convert validation to use FieldPath
Before this change we have a mish-mash of ways to pass field names around for
error generation.  Sometimes string fieldnames, sometimes .Prefix(), sometimes
neither, often wrong names or not indexed when it should be.

Instead of that mess, this is part one of a couple of commits that will make it
more strongly typed and hopefully encourage correct behavior.  At least you
will have to think about field names, which is better than nothing.

It turned out to be really hard to do this incrementally.
2015-12-03 08:19:44 -08:00
Tim Hockin ceee678b29 Rename validation 'New' funcs 2015-11-23 10:01:43 -08:00
Tim Hockin 0ff66da346 Move fielderrors into validation 2015-11-22 20:12:20 -08:00
Wojciech Tyczynski 975871e0a0 JSON marshaling/unmarshaling of label Selector 2015-11-19 16:44:48 +01:00
Mike Danese 29c50cdc1a plumb PodSelector through the api 2015-10-15 07:42:57 -07:00
Brian Grant 1bac67f9e2 Add DoesNotExist label operator. 2015-10-13 20:13:19 +00:00
tummychow b9ff3a0741 Add getters for labels.Requirement
Useful for some label backends that need access to the fields.
2015-10-05 11:48:20 -07:00
Chao Xu 9be421c053 fix label selector parser in case no value (or only whitespaces) is specified after the key 2015-10-02 16:17:56 -07:00
tummychow a21c52a766 Move util/validation files to their own package 2015-09-13 00:46:52 -07:00
tummychow 78ce5da988 Move util.StringSet into its own package
A lot of packages use StringSet, but they don't use anything else from
the util package. Moving StringSet into another package will shrink
their dependency trees significantly.
2015-09-10 12:04:15 -07:00
Steve Kuznetsov 0a07a46100 fixed error typo 2015-09-03 09:28:02 -04:00
hurf 36987e9dce Move formatLabels function to labels package
As the TODO above the function instructed, move formatLables
function to labels package.
2015-08-23 18:27:48 +08:00
Kris Rousey 565189f5b8 Correcting all go vet errors 2015-08-11 13:55:37 -07:00
Mike Danese 8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
Maciej Szulik a11911d20d Fixed notin operator in labels' selectors comments. 2015-07-03 17:33:46 +02:00
Eric Paris 6b3a6e6b98 Make copyright ownership statement generic
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
Prashanth Balasubramanian 7592dabeba RcManager uses informers 2015-04-28 13:45:15 -07:00
Kris Rousey 6904c4d585 Fixing a lot of string formatting issues with regards to:
* Improper format specifier (e.g. %s for bools or %s for ints)
  * More or less parameters than format specifiers
  * Not calling a formatting function when it should have (e.g. Error() instead of Errorf())
2015-03-31 16:47:10 -07:00
Salvatore Dario Minonne 6ad5c07350 Adding a func to labels.Selector to add requirement 2015-03-25 20:37:04 +01:00
Nikhil Jindal 5c71e2ba00 Merge pull request #5769 from sdminonne/cleaning_labels
Removing dead code in labels package and changing LabelSelector type
2015-03-23 16:28:31 -07:00
Clayton Coleman 65425f690c Move field errors to pkg/util/fielderrors
Allows pkg/api to take a reference to labels.Selector and fields.Selector
2015-03-22 17:43:34 -04:00
Salvatore Dario Minonne 4c55689fb7 Removing dead code in labels package and chaning LabelSelector type 2015-03-22 18:03:50 +01:00
gmarek bb8a4f5ed3 apply comments 2015-03-06 08:23:22 +01:00
gmarek 726a5af075 Loosen label and annotation validation and related tests 2015-03-06 08:23:22 +01:00
Salvatore Dario Minonne 75f2efb500 moving ParseSelector to Parse for labels only. 2015-03-05 22:39:36 +01:00
Daniel Smith c4822dc060 Revert "Revert "Adding converter functions to convert field label selectors to internal version before matching""
This reverts commit 5f35a67002.
2015-03-02 15:00:09 -08:00
Zach Loafman 5f35a67002 Revert "Adding converter functions to convert field label selectors to internal version before matching" 2015-02-28 11:42:49 -08:00
nikhiljindal 48e7945f65 Versioning the field selectors 2015-02-27 16:10:59 -08:00
Salvatore Dario Minonne 0186acc37c Extending label.Parse method to support exact match 2015-02-25 08:52:20 +01:00
bgrant0607 0c2be7e9ae Merge pull request #2559 from meirf/add-whitespace-flexibility-to-multivalued-requirement-parser
Make multivalued requirement parser more whitespace tolerant
2014-12-08 11:01:13 -08:00
Tim Hockin 89875ef09d Loosen DNS 952 for labels 2014-12-01 12:30:43 -08:00
Meir Fischer 763e48bc6f multivalued requirement parser more whitespace tolerant 2014-11-23 21:55:34 -05:00
Eric Tune 01434a8c04 Add helper for making simple selector. 2014-11-21 13:34:20 -08:00
Tim Hockin 95a9098311 fix 'go vet' warnings 2014-11-21 09:45:28 +08:00
Meir Fischer 444b74302a state-based parser for multi-valued set selector syntax 2014-11-05 08:47:51 -05:00
Eric Tune 800284164a Fix format specifiers in Printf-type functions. 2014-10-09 17:06:32 -07:00
Meir Fischer 89a9e5e672 extend selector with EXISTS, new tests/some old tests use table-driven style; add Has to Labels interface; enforce Requirement restrictions in constructor 2014-10-06 21:10:11 -04:00
Clayton Coleman ae698bcff8 Allow field/label users to get info from fields
Allows a consumer to get at the information stored in the field selector
for querying an underlying data store.  Not generic, but offers a
simple start.
2014-08-27 15:49:00 -04:00
Meir Fischer 9076e78654 change strValues's type to util.StringSet; rename Comparator to Operator; small syntax fix 2014-07-31 23:56:37 -04:00
Meir Fischer 80b1fa000e structured message for selector; matching functionality 2014-07-31 00:29:42 -04:00
Clayton Coleman 5bc19584a5 Update Service and ReplControllers to validate
Validations are performed on update and on create.
2014-07-27 19:55:03 -04:00
Clayton Coleman d32024870a Extend validation for ReplicationController
Provide type safe checks for empty sets of selectors.
2014-07-25 12:15:17 -04:00
Yuki Yugui Sonoda 60dd1f7cc0 Eliminates tautological comments 2014-07-15 20:58:01 +09:00
Yuki Yugui Sonoda 41febcee5e Merge branch 'master' into fix/golint
Conflicts:
	pkg/master/master.go
	pkg/master/pod_cache.go
	pkg/proxy/config/file.go
	pkg/proxy/proxier.go
	pkg/proxy/roundrobbin.go
	pkg/scheduler/randomfit.go
	pkg/scheduler/randomfit_test.go
2014-07-15 20:57:47 +09:00