Tim Hockin
064b7dec42
Merge pull request #5807 from pmorie/secret_volume_ref
...
Change secret volume plugin reference to name
2015-03-24 14:18:35 -07:00
Paul Morie
e40ba109a1
Change SecretVolumeSource to use a secret name instead of ObjRef
2015-03-24 13:58:41 -04:00
derekwaynecarr
29c491ef2e
Namespace.Spec.Finalizer support
2015-03-24 10:36:06 -04:00
Filip Grzadkowski
24eb1a08f3
Validate Service.Spec.publicIPs to be a valid IP that is not a localhost
2015-03-24 10:48:46 +01:00
Clayton Coleman
65425f690c
Move field errors to pkg/util/fielderrors
...
Allows pkg/api to take a reference to labels.Selector and fields.Selector
2015-03-22 17:43:34 -04:00
Dawn Chen
7a6490f572
Merge pull request #5729 from thockin/plural_endpoints_30_restart
...
Rename Service.ContainerPort to TargetPort in v1b3
2015-03-20 14:37:46 -07:00
Tim Hockin
4375376e9c
Rename Service.ContainerPort to TargetPort in v1b3
...
Fix all callers and examples. Part of multi-port service cleanup.
2015-03-20 13:50:06 -07:00
Abhishek Gupta
b0c23c1046
Headless Services: Adding option to specify None for PortalIP
2015-03-20 12:10:03 -07:00
Filip Grzadkowski
f89f91b7bd
Validate that there is at least one container in the pod
2015-03-19 12:31:53 +01:00
gmarek
a3b137ce8e
Cleanup of validation.go
2015-03-18 08:59:35 +01:00
Wojciech Tyczynski
e6d188fca8
Remove BoundPod structure
2015-03-17 10:27:41 +01:00
Dawn Chen
34e9c82c70
Convert RestartPolicy to string for v1beta3.
...
Fixed #3607 and spiritually support #5475
2015-03-13 18:38:07 -07:00
Nikhil Jindal
d9249a26e0
Merge pull request #5175 from thockin/plural_services_10
...
Make testing service validation easier
2015-03-12 15:48:37 -07:00
Ravi Sankar Penta
f6ecec5880
Allow admin user to explicitly unschedule the node
...
Setting Unschedulable on the node will not touch any existing pods
on the node but will block scheduling of new pods on the node.
2015-03-12 14:27:27 -07:00
Clayton Coleman
d016f478e0
Ignore changes to creation timestamp from clients on update
...
CreationTimestamp is not an authoritative field (like UID) so mismatches
can be safely ignored.
2015-03-09 12:04:35 -04:00
Tim Hockin
0b888e8673
Make testing service validation easier
...
Part of multi-port services.
If people like this, we could start to apply this pattern elsewhere.
TL;DR: don't redefine objects over and over changing one thing each
time. Instead provide a func that mutates a base object to test facets
of validation. Much easier to read and to update.
2015-03-08 21:41:37 -07:00
gmarek
bb8a4f5ed3
apply comments
2015-03-06 08:23:22 +01:00
gmarek
726a5af075
Loosen label and annotation validation and related tests
2015-03-06 08:23:22 +01:00
Deyuan Deng
9b0af8df63
Node addresses
2015-03-04 16:47:31 -05:00
Brendan Burns
fb90b56bf6
Embed VolumeSource in v1beta3 and internal.
2015-03-04 02:25:40 -08:00
Clayton Coleman
0ac49d77a0
TCPSocket could not be used as it was not checked in validation
...
Attempting to use it gave the error "must register one handler".
Added more tests for it.
2015-03-02 15:27:11 -05:00
Zach Loafman
4937008ae0
Revert "TCPSocket could not be used as it was not checked in validation"
2015-03-02 11:14:27 -08:00
Brendan Burns
c7cbc5c991
Merge pull request #4883 from smarterclayton/fix_tcpsocket_validation
...
TCPSocket could not be used as it was not checked in validation
2015-03-02 10:53:48 -08:00
Brendan Burns
fe973461f5
Merge pull request #4916 from thockin/plural_21_endpoints
...
Rename type Port to ContainerPort
2015-03-02 10:53:32 -08:00
Tim Hockin
532c39c336
Add defaults for HTTGetAction.Path & test actions
...
The comment says optional - this makes it optional. Test handler actions.
2015-03-01 21:23:18 -08:00
Clayton Coleman
d3a5a48d00
TCPSocket could not be used as it was not checked in validation
...
Attempting to use it gave the error "must register one handler".
Added more tests for it.
2015-03-01 22:31:57 -05:00
Tim Hockin
ea548b8260
Rename type Port to ContainerPort
...
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
2015-02-27 21:05:59 -08:00
Daniel Smith
650f6cb826
Revert "Multi-port Endpoints"
2015-02-23 13:53:21 -08:00
Tim Hockin
eed36455a7
Merge pull request #4653 from thockin/secret_fixups
...
Secrets fixups
2015-02-23 13:49:19 -08:00
Tim Hockin
607b736a3f
Rename volume source types to be consistent.
2015-02-23 12:39:57 -08:00
Tim Hockin
8bdfc352ce
minor fixups as I review secrets
2015-02-23 12:39:47 -08:00
Tim Hockin
e0fd83096c
Rename type Port to ContainerPort
...
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
2015-02-21 22:26:38 -08:00
Paul Morie
a42ff94c8f
Add secret volume plugin and e2e test
2015-02-18 16:27:44 -05:00
Paul Morie
fb001ada21
Secret API resource
2015-02-18 11:54:56 -05:00
Mike Danese
f7df9b9d37
add validation for api.Probe
2015-02-16 21:56:03 -08:00
derekwaynecarr
0bd0e12bbc
Add support for Namespace as Kind
...
Add example for using namespaces
2015-02-10 09:50:50 -05:00
Vishnu Kannan
d0524d4778
Rename ResourceRequirementSpec to ResourceRequirements.
2015-02-09 23:19:38 +00:00
Marek Grabowski
72a066a992
Add more information to Validator error messages.
2015-02-09 18:07:09 +01:00
Brendan Burns
31ce2a9411
Adjust replication controller validation to be more flexible about
...
read/write volumes.
Update docs to reflect reality as it is implemented.
2015-02-06 14:58:21 -08:00
Brendan Burns
50e855953f
Merge pull request #4131 from a-robinson/validate
...
Add a few extra test cases for API validation of labels
2015-02-05 15:37:45 -08:00
Yu-Ju Hong
283919e8b1
Fix tests in validation_test
...
Some tests expect the error cases to fail for a specific reason, but they could
fail for other reasons and still pass. This caused some changes to break the
tests without noticing the breakage. Example are the recent defaulting PR
This change fixes such tests and also updates some obsolete tests.
2015-02-04 15:44:46 -08:00
Alex Robinson
6bb374ca54
Add a few extra test cases for API validation of labels that would have
...
caught a bug that was in past versions. Also, copy the label key format
requirements from the API types.go comments into the labels doc.
2015-02-04 22:24:46 +00:00
Yu-Ju Hong
4a72addaeb
Factor out API defaulting from validation logic
...
Currently, the validation logic validates fields in an object and supply default
values wherever applies. This change factors out defaulting to a set of
defaulting callback functions for decoding (see #1502 for more discussion).
* This change is based on pull request 2587.
* Most defaulting has been migrated to defaults.go where the defaulting
functions are added.
* validation_test.go and converter_test.go have been adapted to not testing the
default values.
* Fixed all tests with that create invalid objects with the absence of
defaulting logic.
2015-02-03 00:55:42 -08:00
Clayton Coleman
a7c9a12286
Add name generation and normalize common create flows
...
Adds `ObjectMeta.GenerateName`, an optional string field that defines
name generation behavior if a Name is not provided.
Adds `pkg/api/rest`, which defines the default Kubernetes API pattern
for creation (and will cover update as well). Will allow registries
and REST objects to be merged by moving logic on api out of those places.
Add `pkg/api/rest/resttest`, which will be the test suite that verifies
a RESTStorage object follows the Kubernetes API conventions and begin
reducing our duplicated tests.
2015-02-02 14:44:53 -05:00
Brian Grant
6e415f760b
Merge pull request #4017 from smarterclayton/relax_annotation_validations
...
Slightly relax annotation validation
2015-02-02 11:42:38 -08:00
Clayton Coleman
b30173658f
Slightly relax annotation validation
...
The more aggressive validation on annotations broke openshift (and
backwards compat for our data). This change relaxes to allow mixed
case so we can continue working in the short term, try to see if we
can agree on relaxation, and if we can't, apply the stronger
validation here.
2015-02-01 19:03:04 -05:00
Vishnu Kannan
5e36f63f8b
Adding ResourceRequirementSpec to v1beta1, v1beta2, and v1beta3 APIs. The old resource
...
quantities 'CPU' and 'Memory' will be preserved until support for v1beta1 and v1beta2 APIs are
dropped.
Improved resource validation in the process.
2015-02-01 02:19:55 +00:00
Deyuan Deng
c793c4f0ab
Sync node status from node controller to master.
2015-01-29 23:17:15 -05:00
Tim Hockin
d01ea11a6e
Merge pull request #3856 from smarterclayton/validation_logic_needs_cleanup
...
Validation of ObjectMeta is inconsistently applied
2015-01-29 14:12:44 -08:00
derekwaynecarr
829fa69527
Introduce a ResourceQuota object
2015-01-28 15:03:19 -05:00
Clayton Coleman
a0356bca96
Unify validation logic for create and update paths
...
Ensure ObjectMeta is consistently validated on both create and update
Make PortalIP uncleareable
2015-01-28 13:10:37 -05:00
derekwaynecarr
74f368f50e
Modified LimitRangeItem.Kind to LimitRangeItem.Type, added example files
2015-01-27 16:41:28 -05:00
derekwaynecarr
091cbe5fa2
Add a limit range resource
2015-01-27 16:41:27 -05:00
Brendan Burns
99583fc8c5
Fix a bug in validation that was leftover from the previous way of externalizing services.
2015-01-26 13:19:27 -08:00
markturansky
131ce993c4
Added validation for annotations
2015-01-26 09:32:09 -05:00
Vishnu Kannan
c32295a180
Adding a 'Typename' strongtype for representing all compute resource types.
2015-01-23 22:17:56 +00:00
Tim Hockin
30219f8dfa
Merge pull request #3664 from thockin/pull-if
...
Pull if
2015-01-21 13:05:28 -08:00
Tim Hockin
81343aac63
Change PullPolicy constants to match
2015-01-21 12:48:56 -08:00
Tim Hockin
819803b79f
Make VolumeSource not be a pointer
...
There's no reason for it to be a pointer.
2015-01-20 17:54:04 -08:00
Brian Grant
dd45246150
Merge pull request #3587 from dchen1107/image
...
Clean up Kubernetes PullPolicy
2015-01-20 17:18:26 -08:00
Tim Hockin
60ec08db93
Rename HostDir to HostPath in v1beta3
2015-01-20 15:56:44 -08:00
Dawn Chen
aec4594a8d
Introduce validatePullPolicyWithDefault to validation.
2015-01-20 11:54:22 -08:00
Tim Hockin
6ff26d924c
Merge pull request #3619 from smarterclayton/expose_validate_labels
...
Expose ValidateLabels in validation.go for reuse by other components
2015-01-20 09:11:08 -08:00
Clayton Coleman
48146e01cd
Expose ValidateLabels in validation.go for reuse by other components
...
Label validation is common to anyone building kube resources.
2015-01-19 22:33:52 -05:00
Andrew Seidl
6dee1d7fa4
Fix typos in user-facing strings
2015-01-18 01:32:34 -06:00
Paul Morie
fd834ae84d
Pods should see services only from their own ns
2015-01-14 17:06:36 -05:00
Tim Hockin
4fcd496d59
change everything to use new util/errors
2015-01-08 22:10:03 -08:00
Daniel Smith
2050131b9a
ParseOrDie -> MustParse; stop returning pointer
2015-01-07 15:21:35 -08:00
Daniel Smith
7f49ba0dcf
Put quantity into packages
...
kubelet, GCE, validation, client
2015-01-07 15:21:34 -08:00
Tim Hockin
1ec3457fc9
Beef up validation tests
2015-01-06 13:02:42 -08:00
Brendan Burns
9884142061
Clear node status before the validation check.
2014-12-22 11:57:31 -08:00
Brendan Burns
36bc3604b9
Merge pull request #2893 from brendandburns/pd3
...
Make it easier to update nodes, make it possible to update capacity.
2014-12-18 10:18:54 -08:00
Brendan Burns
cf0b41535f
Make it easier to update nodes, make it possible to update capacity.
2014-12-17 21:50:26 -08:00
George Kuan
5e1fc1f4e0
Fixes #1605 : make ErrorList introspectable by replacing ErrorList and
...
ErrorList#ToError with []error and util.SliceToError() respectively
2014-12-12 10:56:31 -08:00
Clayton Coleman
19379b5a38
Internal rename api.Minion -> api.Node
2014-12-10 12:08:18 -05:00
Clayton Coleman
2c27f7d332
Allow an empty service
2014-12-09 12:48:53 -05:00
Tim Hockin
89875ef09d
Loosen DNS 952 for labels
2014-12-01 12:30:43 -08:00
Tim Hockin
c857dc1196
Add namespacing for label keys
2014-12-01 12:30:43 -08:00
Tim Hockin
d5a6a54391
clean up error message on labels validation errs
2014-12-01 12:30:43 -08:00
Tim Hockin
b08e5b24b0
Change ValidationError to a pointer
...
In Prep for adding at leats one more field, make this operate more list
StatusError.
2014-11-24 17:28:42 -08:00
Deyuan Deng
b5fce5021f
gitrepo validation
2014-11-23 23:03:11 -05:00
Deyuan Deng
a4e7604266
Merge pull request #2478 from smarterclayton/refactor_minion_to_match_v1beta3
...
Move the internal minion representation to match v1beta3
2014-11-20 21:37:43 -05:00
Clayton Coleman
156000ef6d
Move the internal minion representation to match v1beta3
...
Moves to 'Spec' and 'Status' internally and removes duplicate
fields. Moves Capacity into Spec and drops use of NodeResources
2014-11-20 20:53:08 -05:00
Tim Hockin
ea960711ff
Clean up error logs.
...
Use %v for errors, tidy some messages, make error messages start lowe-case
(as per go guidelines). Just accumulated nits.
2014-11-21 09:45:26 +08:00
markturansky
8af4ccb111
v1beta3 Pod refactor
2014-11-18 09:25:42 -05:00
Deyuan Deng
a07661dcea
Add pod restart policy validation for replication controller.
2014-11-17 23:08:23 -05:00
Deyuan Deng
c20ceea170
Add more validation for updating node.
2014-11-17 13:42:31 -05:00
Daniel Smith
0348a67413
Merge pull request #2195 from smarterclayton/prepare_pod_template_v1beta3
...
Allow an internal pod template reference or object
2014-11-12 10:55:08 -08:00
derekwaynecarr
b326cbbe0c
Centralize minion validation
2014-11-12 12:38:15 -05:00
Clayton Coleman
72bf12c86d
Update the validation logic to test PodTemplateSpec
2014-11-10 11:33:51 -05:00
Brian Grant
535785e3b9
Update api/validation service validation with service fields moved by #2086
2014-11-05 06:52:06 +00:00
bgrant0607
fc0dab630c
Merge pull request #2086 from markturansky/v1beta3_refactor
...
Refactor internal API for Services to match v1beta3
2014-11-04 21:48:02 -08:00
markturansky
bd7643c033
refactor services to v1beta3
2014-11-04 14:23:53 -05:00
Brendan Burns
f556f2f82f
Add some validation for externalized service ports.
2014-11-03 13:36:34 -08:00
markturansky
e2365b1f96
add RFC952 label validation
2014-10-24 16:01:52 -04:00
Tim Hockin
d6effe3c6d
Rename api ErrorList for clarity
2014-10-24 09:43:14 -07:00
Clayton Coleman
644eb70085
Refactor tests to split ObjectMeta from TypeMeta
2014-10-24 11:22:21 -04:00
Clayton Coleman
91d9a90e4e
Replace use of "id" in strings with "name"
2014-10-22 15:59:12 -04:00
Clayton Coleman
bb77a5d15f
Rename ID -> Name
2014-10-22 15:00:26 -04:00
Clayton Coleman
892942af8f
Read BoundPods from etcd instead of ContainerManifestList
...
There are three values that uniquely identify a pod on a host -
the configuration source (etcd, file, http), the pod name, and the
pod namespace. This change ensures that configuration properly
makes those names unique by changing podFullName to contain both
name (currently ID in v1beta1, Name in v1beta3) and namespace.
The Kubelet does not properly handle information requests for
pods not in the default namespace at this time.
2014-10-16 19:29:08 -04:00
Daniel Smith
841e9e87ff
Merge pull request #1713 from brendandburns/update
...
Add update to the pod etcd handler.
2014-10-13 17:42:30 -07:00
Brendan Burns
4380637be7
Add update to the pod etcd handler.
2014-10-13 17:27:31 -07:00
Brendan Burns
695fbee343
Merge pull request #1742 from dchen1107/termination
...
Set EmptyDir when VolumeSource is absent.
2014-10-10 16:27:26 -07:00
Dawn Chen
c511b7a0ce
Fix #1683
2014-10-10 15:34:48 -07:00
Tim Hockin
d84816aaec
Merge pull request #1709 from erictune/move_line
...
Fix format specifiers in Printf-type functions.
2014-10-09 20:40:35 -07:00
Eric Tune
800284164a
Fix format specifiers in Printf-type functions.
2014-10-09 17:06:32 -07:00
Danny Jones
4ec25f3b81
Adds support for attaching GCEPersitentDisks
...
Adds GCEPersistentDisk volume struct
Adds gce-utils to attach disk to kubelet's VM.
Updates config to give compute-rw to every minion.
Adds GCEPersistentDisk to API
Adds ability to mount attached disks
Generalizes PD and adds tests.
PD now uses an pluggable API interface.
Unit Tests more cleanly separates TearDown and SetUp
Modify boilerplate hook to omit build tags
Adds Mounter interface; mount is now built by OS
TearDown() for PD now detaches disk on final refcount
Un-generalized PD; GCE calls moved to cloudprovider
Address comments.
2014-10-08 20:03:59 -07:00
Daniel Smith
7ffe791486
fix error message in validation test
2014-10-07 13:54:41 -07:00
Clayton Coleman
d3e51a0f24
Rename JSONBase -> TypeMeta in preparation for v1beta3
...
Will make subsequent refactor much easier
2014-10-07 11:12:16 -04:00
Clayton Coleman
0ff77ffcb3
Some field names in validation.go not consistent
...
Fields are (for now) JavaScript style field accessors
2014-10-02 23:43:30 -04:00
Eric Tune
9c0769422d
Directory renamed to Dir to match json property
2014-10-01 13:35:21 -07:00
derekwaynecarr
0312d80ffa
Update test cases to use default context
2014-10-01 10:57:50 -04:00
Brendan Burns
dc5a4a8c3f
Refactor to clean up names.
2014-09-16 15:19:02 -07:00
Brendan Burns
5b9e2a55b5
Add a flag to reject privileged containers in the apiserver.
2014-09-16 11:22:32 -07:00
Dawn Chen
d51c28d757
Merge pull request #1304 from brendandburns/valid
...
Add some lifecycle validation.
2014-09-15 16:50:03 -07:00
Brendan Burns
6efafb141f
Add some lifecycle validation.
2014-09-15 16:45:26 -07:00
Tim Hockin
9f275c81ac
add a 'protocol' field to api.Service
2014-09-12 16:38:17 -07:00
Tim Hockin
b566339f0c
make service validation test be table-driven
2014-09-12 16:38:17 -07:00
Dawn Chen
15cab4d053
Introduce the simplest RestartPolicy and handling.
2014-09-08 22:41:38 -07:00
Daniel Smith
7615c00a9a
Make validation work when not in the api package.
2014-09-02 10:42:06 -07:00
Daniel Smith
6121e61f99
Split api into api, api/common, api/validation & apitools
2014-09-02 10:40:52 -07:00