d8d260a09d
Merge pull request #74755 from liggitt/kubelet-watch
...
Revert kubelet to default to ttl cache secret/configmap behavior
2019-03-01 19:14:14 -08:00
9b8c58644a
Merge pull request #74418 from danielqsj/duration
...
convert latency/latencies in metrics name to duration
2019-03-01 17:58:12 -08:00
5e3f3b35e0
Review comments
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-03-01 17:57:39 -08:00
e29c6e1b38
go-1.12: fix 'go vet' failures
2019-03-01 18:48:17 +02:00
4f01eb528e
Merge pull request #74336 from littleroad/exited_container
...
cri_stats_provider: Implement removeTerminatedContainer correctly
2019-02-28 19:12:07 -08:00
cd1c9f9018
Revert kubelet to default to ttl cache secret/configmap behavior
2019-02-28 17:54:22 -05:00
1908a0ce04
Fixing a small bug with GMSA support
...
A previous PR (https://github.com/kubernetes/kubernetes/pull/73726 )
added GMSA support to the dockershim. Unfortunately, there was a
bug in there: the registry keys used to pass the cred specs down
to Docker were being cleaned up too early, right after the containers'
creation - before Docker would ever try to read them, when trying to
actually start the container.
This patch fixes this.
An e2e test is also provided in a separate PR.
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-28 10:26:54 -08:00
6dce4d87a3
Fix secret/configmap management for terminated pods
2019-02-28 18:59:53 +01:00
32c0af42e6
Remove last pieces of mount propagation gate
2019-02-28 13:05:02 +01:00
4b1282d925
Merge pull request #74016 from ahadas/topology_cleanup
...
Cleanup in topology.go
2019-02-27 22:49:24 -08:00
3f8eda37ce
cri_stats_provider: overload nil as 0 for exited containers stats
...
Always report 0 cpu/memory usage for exited containers to make
metrics-server work as expect.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2019-02-28 10:41:15 +08:00
84dce4d119
Merge pull request #74393 from codenrhoden/refactor-subpath
...
Refactor subpath out of pkg/util/mount
2019-02-27 15:54:36 -08:00
8940976602
Distinguish volume path with mount path
2019-02-27 19:31:26 +08:00
2c4d748bed
Refactor subpath out of pkg/util/mount
...
This patch moves subpath functionality out of pkg/util/mount and into a
new package pkg/volume/util/subpath. NSEnter funtionality is maintained.
2019-02-26 19:59:53 -07:00
f9b8d27cef
Lower the log level for non-exist cadvisor stats.
...
For exited container, it is quite normal that cri stats
are returned, but there is no corresponding cadvisor stats.
2019-02-26 16:43:42 -08:00
cf24d24e66
Merge pull request #70647 from vshn/imagegc_multi_repo_image_removal
...
Always run untag when removing docker image
2019-02-26 11:04:58 -08:00
44d13d3b77
Merge pull request #73726 from wk8/wk8/gmsa_alpha
...
Kubelet changes for Windows GMSA support
2019-02-25 21:48:21 -08:00
272d78f1d9
Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server
...
Fix lint on pkg/kubelet/server/...
2019-02-25 20:27:48 -08:00
0d392ffcef
Udpated Bazel files
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-26 03:02:09 +00:00
77cf7c7b86
Merge pull request #73703 from rphillips/fixes/kubelet_file_fsnotify
...
kubelet: upgrade sourceFile to use fsnotify
2019-02-25 15:15:08 -08:00
f1bdfa93f9
Review comments
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-25 10:59:23 -08:00
4ac08be206
prevent panic on nil pod.spec.enableServiceLinks
2019-02-25 10:43:29 -05:00
9788d401e2
Revert "bug: fix segfault when EnableServiceLinks is nil"
...
This reverts commit e9f1700512
2019-02-25 10:35:48 -05:00
7181c44230
fix some golint failures for pkg/cloudprovider/providers/vsphere/vclib and pkg/kubelet/apis/...
2019-02-25 18:01:41 +08:00
8993fbc543
Merge pull request #74328 from daixiang0/delete-blank
...
delete all duplicate empty blanks
2019-02-23 01:43:58 -08:00
b5566c7818
Merge pull request #71896 from awly/client-go-keyutil
...
client-go: extract new keyutil package from util/cert
2019-02-23 01:43:16 -08:00
36065c6dd7
delete all duplicate empty blanks
...
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
b77e4e2417
Merge pull request #74389 from answer1991/sync-cni-config-in-goroutine
...
sync CNI config in goroutine
2019-02-22 17:58:54 -08:00
95856e30c4
Merge pull request #73820 from haiyanmeng/runtimeclass
...
Fit RuntimeClass metrics to prometheus conventions
2019-02-22 16:14:59 -08:00
2f2945732b
Merge pull request #69099 from ehashman/issue-66790
...
Rename cadvisor metric labels to match instrumentation guidelines
2019-02-22 14:56:01 -08:00
f7b437cae0
convert latency in mertics name to duration
2019-02-22 21:40:13 +08:00
4fe13c2a99
sync CNI config in goroutine
2019-02-22 16:26:49 +08:00
e61cd68bf3
Fix lint on pkg/kubelet/server/...
2019-02-21 10:31:41 -05:00
5bfea15e7b
Merge pull request #71351 from HotelsDotCom/kep/VolumeSubpathEnvExpansion
...
kep/VolumeSubpathEnvExpansion
2019-02-20 14:05:20 -08:00
a2a5bd03fd
Merge pull request #71119 from Chenditang/typo
...
Fix typos.
2019-02-20 12:54:30 -08:00
78573805a7
Merge pull request #66228 from liucimin/fix_cniplugin_get_expose_hostip
...
fix_the_checkpoint_no_hostip_bug
2019-02-20 12:51:14 -08:00
a64b854137
Implementation of KEP Feature Gate VolumeSubpathEnvExpansion
2019-02-20 01:37:16 +00:00
a09031dbbd
Typo in comment
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-19 13:10:23 -08:00
ec18200f8b
Fit RuntimeClass metrics to prometheus conventions
...
1) Add suffix (`seconds` or `total`) to metric name
2) Switch Summary metric to Histogram metric (Summary metrics are not
supported completely by prometheus-to-sd and can't be aggregated.)
2019-02-19 12:46:37 -08:00
18458392ca
Extract new keyutil package from client-go/util/cert
...
This package contains public/private key utilities copied directly from
client-go/util/cert. All imports were updated.
Future PRs will actually refactor the libraries.
Updates #71004
2019-02-19 09:48:59 -08:00
d61e878533
Merge pull request #73997 from xichengliudui/fixlintcode
...
Fix golint failures
2019-02-19 01:44:48 -08:00
c0c93f4a52
kubelet: return mirror pod in GetActivePods()
2019-02-18 12:06:43 -08:00
79a3eb816c
rename latency to duration in metrics
2019-02-18 17:40:04 +08:00
0bfe4c26b1
add default buckets for histogram metrics
2019-02-18 14:07:30 +08:00
4fa0ee7805
Mark deprecated in related kubelet metrics
2019-02-18 14:03:44 +08:00
0e9515c709
Move kubelet metrics to histogram metrics
2019-02-18 14:03:44 +08:00
9fd99a48f5
Change kubelet metrics to conform guideline
2019-02-18 14:01:58 +08:00
b1ea622359
Review from @yujuhong
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-16 07:55:43 -08:00
c88dcee3e9
Merge pull request #73824 from jiayingz/reallocate
...
Checks whether we have cached runtime state before starting a container
2019-02-15 20:35:30 -08:00
063e7ff358
Merge pull request #73833 from haiyanmeng/cri_runtimeclass
...
Add `runtime_handler` into PodSandbox and PodSandboxStatus
2019-02-15 18:02:46 -08:00
3e748958dc
Merge pull request #73333 from yujuhong/os-arch-labels
...
kubelet: promote OS & arch labels to GA
2019-02-15 16:45:57 -08:00
fbee96d733
Merge pull request #73699 from pivotal-k8s/doc-links
...
Update deprecated and broken links
2019-02-15 14:05:09 -08:00
6310f9681e
Merge pull request #74114 from feiskyer/revert-70121
...
Revert #70121 : Add network stats for Windows containers #70121
2019-02-15 12:44:06 -08:00
34ac4d9ee9
Update deprecated links
2019-02-15 09:13:07 -05:00
bf20886f4e
Merge pull request #73990 from xichengliudui/fixlinterror
...
Fix golint failures pkg/kubelet/util/cache
2019-02-14 22:43:15 -08:00
0d03672e02
Revert "Add network stats for windows node"
...
This reverts commit f9fa1c6a38
2019-02-15 12:20:41 +08:00
2449b0997c
Revert "Add network stats for Windows containers"
...
This reverts commit 9cf38de44b
2019-02-15 12:20:23 +08:00
6a9902deee
Merge pull request #73802 from Random-Liu/handle-unknown-state
...
Stop container in unknown state before recreate or remove.
2019-02-14 15:50:12 -08:00
b435dbf718
Merge branch 'master' into wk8/gmsa_alpha
...
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-14 15:38:25 -08:00
c3a533e5b2
Cleanup in topology.go
...
1. Find the minimal thread number within a core using a
single loop rather than by sorting the thread numbers.
2. Inline getUniqueCoreID#err and Discover#numCPUs variables.
3. Narrow the scope of Discover#coreID and Discover#err variables.
Signed-off-by: Arik Hadas <ahadas@redhat.com>
2019-02-14 16:55:37 +02:00
de8ee94d14
Stop container in unknown state before recreate or remove.
2019-02-14 02:31:17 -08:00
5fd27c38da
Move beta OS/Arch labels back to the kubelet package
...
These labels are being deprecated
2019-02-13 18:09:49 -08:00
888ff4097a
Merge pull request #73651 from RobertKrawitz/node_pids_limit
...
Support total process ID limiting for nodes
2019-02-13 17:31:18 -08:00
2597a1d97e
Implement SupportNodePidsLimit, hand-tested
2019-02-13 14:56:17 -05:00
289a60ad71
Merge pull request #72709 from changyaowei/pleg_relist
...
When pleg channel is full, discard events and record its count
2019-02-13 01:44:48 -08:00
19f73899fc
modify test case
2019-02-13 16:27:15 +08:00
19e57c616c
Merge pull request #73892 from smarterclayton/fix_container_message
...
Make container create, start, and stop events consistent
2019-02-12 20:01:36 -08:00
a684bd5eb1
Merge pull request #73556 from msau42/triage-72931
...
Mark volume as in use even when node status didn't change
2019-02-12 17:29:05 -08:00
80a2698a02
Add unit tests for volumesinuse during node status update
2019-02-12 13:46:30 -08:00
62f874b19b
Mark volume as in use even when node status didn't change
2019-02-12 13:46:29 -08:00
4c42d542dc
Fix golint failures
...
update pull request
update pull request
2019-02-12 13:01:49 -05:00
d1d54f81ec
update pull request
...
update pull request
2019-02-12 12:13:19 -05:00
4000ef006c
kubelet: upgrade sourceFile to use fsnotify
...
Mitigate some flakes for deleted watch directories and use the
maintained fsnotify package.
2019-02-12 08:00:56 -06:00
5aa58efe07
Fix golint failures
...
update pull request
2019-02-12 07:14:57 -05:00
0480214903
Merge pull request #73804 from Random-Liu/remove-unused-functions
...
Remove unused function from the legacy runtime interface.
2019-02-11 22:56:00 -08:00
5dd26ecab5
Fix function comment to consistent with its name
...
update pull request
update pull request
2019-02-12 01:37:20 -05:00
c9964aa519
Merge pull request #73342 from szuecs/fix/period-not-reset-if-gate-not-set
...
cpuPeriod was not reset
2019-02-11 19:58:07 -08:00
04575f01b0
kubelet: promote OS & arch labels to GA
...
kubelet now applies both the beta and the GA labels to ensure backward
compatibility.
2019-02-11 11:24:58 -08:00
49250c6efc
Make container create, start, and stop events consistent
...
The messages for container lifecycle events are subtly inconsistent
and should be unified.
First, the field format for containers is hard to parse for a human,
so include the container name directly in the message for create
and start, and for kill remove the container runtime prefix.
Second, the pulling image event has inconsistent capitalization, fix
that to be sentence without punctuation.
Third, the kill container event was unnecessarily wordy and inconsistent
with the create and start events. Make the following changes:
* Use 'Stopping' instead of 'Killing' since kill is usually reserved for
when we decide to hard stop a container
* Send the event before we dispatch the prestop hook, since this is an
"in-progress" style event vs a "already completed" type event
* Remove the 'cri-o://' / 'docker://' prefix by printing the container
name instead of id (we already do that replacement at the lower level
to prevent high cardinality events)
* Use 'message' instead of 'reason' as the argument name since this is a
string for humans field, not a string for machines field
* Remove the hash values on the container spec changed event because no
human will ever be able to do anything with the hash value
* Use 'Stopping container %s(, explanation)?' form without periods to
follow event conventions
The end result is a more pleasant message for humans:
```
35m Normal Created Pod Created container
35m Normal Started Pod Started container
10m Normal Killing Pod Killing container cri-o://installer:Need to kill Pod
10m Normal Pulling Pod pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```
becomes
```
35m Normal Created Pod Created container installer
35m Normal Started Pod Started container installer
10m Normal Killing Pod Stopping container installer
10m Normal Pulling Pod Pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```
2019-02-10 16:39:42 -05:00
ee44e24cd3
Merge pull request #73659 from feiskyer/usage-nano-cores
...
Kubelet: add usageNanoCores from CRI stats provider
2019-02-08 19:26:21 -08:00
5b7a790d35
Merge pull request #72185 from dcbw/owners-label-sig-network
...
OWNERS: add label:sig/network to a bunch of places
2019-02-08 10:36:16 -08:00
5bedff6625
Merge pull request #73836 from Random-Liu/clarify-hostname-in-cri
...
Clarify hostname emptiness in CRI.
2019-02-08 09:06:27 -08:00
b50c643be0
Merge pull request #73540 from rlenferink/patch-5
...
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
eac19a3ab9
Merge pull request #73616 from dims/move-part-of-kubelet-apis-well-known-lables
...
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
2019-02-07 19:44:34 -08:00
5b86ee1c82
Clarify hostname emptiness in CRI.
2019-02-07 18:37:59 -08:00
1a92e218e0
Remove unused function from the legacy runtime interface.
...
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-02-07 16:57:19 -08:00
c35335808c
Add `runtime_handler` into PodSandbox and PodSandboxStatus
2019-02-07 15:52:09 -08:00
00b88c14b0
Checks whether we have cached runtime state before starting a container
...
that requests any device plugin resource. If not, re-issue Allocate
grpc calls. This allows us to handle the edge case that a pod got
assigned to a node even before it populates its extended resource
capacity.
2019-02-07 11:12:36 -08:00
01fbca29cb
Kubelet: add usageNanoCores from CRI stats provider
2019-02-07 22:31:30 +08:00
6796645672
Merge pull request #73758 from sjenning/priority-based-oom-score-adj
...
kubelet: set low oom_score_adj for containers in critical pods
2019-02-06 21:13:55 -08:00
ae45068688
Merge pull request #72323 from danielqsj/dockershim
...
Change docker metrics to conform metrics guidelines
2019-02-06 09:30:54 -08:00
c4806186d4
Review comments
...
* value names are now purely random
* cleaning up leaked registry keys at Kubelet init
* fixing a small bug masking create errors
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-05 16:53:17 -08:00
459e509f94
Merge pull request #73549 from haiyanmeng/runtimeclass
...
Add monitoring for RuntimeClass
2019-02-05 15:14:38 -08:00
a20cd49d6d
Merge pull request #72910 from danielqsj/kn
...
Add kubelet_node_name metrics
2019-02-05 15:14:06 -08:00
dc1244c6cd
Merge pull request #72785 from derekwaynecarr/hugepages-ga
...
Graduate HugePages feature to GA
2019-02-05 13:56:51 -08:00
7dcf1fe5f8
kubelet: set low oom_score_adj for containers in critical pods
2019-02-05 14:28:36 -06:00
274c9976d2
DefaultFailureDomains does not need to be global
...
Change-Id: I5ccfe8b836133b0db402a37a6974fc011aa6335e
2019-02-05 13:39:07 -05:00
b975573385
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
...
Co-Authored-By: Weibin Lin <linweibin1@huawei.com>
Change-Id: I163b2f2833e6b8767f72e2c815dcacd0f4e504ea
2019-02-05 13:39:07 -05:00
3f5675880d
Kubelet changes for Windows GMSA support
...
This patch comprises the kubelet changes outlined in the GMSA KEP
(https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md )
to add GMSA support to Windows workloads.
More precisely, it includes the logic proposed in the KEP to resolve
which GMSA spec should be applied to which containers, and changes
`dockershim` to copy the relevant GMSA credential specs to Windows
registry values prior to creating the container, passing them down
to docker itself, and finally removing the values from the registry
afterwards; both these changes need to be activated with the `WindowsGMSA`
feature gate.
Includes unit tests.
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-05 09:17:46 -08:00
6a149864fb
Merge pull request #73285 from tallclair/typed-runtimeclass
...
Migrate RuntimeClass support to the generated typed client
2019-02-04 16:13:30 -08:00
Kubernetes Prow Robot