Review comments

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
pull/564/head
Jean Rouge 2019-03-01 17:57:39 -08:00
parent 1908a0ce04
commit 5e3f3b35e0
1 changed files with 4 additions and 1 deletions

View File

@ -177,7 +177,10 @@ func (ds *dockerService) CreateContainer(_ context.Context, r *runtimeapi.Create
containerID := createResp.ID
if cleanupInfo != nil {
// save it for when the container starts or gets removed
// we don't perform the clean up just yet at that could destroy information
// needed for the container to start (e.g. Windows credentials stored in
// registry keys); instead, we'll clean up after the container successfully
// starts or gets removed
ds.containerCleanupInfos[containerID] = cleanupInfo
}
return &runtimeapi.CreateContainerResponse{ContainerId: containerID}, nil