From 5e3f3b35e0b46bc3a3d35c4986220f36777431c2 Mon Sep 17 00:00:00 2001 From: Jean Rouge Date: Fri, 1 Mar 2019 17:57:39 -0800 Subject: [PATCH] Review comments Signed-off-by: Jean Rouge --- pkg/kubelet/dockershim/docker_container.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/dockershim/docker_container.go b/pkg/kubelet/dockershim/docker_container.go index 054600a267..af69796cd0 100644 --- a/pkg/kubelet/dockershim/docker_container.go +++ b/pkg/kubelet/dockershim/docker_container.go @@ -177,7 +177,10 @@ func (ds *dockerService) CreateContainer(_ context.Context, r *runtimeapi.Create containerID := createResp.ID if cleanupInfo != nil { - // save it for when the container starts or gets removed + // we don't perform the clean up just yet at that could destroy information + // needed for the container to start (e.g. Windows credentials stored in + // registry keys); instead, we'll clean up after the container successfully + // starts or gets removed ds.containerCleanupInfos[containerID] = cleanupInfo } return &runtimeapi.CreateContainerResponse{ContainerId: containerID}, nil