Commit Graph

40620 Commits (12147a3cd6f52b1831c8af34d14d52e2811a4668)

Author SHA1 Message Date
Kubernetes Submit Queue 12147a3cd6 Merge pull request #38630 from ncdc/fix-threshold-notifier-build-tags
Automatic merge from submit-queue (batch tested with PRs 38453, 36672, 38629, 34966, 38630)

Fix threshold notifier build tags

Fix threshold notifier build tags so the linux version is only built if cgo is
enabled, and the unsupported version is built if it's either not linux or not
cgo.
2016-12-12 11:41:12 -08:00
Kubernetes Submit Queue 0ac73a823a Merge pull request #34966 from ivan4th/make-top-pod-test-table-driven
Automatic merge from submit-queue (batch tested with PRs 38453, 36672, 38629, 34966, 38630)

Make kubectl top pod test table-driven
2016-12-12 11:41:10 -08:00
Kubernetes Submit Queue 43dda9c64f Merge pull request #38629 from soltysh/fix_copy
Automatic merge from submit-queue (batch tested with PRs 38453, 36672, 38629, 34966, 38630)

Fix staging/copy.sh to work on mac and linux

@smarterclayton ptal
2016-12-12 11:41:08 -08:00
Kubernetes Submit Queue 3d29c3d229 Merge pull request #36672 from ymqytw/check_annotation_for_apply
Automatic merge from submit-queue (batch tested with PRs 38453, 36672, 38629, 34966, 38630)

Warn user if they try to apply on an object without the annotation

Give user a warning when using `kubectl apply` on a resource lacking the `LastAppliedConfig` annotation

fixes #36620

Ref: #35134 and #36509.

**Release note**:
```release-note
Issue a warning when using `kubectl apply` on a resource lacking the `LastAppliedConfig` annotation
```
2016-12-12 11:41:06 -08:00
Kubernetes Submit Queue 5b89e8ab01 Merge pull request #38453 from liggitt/apps-group
Automatic merge from submit-queue

remove incorrect groupName comment for apps.k8s.io

The group name is "apps", not "apps.k8s.io"

The comment didn't actually affect client generation because there was an extra space between it and the package declaration, but removing it to avoid confusion
2016-12-12 11:31:15 -08:00
Kubernetes Submit Queue b5cf713bc7 Merge pull request #38108 from hodovska/1396877-pvc-limitrange-max
Automatic merge from submit-queue (batch tested with PRs 37846, 38619, 38108)

LimitRange: modified approach for PVC max storage request enforcing

Behavior was correct but with not correct error messages. This pull request creates separate approach for enforcing the max request for persistent volume claim.

Additional info:
https://github.com/kubernetes/kubernetes/blob/master/docs/design/admission_control_limit_range.md#enforcement-of-constraints

bugzilla : https://bugzilla.redhat.com/show_bug.cgi?id=1396877
2016-12-12 10:30:07 -08:00
Kubernetes Submit Queue 60593467b0 Merge pull request #38619 from wojtek-t/increase_gce_operation_timeout
Automatic merge from submit-queue

Increase GCE operation timeout

It seems 30 minutes is too small for creating some routes in large clusters.

@thockin - FYI
2016-12-12 10:28:43 -08:00
Kubernetes Submit Queue dca0b2a73d Merge pull request #37846 from sjenning/no-abort-node-status-update
Automatic merge from submit-queue

error in setNodeStatus func should not abort node status update

`setNodeStatus()` currently errors out if any of the functions in the `kl.setNodeStatusFuncs` returns an error, resulting in the node not reporting status and eventually being marked as `NotReady`.

`setNodeAddress()` is currently the only function in `defaultNodeStatusFuncs()` that can return an error and it does if the cloud provider can't be contacted for any number of reasons like token expiration, API outage, ratelimit block, etc.

This PR changes `setNodeStatus()` to log, rather than return, when an error is returned by one of the `setNodeStatusFuncs` so that the node status update can proceed.

Fixes #34455

xref https://bugzilla.redhat.com/show_bug.cgi?id=1400574

@eparis @derekwaynecarr @mikedanese @anguslees
2016-12-12 09:48:10 -08:00
Ivan Shvedunov 9b9c1e6952 Make top pod test table-driven 2016-12-12 20:23:17 +03:00
Andy Goldstein 89ea5ac9c1 Fix threshold notifier build tags
Fix threshold notifier build tags so the linux version is only built if cgo is
enabled, and the unsupported version is built if it's either not linux or not
cgo.
2016-12-12 11:56:07 -05:00
Maciej Szulik 6bc12f2a69 Fix staging/copy.sh to work on mac and linux 2016-12-12 17:47:39 +01:00
Kubernetes Submit Queue 492f8d412f Merge pull request #38512 from deads2k/fed-11-fix-client-cert-termination
Automatic merge from submit-queue

fix client cert handling for delegate authn

Builds on https://github.com/kubernetes/kubernetes/pull/38409.

The client cert wasn't presented by the API server, so tools didn't send it.  These will start getting caught as we add usage into e2e. Once we split genericapiserver out, we can have a different style integration test that hits these too.
2016-12-12 08:01:22 -08:00
Wojciech Tyczynski 289a7ada44 Increase GCE operation timeout 2016-12-12 16:37:21 +01:00
Seth Jennings a40b15d8bd error in setNodeStatus func should not abort node status update 2016-12-12 09:29:24 -06:00
Kubernetes Submit Queue b6f466ac61 Merge pull request #38611 from kargakis/log-controller-enqueues-on-minreadyseconds
Automatic merge from submit-queue (batch tested with PRs 38603, 38611)

Log enqueueing replica sets for availability checks

@kubernetes/deployment these logs should help debugging https://github.com/kubernetes/kubernetes/issues/38275 + https://github.com/kubernetes/kubernetes/issues/36458
2016-12-12 07:05:04 -08:00
Kubernetes Submit Queue de33a618a6 Merge pull request #38603 from sttts/sttts-repair-healthz-ping
Automatic merge from submit-queue

Re-add /healthz/ping handler in genericapiserver

The ping handler was removed through f56cbfa8d5 (diff-c47934bf31679532191ed2b519d74399L233) (in case `c.Tunneler` was disabled).
2016-12-12 06:53:58 -08:00
deads2k bae26c2030 fix delegated authn client cert presentation 2016-12-12 09:30:59 -05:00
deads2k 79a956c197 react to kube-dns yaml manifests moving 2016-12-12 09:30:31 -05:00
deads2k 4aeb3f3ffe update pod RBAC roles to work against head 2016-12-12 08:55:47 -05:00
deads2k 6421405d0e create hack/local-up-discovery.sh 2016-12-12 08:40:00 -05:00
Dr. Stefan Schimanski e1f0bdbf37 Re-add /healthz/ping handler in genericapiserver 2016-12-12 14:29:33 +01:00
deads2k bcb8d8b8bb extra discovery start and cert generation 2016-12-12 08:28:29 -05:00
Michail Kargakis 9c7b39066e Log enqueueing replica sets for availability checks 2016-12-12 14:09:16 +01:00
Kubernetes Submit Queue 59c313730c Merge pull request #38510 from kargakis/declutter-deployment-logs
Automatic merge from submit-queue

test: cleanup test logs for deployments

@mfojtik @janetkuo this will help with the deployment logs (should make them a bit cleaner) ptal
2016-12-12 04:58:30 -08:00
Kubernetes Submit Queue 83a77fa5a1 Merge pull request #38299 from kargakis/calculate-unavailable-correctly
Automatic merge from submit-queue (batch tested with PRs 38608, 38299)

controller: set unavailableReplicas correctly when scaling down

```
deployment_controller.go:299] Error syncing deployment
e2e-tests-kubectl-2l7xx/e2e-test-nginx-deployment:
Deployment.extensions "e2e-test-nginx-deployment" is invalid:
status.unavailableReplicas: Invalid value: -1:
must be greater than or equal to 0
```

The validation error above occurs usually when a Deployment is
scaled down. In such a case we should default unavailableReplicas
to 0 instead of making an invalid api call.

@kubernetes/deployment
2016-12-12 04:18:04 -08:00
Kubernetes Submit Queue b2047ad4a5 Merge pull request #38608 from wojtek-t/logrotate_in_kubemark
Automatic merge from submit-queue

Increase single logfile size in kubemark
2016-12-12 03:50:07 -08:00
Michail Kargakis 0d95d71e65 test: cleanup test logs for deployments 2016-12-12 12:19:51 +01:00
Wojciech Tyczynski 9439453527 Increase single logfile size in kubemark 2016-12-12 11:18:20 +01:00
Kubernetes Submit Queue 5b37bcc3f3 Merge pull request #38604 from wojtek-t/fix_services_in_load
Automatic merge from submit-queue

Fix services in load test
2016-12-12 02:17:00 -08:00
Kubernetes Submit Queue 9e6b090804 Merge pull request #38570 from smarterclayton/cleanup_body_logging
Automatic merge from submit-queue (batch tested with PRs 38597, 38570)

Logging request / response body should not allocate

Putting string(data) in the critical path causes an allocation which can
be very large, and happens regardless of whether logging is enabled.

Also, use the more sophisticated logging of body output that avoids
causing quoting of JSON output (current behavior is "{\"key\":...}" and
should be {"key":...} for readability).

@wojtek-t reduces large heap allocations on updates
2016-12-12 01:24:04 -08:00
Kubernetes Submit Queue ec72d95a3e Merge pull request #38597 from hongchaodeng/sr2
Automatic merge from submit-queue

generic_scheduler: Schedule() pod param should never be nil

This code doesn't make sense.
Schedule() pod param should never be nil.
2016-12-12 01:15:50 -08:00
Wojciech Tyczynski b1da629374 Fix services in load test 2016-12-12 09:40:43 +01:00
Kubernetes Submit Queue f071c7701d Merge pull request #38595 from yarntime/fix_typo_storage
Automatic merge from submit-queue

fix typo

**What this PR does / why we need it**:
    fix typo.

**Release note**:

```NONE
```
2016-12-11 22:14:21 -08:00
Kubernetes Submit Queue b7559ad4c5 Merge pull request #37934 from xilabao/improve-the-result-of-checking-role-name
Automatic merge from submit-queue (batch tested with PRs 38527, 37934)

improve the result of checking role name

Get all error messages before return.
2016-12-11 21:08:01 -08:00
Hongchao Deng 479f507532 scheduler test: fix test due to nil pod assumption 2016-12-11 20:46:38 -08:00
Kubernetes Submit Queue 07312ee4b5 Merge pull request #38527 from derekwaynecarr/reduce-max-wait-time
Automatic merge from submit-queue

Fail kubelet is runtime is unresponsive for 30 seconds

Fixes https://github.com/kubernetes/kubernetes/issues/30534
2016-12-11 20:29:19 -08:00
xilabao ce2085594e improve the result of checking role name 2016-12-12 11:44:16 +08:00
Hongchao Deng a2426bd48a generic_scheduler: Schedule() pod param should never be nil 2016-12-11 19:30:48 -08:00
Kubernetes Submit Queue e092d3f47b Merge pull request #38571 from madhusudancs/fed-federation-api-getoptions
Automatic merge from submit-queue

Register metav1.GetOptions with federation APIs.

PR #37693 missed a spot.

cc @kubernetes/sig-federation @nikhiljindal
2016-12-11 19:24:29 -08:00
yarntime@163.com a71741929e fix typo 2016-12-12 10:32:06 +08:00
Kubernetes Submit Queue 3f7b000496 Merge pull request #38452 from euank/cfssl
Automatic merge from submit-queue (batch tested with PRs 38277, 36361, 38452)

local-up: resolve sudo -E'd paths better

This problem won't affect everyone, but for people who have `--with-secure-path` configured for their sudo binaries, `sudo -E` won't actually preserve PATH, which means the sub-bash won't necessarily be able to find the binary which `test` found to exist.
This fixes that.

Ubuntu [used to](https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/50797) configure it that way, and they might still.
It's configured as such on my (Gentoo) machine.
2016-12-11 13:02:54 -08:00
Kubernetes Submit Queue 48cae78257 Merge pull request #36361 from ivan4th/build-container-rsync-optimizations
Automatic merge from submit-queue (batch tested with PRs 38277, 36361, 38452)

Add options for build container rsync optimization

KUBE_RSYNC_COMPRESS env var sets rsync compression level.
KUBE_RSYNC_GENERATED_TO_BUILD_CONTAINER env var disables rsyncing
generated files to build containers.

Why KUBE_RSYNC_COMPRESS is needed -- from rsync manual on `--compress` option (implied by non-zero `--compress-level`):
> Note that this option typically achieves better compression ratios than can be achieved by using a compressing remote shell or a compressing transport because it takes advantage of the implicit information in the matching data blocks that are not explicitly sent over  the connection.

Use case for `KUBE_RSYNC_GENERATED_TO_BUILD_CONTAINER`: when you sometimes build stuff locally (e.g. `make WHAT=cmd/kubectl`) and sometimes do it on remote docker (`build-tools/run.sh make WHAT=cmd/hyperkube`), local builds touch generated files which causes them to be rsynced to the build data container, which may slow down the builds. Still, I'm not sure whether local->remote rsync of generated files is useful (e.g. someone may want to edit generated files for debugging purposes?), so I made not rsyncing these files an option instead of forcing such behavior.
2016-12-11 13:02:53 -08:00
Kubernetes Submit Queue e8bcf8d36e Merge pull request #38277 from xilabao/fix-advertise-address-in-local-cluster
Automatic merge from submit-queue

fix set advertise address in local cluster
2016-12-11 13:00:27 -08:00
Kubernetes Submit Queue 37cd01dc8c Merge pull request #38438 from MrHohn/addon-manager-coreos
Automatic merge from submit-queue

Keeps addon manager yamls in sync

From #38437.

We should have kept all addon manager YAML files in sync. This does not fix the release scripts issue, but we should still have this.

@mikedanese @ixdy
2016-12-11 11:41:35 -08:00
Kubernetes Submit Queue d8c925319a Merge pull request #38523 from MrHohn/kube-dns-rename
Automatic merge from submit-queue (batch tested with PRs 38058, 38523)

Renames kube-dns configure files from skydns* to kubedns*

`skydns-` prefix and `-rc` suffix are confusing and misleading. Renaming it to `kubedns` in existing yaml files and scripts.

@bowei @thockin
2016-12-10 17:04:53 -08:00
Kubernetes Submit Queue 543cfa1ad0 Merge pull request #38058 from smarterclayton/unstructured
Automatic merge from submit-queue (batch tested with PRs 38058, 38523)

Move unstructured types under `meta/v1` to indicate they are typed

Add a few abstractions that make them simpler to use from generic code that does not need accessors. Move OwnerReference to meta/v1 and remote metatypes.go

Part of #37530
2016-12-10 17:04:51 -08:00
Madhusudan.C.S 8c63a14e5e Register metav1.GetOptions with federation APIs.
PR #37693 missed a spot.
2016-12-10 16:35:08 -08:00
Clayton Coleman ea2ab71f4b
Logging request / response body should not allocate
Putting string(data) in the critical path causes an allocation which can
be very large, and happens regardless of whether logging is enabled.

Also, use the more sophisticated logging of body output that avoids
causing quoting of JSON output (current behavior is "{\"key\":...}" and
should be {"key":...} for readability).
2016-12-10 19:27:17 -05:00
Kubernetes Submit Queue 8ccecf93aa Merge pull request #38520 from ixdy/clean-no-docker
Automatic merge from submit-queue

Don't require docker or other tools when running `make clean`

**What this PR does / why we need it**: we don't require `docker` for a local build, so we shouldn't require it for `make clean` either.

**Which issue this PR fixes**: fixes #37690

cc @sebgoa
2016-12-10 15:48:30 -08:00
Clayton Coleman 42e0eda3e4
Sorting printer changed 2016-12-10 18:07:33 -05:00