b1cb58fdf2
fix golint failures in test/e2e_node/builder
2019-03-26 14:12:45 +08:00
3d5d38607d
fix 'make generated_files' build on MacOS
...
Recent change to hack/lib/golang.sh broke the build on MacOS this way:
$ make clean && make generated_files
+++ [0325 13:38:22] Verifying Prerequisites....
+++ [0325 13:38:23] Removing _output directory
k8s.io/kubernetes/vendor/github.com/spf13/pflag
k8s.io/kubernetes/hack/make-rules/helpers/go2make
+++ [0325 13:38:40] Building go targets for darwin/amd64:
./vendor/k8s.io/code-generator/cmd/deepcopy-gen
can't load package: package k8s.io/kubernetes: no Go files in k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes
!!! [0325 13:38:40] Call tree:
!!! [0325 13:38:40] 1: k8s.io/kubernetes/hack/lib/golang.sh:629 kube::golang::build_some_binaries(...)
!!! [0325 13:38:40] 2: k8s.io/kubernetes/hack/lib/golang.sh:764 kube::golang::build_binaries_for_platform(...)
!!! [0325 13:38:40] 3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [_output/bin/deepcopy-gen] Error 1
make: *** [generated_files] Error 2
It was caused by 'binaries' array not being declared with 'local -a'.
It looks like MacOS' old bash version makes an array to contain first
empty element if declared this way.
The fix has been tested on MacOS High Sierra and Linux openSUSE 42.3 (x86_64)
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
2019-03-25 17:08:13 +01:00
8cc3718e69
fix eliminate shellcheck failures in hack/local-up-cluster.sh
2019-03-25 07:17:06 +00:00
f82fb4059d
fix some failures in pkg/apis
2019-03-23 12:20:49 +08:00
9c53f24012
Merge pull request #75179 from rosti/kill-v1alpha3
...
kubeadm: remove v1alpha3
2019-03-22 17:02:21 -07:00
ffd8f3dacb
Merge pull request #73255 from ds-ms/golint
...
Fix linting issues in pkg/kubectl/cmd/version
2019-03-22 17:02:08 -07:00
a3bc56fffb
Merge pull request #74746 from oomichi/golint-e2e-framework-gce
...
Fix golint failures under test/e2e/[..]/gce
2019-03-22 15:46:08 -07:00
3d64667507
Add check-conformance-test-requirements.go
...
We have defined requirements of conformance test as [1], and this
adds coding check for one requirement "it works for all providers".
[1]: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements
2019-03-22 21:56:07 +00:00
fcb102b2a4
Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
...
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
da7c9f70c3
Fix golint failures under test/e2e/[..]/gce
...
This fixes golint failures under test/e2e/framework/providers/gce/.
Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
are used at test/e2e/network/firewall.go only. So move them.
2019-03-22 15:59:17 +00:00
22621ca415
Merge pull request #74739 from moshe010/nokubeproxy
...
Add nokubeproxy option in START_MODE
2019-03-21 22:50:44 -07:00
51b5d28c15
Merge pull request #74333 from SataQiu/fix-shell-20190221
...
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
4c16fb78b3
Merge pull request #74242 from xichengliudui/fixshellcheck19021903
...
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
a52af3a9d5
fix shellcheck failure golang.sh
2019-03-22 13:29:26 +09:00
c48ed1c5ac
Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark
...
Fix golint failures for e2e/[..]/kubemark
2019-03-21 19:26:32 -07:00
4499275cb9
Merge pull request #72800 from stewart-yu/stewart-component-base
...
Move config local to every controller in KCM
2019-03-21 19:26:19 -07:00
64f8f30c07
fix shellcheck failures in ./hack/jenkins/...
2019-03-21 05:30:11 -04:00
f82870291f
Fix shellcheck failures in godep-save.sh and godep-restore.sh
...
update pull request
update pull request
2019-03-21 05:02:47 -04:00
112af136df
update verify-staging-meta-files.sh
2019-03-21 12:44:39 +08:00
a5ddc3943a
bump required minimum go version to 1.12.1 (strings package compatibility)
2019-03-20 16:07:07 -07:00
46799b6dd4
Fix shellcheck failures in bootstrap.sh and create_block.sh
2019-03-20 17:37:50 -04:00
481de197c0
Merge pull request #75156 from smarterclayton/diff_invalid
...
Handle nil interface inputs to diff.ObjectReflectDiff
2019-03-20 00:55:01 -07:00
6a2936dcbf
Merge pull request #74642 from SataQiu/fix-golint-20190227
...
Fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-19 20:14:54 -07:00
d261549a1c
Merge pull request #71813 from booxter/make-update-errors-visibility
...
Expose errors from godep_restored to caller
2019-03-19 19:00:25 -07:00
ac88e13821
Fix lint warnings in pkg/controller/cronjob.
2019-03-19 14:36:26 -04:00
4cfcf0519d
Fix lint warnings in pkg/controller/bootstrap
2019-03-19 14:36:26 -04:00
dcebfd82ac
Add nokubeproxy option in START_MODE
...
Some CNIs such as OVN don't use kubeproxy and provide
there own implementation for network proxy .
This patch allow to disable the kubeproxy start in the
local-up-cluster.sh script.
It is also move the generation of the certificate and
kubeconfig to start_kubeproxy function so it will be
generated only when it needed.
This is useful for us for developement and CI testing.
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-03-14 02:29:31 +02:00
2fde54c1f3
staging: include generated code in godep verification
...
as we now commit up-to-date generated definitions in
apiextensions-apiserver
2019-03-13 17:11:05 -07:00
5d0bef342a
apiextensions: commit generated openapi definition
2019-03-13 15:15:34 -07:00
eb4865fbe5
Hack to ignore stale packages in godep
...
Change-Id: Ibf0877521310d6f2baad605bf1216940e95cb9cd
2019-03-12 09:49:03 -04:00
f71ac0fc5f
Merge pull request #75048 from dims/add-verify-check-for-publish-bot-dependencies
...
verify script to ensure publishing bot rules and godeps are in sync
2019-03-08 15:41:11 -08:00
9fd3d2718b
Merge pull request #75184 from liggitt/verify-godeps-generated
...
ignore uncommitted generated openapi files in verify-godeps
2019-03-08 14:19:47 -08:00
060e44ae85
ignore uncommitted generated openapi files in verify-godeps
2019-03-08 11:46:11 -05:00
f229aa0ad6
Merge pull request #75044 from errordeveloper/move-cli-runtime-subpackages
...
Move printers & resources packages
2019-03-08 05:43:26 -08:00
36783eb88b
kubeadm: remove v1alpha3
...
Remove deprecated old v1alpha3 kubeadm config.
Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
2019-03-08 14:54:51 +02:00
7d06bb8bc2
verify script to ensure publishing bot rules and godeps are in sync
...
Change-Id: Idbad862a797916cc4408ea0099c30d0557044907
2019-03-08 07:38:11 -05:00
fa0fd28767
Handle nil interface inputs to diff.ObjectReflectDiff
...
Causes a panic today. Add godoc bragging about how ridiculously awesome
ObjectReflectDiff is.
2019-03-08 00:15:50 -05:00
6d7a9048b6
Move printers & resources packages
...
These packages deserve to live at the top level of `k8s.io/cli-runtime`,
as they are potentially of wider use than genericclioptions.
2019-03-07 23:00:24 +00:00
820a1dc96b
Add node.k8s.io/v1beta1 API
2019-03-07 11:57:12 -08:00
63f61a6714
Migrate RuntimeClass to internal API
2019-03-07 11:07:54 -08:00
f8024ab087
Merge pull request #74904 from sttts/sttts-proto-tests
...
Rework proto generation scripts and add tests
2019-03-07 10:58:05 -08:00
ef5ba5cc8b
Merge pull request #75061 from andrewsykim/fix-mac-bazel
...
fix hack/update-bazel.sh for mac os environments
2019-03-07 01:07:52 -08:00
bd8eeaaaaf
Merge pull request #74468 from ixdy/bazel-cgo-crossbuild
...
bazel: improve multi-arch support for docker image artifacts
2019-03-06 20:35:11 -08:00
88a685feef
Merge pull request #74807 from runyontr/test-cmd-kubeadm-isolation
...
Kubeadm test Isolation: #74464
2019-03-06 17:59:52 -08:00
752d18d2b0
Merge pull request #74510 from SataQiu/fix-golint-2019022502
...
Fix some golint failures for pkg/kubelet/apis/...
2019-03-06 17:59:25 -08:00
a6c3a26c34
fix hack/update-bazel.sh for mac os environments
2019-03-06 15:47:25 -05:00
8495f7c9ed
bazel: add docker_push rules
2019-03-06 12:35:33 -08:00
611563c913
golint fix
2019-03-06 19:47:54 +08:00
a7346b60bc
Merge pull request #74970 from ipuustin/lib-util-sh-2
...
hack/lib/util.sh: fix empty array expansion with bash 3.
2019-03-06 02:08:33 -08:00
45b0d9bd0a
hack/*protobuf.sh: dynamically find api roots
2019-03-06 08:36:14 +01:00
9f7560de70
Merge pull request #74153 from ixdy/bazel-kubernetes-src-tarball-new
...
bazel: make kubernetes-src.tar.gz actually include all srcs
2019-03-05 21:42:00 -08:00
21239a350d
fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-06 13:26:39 +08:00
1fcab19821
Fix golint failures for e2e/[..]/kubemark
2019-03-05 20:55:00 +00:00
ecb6d13253
hack/lib/util.sh: fix empty array expansion with bash 3.
2019-03-05 21:34:08 +02:00
b4e692b68f
Merge pull request #74854 from neolit123/conformance-nodes
...
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
2019-03-05 09:50:12 -08:00
493f53433a
Merge pull request #74872 from nikopen/patch-2
...
cherry picks usage info link
2019-03-05 08:16:37 -08:00
298b8869cf
Merge pull request #74800 from danielqsj/mgo
...
fix golint failures for some files under metrics k8s.io/metrics/pkg/apis
2019-03-05 06:51:20 -08:00
e24e26fac8
Merge pull request #74647 from danielqsj/e2ein
...
Fix golint failures for e2e/instrumentation/...
2019-03-05 06:51:10 -08:00
890b5c1d9a
Merge pull request #74582 from SataQiu/fix-golint-2019022602
...
fix some golint failures for plugin/pkg/admission/...
2019-03-05 06:50:46 -08:00
6c31101257
Merge pull request #74283 from xing-yang/csi_crd_controller
...
CSINodeInfo and CSIDriver Controller Changes
2019-03-05 04:44:42 -08:00
baf4eb67ac
Merge pull request #74257 from ipuustin/lib-util-sh
...
Fix shellcheck-reported errors in hack/lib/util.sh.
2019-03-04 23:11:59 -08:00
e2f42845d1
Merge pull request #74487 from danielqsj/window
...
Fix golint failures for e2e/windows
2019-03-04 19:27:11 -08:00
fe2301f17d
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
...
- for ginkgo parallel mode pass -p to autodetect ginkgo nodes.
- disable parallel mode by default (false).
- use provider "skeleton" instead of "local".
- make run_e2e.sh pass shellcheck.
2019-03-05 01:32:57 +02:00
5cf1950ef8
Fix golint in test/e2e/instrumentation/logging
2019-03-05 07:10:39 +08:00
873fbf9112
Fix golint in test/e2e/instrumentation/monitoring
2019-03-05 07:07:06 +08:00
dddb13c690
Merge pull request #74711 from SataQiu/fix-golint-2019022802
...
Fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-03-04 13:25:38 -08:00
5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228
...
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-03-04 13:25:26 -08:00
f7e1058c98
shellcheck failures: remove hack/lib/util.sh
2019-03-04 23:23:20 +02:00
1e34d9df7d
hack/lib/util.sh: replace sed with bash replace.
...
Test script:
#!/bin/bash
rev1="foo"
rev2="\"bar\""
rev3="'bar'"
newrev1="${rev1//[\'\"]}"
newrev2="${rev2//[\'\"]}"
newrev3="${rev3//[\'\"]}"
oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")
echo "$newrev1 vs. $oldrev1"
echo "$newrev2 vs. $oldrev2"
echo "$newrev3 vs. $oldrev3"
expected output:
foo vs. foo
bar vs. bar
bar vs. bar
2019-03-04 23:23:20 +02:00
0078fce5bd
hack/lib/util.sh: don't implicitly convert "find" results into array.
...
Also fix array item comparison. Test script for the comparison change:
#!/bin/bash
staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)
for group_version in ${group_versions[@]}; do
# original code
if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
# new code
for api in ${staging_apis[@]}; do
if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
done
done
Expected output:
orig: vendor/k8s.io/api/extensions/v1beta1
new: vendor/k8s.io/api/extensions/v1beta1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
2019-03-04 23:23:20 +02:00
edd806330a
hack/lib/util.sh: mark variables to be used in a sourcing context.
...
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
2019-03-04 23:23:20 +02:00
24b5c67723
hack/lib/util.sh: various shellcheck-reported cleanups.
...
Use "command -v" instead of "which". Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.
However, one shellcheck error is ignored in trap mechanism. The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.
An alternative to ignoring could be tricking shellcheck with:
trap ''"${new_cmd}" "${trap_add_name}"
2019-03-04 23:18:54 +02:00
32f4bf6edf
cherry picks usage info link
2019-03-04 03:20:41 +00:00
bb45b8ee34
Make CSINodeInfo and CSIDriver Core APIs
...
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
2019-03-02 12:31:05 -08:00
dab1c54942
fix golint failures
2019-03-02 12:55:26 +08:00
222dd0af4c
Merge pull request #71022 from emwalker/68026-golint-fixes-5
...
Remove test/integration/* from hack/.golint_failures
2019-03-01 14:08:33 -08:00
8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502
...
fix shellcheck in test/e2e_node/jenkins/...
2019-03-01 12:49:08 -08:00
1e44e33517
pulled kubeadm tests out of runTests to run before tests in test/cmd
...
Added timeout for https://github.com/kubernetes/kubeadm/issues/1430
2019-03-01 12:17:25 -05:00
696c98a5e6
fix golint failures for metrics api
2019-03-01 17:36:20 +08:00
75df4dc04c
Remove test/integration/* from hack/.golint_failures
2019-02-28 19:52:39 -07:00
343bb4bd6b
Merge pull request #74561 from moshe010/start_kube_scheduler
...
Move start kubescheduler to it own function
2019-02-28 05:07:37 -08:00
02b8056efb
Merge pull request #73288 from wangzhen127/npd-config
...
Decouple node-problem-detector release from kubernetes
2019-02-28 00:27:25 -08:00
11451bbb59
fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-02-28 15:51:05 +08:00
cee02e62b7
Fix golint failures for e2e/windows
2019-02-28 15:48:48 +08:00
6af2e9afea
Merge pull request #74591 from xichengliudui/fixgolint190226
...
fix shellcheck in test/image/...
2019-02-27 20:39:25 -08:00
c0a0471b3b
fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-02-28 12:29:22 +08:00
d58ff3bfc0
Merge pull request #74176 from dims/containerized-kubelet-is-being-deprecated
...
Remove support for containerized-kubelet in local-up-cluster.sh
2019-02-27 14:40:06 -08:00
6df207bdaa
allows configuring NPD image version in node e2e test and fix the test
2019-02-26 21:29:50 -08:00
81e6407393
Merge pull request #74140 from Liujingfang1/kflag
...
add -k flag in cli-runtime and kubectl to process kustomization directories
2019-02-26 19:40:16 -08:00
5ebdf3e3f2
Merge pull request #74574 from SataQiu/fix-golint-20190226
...
fix some golint failures in pkg/registry/...
2019-02-26 18:12:19 -08:00
493b261057
Merge pull request #74586 from danielqsj/patch3
...
fix golint failures for test/e2e/cloud|kubectl|servicecatalog
2019-02-26 14:08:16 -08:00
26f90e850d
Merge pull request #74540 from oomichi/golint-e2e-framework-ingress
...
Fix golint under test/e2e/framework/ingress
2019-02-26 14:08:06 -08:00
0ecba229aa
Merge pull request #74512 from danielqsj/ui
...
fix golint failures for test/e2e/ui
2019-02-26 14:07:54 -08:00
ede5477697
Enable StorageObjectInUseProtection by default
...
StorageObjectInUseProtection plugin of admission controller adds
the flag `kubernetes.io/pvc-protection` or `kubernetes.io/pv-protection`
to newly created PVCs or PV. In case a user deletes a PVC or PV the PVC
or PV is not removed until the finalizer is removed from the PVC or PV
by PVC or PV Protection Controller.
We are testing this plugin on the e2e tests of "PV Protection" because
most setup scripts enable that like:
* cluster/centos/config-default.sh: Enabled
* cluster/gce/config-default.sh: Enabled
* cluster/gce/config-test.sh: Enabled
* cluster/kubemark/gce/config-default.sh: Enabled
* hack/local-up-cluster.sh: Enabled
* cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py: Disabled
As we are testing it normally, it is nice to enable the plugin by
default.
2019-02-26 18:08:44 +00:00
9e4c8950be
fix some golint failures in pkg/registry/...
2019-02-26 22:36:52 +08:00
8911a2ddbb
fix golint failures for test/e2e/kubectl
2019-02-26 18:27:01 +08:00
9ea1b3d86d
fix golint failures for test/e2e/servicecatalog
2019-02-26 18:25:23 +08:00
84aeafee7b
fix golint failures for test/e2e/cloud
2019-02-26 18:25:23 +08:00
f8c4aba0cb
fix some golint failures for plugin/pkg/admission/...
2019-02-26 17:12:40 +08:00
736baa5e33
Merge pull request #73593 from danielqsj/etcd
...
fix shellcheck failure in etcd shell
2019-02-25 23:11:50 -08:00
1ce7b0b2fa
fix golint failures for test/e2e/ui
2019-02-26 14:03:34 +08:00
4b38978329
fix shellcheck in test/e2e_node/jenkins/...
...
update pull request
2019-02-26 01:01:48 -05:00
ec5fddfe4f
fix shellcheck in hack/make-rules/...
...
update pull request
update pull request
update pull request
update pull request
update pull request
update pull request
update pull request
update pull request
2019-02-26 00:56:36 -05:00
33a0afafe7
Merge pull request #74508 from danielqsj/uapps
...
Fix golint failures for e2e/upgrades/...
2019-02-25 21:48:42 -08:00
c6ae694b79
fix some shellcheck failures in hack
2019-02-26 12:45:38 +08:00
5a2d587ac4
Merge pull request #74505 from SataQiu/fix-golint-20190225
...
fix golint failures for pkg/apis/...
2019-02-25 20:28:30 -08:00
272d78f1d9
Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server
...
Fix lint on pkg/kubelet/server/...
2019-02-25 20:27:48 -08:00
b9fb656546
Move start kubescheduler to it own function
...
Currently the kubescheduler starts in the start_kubeproxy
This change move it to ir own function start_kubescheduler
Change-Id: Iff93114d4becabe4b6b937c5077821e092abffd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-02-26 04:30:11 +02:00
1595089ec5
Merge pull request #74453 from xichengliudui/fixgolintfailures1902
...
fixgo lint failures test/integration/...
2019-02-25 17:25:34 -08:00
483d19ccc4
Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack
...
Fix shellcheck for more scripts in hack
2019-02-25 17:25:23 -08:00
0ff7e463ee
Merge pull request #73746 from mrbobbytables/kubemark-shellcheck
...
Fix shellcheck lint errors in Kubemark scripts
2019-02-25 17:25:13 -08:00
beacc87ebf
add cmdline tests for -k
2019-02-25 16:31:03 -08:00
392ad719eb
add comments
2019-02-25 15:34:09 -08:00
883b6cff0d
Generate a repos_generated.bzl file with all staging repos
...
Additionally, ensure that every staging repo has a BUILD file at its
root.
Also, remove a gazelle directive we no longer need.
2019-02-25 15:33:46 -08:00
3814176d42
Merge pull request #74455 from SataQiu/fix-shell-2019022302
...
Fix shellcheck lint errors in cluster and hack scripts
2019-02-25 15:15:19 -08:00
a778f409ba
Merge pull request #74385 from SataQiu/fix-shell-20190222
...
Fix some shellcheck failures in hack
2019-02-25 13:54:32 -08:00
0813567660
Merge pull request #74349 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-in-hack
...
Fix shellcheck for hack/verify-generated-*
2019-02-25 13:54:10 -08:00
215dee7dd2
Fix golint under test/e2e/framework/ingress
2019-02-25 20:55:03 +00:00
e137f4702a
Fix shellcheck lint errors in test/kubemark/stop-kubemark.sh
2019-02-25 15:21:32 -05:00
b8aae458a1
Fix shellcheck lint errors in test/kubemark/start-kubemark.sh
2019-02-25 15:21:31 -05:00
46333a01b4
Fix shellcheck lint errors in test/kubemark/run-e2e-tests.sh
2019-02-25 15:21:31 -05:00
adf4bf1741
Fix shellcheck lint errors in test/kubemark/resources/start-kubemark-master.sh
2019-02-25 15:21:31 -05:00
f72ac1f5b7
Fix shellcheck lint errors in test/kubemark/master-log-dump.sh
2019-02-25 15:21:31 -05:00
cb59cb33ff
Fix shellcheck lint errors in test/kubemark/iks/util.sh
2019-02-25 15:21:30 -05:00
e3e2a96521
Fix shellcheck lint errors in test/kubemark/iks/startup.sh
2019-02-25 15:21:30 -05:00
6310305d3b
Fix shellcheck lint errors in test/kubemark/iks/shutdown.sh
2019-02-25 15:21:30 -05:00
186b83fe5b
Fix shellcheck lint errors in test/kubemark/gce/util.sh
2019-02-25 15:21:30 -05:00
5f4b919887
Fix shellcheck lint errors in test/kubemark/common/util.sh
2019-02-25 15:21:29 -05:00
9a4f4878f5
Fix shellcheck lint errors in cluster/kubemark/util.sh
2019-02-25 15:21:29 -05:00
9a58913e8f
Fix shellcheck lint errors in cluster/kubemark/iks/config-default.sh
2019-02-25 15:21:25 -05:00
ce4c85e3fd
Fix shellcheck lint errors in cluster/kubemark/gce/config-default.sh
2019-02-25 14:55:01 -05:00
35a258d640
Merge pull request #73272 from danielqsj/juju
...
fix shellcheck in cluster/juju
2019-02-25 11:33:21 -08:00
f288678cfa
Merge pull request #73261 from danielqsj/local
...
fix shellcheck in cluster/local
2019-02-25 11:33:11 -08:00
5d13f6f776
Remove support for containerized-kubelet in local-up-cluster.sh
...
Change-Id: I3435b02fbe052a88f6b88d5517de2d68ff636a66
2019-02-25 08:53:14 -05:00
09ba08f8f4
fix some golint failures for pkg/apis/...
2019-02-25 18:06:08 +08:00
7181c44230
fix some golint failures for pkg/cloudprovider/providers/vsphere/vclib and pkg/kubelet/apis/...
2019-02-25 18:01:41 +08:00
6322025d5c
fix golint failures for test/e2e/upgrades
2019-02-25 16:36:26 +08:00
7c8498ab03
fix golint failures for test/e2e/upgrades/storage
2019-02-25 15:41:31 +08:00
8916ccabaf
fix golint failures for test/e2e/upgrades/apps
2019-02-25 13:32:15 +08:00
b4d086f914
Fix shellcheck for hack/verify-generated-*
...
All of the `hack/verify-generated-*` files now pass shellcheck and are
removed from `hack/.shellcheck_failures`.
2019-02-24 23:50:59 -05:00
57c51c741d
Fix shellcheck for more scripts in hack
...
Making more of the scripts in hack pass the shellcheck linter.
2019-02-24 23:48:21 -05:00
d357bcd2cd
fix some shellcheck failures in hack
2019-02-25 11:38:56 +08:00
7e655e8666
fix shellcheck in cluster/juju
2019-02-24 20:40:59 +08:00
e698682a0e
change a way to pass SC2164 in etcd.sh
2019-02-24 20:26:59 +08:00
c215966d22
fix shellcheck failure in etcd shell
2019-02-24 20:19:50 +08:00
9cda80e836
fix shellcheck lint errors in cluster and hack scripts
2019-02-24 11:15:35 +08:00
139a13d312
Merge pull request #74269 from moshe010/kubelet_gen_cert
...
Move kubelet cert generation when starting kubelet
2019-02-23 18:41:10 -08:00
1cf8001e53
Merge pull request #74449 from xichengliudui/fix190223
...
make more of the shell pass lints
2019-02-23 12:52:34 -08:00
6a29f8ca5f
Merge pull request #74451 from xichengliudui/fixshellcheckout190223
...
fix shellcheck in hack/...
2019-02-23 10:23:15 -08:00
0133d14170
Merge pull request #72939 from runyontr/test-cmd-what
...
Test cmd what
2019-02-23 02:54:36 -08:00
8993fbc543
Merge pull request #74328 from daixiang0/delete-blank
...
delete all duplicate empty blanks
2019-02-23 01:43:58 -08:00
795ae35201
Merge pull request #74318 from cblecker/fix-swagger
...
Fix verify-generated-swagger-docs script
2019-02-23 01:43:48 -08:00
36065c6dd7
delete all duplicate empty blanks
...
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
743f864310
Merge pull request #73819 from coffeepac/move-fluentd-es-images
...
Move fluentd es images
2019-02-22 17:58:12 -08:00
e2b74ad91d
Merge pull request #73864 from oomichi/cleanup-array_contains
...
Use kube::util::array_contains() in hack
2019-02-22 16:15:10 -08:00
3afa003126
Merge pull request #73555 from bsalamat/priority_to_ga
...
Graduate PriorityClass API to GA
2019-02-22 16:14:49 -08:00
453498fe2c
Graduate PriorityClass to GA
2019-02-22 10:51:13 -08:00
1bd45ba6eb
review updates
2019-02-22 10:00:10 -08:00
998147de59
fix shellcheck in pkg/kubectl/cmd/edit/testdata/record_testcase.sh
2019-02-22 15:10:38 +08:00
0e78dd2d17
fix shellcheck in pkg/util/verify-util-pkg.sh
2019-02-22 15:10:16 +08:00
5733241f7a
fix shellcheck in plugin/pkg/admission/imagepolicy/gencerts.sh
2019-02-22 15:10:06 +08:00
651faf2e0d
Merge pull request #74250 from SataQiu/fix-golint-20190219
...
Fix golint failures on pkg/kubectl/cmd/completion, pkg/kubectl/cmd/cp, pkg/kubectl/cmd/edit
2019-02-21 22:17:36 -08:00
125dc6c8ea
Merge pull request #74187 from xichengliudui/fixgolint0218
...
Fix shellcheck lint errors in cluster/addons/fluentd-elasticsearch/fl……uentd-es-image/run.sh
2019-02-21 20:51:13 -08:00
4f4695fefe
Merge pull request #73214 from danielqsj/metrics
...
fix shellcheck in k8s.io/metrics
2019-02-21 19:16:31 -08:00
4763720dc1
Merge pull request #74338 from BenTheElder/testcmdshellcheck
...
make test/cmd/delete.sh pass shellcheck
2019-02-21 12:26:57 -08:00
f97170ea38
Merge remote-tracking branch 'upstream/master' into test-cmd-what
2019-02-21 11:35:23 -05:00
e61cd68bf3
Fix lint on pkg/kubelet/server/...
2019-02-21 10:31:41 -05:00
59beb8c36b
Merge pull request #74299 from SataQiu/fix-shell-20190220
...
Fix some shellcheck failures in hack
2019-02-21 02:20:05 -08:00
7d75b73e1d
Merge pull request #74057 from liggitt/ingress-network-v1beta1
...
Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1
2019-02-21 01:07:48 -08:00
da859ae734
make test/cmd/delete.sh pass shellcheck
2019-02-21 00:45:37 -08:00
a499d81fc6
fix shellcheck in test/image/...
...
update pull request
2019-02-21 03:11:55 -05:00
e24e944ce1
Merge pull request #74312 from oomichi/golint-e2e-framework-aws
...
Fix golint failures on e2e/[..]/(aws|azure)
2019-02-20 23:56:36 -08:00
b3b9658954
Merge pull request #74286 from xichengliudui/fixshellcheck190220
...
Fix shellcheck lint errors in ./hack/...
2019-02-20 23:56:15 -08:00
053332ad46
Fix shellcheck lint errors in cluster/addons/fluentd-elasticsearch/fluentd-es-image/run.sh
...
update pull request
update pull request
update pull request
update pull request
update pull request
2019-02-21 02:00:48 -05:00
6c1f2077e5
Merge pull request #74192 from xichengliudui/fixshellcheck190218
...
make more of the shell pass lints
2019-02-20 21:41:25 -08:00
61b676aae1
Merge pull request #73094 from oomichi/fix-golint-negociate
...
Fix golint failures on handlers/negotiation
2019-02-20 15:20:48 -08:00
1f5dff7e53
Fix verify-generated-swagger-docs script
2019-02-20 14:37:46 -08:00
8c28d3f63c
Add networking.k8s.io/v1beta1 Ingress
2019-02-20 16:41:14 -05:00
47cb9559be
Move internal Ingress type from extensions to networking
2019-02-20 16:41:12 -05:00
d60b7d6a64
Merge pull request #73866 from apelisse/add-ssa-tests
...
Add basic server-side apply test to test-cmd
2019-02-20 11:33:02 -08:00
36b80a4c61
Fix golint failures on e2e/[..]/(aws|azure)
2019-02-20 19:11:53 +00:00
302ec98591
Fix golint failures on handlers/negotiation
...
DefaultEndpointRestrictions is only used in the module,
so this renames it to defaultEndpointRestrictions.
2019-02-20 18:00:25 +00:00
0311c4ddc8
fix some shellcheck failures in hack
2019-02-20 20:37:51 +08:00
b96342ab92
Merge pull request #72487 from dims/add-minimal-audit-policy-to-local-up-cluster
...
Add minimal audit policy to local-up-cluster
2019-02-19 23:20:30 -08:00
9f6928c259
Fix shellcheck lint errors in ./hack/...
2019-02-20 01:31:58 -05:00
155caa14f6
Merge pull request #74259 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-lint-failures
...
Fix shellcheck errors for some scripts in hack/
2019-02-19 21:41:27 -08:00
f5989303b7
Merge pull request #74060 from SataQiu/fix-shellcheck-20190214
...
Fix shellcheck failures on kube-down.sh kubeadm.sh get-build.sh
2019-02-19 21:41:17 -08:00
5cc52ce5d3
Merge pull request #74230 from xichengliudui/fixshellcheck19021902
...
fix eliminate shellcheck failures in /hack/e2e-internal/...
2019-02-19 19:58:00 -08:00
9e55995a31
Merge pull request #73989 from oomichi/golint-e2e-framework-metrics
...
Fix golint failures under test/e2e/framework/metrics
2019-02-19 16:23:48 -08:00
33a81a7882
Move kubelet cert generation when starting kubelet
...
Running local-up-cluster with START_MODE='kubeletonly'
requires cert and kubeconfig. Currently, all the
certs and the kubeconfig are created in the start_apiserver
so it won't be created when only kubelet is started.
This change moves the creation of the kubelet cert and
kubeconfig to start_kubelet. This is helpful if you
want to run kubelet with local-up-cluster and to connect
to an existing master node.
Change-Id: Iaba0bf975297346fbede44342f163024caa256cf
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-02-19 23:04:18 +02:00
ee50d4784d
Merge pull request #74193 from xichengliudui/fixshellcheck19021802
...
fix shellcheck in test/integration/... and test/kubemark/...
2019-02-19 09:56:07 -08:00
7fb16d9a8d
Merge pull request #74045 from xichengliudui/fixgolint
...
Fix golint failures on cmd/apis/extensions/...
2019-02-19 09:55:44 -08:00
214b910511
Fix shellcheck errors for some scripts in hack/
...
Five more of the hack/verify-* scripts now pass shellcheck and have been
removed from hack/.shellcheck_failures.
2019-02-19 10:08:15 -05:00
d61e878533
Merge pull request #73997 from xichengliudui/fixlintcode
...
Fix golint failures
2019-02-19 01:44:48 -08:00
0b184d35a1
fixgo lint failures test/integration/...
...
update pull request
update pull request
add files
update pull request
2019-02-19 04:41:50 -05:00
e2c1f43551
fix golint failures on pkg/kubectl/cmd/completion pkg/kubectl/cmd/cp pkg/kubectl/cmd/edit
2019-02-19 17:39:39 +08:00
dd7acdcd55
make more of the shell pass lints
2019-02-18 22:50:03 -05:00
783aa61979
fix shellcheck in hack/
2019-02-18 19:11:21 -05:00
b83b83f8e3
aaa
2019-02-18 17:50:55 -05:00
6b6bfb37fb
Add minimal audit policy to local-up-cluster
...
Change-Id: Ia2cdb5a6a891665ece5365698f2989ba3782a5ec
2019-02-18 11:18:34 -05:00
92e0c231fa
Merge pull request #74107 from truongnh1992/adding-shebang
...
Adding '/usr/bin/env bash'
2019-02-18 00:23:35 -08:00
641f883b82
fix shellcheck in test/integration/... and test/kubemark/...
2019-02-18 01:16:39 -05:00
d065dd28cd
fix shellcheck in k8s.io/metrics
2019-02-18 13:54:11 +08:00
fd044c5770
make more of the shell pass lints
2019-02-18 00:42:46 -05:00
16e08f3e53
Merge pull request #73408 from Klaven/component-base-flags
...
Move flag util pkgs to k8s.io/component-base/cli
2019-02-15 16:46:08 -08:00
fbee96d733
Merge pull request #73699 from pivotal-k8s/doc-links
...
Update deprecated and broken links
2019-02-15 14:05:09 -08:00
256106e5d1
Merge pull request #74053 from SataQiu/fix-golint-20190214
...
Fix golint failures on cmd/kubeadm/app/util/config
2019-02-15 12:43:45 -08:00
2e04569530
updated golint_failures to match new project structure.
2019-02-15 10:29:13 -05:00
aeaeba4a6e
Merge pull request #72772 from lubinsz/pr_etcd
...
Bug fix: ./hack/install-etcd.sh is not work on Arm64 platform
2019-02-15 06:40:02 -08:00
c0775786a4
Merge pull request #69250 from warmchang/lint-pkg/routes
...
fix golint errors in pkg/routes
2019-02-15 06:39:29 -08:00
34ac4d9ee9
Update deprecated links
2019-02-15 09:13:07 -05:00
bf20886f4e
Merge pull request #73990 from xichengliudui/fixlinterror
...
Fix golint failures pkg/kubelet/util/cache
2019-02-14 22:43:15 -08:00
848da13359
Adding '/usr/bin/env bash'
...
This commit aims to add '/usr/bin/env bash' as a shebang line
to indicates scripts use bash shell for interpreting.
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-14 19:18:49 -08:00
78e272a927
fix shellcheck failures on kube-down.sh kubeadm.sh get-build.sh
2019-02-14 15:12:08 +08:00
19c7f4cb0b
fix golint failures on cmd/kubeadm/app/util/config
2019-02-14 12:11:24 +08:00
03320c1436
Merge pull request #73985 from BenTheElder/manual-vendor
...
mark vendor build targets manual
2019-02-13 16:12:02 -08:00
89f6f1d0cc
Fix golint failures under e2e/framework/metrics
2019-02-13 18:07:16 +00:00
a957c83181
fix golint failures on cmd/kubeadm/app
2019-02-13 12:02:28 +08:00
cb68f3edf9
autotag vendor as manual in update-bazel
2019-02-12 18:38:36 -08:00
5c780c8cb1
Merge pull request #73978 from oomichi/golint-e2e-framework-timer
...
Fix golint failures of test/e2e/framework/timer
2019-02-12 17:29:43 -08:00
e4a8ffc9b5
Merge pull request #73218 from danielqsj/kube-aggregator
...
fix shellcheck in kube-aggregator
2019-02-12 17:28:54 -08:00
d49953e8d0
add buildozer to deps
2019-02-12 15:04:58 -08:00
60ded1d54a
Fix golint failures of test/e2e/framework/timer
2019-02-12 21:01:39 +00:00
4c42d542dc
Fix golint failures
...
update pull request
update pull request
2019-02-12 13:01:49 -05:00
a89ee493dd
Fix golint failures on cmd/apis/extensions/...
2019-02-12 12:39:48 -05:00
df7c54fbe4
Merge pull request #73690 from ipuustin/verify-generated-files-remake-2
...
verify-generated-files-remake.sh: fix issues reported by shellcheck (part 2)
2019-02-12 06:40:50 -08:00
5aa58efe07
Fix golint failures
...
update pull request
2019-02-12 07:14:57 -05:00
a1539747db
Merge pull request #73926 from alculquicondor/fix/kubelet-app-lint
...
Fix cmd/kubelet/app lint issues
2019-02-12 00:19:06 -08:00
0ae81c986a
Merge pull request #67678 from caesarxuchao/remove-storage-versions-flag
...
Remove storage versions flag
2019-02-11 17:40:27 -08:00
805a9e7036
Fixes Golint Errors: staging/src/k8s.io/kube-aggregator ( #73369 )
...
* fixed golint errors in staging/src/k8s.io/kube-aggregator
* update openapi
* unexported autoRegisterController
2019-02-11 14:16:05 -08:00
6912bbb153
Merge pull request #71223 from sttts/sttts-openapi-aggreation-without-clone
...
openapi-aggregation: speed up merging from 1 sec to 50-100 ms
2019-02-11 10:30:56 -08:00
17a635448a
Fix cmd/kubelet/app lint issues
2019-02-11 13:18:25 -05:00
2393799e2e
hack/update-openapi-spec.sh: normalize indention of spec through jq
2019-02-11 13:16:36 +01:00
342dc93187
fix shellcheck in kube-aggregator
2019-02-11 10:30:34 +08:00
e47973bd31
Merge pull request #69086 from bruceauyeung/log-useful-info-instead-of-silent-exit-when-etcd-already-installed
...
log useful information instead of silent exit without error
2019-02-10 18:14:26 -08:00
f1cb820b16
Remove verify-generated-files-remake.sh from shellcheck failures.
2019-02-09 22:41:53 +02:00
b06533af65
verify-generated-files-remake: quote return value.
...
Fix a shellcheck error by quoting a return value properly.
2019-02-09 22:41:53 +02:00
c23c83724c
verify-generated-files-remake.sh: use strings instead of arrays.
...
Move away from arrays to strings to fix several shellcheck-reported
issues. It isn't useful to expand the found files into arrays, because
only things that are checked are if the array is empty or the contents
of the first array item.
Fix also a shellcheck issue about using a literal string as regexp
match. It appears that the original reason for using a regexp was to
avoid specifying the directory in which the script is run. However, due
to the need of calling 'make generated_files', the directory is fixed
anyway, and the regexp can be left out.
Testing the change can be done with the following script which emulates
the different cases which the script can see. In the output the variable
'X' is the array and 'Z' is the string.
#!/bin/bash
set -o errexit
set -o nounset
set -o pipefail
function find_genfiles() {
find . \
\( \
-not \( \
\( \
-path ./_\* -o \
-path ./.\* \
\) -prune \
\) \
\) -name "$1"
}
# $1 = filename pattern as in "zz_generated.$1.go"
# $2 timestamp file
function newer() {
find_genfiles "$1" | while read -r F; do
if [[ "${F}" -nt "$2" ]]; then
echo "${F}"
fi
done
}
STAMP=stamp
mkdir -p xxx
touch xxx/foobar
touch "${STAMP}"
mkdir -p foo
touch foo/foobar
mkdir -p bar
touch bar/foobar
# two newer files
X=($(newer foobar "${STAMP}"))
if [[ "${#X[*]}" != 0 ]]; then
echo "X1:"
echo " ${X[*]:-(none)}"
fi
Z="$(newer foobar "${STAMP}")"
if [[ -n "$Z" ]]; then
echo "Z1:"
echo " ${Z}" | tr '\n' ' '
echo ""
fi
# no newer files
touch "${STAMP}"
X=($(newer foobar "${STAMP}"))
if [[ "${#X[*]}" != 0 ]]; then
echo "X2:"
echo " ${X[*]:-(none)}"
fi
Z="$(newer foobar "${STAMP}")"
if [[ -n "$Z" ]]; then
echo "Z2:"
echo " ${Z}" | tr '\n' ' '
echo ""
fi
# one newer file, name matches
touch "${STAMP}"
touch bar/foobar
X=($(newer foobar "${STAMP}"))
if [[ "${#X[@]}" != 1 || ! ( "${X[0]}" =~ "bar/foobar" ) ]]; then
echo "X3:"
echo " ${X[*]:-(none)}"
fi
Z="$(newer foobar "${STAMP}")"
if [[ -z "${Z}" || ${Z} != "./bar/foobar" ]]; then
echo "Z3:"
echo " ${Z:-(none)}" | tr '\n' ' '
echo ""
fi
# one newer file, name doesn't match
touch "${STAMP}"
touch foo/foobar
X=($(newer foobar "${STAMP}"))
if [[ "${#X[@]}" != 1 || ! ( "${X[0]}" =~ "bar/foobar" ) ]]; then
echo "X4:"
echo " ${X[*]:-(none)}"
fi
Z="$(newer foobar "${STAMP}")"
if [[ -z "${Z}" || ${Z} != "./bar/foobar" ]]; then
echo "Z4:"
echo " ${Z:-(none)}" | tr '\n' ' '
echo ""
fi
The expected output from running this script:
X1:
./bar/foobar ./foo/foobar
Z1:
./bar/foobar ./foo/foobar
X4:
./foo/foobar
Z4:
./foo/foobar
2019-02-09 22:32:31 +02:00
fefdfc2ad7
verify-generated-files-remake.sh: fix BASH_SOURCE array.
2019-02-09 22:32:31 +02:00
40a4c1f723
Merge pull request #73854 from RajatVaryani/master
...
Fix linting in cmd/kubemark package
2019-02-08 22:00:24 -08:00
308c981633
Add basic server-side apply test to test-cmd
2019-02-08 16:51:29 -08:00
4a91b593ba
Use kube::util::array_contains() in hack
...
The common kube::util::array_contains() is already there, so this
makes both scripts use it.
2019-02-08 23:13:48 +00:00
2a664f4820
Merge pull request #73213 from danielqsj/nodeapi
...
fix shellcheck in node-api
2019-02-08 13:14:25 -08:00
947afbddb8
test to try and silence spurious spelling warnings
2019-02-08 11:51:31 -08:00
b50c643be0
Merge pull request #73540 from rlenferink/patch-5
...
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
17fd66946b
Fix linting in cmd/kubemark package
2019-02-08 21:30:34 +05:30
30397a3d23
Merge pull request #73219 from danielqsj/csi-api
...
fix shellcheck in csi-api
2019-02-08 06:53:52 -08:00
999e2e0ce8
Merge pull request #73581 from krzysied/test_KUBE_JUNIT_REPORT_DIR_revert
...
KUBE_JUNIT_REPORT_DIR fixes
2019-02-08 02:39:14 -08:00
92db54cc53
Merge pull request #73335 from oomichi/cleanup-hack
...
Add check-file-in-alphabetical-order for cleanup
2019-02-07 18:24:41 -08:00
22b74dc67b
Merge pull request #73768 from mattjmcnaughton/mattjmcnaughton/support-what-subdirs-for-test
...
Support make test WHAT=path/to/pkg/...
2019-02-07 09:10:17 -08:00
SataQiu