github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
77,674 Commits
32 Branches
881 Tags
633 MiB
Commit Graph

7511 Commits (0d77f62c02cbf2e88547cd3d114e948a1fdb3371)

Author SHA1 Message Date
Mehdy Bohlool 8702550beb Support service port other than 443 for kube-aggregator 2019-04-08 00:19:57 -07:00
Kubernetes Prow Robot f873d2a056
Merge pull request #75862 from xichengliudui/fixshellcheckfailures 
Fix shellcheck failures in bootstrap.sh and create_block.sh
 2019-04-07 21:52:24 -07:00
Christoph Blecker 2363136f2c
Remove has_changes logic from vendor scripts 2019-04-07 12:11:18 -07:00
Christoph Blecker 668a288595
Remove unneeded scripts 2019-04-07 12:08:41 -07:00
Kubernetes Prow Robot 06655abd87
Merge pull request #76168 from caesarxuchao/local-up-followup 
Follow up of https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758
 2019-04-05 07:43:44 -07:00
Kubernetes Prow Robot 5756bfbf8d
Merge pull request #76180 from nikhita/verify-publishing-bot-deps 
Show all missing deps when publishing-bot rules has no listed dependencies
 2019-04-05 06:27:19 -07:00
Kubernetes Prow Robot 0c32c22b2e
Merge pull request #75546 from fabriziopandini/e2e-kubeadm-first-class 
Implement make test-e2e-kubeadm
 2019-04-05 04:59:19 -07:00
Nikhita Raghunath d474631e38 Show all missing deps when publishing-bot has no listed dependencies 
Before this, it only showed one dependency in the error message.

Also, replace godeps.json with go.mod in the error message.
 2019-04-05 13:08:12 +05:30
Kubernetes Prow Robot 54ba23eec6
Merge pull request #76169 from BenTheElder/hack-the-planet 
add bentheelder to hack/ approvers
 2019-04-04 23:53:54 -07:00
Kubernetes Prow Robot 470bda42c3
Merge pull request #76153 from liggitt/update-vendor-cleanup 
Update vendor cleanup
 2019-04-04 23:53:42 -07:00
Kubernetes Prow Robot 87247f5357
Merge pull request #75915 from xichengliudui/fixshellcheckfailures-05 
fix shellcheck failures in ./hack/jenkins/...
 2019-04-04 22:31:19 -07:00
Benjamin Elder d3c405c7c3 add bentheelder to hack/ approvers 2019-04-04 15:23:52 -07:00
Chao Xu ce0cd866c0 followup https://github.com/kubernetes/kubernetes/pull/76050#discussion_r271540758 2019-04-04 14:38:26 -07:00
Jordan Liggitt 86f29e210b Clean up generated file warnings, add recursive dependency detection 2019-04-04 12:06:45 -04:00
Jordan Liggitt 892ad8b449 Make pin-dependency.sh work with things other than docker 2019-04-04 09:20:55 -04:00
Jordan Liggitt 2ea3cbdcbc Update hack scripts to use go mod 2019-04-03 10:19:39 -04:00
Jordan Liggitt 7f246d461b Remove third_party/forked/godep 2019-04-03 10:19:39 -04:00
SataQiu b732a53c6b fix shellcheck failures of test/images/pets/redis-installer/on-start.sh 2019-04-03 21:55:05 +08:00
Jordan Liggitt 8ead4b059f Add kubernetes/kubernetes tools.go imports 2019-04-03 09:15:39 -04:00
Kubernetes Prow Robot 658c290ed5
Merge pull request #76063 from Huang-Wei/option-clean-stdout 
give users option to suppress detailed output in integration test
 2019-04-03 03:24:19 -07:00
Kubernetes Prow Robot 42877480ad
Merge pull request #75747 from msau42/remove-alpha-crd 
Remove alpha csi CRD
 2019-04-02 22:47:41 -07:00
Kubernetes Prow Robot 28ac3063da
Merge pull request #76050 from caesarxuchao/fix-local-up-cluster 
Fix kubelet start in local-up-cluster.sh
 2019-04-02 20:11:42 -07:00
Wei Huang 66a3094419
give users option to suppress detailed output in integration test 2019-04-02 17:27:32 -07:00
Kubernetes Prow Robot b274fb3570
Merge pull request #75984 from umohnani8/e2e 
Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh
 2019-04-02 15:45:20 -07:00
Chao Xu 1b953aaa59 Fix kubelet start in local-up-cluster.sh 2019-04-02 12:59:32 -07:00
Michelle Au d2aa8178f2 Remove alpha CRD install 2019-04-02 10:59:11 -07:00
Kubernetes Prow Robot aa52140928
Merge pull request #75346 from seans3/version-fix 
kubectl: removes pkg/version dependency
 2019-04-02 10:19:18 -07:00
Urvashi Mohnani 8b96021c67 Add RUNTIME_REQUEST_TIMEOUT to local-up-cluster.sh 
The changes to local-cluster-up.sh from #75662 is causing the
CRI-O CI to break since it picks up the --runtime-request-timeout
flag as part of the container-runtime-endpoint flag.
Adding a new env so that we can set the runtime-request-timeout
value for our CI.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
 2019-04-02 11:25:55 -04:00
Kubernetes Prow Robot d7d852a3ed
Merge pull request #75994 from mrunalp/fix_unbound_args_array 
Fix older bash failing on unbound array variables
 2019-04-02 08:22:48 -07:00
Mrunal Patel 8c9b169f17 Fix older bash failing on unbound array variables 
Older bash versions fail when trying to expand array variables
when the array is empty.

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
 2019-04-01 21:04:48 -07:00
Benjamin Elder 2b7cc095cc enable external sources in verify-shellcheck 2019-04-01 11:03:37 -07:00
Kubernetes Prow Robot 997d5182d0
Merge pull request #75662 from s-ito-ts/shellcheck_local-up-cluster.sh 
fix shellcheck failures in hack/local-up-cluster.sh
 2019-03-31 18:24:32 -07:00
Kubernetes Prow Robot 72418519ff
Merge pull request #75865 from xichengliudui/fixshellcheckfailure-03 
Fix shellcheck failures in godep-save.sh and godep-restore.sh
 2019-03-30 15:57:08 -07:00
Kubernetes Prow Robot 66dad3bb09
Merge pull request #75868 from xichengliudui/patch-4 
Add @xichengliudui to hack/OWNERS reviewers
 2019-03-29 23:53:21 -07:00
Kubernetes Prow Robot c7a8596a39
Merge pull request #75867 from SataQiu/fix-kubeadm-golint-20190329 
Fix golint failures in cmd/kubeadm/app/util/system
 2019-03-29 17:33:57 -07:00
Kubernetes Prow Robot 259f706c73
Merge pull request #75834 from jlucktay/golint_pkg/auth/authorizer/abac 
Golint pkg/auth/authorizer/abac
 2019-03-29 11:48:50 -07:00
Kubernetes Prow Robot 733f2478d3
Merge pull request #75584 from SataQiu/fix-golint-20190322 
fix some golint failures in pkg/apis
 2019-03-29 10:28:40 -07:00
James Lucktaylor dbb696508a Enact golint recommendations per issue 68026. 
Remove the 'abac' package from the golint exclusion list.
Add/edit comments per golint feedback.
Set PolicyList to be exported, as not exporting was breaking one of
golint's rules around exported funcs returning an unexported type.
Fix a broken test
 2019-03-29 12:50:31 +00:00
lIuDuI 6f970d3d70
Update OWNERS 2019-03-29 12:15:39 +08:00
SataQiu a41c85ea07 fix golint failures in cmd/kubeadm/app/util/system 2019-03-29 12:03:25 +08:00
Sean Sullivan d4d6e19f1e kubectl: removes pkg/version dependency 2019-03-28 16:08:34 -07:00
fabriziopandini 2cb2a979d4 e2e-kubeadm-first-class 2019-03-28 16:29:56 +01:00
Kubernetes Prow Robot f6c51d6e99
Merge pull request #75751 from BenTheElder/bash-fun 
fix kube::golang::is_instrumented_package
 2019-03-26 23:19:01 -07:00
Kubernetes Prow Robot 29353452c4
Merge pull request #75668 from bart0sh/PR0068-hack-lib-golang.sh-fix-mac-build 
fix 'make generated_files' build on MacOS
 2019-03-26 20:45:01 -07:00
Kubernetes Prow Robot d24fe8a801
Merge pull request #75735 from andrewsykim/update-install-etcd-link 
fix link to etcd install docs for integration tests
 2019-03-26 18:11:29 -07:00
Kubernetes Prow Robot 4b3eb60081
Merge pull request #75531 from dims/add-new-staging-repository-for-cri-api 
New staging repository for cri-api
 2019-03-26 18:10:49 -07:00
Benjamin Elder 0833a9cc38 fix kube::golang::is_instrumented_package 2019-03-26 17:17:16 -07:00
Davanum Srinivas 33081c1f07
New staging repository for cri-api 
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb
 2019-03-26 18:21:04 -04:00
Kubernetes Prow Robot 2086f81546
Merge pull request #74678 from pmcalpine/lint-bs_cj 
Fix some golint failures for pkg/controller
 2019-03-26 15:10:16 -07:00
Andrew Sy Kim e26157df07 fix link to etcd install docs 2019-03-26 13:40:18 -04:00
SataQiu b1cb58fdf2 fix golint failures in test/e2e_node/builder 2019-03-26 14:12:45 +08:00
Ed Bartosh 3d5d38607d fix 'make generated_files' build on MacOS 
Recent change to hack/lib/golang.sh broke the build on MacOS this way:

$ make clean && make generated_files
+++ [0325 13:38:22] Verifying Prerequisites....
+++ [0325 13:38:23] Removing _output directory
k8s.io/kubernetes/vendor/github.com/spf13/pflag
k8s.io/kubernetes/hack/make-rules/helpers/go2make
+++ [0325 13:38:40] Building go targets for darwin/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
can't load package: package k8s.io/kubernetes: no Go files in k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes
!!! [0325 13:38:40] Call tree:
!!! [0325 13:38:40]  1: k8s.io/kubernetes/hack/lib/golang.sh:629 kube::golang::build_some_binaries(...)
!!! [0325 13:38:40]  2: k8s.io/kubernetes/hack/lib/golang.sh:764 kube::golang::build_binaries_for_platform(...)
!!! [0325 13:38:40]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [_output/bin/deepcopy-gen] Error 1
make: *** [generated_files] Error 2

It was caused by 'binaries' array not being declared with 'local -a'.
It looks like MacOS' old bash version makes an array to contain first
empty element if declared this way.

The fix has been tested on MacOS High Sierra and Linux openSUSE 42.3 (x86_64)

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
 2019-03-25 17:08:13 +01:00
s-ito-ts 8cc3718e69 fix eliminate shellcheck failures in hack/local-up-cluster.sh 2019-03-25 07:17:06 +00:00
SataQiu f82fb4059d fix some failures in pkg/apis 2019-03-23 12:20:49 +08:00
Kubernetes Prow Robot 9c53f24012
Merge pull request #75179 from rosti/kill-v1alpha3 
kubeadm: remove v1alpha3
 2019-03-22 17:02:21 -07:00
Kubernetes Prow Robot ffd8f3dacb
Merge pull request #73255 from ds-ms/golint 
Fix linting issues in pkg/kubectl/cmd/version
 2019-03-22 17:02:08 -07:00
Kubernetes Prow Robot a3bc56fffb
Merge pull request #74746 from oomichi/golint-e2e-framework-gce 
Fix golint failures under test/e2e/[..]/gce
 2019-03-22 15:46:08 -07:00
Kenichi Omichi 3d64667507 Add check-conformance-test-requirements.go 
We have defined requirements of conformance test as [1], and this
adds coding check for one requirement "it works for all providers".

[1]: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md#conformance-test-requirements
 2019-03-22 21:56:07 +00:00
Kubernetes Prow Robot fcb102b2a4
Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh 
fix eliminate shellcheck failures in hack/lib/golang.sh
 2019-03-22 14:09:37 -07:00
Kenichi Omichi da7c9f70c3 Fix golint failures under test/e2e/[..]/gce 
This fixes golint failures under test/e2e/framework/providers/gce/.

Cleanup:
* FirewallTimeoutDefault is not used at all, so remove it.
* FirewallTestTcpTimeout, FirewallTestHttpPort and FirewallTestUdpPort
  are used at test/e2e/network/firewall.go only. So move them.
 2019-03-22 15:59:17 +00:00
Kubernetes Prow Robot 22621ca415
Merge pull request #74739 from moshe010/nokubeproxy 
Add nokubeproxy option in START_MODE
 2019-03-21 22:50:44 -07:00
Kubernetes Prow Robot 51b5d28c15
Merge pull request #74333 from SataQiu/fix-shell-20190221 
Fix some shellcheck failures in hack
 2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot 4c16fb78b3
Merge pull request #74242 from xichengliudui/fixshellcheck19021903 
fix shellcheck in hack/make-rules/...
 2019-03-21 21:36:17 -07:00
toyoda a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
Kubernetes Prow Robot c48ed1c5ac
Merge pull request #74356 from oomichi/golint-e2e-framework-kubemark 
Fix golint failures for e2e/[..]/kubemark
 2019-03-21 19:26:32 -07:00
Kubernetes Prow Robot 4499275cb9
Merge pull request #72800 from stewart-yu/stewart-component-base 
Move config local to every controller in KCM
 2019-03-21 19:26:19 -07:00
aaa 64f8f30c07 fix shellcheck failures in ./hack/jenkins/... 2019-03-21 05:30:11 -04:00
aaa f82870291f Fix shellcheck failures in godep-save.sh and godep-restore.sh 
update pull request

update pull request
 2019-03-21 05:02:47 -04:00
SataQiu 112af136df update verify-staging-meta-files.sh 2019-03-21 12:44:39 +08:00
Han Kang a5ddc3943a bump required minimum go version to 1.12.1 (strings package compatibility) 2019-03-20 16:07:07 -07:00
aaa 46799b6dd4 Fix shellcheck failures in bootstrap.sh and create_block.sh 2019-03-20 17:37:50 -04:00
Kubernetes Prow Robot 481de197c0
Merge pull request #75156 from smarterclayton/diff_invalid 
Handle nil interface inputs to diff.ObjectReflectDiff
 2019-03-20 00:55:01 -07:00
Kubernetes Prow Robot 6a2936dcbf
Merge pull request #74642 from SataQiu/fix-golint-20190227 
Fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
 2019-03-19 20:14:54 -07:00
Kubernetes Prow Robot d261549a1c
Merge pull request #71813 from booxter/make-update-errors-visibility 
Expose errors from godep_restored to caller
 2019-03-19 19:00:25 -07:00
Peter McAlpine ac88e13821 Fix lint warnings in pkg/controller/cronjob. 2019-03-19 14:36:26 -04:00
Peter McAlpine 4cfcf0519d Fix lint warnings in pkg/controller/bootstrap 2019-03-19 14:36:26 -04:00
Moshe Levi dcebfd82ac Add nokubeproxy option in START_MODE 
Some CNIs such as OVN don't use kubeproxy and provide
there own implementation for network proxy .
This patch allow to disable the kubeproxy start in the
local-up-cluster.sh script.

It is also move the generation of the certificate and
kubeconfig to  start_kubeproxy function so it will be
generated only when it needed.

This is useful for us for developement and CI testing.
Signed-off-by: Moshe Levi <moshele@mellanox.com>
 2019-03-14 02:29:31 +02:00
Haowei Cai 2fde54c1f3 staging: include generated code in godep verification 
as we now commit up-to-date generated definitions in
apiextensions-apiserver
 2019-03-13 17:11:05 -07:00
Haowei Cai 5d0bef342a apiextensions: commit generated openapi definition 2019-03-13 15:15:34 -07:00
Davanum Srinivas eb4865fbe5
Hack to ignore stale packages in godep 
Change-Id: Ibf0877521310d6f2baad605bf1216940e95cb9cd
 2019-03-12 09:49:03 -04:00
Kubernetes Prow Robot f71ac0fc5f
Merge pull request #75048 from dims/add-verify-check-for-publish-bot-dependencies 
verify script to ensure publishing bot rules and godeps are in sync
 2019-03-08 15:41:11 -08:00
Kubernetes Prow Robot 9fd3d2718b
Merge pull request #75184 from liggitt/verify-godeps-generated 
ignore uncommitted generated openapi files in verify-godeps
 2019-03-08 14:19:47 -08:00
Jordan Liggitt 060e44ae85 ignore uncommitted generated openapi files in verify-godeps 2019-03-08 11:46:11 -05:00
Kubernetes Prow Robot f229aa0ad6
Merge pull request #75044 from errordeveloper/move-cli-runtime-subpackages 
Move printers & resources packages
 2019-03-08 05:43:26 -08:00
Rostislav M. Georgiev 36783eb88b kubeadm: remove v1alpha3 
Remove deprecated old v1alpha3 kubeadm config.

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
 2019-03-08 14:54:51 +02:00
Davanum Srinivas 7d06bb8bc2
verify script to ensure publishing bot rules and godeps are in sync 
Change-Id: Idbad862a797916cc4408ea0099c30d0557044907
 2019-03-08 07:38:11 -05:00
Clayton Coleman fa0fd28767
Handle nil interface inputs to diff.ObjectReflectDiff 
Causes a panic today. Add godoc bragging about how ridiculously awesome
ObjectReflectDiff is.
 2019-03-08 00:15:50 -05:00
Ilya Dmitrichenko 6d7a9048b6
Move printers & resources packages 
These packages deserve to live at the top level of `k8s.io/cli-runtime`,
as they are potentially of wider use than genericclioptions.
 2019-03-07 23:00:24 +00:00
Tim Allclair 820a1dc96b Add node.k8s.io/v1beta1 API 2019-03-07 11:57:12 -08:00
Tim Allclair 63f61a6714 Migrate RuntimeClass to internal API 2019-03-07 11:07:54 -08:00
Kubernetes Prow Robot f8024ab087
Merge pull request #74904 from sttts/sttts-proto-tests 
Rework proto generation scripts and add tests
 2019-03-07 10:58:05 -08:00
Kubernetes Prow Robot ef5ba5cc8b
Merge pull request #75061 from andrewsykim/fix-mac-bazel 
fix hack/update-bazel.sh for mac os environments
 2019-03-07 01:07:52 -08:00
Kubernetes Prow Robot bd8eeaaaaf
Merge pull request #74468 from ixdy/bazel-cgo-crossbuild 
bazel: improve multi-arch support for docker image artifacts
 2019-03-06 20:35:11 -08:00
Kubernetes Prow Robot 88a685feef
Merge pull request #74807 from runyontr/test-cmd-kubeadm-isolation 
Kubeadm test Isolation: #74464
 2019-03-06 17:59:52 -08:00
Kubernetes Prow Robot 752d18d2b0
Merge pull request #74510 from SataQiu/fix-golint-2019022502 
Fix some golint failures for pkg/kubelet/apis/...
 2019-03-06 17:59:25 -08:00
Andrew Kim a6c3a26c34 fix hack/update-bazel.sh for mac os environments 2019-03-06 15:47:25 -05:00
Jeff Grafton 8495f7c9ed bazel: add docker_push rules 2019-03-06 12:35:33 -08:00
WanLinghao 611563c913 golint fix 2019-03-06 19:47:54 +08:00
Kubernetes Prow Robot a7346b60bc
Merge pull request #74970 from ipuustin/lib-util-sh-2 
hack/lib/util.sh: fix empty array expansion with bash 3.
 2019-03-06 02:08:33 -08:00
Dr. Stefan Schimanski 45b0d9bd0a hack/*protobuf.sh: dynamically find api roots 2019-03-06 08:36:14 +01:00
Kubernetes Prow Robot 9f7560de70
Merge pull request #74153 from ixdy/bazel-kubernetes-src-tarball-new 
bazel: make kubernetes-src.tar.gz actually include all srcs
 2019-03-05 21:42:00 -08:00
SataQiu 21239a350d fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme 2019-03-06 13:26:39 +08:00
Kenichi Omichi 1fcab19821 Fix golint failures for e2e/[..]/kubemark 2019-03-05 20:55:00 +00:00
Ismo Puustinen ecb6d13253 hack/lib/util.sh: fix empty array expansion with bash 3. 2019-03-05 21:34:08 +02:00
Kubernetes Prow Robot b4e692b68f
Merge pull request #74854 from neolit123/conformance-nodes 
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
 2019-03-05 09:50:12 -08:00
Kubernetes Prow Robot 493f53433a
Merge pull request #74872 from nikopen/patch-2 
cherry picks usage info link
 2019-03-05 08:16:37 -08:00
Kubernetes Prow Robot 298b8869cf
Merge pull request #74800 from danielqsj/mgo 
fix golint failures for some files under metrics k8s.io/metrics/pkg/apis
 2019-03-05 06:51:20 -08:00
Kubernetes Prow Robot e24e26fac8
Merge pull request #74647 from danielqsj/e2ein 
Fix golint failures for e2e/instrumentation/...
 2019-03-05 06:51:10 -08:00
Kubernetes Prow Robot 890b5c1d9a
Merge pull request #74582 from SataQiu/fix-golint-2019022602 
fix some golint failures for plugin/pkg/admission/...
 2019-03-05 06:50:46 -08:00
Kubernetes Prow Robot 6c31101257
Merge pull request #74283 from xing-yang/csi_crd_controller 
CSINodeInfo and CSIDriver Controller Changes
 2019-03-05 04:44:42 -08:00
Kubernetes Prow Robot baf4eb67ac
Merge pull request #74257 from ipuustin/lib-util-sh 
Fix shellcheck-reported errors in hack/lib/util.sh.
 2019-03-04 23:11:59 -08:00
Kubernetes Prow Robot e2f42845d1
Merge pull request #74487 from danielqsj/window 
Fix golint failures for e2e/windows
 2019-03-04 19:27:11 -08:00
Lubomir I. Ivanov fe2301f17d conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes 
- for ginkgo parallel mode pass -p to autodetect ginkgo nodes.
- disable parallel mode by default (false).
- use provider "skeleton" instead of "local".
- make run_e2e.sh pass shellcheck.
 2019-03-05 01:32:57 +02:00
danielqsj 5cf1950ef8 Fix golint in test/e2e/instrumentation/logging 2019-03-05 07:10:39 +08:00
danielqsj 873fbf9112 Fix golint in test/e2e/instrumentation/monitoring 2019-03-05 07:07:06 +08:00
Kubernetes Prow Robot dddb13c690
Merge pull request #74711 from SataQiu/fix-golint-2019022802 
Fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
 2019-03-04 13:25:38 -08:00
Kubernetes Prow Robot 5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228 
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
 2019-03-04 13:25:26 -08:00
Ismo Puustinen f7e1058c98 shellcheck failures: remove hack/lib/util.sh 2019-03-04 23:23:20 +02:00
Ismo Puustinen 1e34d9df7d hack/lib/util.sh: replace sed with bash replace. 
Test script:

  #!/bin/bash

  rev1="foo"
  rev2="\"bar\""
  rev3="'bar'"

  newrev1="${rev1//[\'\"]}"
  newrev2="${rev2//[\'\"]}"
  newrev3="${rev3//[\'\"]}"

  oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
  oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
  oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")

  echo "$newrev1 vs. $oldrev1"
  echo "$newrev2 vs. $oldrev2"
  echo "$newrev3 vs. $oldrev3"

expected output:

  foo vs. foo
  bar vs. bar
  bar vs. bar
 2019-03-04 23:23:20 +02:00
Ismo Puustinen 0078fce5bd hack/lib/util.sh: don't implicitly convert "find" results into array. 
Also fix array item comparison. Test script for the comparison change:

  #!/bin/bash

  staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
  group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)

  for group_version in ${group_versions[@]}; do
    # original code
    if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
      echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
    fi
    # new code
    for api in ${staging_apis[@]}; do
      if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
        echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
      fi
    done
  done

Expected output:

  orig: vendor/k8s.io/api/extensions/v1beta1
  new: vendor/k8s.io/api/extensions/v1beta1
  orig: vendor/k8s.io/api/extensions/v1
  new: vendor/k8s.io/api/extensions/v1
  orig: vendor/k8s.io/api/extensions/v1
  new: vendor/k8s.io/api/extensions/v1
 2019-03-04 23:23:20 +02:00
Ismo Puustinen edd806330a hack/lib/util.sh: mark variables to be used in a sourcing context. 
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
 2019-03-04 23:23:20 +02:00
Ismo Puustinen 24b5c67723 hack/lib/util.sh: various shellcheck-reported cleanups. 
Use "command -v" instead of "which".  Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.

However, one shellcheck error is ignored in trap mechanism.  The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.

An alternative to ignoring could be tricking shellcheck with:

  trap ''"${new_cmd}" "${trap_add_name}"
 2019-03-04 23:18:54 +02:00
Niko Pen 32f4bf6edf
cherry picks usage info link 2019-03-04 03:20:41 +00:00
Xing Yang bb45b8ee34 Make CSINodeInfo and CSIDriver Core APIs 
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
 2019-03-02 12:31:05 -08:00
stewart-yu dab1c54942 fix golint failures 2019-03-02 12:55:26 +08:00
Kubernetes Prow Robot 222dd0af4c
Merge pull request #71022 from emwalker/68026-golint-fixes-5 
Remove test/integration/* from hack/.golint_failures
 2019-03-01 14:08:33 -08:00
Kubernetes Prow Robot 8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502 
fix shellcheck in test/e2e_node/jenkins/...
 2019-03-01 12:49:08 -08:00
Thomas Runyon 1e44e33517 pulled kubeadm tests out of runTests to run before tests in test/cmd 
Added timeout for https://github.com/kubernetes/kubeadm/issues/1430
 2019-03-01 12:17:25 -05:00
danielqsj 696c98a5e6 fix golint failures for metrics api 2019-03-01 17:36:20 +08:00
Eric Walker 75df4dc04c Remove test/integration/* from hack/.golint_failures 2019-02-28 19:52:39 -07:00
Kubernetes Prow Robot 343bb4bd6b
Merge pull request #74561 from moshe010/start_kube_scheduler 
Move start kubescheduler to it own function
 2019-02-28 05:07:37 -08:00
Kubernetes Prow Robot 02b8056efb
Merge pull request #73288 from wangzhen127/npd-config 
Decouple node-problem-detector release from kubernetes
 2019-02-28 00:27:25 -08:00
SataQiu 11451bbb59 fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd 2019-02-28 15:51:05 +08:00
danielqsj cee02e62b7 Fix golint failures for e2e/windows 2019-02-28 15:48:48 +08:00
Kubernetes Prow Robot 6af2e9afea
Merge pull request #74591 from xichengliudui/fixgolint190226 
fix shellcheck in test/image/...
 2019-02-27 20:39:25 -08:00
SataQiu c0a0471b3b fix golint failures in test/e2e/instrumentation, test/e2e_node/environment 2019-02-28 12:29:22 +08:00
Kubernetes Prow Robot d58ff3bfc0
Merge pull request #74176 from dims/containerized-kubelet-is-being-deprecated 
Remove support for containerized-kubelet in local-up-cluster.sh
 2019-02-27 14:40:06 -08:00
Zhen Wang 6df207bdaa allows configuring NPD image version in node e2e test and fix the test 2019-02-26 21:29:50 -08:00
Kubernetes Prow Robot 81e6407393
Merge pull request #74140 from Liujingfang1/kflag 
add -k flag in cli-runtime and kubectl to process kustomization directories
 2019-02-26 19:40:16 -08:00
Kubernetes Prow Robot 5ebdf3e3f2
Merge pull request #74574 from SataQiu/fix-golint-20190226 
fix some golint failures in pkg/registry/...
 2019-02-26 18:12:19 -08:00
Kubernetes Prow Robot 493b261057
Merge pull request #74586 from danielqsj/patch3 
fix golint failures for test/e2e/cloud|kubectl|servicecatalog
 2019-02-26 14:08:16 -08:00
Kubernetes Prow Robot 26f90e850d
Merge pull request #74540 from oomichi/golint-e2e-framework-ingress 
Fix golint under test/e2e/framework/ingress
 2019-02-26 14:08:06 -08:00
Kubernetes Prow Robot 0ecba229aa
Merge pull request #74512 from danielqsj/ui 
fix golint failures for test/e2e/ui
 2019-02-26 14:07:54 -08:00
Kenichi Omichi ede5477697 Enable StorageObjectInUseProtection by default 
StorageObjectInUseProtection plugin of admission controller adds
the flag `kubernetes.io/pvc-protection` or `kubernetes.io/pv-protection`
to newly created PVCs or PV. In case a user deletes a PVC or PV the PVC
or PV is not removed until the finalizer is removed from the PVC or PV
by PVC or PV Protection Controller.
We are testing this plugin on the e2e tests of "PV Protection" because
most setup scripts enable that like:

* cluster/centos/config-default.sh: Enabled
* cluster/gce/config-default.sh: Enabled
* cluster/gce/config-test.sh: Enabled
* cluster/kubemark/gce/config-default.sh: Enabled
* hack/local-up-cluster.sh: Enabled
* cluster/juju/layers/kubernetes-master/reactive/kubernetes_master.py: Disabled

As we are testing it normally, it is nice to enable the plugin by
default.
 2019-02-26 18:08:44 +00:00
SataQiu 9e4c8950be fix some golint failures in pkg/registry/... 2019-02-26 22:36:52 +08:00
danielqsj 8911a2ddbb fix golint failures for test/e2e/kubectl 2019-02-26 18:27:01 +08:00
danielqsj 9ea1b3d86d fix golint failures for test/e2e/servicecatalog 2019-02-26 18:25:23 +08:00
danielqsj 84aeafee7b fix golint failures for test/e2e/cloud 2019-02-26 18:25:23 +08:00
SataQiu f8c4aba0cb fix some golint failures for plugin/pkg/admission/... 2019-02-26 17:12:40 +08:00
Kubernetes Prow Robot 736baa5e33
Merge pull request #73593 from danielqsj/etcd 
fix shellcheck failure in etcd shell
 2019-02-25 23:11:50 -08:00
danielqsj 1ce7b0b2fa fix golint failures for test/e2e/ui 2019-02-26 14:03:34 +08:00
xichengliudui 4b38978329 fix shellcheck in test/e2e_node/jenkins/... 
update pull request
 2019-02-26 01:01:48 -05:00
xichengliudui ec5fddfe4f fix shellcheck in hack/make-rules/... 
update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request
 2019-02-26 00:56:36 -05:00
Kubernetes Prow Robot 33a0afafe7
Merge pull request #74508 from danielqsj/uapps 
Fix golint failures for e2e/upgrades/...
 2019-02-25 21:48:42 -08:00
SataQiu c6ae694b79 fix some shellcheck failures in hack 2019-02-26 12:45:38 +08:00
Kubernetes Prow Robot 5a2d587ac4
Merge pull request #74505 from SataQiu/fix-golint-20190225 
fix golint failures for pkg/apis/...
 2019-02-25 20:28:30 -08:00
Kubernetes Prow Robot 272d78f1d9
Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server 
Fix lint on pkg/kubelet/server/...
 2019-02-25 20:27:48 -08:00
Moshe Levi b9fb656546 Move start kubescheduler to it own function 
Currently the kubescheduler starts in the start_kubeproxy
This change move it to ir own function start_kubescheduler

Change-Id: Iff93114d4becabe4b6b937c5077821e092abffd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
 2019-02-26 04:30:11 +02:00
Kubernetes Prow Robot 1595089ec5
Merge pull request #74453 from xichengliudui/fixgolintfailures1902 
fixgo lint failures test/integration/...
 2019-02-25 17:25:34 -08:00
Kubernetes Prow Robot 483d19ccc4
Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack 
Fix shellcheck for more scripts in hack
 2019-02-25 17:25:23 -08:00
Kubernetes Prow Robot 0ff7e463ee
Merge pull request #73746 from mrbobbytables/kubemark-shellcheck 
Fix shellcheck lint errors in Kubemark scripts
 2019-02-25 17:25:13 -08:00
Jingfang Liu beacc87ebf add cmdline tests for -k 2019-02-25 16:31:03 -08:00
Jeff Grafton 392ad719eb add comments 2019-02-25 15:34:09 -08:00
Jeff Grafton 883b6cff0d Generate a repos_generated.bzl file with all staging repos 
Additionally, ensure that every staging repo has a BUILD file at its
root.

Also, remove a gazelle directive we no longer need.
 2019-02-25 15:33:46 -08:00
Kubernetes Prow Robot 3814176d42
Merge pull request #74455 from SataQiu/fix-shell-2019022302 
Fix shellcheck lint errors in cluster and hack scripts
 2019-02-25 15:15:19 -08:00
Kubernetes Prow Robot a778f409ba
Merge pull request #74385 from SataQiu/fix-shell-20190222 
Fix some shellcheck failures in hack
 2019-02-25 13:54:32 -08:00
Kubernetes Prow Robot 0813567660
Merge pull request #74349 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-in-hack 
Fix shellcheck for hack/verify-generated-*
 2019-02-25 13:54:10 -08:00
Kenichi Omichi 215dee7dd2 Fix golint under test/e2e/framework/ingress 2019-02-25 20:55:03 +00:00
Bob Killen e137f4702a
Fix shellcheck lint errors in test/kubemark/stop-kubemark.sh 2019-02-25 15:21:32 -05:00
Bob Killen b8aae458a1
Fix shellcheck lint errors in test/kubemark/start-kubemark.sh 2019-02-25 15:21:31 -05:00
Bob Killen 46333a01b4
Fix shellcheck lint errors in test/kubemark/run-e2e-tests.sh 2019-02-25 15:21:31 -05:00
Bob Killen adf4bf1741
Fix shellcheck lint errors in test/kubemark/resources/start-kubemark-master.sh 2019-02-25 15:21:31 -05:00
Bob Killen f72ac1f5b7
Fix shellcheck lint errors in test/kubemark/master-log-dump.sh 2019-02-25 15:21:31 -05:00
Bob Killen cb59cb33ff
Fix shellcheck lint errors in test/kubemark/iks/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen e3e2a96521
Fix shellcheck lint errors in test/kubemark/iks/startup.sh 2019-02-25 15:21:30 -05:00
Bob Killen 6310305d3b
Fix shellcheck lint errors in test/kubemark/iks/shutdown.sh 2019-02-25 15:21:30 -05:00
Bob Killen 186b83fe5b
Fix shellcheck lint errors in test/kubemark/gce/util.sh 2019-02-25 15:21:30 -05:00
Bob Killen 5f4b919887
Fix shellcheck lint errors in test/kubemark/common/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen 9a4f4878f5
Fix shellcheck lint errors in cluster/kubemark/util.sh 2019-02-25 15:21:29 -05:00
Bob Killen 9a58913e8f
Fix shellcheck lint errors in cluster/kubemark/iks/config-default.sh 2019-02-25 15:21:25 -05:00
Bob Killen ce4c85e3fd
Fix shellcheck lint errors in cluster/kubemark/gce/config-default.sh 2019-02-25 14:55:01 -05:00
Kubernetes Prow Robot 35a258d640
Merge pull request #73272 from danielqsj/juju 
fix shellcheck in cluster/juju
 2019-02-25 11:33:21 -08:00
Kubernetes Prow Robot f288678cfa
Merge pull request #73261 from danielqsj/local 
fix shellcheck in cluster/local
 2019-02-25 11:33:11 -08:00
Davanum Srinivas 5d13f6f776
Remove support for containerized-kubelet in local-up-cluster.sh 
Change-Id: I3435b02fbe052a88f6b88d5517de2d68ff636a66
 2019-02-25 08:53:14 -05:00
SataQiu 09ba08f8f4 fix some golint failures for pkg/apis/... 2019-02-25 18:06:08 +08:00
SataQiu 7181c44230 fix some golint failures for pkg/cloudprovider/providers/vsphere/vclib and pkg/kubelet/apis/... 2019-02-25 18:01:41 +08:00
danielqsj 6322025d5c fix golint failures for test/e2e/upgrades 2019-02-25 16:36:26 +08:00
danielqsj 7c8498ab03 fix golint failures for test/e2e/upgrades/storage 2019-02-25 15:41:31 +08:00
danielqsj 8916ccabaf fix golint failures for test/e2e/upgrades/apps 2019-02-25 13:32:15 +08:00
mattjmcnaughton b4d086f914 Fix shellcheck for hack/verify-generated-* 
All of the `hack/verify-generated-*` files now pass shellcheck and are
removed from `hack/.shellcheck_failures`.
 2019-02-24 23:50:59 -05:00
mattjmcnaughton 57c51c741d Fix shellcheck for more scripts in hack 
Making more of the scripts in hack pass the shellcheck linter.
 2019-02-24 23:48:21 -05:00
SataQiu d357bcd2cd fix some shellcheck failures in hack 2019-02-25 11:38:56 +08:00
danielqsj 7e655e8666 fix shellcheck in cluster/juju 2019-02-24 20:40:59 +08:00
danielqsj e698682a0e change a way to pass SC2164 in etcd.sh 2019-02-24 20:26:59 +08:00
danielqsj c215966d22 fix shellcheck failure in etcd shell 2019-02-24 20:19:50 +08:00
SataQiu 9cda80e836 fix shellcheck lint errors in cluster and hack scripts 2019-02-24 11:15:35 +08:00
Kubernetes Prow Robot 139a13d312
Merge pull request #74269 from moshe010/kubelet_gen_cert 
Move kubelet cert generation when starting kubelet
 2019-02-23 18:41:10 -08:00
Kubernetes Prow Robot 1cf8001e53
Merge pull request #74449 from xichengliudui/fix190223 
make more of the shell pass lints
 2019-02-23 12:52:34 -08:00
Kubernetes Prow Robot 6a29f8ca5f
Merge pull request #74451 from xichengliudui/fixshellcheckout190223 
fix shellcheck in hack/...
 2019-02-23 10:23:15 -08:00
Kubernetes Prow Robot 0133d14170
Merge pull request #72939 from runyontr/test-cmd-what 
Test cmd what
 2019-02-23 02:54:36 -08:00