github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

cmd: kubectl: remove golint_failures entry 

`.golint_failures` currently has an entry for `cmd/kubectl/app`. We can lint this package and remove
the entry. There is only one `golint` warning; comment on exported function Run should be of the
form "Run ..."

Fix documentation comment and remove `cmd/kubectl/app` from `.golint_failures`.
pull/6/head
tcharding 2017-10-03 16:25:57 +11:00
parent 6d1f73392f
commit fa2de842d0
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/kubectl/app/kubectl.go
View File

@ -31,6 +31,8 @@ import (
WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go
Any salient changes here will need to be manually reflected in that file. Any salient changes here will need to be manually reflected in that file.
*/ */
// Run runs the kubectl program (creates and executes a new cobra command).
func Run() error { func Run() error {
logs.InitLogs() logs.InitLogs()
defer logs.FlushLogs() defer logs.FlushLogs()

1
hack/.golint_failures
View File

@ -9,7 +9,6 @@ cmd/kube-proxy/app
cmd/kubeadm/app cmd/kubeadm/app
cmd/kubeadm/app/apis/kubeadm cmd/kubeadm/app/apis/kubeadm
cmd/kubeadm/app/apis/kubeadm/v1alpha1 cmd/kubeadm/app/apis/kubeadm/v1alpha1
cmd/kubectl/app
cmd/kubelet/app cmd/kubelet/app
cmd/kubelet/app/options cmd/kubelet/app/options
cmd/kubemark cmd/kubemark