From fa2de842d08a7f8a7dbd21bac7fadd3ea3f8c55e Mon Sep 17 00:00:00 2001
From: tcharding <me@tobin.cc>
Date: Tue, 3 Oct 2017 16:25:57 +1100
Subject: [PATCH] cmd: kubectl: remove golint_failures entry

`.golint_failures` currently has an entry for `cmd/kubectl/app`. We can lint this package and remove
the entry. There is only one `golint` warning; comment on exported function Run should be of the
form "Run ..."

Fix documentation comment and remove `cmd/kubectl/app` from `.golint_failures`.
---
 cmd/kubectl/app/kubectl.go | 2 ++
 hack/.golint_failures      | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/cmd/kubectl/app/kubectl.go b/cmd/kubectl/app/kubectl.go
index 7d39fd7ec7..ddcdfb9227 100644
--- a/cmd/kubectl/app/kubectl.go
+++ b/cmd/kubectl/app/kubectl.go
@@ -31,6 +31,8 @@ import (
 WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go
 Any salient changes here will need to be manually reflected in that file.
 */
+
+// Run runs the kubectl program (creates and executes a new cobra command).
 func Run() error {
 	logs.InitLogs()
 	defer logs.FlushLogs()
diff --git a/hack/.golint_failures b/hack/.golint_failures
index afd37390f1..ead971d9b1 100644
--- a/hack/.golint_failures
+++ b/hack/.golint_failures
@@ -9,7 +9,6 @@ cmd/kube-proxy/app
 cmd/kubeadm/app
 cmd/kubeadm/app/apis/kubeadm
 cmd/kubeadm/app/apis/kubeadm/v1alpha1
-cmd/kubectl/app
 cmd/kubelet/app
 cmd/kubelet/app/options
 cmd/kubemark