You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Yaroslav Halchenko 8d25e83f5d BF: race condition -- file should not be read unless it is not empty ... Previous code would store md5sum of an empty line as the one identifying the monitored file. That file then was read and possibly failures were found. Upon next "container.open()", md5 digest of now present first line was compared against previous digest of an empty line, which was different, thus file was assumed to be rotated and all the log lines were read once again. The History ----------- In rare cases various tests failed somewhat consistently. Below you can find one case in test_move_file where such failure really made no sense -- we should have not had 4 failures by that point. Fail2ban 0.8.10.dev test suite. Python 2.4.6 (#2, Sep 25 2009, 22:22:06) [GCC 4.3.4]. Please wait... I: Skipping gamin backend testing. Got exception 'No module named gamin' I: Skipping pyinotify backend testing. Got exception 'No module named pyinotify' D: fn=/home/yoh/test/monitorfailures_FilterPoll9nUKoCfail2ban-0 hashes=d41d8cd98f00b204e9800998ecf8427e/d41d8cd98f00b204e9800998ecf8427e inos=5398862/5398862 pos=0 rotate=False D: Adding a ticket for ('193.168.0.128', 1124013599.0, ['Aug 14 11:59:59 [sshd] error: PAM: Authentication failure for kevin from 193.168.0.128\n']) D: Adding a ticket for ('193.168.0.128', 1124013599.0, ['Aug 14 11:59:59 [sshd] error: PAM: Authentication failure for kevin from 193.168.0.128\n']) D: Closed <closed file '/home/yoh/test/monitorfailures_FilterPoll9nUKoCfail2ban-0', mode 'r' at 0x7f472b2efdc8> with pos 1231 D: fn=/home/yoh/test/monitorfailures_FilterPoll9nUKoCfail2ban-0 hashes=d41d8cd98f00b204e9800998ecf8427e/aeb4e73e6922a746d027eb365ece2149 inos=5398862/5398862 pos=1231 rotate=True D: Adding a ticket for ('193.168.0.128', 1124013599.0, ['Aug 14 11:59:59 [sshd] error: PAM: Authentication failure for kevin from 193.168.0.128\n']) D: Adding a ticket for ('193.168.0.128', 1124013599.0, ['Aug 14 11:59:59 [sshd] error: PAM: Authentication failure for kevin from 193.168.0.128\n']) D: Closed <closed file '/home/yoh/test/monitorfailures_FilterPoll9nUKoCfail2ban-0', mode 'r' at 0x7f472b2ef558> with pos 1231 F ====================================================================== FAIL: test_move_file (testcases.filtertestcase.MonitorFailures<FilterPoll>(/home/yoh/test/monitorfailures_FilterPoll9nUKoCfail2ban)) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/yoh/deb/gits/fail2ban/testcases/filtertestcase.py", line 451, in test_move_file "Queue must be empty but it is not: %s." AssertionError: Queue must be empty but it is not: server.ticket.FailTicket: ip=193.168.0.128 time=1124013599.0 #attempts=4. ---------------------------------------------------------------------- N.B.1 I preserved here and in the code corresponding additional debug print statements, which are commented out by default. sensible md5 digest was generated by using hexdigest() instead of current a bit faster digest(). Running tests with all the debug output simply breaks the race loose and failure doesn't trigger. N.B.2 d41d8cd98f00b204e9800998ecf8427e is an md5sum of an empty string, and aeb4e73e6922a746d027eb365ece2149 of the first line in that file.		12 years ago
..
__init__.py	DOC: purge of svn tags	12 years ago
action.py	Merge branch 'master' of git://github.com/fail2ban/fail2ban	12 years ago
actions.py	DOC: purge of svn tags	12 years ago
asyncserver.py	ENH: consistent operation of formatExceptionInfo + unittest for it	12 years ago
banmanager.py	DOC: purge of svn tags	12 years ago
datedetector.py	Merge branch PR #193 ASSP SMTP Proxy support (with some manual squashing)	12 years ago
datetemplate.py	DOC: purge of svn tags	12 years ago
faildata.py	DOC: purge of svn tags	12 years ago
failmanager.py	DOC: purge of svn tags	12 years ago
failregex.py	ENH: "is None" instead of "== None" + tune ups in headers	12 years ago
filter.py	BF: race condition -- file should not be read unless it is not empty	12 years ago
filtergamin.py	FD_CLOEXEC support	12 years ago
filterpoll.py	ENH(+possibly BF): for FilterPoll rely not only on mtime but also ino and size to assess if file was modified	12 years ago
filterpyinotify.py	ENH: strengthen detection of working pyinotify	12 years ago
iso8601.py	ENH: modelines for emacs and vim to assure consistent indentation scheme (tabs)	13 years ago
jail.py	ENH: issue a warning if jail name is longer than 19 symbols (Close #222)	12 years ago
jails.py	RF: move exceptions used by both client and server into common/exceptions.py	12 years ago
jailthread.py	BF: setSleepTime -- would barf since value is not str (wasn't used/tested)	12 years ago
mytime.py	ENH: "is None" instead of "== None" + tune ups in headers	12 years ago
server.py	ENH: now we know that logging handlers closing was still buggy in 2.6.2	12 years ago
ticket.py	DOC: purge of svn tags	12 years ago
transmitter.py	DOC: purge of svn tags	12 years ago