Browse Source

Merge pull request #1002 from sebres/_bf/fix-invalid-ip

fix test for invalid IP (use TEST-NET-1 according to RFC 5737)
pull/1004/head
Yaroslav Halchenko 10 years ago
parent
commit
c926af1fce
  1. 5
      fail2ban/tests/filtertestcase.py

5
fail2ban/tests/filtertestcase.py

@ -224,7 +224,7 @@ class IgnoreIP(LogCaptureTestCase):
self.assertTrue(self.filter.inIgnoreIPList(ip)) self.assertTrue(self.filter.inIgnoreIPList(ip))
def testIgnoreIPNOK(self): def testIgnoreIPNOK(self):
ipList = "", "999.999.999.999", "abcdef", "192.168.0." ipList = "", "999.999.999.999", "abcdef.abcdef", "192.168.0."
for ip in ipList: for ip in ipList:
self.filter.addIgnoreIP(ip) self.filter.addIgnoreIP(ip)
self.assertFalse(self.filter.inIgnoreIPList(ip)) self.assertFalse(self.filter.inIgnoreIPList(ip))
@ -1023,7 +1023,8 @@ class DNSUtilsTests(unittest.TestCase):
def testIpToName(self): def testIpToName(self):
res = DNSUtils.ipToName('66.249.66.1') res = DNSUtils.ipToName('66.249.66.1')
self.assertEqual(res, 'crawl-66-249-66-1.googlebot.com') self.assertEqual(res, 'crawl-66-249-66-1.googlebot.com')
res = DNSUtils.ipToName('10.0.0.0') # invalid ip (TEST-NET-1 according to RFC 5737)
res = DNSUtils.ipToName('192.0.2.0')
self.assertEqual(res, None) self.assertEqual(res, None)
def testAddr2bin(self): def testAddr2bin(self):

Loading…
Cancel
Save