From c5ba76aab8c8604fe3a3c2f84e21a962aebd5c50 Mon Sep 17 00:00:00 2001 From: sebres Date: Wed, 25 Mar 2015 01:10:53 +0100 Subject: [PATCH 1/2] fix test for invalid IP (use TEST-NET-1 according to RFC 5737): since fef031b3cd41c99a4843d5d5b52217b7694eff72 failed, because on some platforms like vm:debian 10.0.0.0 returns 'localhost' (intern network). --- fail2ban/tests/filtertestcase.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fail2ban/tests/filtertestcase.py b/fail2ban/tests/filtertestcase.py index 8fa13dfa..c7c11f61 100644 --- a/fail2ban/tests/filtertestcase.py +++ b/fail2ban/tests/filtertestcase.py @@ -1023,7 +1023,8 @@ class DNSUtilsTests(unittest.TestCase): def testIpToName(self): res = DNSUtils.ipToName('66.249.66.1') self.assertEqual(res, 'crawl-66-249-66-1.googlebot.com') - res = DNSUtils.ipToName('10.0.0.0') + # invalid ip (TEST-NET-1 according to RFC 5737) + res = DNSUtils.ipToName('192.0.2.0') self.assertEqual(res, None) def testAddr2bin(self): From 6da0c4ad48f2c44c55904518ba2db69fbe5ed0d3 Mon Sep 17 00:00:00 2001 From: sebres Date: Wed, 25 Mar 2015 01:50:51 +0100 Subject: [PATCH 2/2] very long time resolving IP for address "abcdef" on some PDC, under NAT etc. - replaced via "abcdef.abcdef" to prevent searching in local domains; --- fail2ban/tests/filtertestcase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fail2ban/tests/filtertestcase.py b/fail2ban/tests/filtertestcase.py index c7c11f61..75f91584 100644 --- a/fail2ban/tests/filtertestcase.py +++ b/fail2ban/tests/filtertestcase.py @@ -224,7 +224,7 @@ class IgnoreIP(LogCaptureTestCase): self.assertTrue(self.filter.inIgnoreIPList(ip)) def testIgnoreIPNOK(self): - ipList = "", "999.999.999.999", "abcdef", "192.168.0." + ipList = "", "999.999.999.999", "abcdef.abcdef", "192.168.0." for ip in ipList: self.filter.addIgnoreIP(ip) self.assertFalse(self.filter.inIgnoreIPList(ip))