github
/
fail2ban
mirror of https://github.com/fail2ban/fail2ban
1
0
Fork 0
Code Issues Releases Wiki Activity

ENH: Pruned some "pragma: no cover"s in fail2banregex 

This code should and can be unit-tested, so no reason to keep it with
no cover
pull/1251/head
Yaroslav Halchenko 2015-11-10 08:31:56 -05:00
parent 584f3af5af
commit 441dffbe2a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fail2ban/client/fail2banregex.py
View File

@ -542,7 +542,7 @@ class Fail2banRegex(object):
return True return True
def exec_command_line(): # pragma: no cover def exec_command_line():
parser = get_opt_parser() parser = get_opt_parser()
(opts, args) = parser.parse_args() (opts, args) = parser.parse_args()
if opts.print_no_missed and opts.print_all_missed: if opts.print_no_missed and opts.print_all_missed:
@ -566,10 +566,10 @@ def exec_command_line(): # pragma: no cover
output( "" ) output( "" )
# TODO: taken from -testcases -- move common functionality somewhere # TODO: taken from -testcases -- move common functionality somewhere
if opts.log_level is not None: # pragma: no cover if opts.log_level is not None:
# so we had explicit settings # so we had explicit settings
logSys.setLevel(getattr(logging, opts.log_level.upper())) logSys.setLevel(getattr(logging, opts.log_level.upper()))
else: # pragma: no cover else:
# suppress the logging but it would leave unittests' progress dots # suppress the logging but it would leave unittests' progress dots
# ticking, unless like with '-l critical' which would be silent # ticking, unless like with '-l critical' which would be silent
# unless error occurs # unless error occurs
@ -587,9 +587,9 @@ def exec_command_line(): # pragma: no cover
Formatter = logging.Formatter Formatter = logging.Formatter
# Custom log format for the verbose tests runs # Custom log format for the verbose tests runs
if opts.verbose: # pragma: no cover if opts.verbose:
stdout.setFormatter(Formatter(' %(asctime)-15s %(thread)s' + fmt)) stdout.setFormatter(Formatter(' %(asctime)-15s %(thread)s' + fmt))
else: # pragma: no cover else:
# just prefix with the space # just prefix with the space
stdout.setFormatter(Formatter(fmt)) stdout.setFormatter(Formatter(fmt))
logSys.addHandler(stdout) logSys.addHandler(stdout)