From 441dffbe2a539a3910c5ae4fc4e1341d9a103640 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Tue, 10 Nov 2015 08:31:56 -0500 Subject: [PATCH] ENH: Pruned some "pragma: no cover"s in fail2banregex This code should and can be unit-tested, so no reason to keep it with no cover --- fail2ban/client/fail2banregex.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fail2ban/client/fail2banregex.py b/fail2ban/client/fail2banregex.py index 92ad4a91..d0cdab84 100755 --- a/fail2ban/client/fail2banregex.py +++ b/fail2ban/client/fail2banregex.py @@ -542,7 +542,7 @@ class Fail2banRegex(object): return True -def exec_command_line(): # pragma: no cover +def exec_command_line(): parser = get_opt_parser() (opts, args) = parser.parse_args() if opts.print_no_missed and opts.print_all_missed: @@ -566,10 +566,10 @@ def exec_command_line(): # pragma: no cover output( "" ) # TODO: taken from -testcases -- move common functionality somewhere - if opts.log_level is not None: # pragma: no cover + if opts.log_level is not None: # so we had explicit settings logSys.setLevel(getattr(logging, opts.log_level.upper())) - else: # pragma: no cover + else: # suppress the logging but it would leave unittests' progress dots # ticking, unless like with '-l critical' which would be silent # unless error occurs @@ -587,9 +587,9 @@ def exec_command_line(): # pragma: no cover Formatter = logging.Formatter # Custom log format for the verbose tests runs - if opts.verbose: # pragma: no cover + if opts.verbose: stdout.setFormatter(Formatter(' %(asctime)-15s %(thread)s' + fmt)) - else: # pragma: no cover + else: # just prefix with the space stdout.setFormatter(Formatter(fmt)) logSys.addHandler(stdout)