12308 Commits (f2373a5575a413fce657e938c11630027052604a)

 

All Branches   

Search

Author	SHA1	Message	Date
Daniel Nephin	f2373a5575	logging: move init of grpclog ... This line initializes global state. Moving it out of the constructor and closer to where logging is setup helps keep related things together.	4 years ago
Daniel Nephin	33c401a16e	logging: Setup accept io.Writer instead of []io.Writer ... Also accept a non-pointer Config, since the config is not modified	4 years ago
Daniel Nephin	2128f40fc2	Merge pull request #8511 from hashicorp/dnephin/agent-setup ... agent: extract dependency creation from New	4 years ago
Kenia	f21895a76d	ui: Increase spacing between detail items in composite row (#8507)	4 years ago
Daniel Nephin	63bad36de7	testing: disable global metrics sink in tests ... This might be better handled by allowing configuration for the InMemSink interval and retail, and disabling the global. For now this is a smaller change to remove the goroutine leak caused by tests because go-metrics does not provide any way of shutting down the global goroutine.	4 years ago
Daniel Nephin	5d4df54296	agent: extract dependency creation from New ... With this change, Agent.New() accepts many of the dependencies instead of creating them in New. Accepting fully constructed dependencies from a constructor makes the type easier to test, and easier to change. There are still a number of dependencies created in Start() which can be addressed in a follow up.	4 years ago
Daniel Nephin	51b08c645b	Merge pull request #8514 from hashicorp/dnephin/testing-improvements-1 ... testing: small improvements to TestSessionCreate and testutil.retry	4 years ago
Daniel Nephin	ab2157bbc9	Merge pull request #8528 from hashicorp/dnephin/move-node-name-validation ... config: Move some config validation from Agent.Start to config.Builder.Validate	4 years ago
danielehc	1790b37a11	Adding warning for ACL replication data loss (#8210)	4 years ago
Hans Hasselberg	a932aafc91	add primary keys to list keyring (#8522) ... During gossip encryption key rotation it would be nice to be able to see if all nodes are using the same key. This PR adds another field to the json response from `GET v1/operator/keyring` which lists the primary keys in use per dc. That way an operator can tell when a key was successfully setup as primary key. Based on https://github.com/hashicorp/serf/pull/611 to add primary key to list keyring output: ```json [ { "WAN": true, "Datacenter": "dc2", "Segment": "", "Keys": { "0OuM4oC3Os18OblWiBbZUaHA7Hk+tNs/6nhNYtaNduM=": 6, "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 6 }, "PrimaryKeys": { "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 6 }, "NumNodes": 6 }, { "WAN": false, "Datacenter": "dc2", "Segment": "", "Keys": { "0OuM4oC3Os18OblWiBbZUaHA7Hk+tNs/6nhNYtaNduM=": 8, "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 8 }, "PrimaryKeys": { "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 8 }, "NumNodes": 8 }, { "WAN": false, "Datacenter": "dc1", "Segment": "", "Keys": { "0OuM4oC3Os18OblWiBbZUaHA7Hk+tNs/6nhNYtaNduM=": 3, "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 8 }, "PrimaryKeys": { "SINm887hKTzmMWeBNKTJReaTLX3mBEJKriDyt88Ad+g=": 8 }, "NumNodes": 8 } ] ``` I intentionally did not change the CLI output because I didn't find a good way of displaying this information. There are a couple of options that we could implement later: * add a flag to show the primary keys * add a flag to show json output Fixes #3393.	4 years ago
Daniel Nephin	35f1ecee0b	config: Move remote-script-checks warning to config ... Previously it was done in Agent.Start, but it can be done much earlier	4 years ago
Daniel Nephin	27b36bfc4e	config: move NodeName validation to config validation ... Previsouly it was done in Agent.Start, which is much later then it needs to be. The new 'dns' package was required, because otherwise there would be an import cycle. In the future we should move more of the dns server into the dns package.	4 years ago
Daniel Nephin	b4015969c9	Merge pull request #8515 from hashicorp/dnephin/unexport-testing-shims ... config: unexport fields and resolve TODOs in config.Builder	4 years ago
Daniel Nephin	30523c22f5	Merge pull request #8517 from hashicorp/dnephin/remove-defer-os-removeall ... testing: remove all the 'defer os.RemoveAll'	4 years ago
danielehc	96916a770c	Refactor api-docs links to learn (#8488)	4 years ago
danielehc	5483988b5b	Refactor docs links to learn 2 (#8491) ... * Refactor docs links to learn * Apply suggestions from code review Co-authored-by: Derek Strickland <1111455+DerekStrickland@users.noreply.github.com> Co-authored-by: Derek Strickland <1111455+DerekStrickland@users.noreply.github.com>	4 years ago
danielehc	f32b3d2cca	Refactor docs links to learn (#8490)	4 years ago
Daniel Nephin	16217fe9b9	testing: use t.Cleanup in testutil.TempFile ... So that it has the same behaviour as TempDir. Also remove the now unnecessary 'defer os.Remove'	4 years ago
Daniel Nephin	d68edcecf4	testing: Remove all the defer os.Removeall ... Now that testutil uses t.Cleanup to remove the directory the caller no longer has to manage the removal	4 years ago
Daniel Nephin	8a4d292c8e	config: unexport and resolve TODOs in config.Builder ... - unexport testing shims, and document their purpose - resolve a TODO by moving validation to NewBuilder and storing the one field that is used instead of all of Options - create a slice with the correct size to avoid extra allocations	4 years ago
Daniel Nephin	a4b201af36	testing: Improve session_endpoint_test ... While working on another change I caused a bunch of these tests to fail. Unfortunately the failure messages were not super helpful at first. One problem was that the request and response were created outside of the retry. This meant that when the second attempt happened, the request body was empty (because the buffer had been consumed), and so the request was not actually being retried. This was fixed by moving more of the request creation into the retry block. Another problem was that these functions can return errors in two ways, and are not consistent about which way they use. Some errors are returned to the response writer, but the tests were not checking those errors, which was causing a panic later on. This was fixed by adding a check for the response code. Also adds some missing t.Helper(), and has assertIndex use checkIndex so that it is clear these are the same implementation.	4 years ago
Daniel Nephin	587dcebfca	Use t.Helper in testutil/retry	4 years ago
Daniel Nephin	bb6737dc60	Merge pull request #8509 from hashicorp/dnephin/use-t.cleanup-in-testagent ... testing: Use t.cleanup in TestAgent , and fix two flaky tests	4 years ago
Derek Strickland	2bf85fae62	Added link to Secure Consul on K8S Tutorial (#8402)	4 years ago
Daniel Nephin	070e843113	testutil: Add t.Cleanup to TempDir ... TempDir registers a Cleanup so that the directory is always removed. To disable to cleanup, set the TEST_NOCLEANUP env var.	4 years ago
Mike Morris	ac6415f0a8	changelog: update for 1.8.3, 1.7.7 and 1.6.8 (#8508) ... * Update CHANGELOG.md * changelog: update for 1.8.3, 1.7.7 and 1.6.8 Co-authored-by: Sarah Christoff <schristoff@hashicorp.com>	4 years ago
Daniel Nephin	2b920ad199	testing: fix flaky test TestDNS_NonExistentDC_RPC ... I saw this test flake locally, and it was easy to reproduce with -count=10. The failure was: 'TestAgent.dns: rpc error: error=No known Consul servers'. Waiting for the agent seems to fix it.	4 years ago
Daniel Nephin	1912c5ad89	testing: wait until monitor has started before shutdown ... This commit fixes a test that I saw flake locally while running tests. The test output from the monitor started immediately after the line the test was looking for. To fix the problem a channel is closed when the goroutine starts. Shutdown is not called until this channel is closed, which seems to greatly reduce the chance of a flake.	4 years ago
Daniel Nephin	3a4e62836b	testing: Remove TestAgent.Key and change TestAgent.DataDir ... TestAgent.Key was only used by 3 tests. Extracting it from the common helper that is used in hundreds of tests helps keep the shared part small and more focused. This required a second change (which I was planning on making anyway), which was to change the behaviour of DataDir. Now in all cases the TestAgent will use the DataDir, and clean it up once the test is complete.	4 years ago
Iryna Shustava	7f8e723dc2	docs: add docs to use Connect CA providers with Helm (#8464)	4 years ago
Daniel Nephin	b1679508d4	testing: use t.Cleanup in TestAgent for returnPorts	4 years ago
Daniel Nephin	4e8e0de8f0	testing: remove unused fields from TestACLAgent	4 years ago
Derek Strickland	930d7d3158	Learn/link updates derek (#8487) ... * Updated Learn url paths. Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>	4 years ago
Iryna Shustava	cd3d6adbf4	docs: consul on k8s doesn't support external servers requiring mTLS (#8484)	4 years ago
Daniel Nephin	2ed33089aa	Merge pull request #8473 from hashicorp/dnephin/unmethod-consul-config ... agent: convert consulConfig method to a function	4 years ago
Daniel Nephin	399c77dfb6	agent: rename vars in newConsulConfig ... 'base' is a bit misleading, since it is the return value. Renamed to cfg.	4 years ago
Daniel Nephin	7b5b170a0d	agent: Move setupKeyring functions to keyring.go ... There are a couple reasons for this change: 1. agent.go is way too big. Smaller files makes code eaasier to read because tools that show usage also include filename which can give a lot more context to someone trying to understand which functions call other functions. 2. these two functions call into a large number of functions already in keyring.go.	4 years ago
Daniel Nephin	9919e5dfa5	agent: unmethod consulConfig ... To allow us to move newConsulConfig out of Agent.	4 years ago
Daniel Nephin	1f7dab07d6	Merge pull request #8482 from hashicorp/dnephin/more-state-store-unmethod ... state: remove unused Store method receiver	4 years ago
Daniel Nephin	8f596f5551	Fix conflict in merged PRs ... One PR renamed the var from config->cfg, and another used the old name config, which caused the build to fail on master.	4 years ago
Daniel Nephin	d677706625	state: remove unused Store method receiver ... And use ReadTxn interface where appropriate.	4 years ago
Daniel Nephin	190fcc14a3	Merge pull request #8463 from hashicorp/dnephin/unmethod-make-node-id ... agent: convert NodeID methods to functions	4 years ago
Daniel Nephin	912aae8624	Merge pull request #8461 from hashicorp/dnephin/remove-notify-shutdown ... agent/consul: Remove NotifyShutdown	4 years ago
Daniel Nephin	5b37efd91b	Merge pull request #8365 from hashicorp/dnephin/fix-service-by-node-meta-flake ... state: speed up tests that use watchLimit	4 years ago
Hans Hasselberg	b86c018a19	Link issue in note template (#8502) ... Issue and PR numbers do not overlap, they are based of the same counter. A PR can be also linked to via issues, if it is a PR, Github will redirect to it. This change has the benefit that one can link to both - issues and PRs.	4 years ago
Luke Kysow	7e5253bf04	Update k8s sync docs (#8452) ... * Update k8s sync docs - remove docs that said for nodeport service we register each instance on a node with its same node name. We instead register each instance onto the k8s-sync node - add docs describing which ports and ips are used	4 years ago
Luke Kysow	0f99b63fc8	Document k8s sidecar resource annotations (#8455)	4 years ago
s-christoff	27a6871434	Update version.js to 1.8.3 (#8505)	4 years ago
Daniel Nephin	3c523eee9e	Merge pull request #8500 from hashicorp/dnephin/auto-config-loader ... auto-config: reduce awareness of config	4 years ago
s-christoff	7301d473ad	Update CHANGELOG.md	4 years ago