281 Commits (d5a889c16049822e21204961c4af8f47edf53150)

Author	SHA1	Message	Date
Frank Schroeder	56e6439be9	fix data race ... Since state.Checks() returns a shallow copy its elements must not be modified. Copying the elements in the handler does not guarantee consistency since that list is guarded by a different lock. Therefore, the only solution is to have state.Checks() return a deep copy.	7 years ago
Frank Schroeder	7bd85792b2	config: do not clobber multiple check and service definitions ... This patch ensures that multiple files with single 'check' or 'service' definitions result in the combination of them.	7 years ago
James Phillips	a75a779469	Renames `enable_ui` to `ui` to keep compatibility with existing configs.	7 years ago
Frank Schröder	1e461110e6	agent: consolidate handling of 405 Method Not Allowed (#3405) ... * agent: consolidate http method not allowed checks This patch uses the error handling of the http handlers to handle HTTP method not allowed errors across all available endpoints. It also adds a test for testing whether the endpoints respond with the correct status code. * agent: do not panic on metrics tests * agent: drop other tests for MethodNotAllowed * agent: align /agent/join with reality /agent/join uses PUT instead of GET as documented. * agent: align /agent/check/{fail,warn,pass} with reality /agent/check/{fail,warn,pass} uses PUT instead of GET as documented. * fix some tests * Drop more tests for method not allowed * Align TestAgent_RegisterService_InvalidAddress with reality * Changes API client join to use PUT instead of GET. * Fixes agent endpoint verbs and removes obsolete tests. * Updates the change log.	7 years ago
preetapan	73951d8319	Merge pull request #3494 from hashicorp/enforce_json_extension ... Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	45646ac3f4	Bumps default Raft protocol to version 3. (#3477) ... * Changes default Raft protocol to 3. * Changes numPeers() to report only voters. This should have been there before, but it's more obvious that this is incorrect now that we default the Raft protocol to 3, which puts new servers in a read-only state while Autopilot waits for them to become healthy. * Fixes TestLeader_RollRaftServer. * Fixes TestOperator_RaftRemovePeerByAddress. * Fixes TestServer_*. Relaxed the check for a given number of voter peers and instead do a thorough check that all servers see each other in their Raft configurations. * Fixes TestACL_*. These now just check for Raft replication to be set up, and don't care about the number of voter peers. * Fixes TestOperator_Raft_ListPeers. * Fixes TestAutopilot_CleanupDeadServerPeriodic. * Fixes TestCatalog_ListNodes_ConsistentRead_Fail. * Fixes TestLeader_ChangeServerID and adjusts the conn pool to throw away sockets when it sees io.EOF. * Changes version to 1.0.0 in the options doc. * Makes metrics test more deterministic with autopilot metrics possible.	7 years ago
Preetha Appan	a286ad7533	Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	f42e85ce22	Removes unused imports in agent_test.go.	7 years ago
Preetha Appan	d7e27e67c1	Introduce Code Policy validation via sentinel, with a noop implementation	7 years ago
Frank Schröder	12216583a1	New config parser, HCL support, multiple bind addrs (#3480) ... * new config parser for agent This patch implements a new config parser for the consul agent which makes the following changes to the previous implementation: * add HCL support * all configuration fragments in tests and for default config are expressed as HCL fragments * HCL fragments can be provided on the command line so that they can eventually replace the command line flags. * HCL/JSON fragments are parsed into a temporary Config structure which can be merged using reflection (all values are pointers). The existing merge logic of overwrite for values and append for slices has been preserved. * A single builder process generates a typed runtime configuration for the agent. The new implementation is more strict and fails in the builder process if no valid runtime configuration can be generated. Therefore, additional validations in other parts of the code should be removed. The builder also pre-computes all required network addresses so that no address/port magic should be required where the configuration is used and should therefore be removed. * Upgrade github.com/hashicorp/hcl to support int64 * improve error messages * fix directory permission test * Fix rtt test * Fix ForceLeave test * Skip performance test for now until we know what to do * Update github.com/hashicorp/memberlist to update log prefix * Make memberlist use the default logger * improve config error handling * do not fail on non-existing data-dir * experiment with non-uniform timeouts to get a handle on stalled leader elections * Run tests for packages separately to eliminate the spurious port conflicts * refactor private address detection and unify approach for ipv4 and ipv6. Fixes #2825 * do not allow unix sockets for DNS * improve bind and advertise addr error handling * go through builder using test coverage * minimal update to the docs * more coverage tests fixed * more tests * fix makefile * cleanup * fix port conflicts with external port server 'porter' * stop test server on error * do not run api test that change global ENV concurrently with the other tests * Run remaining api tests concurrently * no need for retry with the port number service * monkey patch race condition in go-sockaddr until we understand why that fails * monkey patch hcl decoder race condidtion until we understand why that fails * monkey patch spurious errors in strings.EqualFold from here * add test for hcl decoder race condition. Run with go test -parallel 128 * Increase timeout again * cleanup * don't log port allocations by default * use base command arg parsing to format help output properly * handle -dc deprecation case in Build * switch autopilot.max_trailing_logs to int * remove duplicate test case * remove unused methods * remove comments about flag/config value inconsistencies * switch got and want around since the error message was misleading. * Removes a stray debug log. * Removes a stray newline in imports. * Fixes TestACL_Version8. * Runs go fmt. * Adds a default case for unknown address types. * Reoders and reformats some imports. * Adds some comments and fixes typos. * Reorders imports. * add unix socket support for dns later * drop all deprecated flags and arguments * fix wrong field name * remove stray node-id file * drop unnecessary patch section in test * drop duplicate test * add test for LeaveOnTerm and SkipLeaveOnInt in client mode * drop "bla" and add clarifying comment for the test * split up tests to support enterprise/non-enterprise tests * drop raft multiplier and derive values during build phase * sanitize runtime config reflectively and add test * detect invalid config fields * fix tests with invalid config fields * use different values for wan sanitiziation test * drop recursor in favor of recursors * allow dns_config.udp_answer_limit to be zero * make sure tests run on machines with multiple ips * Fix failing tests in a few more places by providing a bind address in the test * Gets rid of skipped TestAgent_CheckPerformanceSettings and adds case for builder. * Add porter to server_test.go to make tests there less flaky * go fmt	7 years ago
James Phillips	d84c0b1a01	Robustifies check in TestCatalog_ListNodes_ConsistentRead_Fail test. ... Fixes #3469	7 years ago
James Phillips	828be5771a	Revert "Manages segments list via a pointer." ... This reverts commit c277a42504.	7 years ago
James Phillips	c277a42504	Manages segments list via a pointer.	7 years ago
James Phillips	96a89a3381	Cleans up formatting.	7 years ago
James Phillips	00605c0214	Shows the segment name in the keyring API and command output.	7 years ago
James Phillips	aa5ef4a098	Populates the segment keyrings based on the LAN keyring.	7 years ago
James Phillips	88a150cee1	Moves reconcile loop into segment stub.	7 years ago
James Phillips	5c03cb571d	Takes the skip out of the client check. ... Without this the merge delegate won't check the segment for non-servers a little below here.	7 years ago
James Phillips	3418c7ff93	Merge pull request #3447 from hashicorp/issue-3070 ... Skips unique node ID check for old versions of Consul.	7 years ago
James Phillips	520060e138	Fixes incorrect comment.	7 years ago
James Phillips	084679ab65	Pulls down some code for the check loop.	7 years ago
James Phillips	3535652595	Uses the Raft configuration for the self-add skip check.	7 years ago
Preetha Appan	5f2e1c9b07	Change member join reconcile step to process joining itself, to handle node IP address changes correctly when number of servers < 3	7 years ago
James Phillips	1333fa57a1	Skips unique node ID check for old versions of Consul. ... Fixes #3070.	7 years ago
James Phillips	67b19ac065	Allow _all for WAN as a no-op.	7 years ago
James Phillips	1a117ba0a8	Makes the all segments query explict, and the default for `consul members`.	7 years ago
James Phillips	9258506dab	Adds simple rate limiting for client agent RPC calls to Consul servers. (#3440) ... * Added rate limiting for agent RPC calls. * Initializes the rate limiter based on the config. * Adds the rate limiter into the snapshot RPC path. * Adds unit tests for the RPC rate limiter. * Groups the RPC limit parameters under "limits" in the config. * Adds some documentation about the RPC limiter. * Sends a 429 response when the rate limiter kicks in. * Adds docs for new telemetry. * Makes snapshot telemetry look like RPC telemetry and cleans up comments.	7 years ago
Kyle Havlovitz	220db48aa7	Merge pull request #3431 from hashicorp/network-segments-oss	7 years ago
Kyle Havlovitz	0e33e2ecab	Pass listeners into setupSegments	7 years ago
Kyle Havlovitz	62102a537e	Organize segments for a cleaner split between enterprise and OSS	7 years ago
Kyle Havlovitz	baa501e0c5	Fill in the segment in the QuerySource for prepared query lookups	7 years ago
Kyle Havlovitz	7e565d7338	Fix some inconsistencies with segment logic and comments	7 years ago
Kyle Havlovitz	16aaf27208	Default bind/advertise for segments to BindAddr/AdvertiseAddr	7 years ago
Preetha Appan	2386214655	Wire server provider for raft layer only on protocol version 3 and above, and update changelog	7 years ago
Kyle Havlovitz	21513b0393	Update coord display in ui to account for segments	7 years ago
Kyle Havlovitz	14b027a3c2	Add segment addr field to tags for LAN flood joiner	7 years ago
Kyle Havlovitz	d129767657	Add agent.segment interpolation to prepared queries	7 years ago
Kyle Havlovitz	2ada0439d4	Add rpc_listener option to segment config	7 years ago
Kyle Havlovitz	a30e7657af	Add segment config validation	7 years ago
James Phillips	b1a15e0c3d	Adds open source side of network segments (feature is Enterprise-only).	7 years ago
Preetha Appan	a231eea0e7	More cleanup from code review	7 years ago
Preetha Appan	c6ee9bfa69	Remove copy pasted duplicate line, update documentation.	7 years ago
Preetha Appan	0f4e24f72c	Consolidate server lookup into one place and replace usages of localConsuls.	7 years ago
Preetha Appan	0f418a1bcf	Remove unused function	7 years ago
Preetha Appan	e639154abd	Remove stray commented line	7 years ago
Preetha Appan	00836a6aab	Remove server address tracking logic from manager/router and maintain it as part of lan event listener instead. Used sync.Map to track this, and added unit tests	7 years ago
Preetha Appan	830aca958a	ServerAddressProvider interface also returns an error now	7 years ago
Preetha Appan	c68fce89b5	Use config struct to create NetworkTransport layer when setting up raft	7 years ago
Preetha Appan	393ce1581b	Implement AddressProvider and wire that up to raft transport layer to support server nodes changing their IP addresses in containerized environments	7 years ago
Frank Schroeder	831d84c940	build: make tests independent of build tags ... When the metadata server is scanning the agents for potential servers it is parsing the version number which the agent provided when it joined. This version number has to conform to a certain format, i.e. 'n.n.n'. Without this version number properly set some tests fail with error messages that disguise the root cause. The default version number is currently set to 'unknown' in version/version.go which does not parse and triggers the tests to fail. The work around is to use a build tag 'consul' which will use the version number set in version_base.go instead which has the correct format and is set to the current release version. In addition, some parts of the code also require the version number to be of a certain value. Setting it to '0.0.0' for example makes some tests pass and others fail since they don't pass the semantic check. When using go build/install/test one has to remember to use '-tags consul' or tests will fail with non-obvious error messages. Using build tags makes the build process more complex and error prone since it prevents the use of the plain go toolchain and - at least in its current form - introduces subtle build and test issues. We should try to eliminate build tags for anything else but platform specific code. This patch removes all references to specific version numbers in the code and tests and sets the default version to '9.9.9' which is syntactically correct and passes the semantic check. This solves the issue of running go build/install/test without tags for the OSS build.	7 years ago
Frank Schroeder	d8195b3a4d	agent: drop status code comments	7 years ago
Frank Schroeder	f09a8bb1b6	agent: use http.StatusRequestEntityTooLarge instead of 413	7 years ago
Frank Schroeder	bc5dc32c1d	agent: use http.StatusInternalServerError instead of 500	7 years ago
Frank Schroeder	fa121be33f	agent: use http.StatusMethodNotAllowed instead of 405	7 years ago
Frank Schroeder	ad5c1d9e72	agent: use http.StatusNotFound instead of 404	7 years ago
Frank Schroeder	1a557ee9e9	agent: use http.StatusForbidden instead of 403	7 years ago
Frank Schroeder	7e2bc1b411	agent: use http.StatusUnauthorized instead of 401	7 years ago
Frank Schroeder	5d1546b052	agent: use http.StatusBadRequest instead of 400	7 years ago
Frank Schroeder	14ab5c7641	agent: support go-discover retry-join for wan	7 years ago
Frank Schröder	a3934c263c	acl: consolidate error handling (#3401) ... The error handling of the ACL code relies on the presence of certain magic error messages. Since the error values are sent via RPC between older and newer consul agents we cannot just replace the magic values with typed errors and switch to type checks since this would break compatibility with older clients. Therefore, this patch moves all magic ACL error messages into the acl package and provides default error values and helper functions which determine the type of error.	7 years ago
Frank Schroeder	16c58da27d	agent: drop unused code ... This code from http://github.com/hashicorp/consul/pull/3353 is no longer required.	7 years ago
Frank Schroeder	bf96857b17	dns: replace nameserver lookup with consistent rpc call ... This patch replaces the code which determines the list of servers in the current cluster with an RPC call to get the list of active consul service instances which only run on servers. This replaces the previous implementation which was more complex and relied on serf messages which can provide a different view than the consistent response from the raft log. As a side effect it makes the implementation independent of the server and the agent which means it works consistently across both. Different behavior for server and agent was the root cause for the bug in http://github.com/hashicorp/consul/issue/3047. Fixes #3407	7 years ago
Frank Schroeder	4052c6d2d2	dns: split node lookup from request handling	7 years ago
Frank Schroeder	d4e3d4344a	dns: refactor label by unrolling loop	7 years ago
Frank Schroeder	70be1ab635	dns: move ttl closer to usage	7 years ago
James Phillips	f51d56c80c	Switches to using a read lock for the agent's RPC dispatcher. ... This prevents RPC calls from getting serialized in this spot. Fixes #3376	7 years ago
Frank Schröder	4b642fed2f	agent: honor deprecated flags for retry-join-{ec2,azure,gce} (#3384)	7 years ago
James Phillips	e8a83bb463	Revert "Return 403 rather than a 404 when acls cause all results to be filter…"	7 years ago
James Phillips	02a87df044	Revert "Ensure that we return a permission denied only if the list of keys/en…"	7 years ago
Preetha Appan	42fb49c00b	Added unit test case to kvs_endpointtest	7 years ago
Preetha Appan	3276891142	Ensure that we return a permission denied only if the list of keys/entries prior to filtering by ACL is non empty	7 years ago
Frank Schroeder	7cff50a4df	agent: move agent/consul/agent to agent/metadata	7 years ago
Frank Schroeder	c395599cea	agent: move agent/consul/servers to agent/router	7 years ago
Frank Schroeder	1acff3533e	agent: move agent/consul/structs to agent/structs	7 years ago
James Phillips	cb618918b3	Cleans up some go fmt issues.	7 years ago
James Phillips	7442039c2d	Fixes a vet error.	7 years ago
Kyle Havlovitz	cf02e3bc22	Merge pull request #3369 from hashicorp/metrics-enhancements ... Add support for labels/filters from go-metrics	7 years ago
Kyle Havlovitz	c1c883f441	Add doc links for metrics endpoint	7 years ago
Kyle Havlovitz	0428e9fe9e	Update docs for metrics endpoint	7 years ago
Frank Schroeder	9fa237ddb6	dns: minor cleanups	7 years ago
Kyle Havlovitz	d5634fe2a8	Add support for labels/filters from go-metrics	7 years ago
Preetha Appan	72ae8c8f33	Go back to using <nodename>.node.dc.consul as the name of the ns record being returned.	7 years ago
Frank Schroeder	8a9653bdf8	dns: keep NS names in consul domain	7 years ago
Frank Schroeder	f17bf78bb1	dns: postmaster -> hostmaster	7 years ago
Frank Schroeder	60608b455d	dns: we do not support zone transfers	7 years ago
Frank Schroeder	76b2538915	dns: drop CNAME for primary name server	7 years ago
Preetha Appan	7f34dc08a5	Added test case with IPV6 bind address for NS records, rewrote tests to use verify library and other code review feedback	7 years ago
Preetha Appan	76319f751d	Added back glue records in NS response, expanded unit test. Also reused same function used in node lookup for adding A/AAAA records in the extra section of the NS response	7 years ago
Preetha Appan	f01f17bda3	Don't add A records for NS requests, because the record being returned already resolves correctly. Also fixed all the unit tests, and ignored hostnames that don't meet valid dns hostname criteria	7 years ago
Frank Schroeder	7ea11c2f45	dns: provide correct SOA and NS responses ... This patch changes the behavior of the DNS server as follows: * The SOA response contains the SOA record in the Answer section instead of the Authority section. It also contains NS records in the Authority and the corresponding A glue records in the Extra section. In addition, CNAMEs are added to the Extra section to make the MNAME of the SOA record resolvable. AAAA glue records are not yet supported. * The NS response returns up to three random servers from the consul cluster in the Answer section and the glue A records in the Extra section. AAAA glue records are not yet supported.	7 years ago
Preetha Appan	824fc4ee20	Unify regex used to identify invalid dns characters	7 years ago
Preetha Appan	37f75a393e	Use sanitized version of node name of server in NS record, and start with "server" rather than "ns"	7 years ago
Preetha Appan	794d1afe44	Removed a copy pasted irrelevant comment, and other code review feedback	7 years ago
Preetha Appan	f9db387097	Add NS records and A records for each server. Constructs ns host names using the advertise address of the server.	7 years ago
James Phillips	4bee2e49f5	Adds secure introduction for the ACL replication token. (#3357) ... Adds secure introduction for the ACL replication token, as well as a separate enable config for ACL replication.	7 years ago
Frank Schroeder	9ffeba18ee	agent: fix code for updated go-discover signature ... Closes #3351	7 years ago
James Phillips	c0a5ad7903	Adds a new /v1/acl/bootstrap API (#3349)	7 years ago
Miguel Prokop	6852dec3f2	agent: Fix script quoting on windows (#1875) ... This patch fixes the quoting for executing scripts on windows and splits the platform dependent code. Fixes #1875	7 years ago
Frank Schroeder	2fac427cd4	agent: use github.com/hashicorp/go-discover ... Replace the provider specific node discovery code with go-discover to support AWS, Azure and GCE. Fixes #3282	7 years ago
Preetha Appan	4076c0d741	Return nil instead of empty list when returning a PermissionDenied error, updated unit test	7 years ago