281 Commits (d5a889c16049822e21204961c4af8f47edf53150)

Author	SHA1	Message	Date
James Phillips	f25c66dfd9	Fixes an XSS issue with unescaped node names. (#3578) ... * Fixes an XSS issue with node names in the tomography graph. * Updates built-in static web assets. * Updates the change log.	7 years ago
James Phillips	c943b1b151	Adds a brief wait and poll period to update check status after a timeout. (#3573) ... * Adds a brief wait and poll period to update the check status if we get stucking waiting for the processes to terminate. Fixes #3570 * Jumps out of timeout case and includes script output.	7 years ago
James Phillips	575d70aaa7	Cleans up some drift between the OSS and Enterprise trees.	7 years ago
Kyle Havlovitz	106b8b0b33	Kill check processes after the timeout is reached (#3567) ... * Kill check processes after the timeout is reached Kill the subprocess spawned by a script check once the timeout is reached. Previously Consul just marked the check critical and left the subprocess around. Fixes #3565. * Set err to non-nil when timeout occurs * Fix check timeout test * Kill entire process subtree on check timeout * Add a docs note about windows subprocess termination	7 years ago
Frank Schroeder	6780964eb8	config: remove redundant code	7 years ago
Frank Schroeder	0faff32c73	config: fix check for segment.port <= 0 and add test	7 years ago
James Phillips	16eb2ef014	Adds check to make sure port is given so we avoid a nil bind address.	7 years ago
James Phillips	e6c50f4a71	Removes obsolete segment stub.	7 years ago
Frank Schröder	94f58199b1	agent: add option to discard health output (#3562) ... * agent: add option to discard health output In high volatile environments consul will have checks with "noisy" output which changes every time even though the status does not change. Since the output is stored in the raft log every health check update unblocks a blocking call on health checks since the raft index has changed even though the status of the health checks may not have changed at all. By discarding the output of the health checks the users can choose a different tradeoff. Less visibility on why a check failed in exchange for a reduced change rate on the raft log. * agent: discard output also when adding a check * agent: add test for discard check output * agent: update docs * go vet * Adds discard_check_output to reloadable config table. * Updates the change log.	7 years ago
preetapan	77c972f594	Fixes agent error handling when check definition is invalid. Distingu… (#3560) ... * Fixes agent error handling when check definition is invalid. Distinguishes between empty checks vs invalid checks * Made CheckTypes return Checks from service definition struct rather than a new copy, and other changes from code review. This also errors when json payload contains empty structs * Simplify and improve validate method, and make sure that CheckTypes always returns a new copy of validated check definitions * Tweaks some small style things and error messages. * Updates the change log.	7 years ago
Frank Schröder	759ef8a1d4	config: add generic method to translate between CamelCase and snake_case (#3557) ... * doc: document discrepancy between id and CheckID * doc: document enable_tag_override change * config: add TranslateKeys helper TranslateKeys makes it easier to map between different representations of internal structures. It allows to recursively map alias keys to canonical keys in structured maps. * config: use TranslateKeys for config file This also adds support for 'enabletagoverride' and removes the need for a separate CheckID alias field. * config: remove dead code * agent: use TranslateKeys for FixupCheckType * agent: translate enable_tag_override during service registration * doc: add '.hcl' as valid extension * config: map ScriptArgs to args * config: add comment for TranslateKeys	7 years ago
James Phillips	bb12368eac	Makes RPC handling more robust when rolling servers. (#3561) ... * Adds client-side retry for no leader errors. This paves over the case where the client was connected to the leader when it loses leadership. * Adds a configurable server RPC drain time and a fail-fast path for RPCs. When a server leaves it gets removed from the Raft configuration, so it will never know who the new leader server ends up being. Without this we'd be doomed to wait out the RPC hold timeout and then fail. This makes things fail a little quicker while a sever is draining, and since we added a client retry AND since the server doing this has already shut down and left the Serf LAN, clients should retry against some other server. * Makes the RPC hold timeout configurable. * Reorders struct members. * Sets the RPC hold timeout default for test servers. * Bumps the leave drain time up to 5 seconds. * Robustifies retries with a simpler client-side RPC hold. * Reverts untended delete.	7 years ago
Preetha Appan	e7dc345cfa	Fix unit test after dns library upgrade to account for correct data length	7 years ago
James Phillips	4dab70cb93	Fixes handling of stop channel and failed barrier attempts. (#3546) ... * Fixes handling of stop channel and failed barrier attempts. There were two issues here. First, we needed to not exit when there was a timeout trying to write the barrier, because Raft might not step down, so we'd be left as the leader but having run all the step down actions. Second, we didn't close over the stopCh correctly, so it was possible to nil that out and have the leaderLoop never exit. We close over it properly AND sequence the nil-ing of it AFTER the leaderLoop exits for good measure, so the code is more robust. Fixes #3545 * Cleans up based on code review feedback. * Tweaks comments. * Renames variables and removes comments.	7 years ago
Victor Boivie	8e361beb7a	Minor typo (boostrap)	7 years ago
James Phillips	3bc6df5f0e	Adds script warning and fixes Docker args recognition.	7 years ago
Kyle Havlovitz	adf29675f3	Merge pull request #3535 from hashicorp/metric-docs ... Update metric names and add a legacy config flag	7 years ago
Kyle Havlovitz	a3e9ac5840	Add a test for legacy metrics with a whitelist filter	7 years ago
Kyle Havlovitz	198ed6076d	Clean up subprocess handling and make shell use optional (#3509) ... * Clean up handling of subprocesses and make using a shell optional * Update docs for subprocess changes * Fix tests for new subprocess behavior * More cleanup of subprocesses * Minor adjustments and cleanup for subprocess logic * Makes the watch handler reload test use the new path. * Adds check tests for new args path, and updates existing tests to use new path. * Adds support for script args in Docker checks. * Fixes the sanitize unit test. * Adds panic for unknown watch type, and reverts back to Run(). * Adds shell option back to consul lock command. * Adds shell option back to consul exec command. * Adds shell back into consul watch command. * Refactors signal forwarding and makes Windows-friendly. * Adds a clarifying comment. * Changes error wording to a warning. * Scopes signals to interrupt and kill. This avoids us trying to send SIGCHILD to the dead process. * Adds an error for shell=false for consul exec. * Adds notes about the deprecated script and handler fields. * De-nests an if statement.	7 years ago
Kyle Havlovitz	c728564994	Update metric names and add a legacy config flag	7 years ago
Frank Schröder	ce887a0c45	Provide stable config for agent/self (#3532) ... * config: provide stable config for /v1/agent/self (#3530) This patch adds a stable subset of the previous Config struct to the agent/self response. The actual runtime configuration is moved into DebugConfig and will be documented to change. Fixes #3530 * config: fix tests * doc: update api documentation for /v1/agent/self	7 years ago
James Phillips	4f2dccc2a9	Merge pull request #3531 from hashicorp/pr-3521-slackpad ... ui: Use monospace font for textarea controls.	7 years ago
James Phillips	b34d576193	Updates checked in web assets to pick up CSS change. ... Closes #3521	7 years ago
Preetha Appan	8dcd7e700c	Remove extra newline	7 years ago
Preetha Appan	26accb3b8a	Only allow 'list' policies within 'key' policy definitions. Consolidated two similar tests into one and fixed alignment.	7 years ago
Preetha Appan	51a04ec87d	Introduces new 'list' permission that applies to KV store recursive reads, and enforced only when opted in.	7 years ago
Frank Schroeder	1944218492	use ports from derived addresses	7 years ago
Frank Schroeder	42f8ff7b3c	config: drop advertise_addrs ... Fixes #3516	7 years ago
Frank Schroeder	abe41d231c	Fix tests after config refactor	7 years ago
Patrick Sodré	7501331d13	Implement encodeKVasRFC1464 function	7 years ago
Patrick Sodré	2cc6ac542c	Add RFC1464 tests	7 years ago
Patrick Sodré	865f087ec9	Turn encodeKVasRFC1464 into a plain function	7 years ago
Patrick Sodré	12fb0bfd5b	Use verify for NodeLookup CNAME, and TXT tests	7 years ago
Patrick Sodré	d5e3b9d843	Refactor formatTxtRecords as encodeKVasRFC1464 ... - Move the logic of rfc1035 out of the encoding function - Left basic version of encodingKV as 'k=v'	7 years ago
Patrick Sodré	655c89ee10	Fix editorial suggestions	7 years ago
Patrick Sodré	afb0c92334	Remove redundant check of Node.Meta size	7 years ago
Patrick Sodré	53e812e759	Return Node.Meta info using the DNS interface	7 years ago
Patrick Sodré	ab90865865	Add test for NoteLookup ANY request	7 years ago
Patrick Sodré	4c6b8022c2	Add test for querying Node.Meta with DNS TXT ... - Lookup TXT records using recursive lookups - Expect TXT record equal to value if key starts with rfc1035- - Expect TXT record in rfc1464 otherwise, i.e. (k=v) ref #2709	7 years ago
Frank Schröder	07dea89f31	fail early when advertise addr is set to ANY (#3507)	7 years ago
Frank Schröder	9a67556bb5	only detect advertise address if derived value is any (#3506) ... * only detect advertise address if derived value is any * determine detect function only when advertise addr is any	7 years ago
James Phillips	98850322c0	Adds a comment about Datacenter and NodeName being stable interfaces ... in the runtime config strucutre.	7 years ago
Frank Schröder	21118cafeb	Recursive sanitize (#3505) ... * vendor: add github.com/sergi/go-diff/diffmatchpatch for diff'ing test output * config: refactor Sanitize to recursively clean runtime config and format complex fields * Removes an extra int cast. * Adds a top-level check test case for sanitization.	7 years ago
James Phillips	0190c4a081	Gets rid of flaky clause in stats fetcher unit test. ... Given how the rutine is coded we can still get data so this wasn't a reliable thing to check.	7 years ago
preetapan	4d9fc638b4	Issue 3452 (#3500) ... * Make sure that id and address are set in member created during reaping of catalog nodes that have been removed from serf * Get address from node table in the state store rather than from service address * Fix incorrect lookup by checkname instead of node name * Make sure that serverlookup is called with the right address format, added unit test. * Address code review comments * Tweaks style stuff.	7 years ago
Frank Schröder	e84c2b2edd	Metrics service prefix (#3498) ... * metrics: replace statsite_prefix with service_prefix The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293 * Updates docs and sorts telemetry section. * Renames to "metrics_prefix" to disambiguate with Consul services. * Updates the change log.	7 years ago
James Phillips	49058fee11	Merge pull request #3501 from hashicorp/snapshot-test-hang ... Cleans up some edge cases in TestSnapshot_Forward_Leader.	7 years ago
James Phillips	5fa2322e0b	Cleans up some edge cases in TestSnapshot_Forward_Leader. ... These could cause the tests to hang.	7 years ago
Kyle Havlovitz	bfa70a10ca	Fix watch error when http & https are disabled (#3493) ... Remove an error in watch reloading that happens when http and https are both disabled, and use an https address for running watches if no http addresses are present. Fixes #3425.	7 years ago
Preetha Appan	3c4a108769	Move Raft protocol version for list peers end point to server side, fix unit tests. This fixes #3449	7 years ago