277 Commits (d189047ac3f6509dc83b85bb7f9aa20f0390c550)

Author	SHA1	Message	Date
John Cowen	21732d57a8	ui: Closes the proxy blocking query for the service instance on dereg (#5667) ... If a service instance show page is being viewed and the service instance is deregistered, this closes the blocking query for the proxy as well as the instance (the instances query will be clsed on the error) Also adds skipped tests to nag in future	6 years ago
John Cowen	e5d59f1dd3	ui: Fixes RTT display, by ensuring use of ember proxies in tomography (#5666) ... Previously the tomography wasn't using ember `get` so proxy updates (specifically here whilst receiving a blocking update) wasn't working. This adds `get` here until we update to newer `get`less ember and also refactors slightly removing `n` and using `distance.length` instead Skipped tests are adding here to nag us to come back here at some point.	6 years ago
John Cowen	6474cec99c	ui: Alter resizing for tabular-collection for sizing based on rows (#5586)	6 years ago
John Cowen	cbded4a10a	ui: Improvements to modal-dialog (#5585) ... 1. If the modal gets bigger than 80% of the viewport height a scrollbar will be shown. Currently there isn't anywhere it can get this big, but future work involves possible larger modals 2. Usually its difficult to figure out which was the 'unchecked' radio button using an onchange event. Luckily ember/handlebars changes its properties after the onchange event, so knowing that and using an extra data-checked attribute set via ember, we can figure out which radio button has been 'unchecked'. This means the logic for opening an closing modals becomes slightly easier	6 years ago
John Cowen	417d3030be	ui: Adds uid to tabular-details for/id's used in toggling for uniqueness (#5584)	6 years ago
John Cowen	255528aaa7	ui: Adds _super in places where it had been missed (mainly dom-buffer) (#5583)	6 years ago
John Cowen	a7c479e073	ui: Increases the pause between blocking queries to 2000ms (#5582) ... ...also: Temporarily overwrites native setTimeout and setInterval for e2e/acceptance testing similar to how XHR is overwritten for e2e/acceptance testing. This makes the blocking query acceptance tests run faster until we add a better burstable rate limiter for blocking queries.	6 years ago
John Cowen	4a9d259304	ui: Remove index.html from the docs URL so we just point to `/docs` (#5547)	6 years ago
John Cowen	a14a37a078	UI: Add support for blocking queries on the service instance detail page (#5487) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that. Also: Add support for blocking queries on the service instance detail page 1. Previous we could return undefined when a service instance has no proxy, but this means we have nothing to attach `meta` to. We've changed this to return an almost empty object, so with only a meta property. At first glance there doesn't seem to be any way to provide a proxy object to templates and be able to detect whether it is actually null or not so we instead change some conditional logic in the templates to detect the property we are using to generate the anchor. 2. Made a `pauseUntil` test helper function for steps where we wait for things. This helps for DRYness but also means if we can move away from setInterval to something else later, we can do it in one place 3. Whilst running into point 1 here, we managed to make the blocking queries eternally loop. Whilst this is due to an error in the code and shouldn't ever happen whilst in actual use, we've added an extra check so that we only recur/loop the blocking query if the previous response has a `meta.cursor` Adds support for blocking queries on the node detail page (#5489) 1. Moves data re-shaping for the templates variables into a repository so they are easily covered by blocking queries (into coordinatesRepo) 2. The node API returns a 404 as signal for deregistration, we also close the sessions and coordinates blocking queries when this happens	6 years ago
John Cowen	9daf8f53d9	ui: Adds blocking query support to the service detail page (#5479) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that.	6 years ago
John Cowen	e2df5de795	UI: Add blocking cursor validation and more straightforward throttle (#5470) ... More recommendations for blocking queries clients was added here: https://github.com/hashicorp/consul/pull/5358 This commit mainly adds cursor/index validation/correction based on these recommendations (plus tests) The recommendations also suggest that clients should include rate limiting. Because of this, we've moved the throttling out of Consul UI specific code and into Blocking Query specific code. Currently the 'rate limiting' in this commit only adds a sleep to every iteration of the loop, which is not the recommended approach, but the code here organizes the throttling functionality into something we can work with later to provide something more apt.	6 years ago
John Cowen	83cd4684c6	UI: Amends blocking queries text and toggle component in settings (#5467)	6 years ago
John Cowen	10c1f29ffa	ui: Add proxy icons to proxy services and instances where appropriate (#5463)	6 years ago
John Cowen	3d76540297	ui: Fix erroneous HTML that was being fixed by either browser/ember (#5530) ... The resulting DOM from this template was actually correct, we'd assume it was being fixed by the browser	6 years ago
John Cowen	5dd9cd2d2e	UI: Add forking based on service instance id existence (#5392) ... * ui: Add forking based on service instance id existence Proxies come in 2 flavours, 'normal' and sidecar. We know when a proxy is a sidecar proxy based on whether a DestinationServiceID is set. LocalServiceAddress and LocalServicePort are only relevant for sidecar proxies. This adds template logic to show different text depending on this information. Additionally adds test around connect proxies (#5418) 1. Adds page object for the instance detail page 2. Adds further scenario steps used in the tests 3. Adds acceptance testing around the instance detail page. Services with proxies and the sidecar proxies and proxies themselves 4. Adds datacenter column for upstreams 5. Fixes bug routing bug for decision as to whether to request proxy information or not	6 years ago
John Cowen	20e1a39aef	ui: remove call to super in setupController (#5383)	6 years ago
John Cowen	11ccea88e1	ui: Amend breakpoints for new numberless filter buttons (#5381)	6 years ago
John Cowen	18b0de2785	UI: Use custom block-slots for changeableset	6 years ago
John Cowen	8f35715e47	UI: Service Numbers (#5348) ... Add totals to some listing views, remove healthcheck totals 1. Adds markup to render totals for Services, Nodes, Intentions and v1 ACLs 2. Removes counts from healthcheck filters, and therefore simplify text, moving the copy to the templates 3. Alter test to reflect the fact that the text of the buttons are no static in the component template rather than a dynamic attribute	6 years ago
John Cowen	355f034822	UI: Service Instances (#5326) ... This gives more prominence to 'Service Instances' as opposed to 'Services'. It also begins to surface Connect related 'nouns' such as 'Proxies' and 'Upstreams' and begins to interconnect them giving more visibility to operators. Various smaller changes: 1. Move healthcheck-status component to healthcheck-output 2. Create a new healthcheck-status component for showing the number of checks plus its icon 3. Create a new healthcheck-info component to group multiple statuses plus a different view if there are no checks 4. Componentize tag-list	6 years ago
John Cowen	cb0c5309c9	UI: Add EventSource ready for implementing blocking queries (#5070) ... - Maintain http headers as JSON-API meta for all API requests (#4946) - Add EventSource ready for implementing blocking queries - EventSource project implementation to enable blocking queries for service and node listings (#5267) - Add setting to enable/disable blocking queries (#5352)	6 years ago
John Cowen	f225da36f1	ui: Correctly rebase own token/no delete change	6 years ago
John Cowen	516610eb0b	ui: Adds XHR connection management to HTTP/1.1 installs (#5083) ... Adds xhr connection managment to http/1.1 installs This includes various things: 1. An object pool to 'acquire', 'release' and 'dispose' of objects, also a 'purge' to completely empty it 2. A `Request` data object, mainly for reasoning about the object better 3. A pseudo http 'client' which doens't actually control the request itself but does help to manage the connections An initializer is used to detect the script element of the consul-ui sourcecode which we use later to sniff the protocol that we are most likely using for API access	6 years ago
John Cowen	4d183ef743	ui: Adds 2 computed utilities, a factory and a purify (#5079) ... 1. The factory is taken from the ember source, but makes it more reusable 2. Purify converts conventional ember `computed` into a pure version This commit only adds new files that could be used further down the line	6 years ago
John Cowen	c71f718bc7	ui: Adds controller lifecycle `reset` hook (#5056)	6 years ago
John Cowen	2920f73ddd	ui: Adds `document` and `viewport` methods to the dom service (#5052) ... `window` and `document` are easily injected anyhow, but this primarily this keeps everything dom related in the same place. Included here are changes to make all ember related objects use the dom service `document` and `viewport` instead of just `document` and `window`. Quote from a previous PR (#4924) which explains the thinking around this: > Now I have all these things in the dom service, it would make sense to get window from there also. I was thinking of making a viewport method, which would be a nice word whether window was a browser window, an iframe (not really a window) like when ember testing, or anything else. To me the viewport is what we are actually talking about here.	6 years ago
John Cowen	ebfddaaace	ui: ember-data AbortError should have a `0` status (#5048)	6 years ago
John Cowen	bf50beff42	ui: Prefer `cursor` over `index`, add `configuration` option to repos (#5042)	6 years ago
John Cowen	338527cc2e	ui: Adds better error passthrough, disable/unauthorize properly on error (#5041) ... 1. Ensure any unexpected developer errors are passed through/shown 2. Previously when errors where returns/resolved the special isEnabled/isAuthorized would never get resolved. This was fine as they were set to false to start with anyway, but this resolves them again to false for completeness 3. Improved unit testing coverage	6 years ago
John Cowen	23a236ae95	ui: Adds warning flash messages (yellow with warning icon) (#5033)	6 years ago
John Cowen	acd121f988	ui: Rename extended Component variables, tweak some comments (#5021)	6 years ago
John Cowen	845081e871	ui: Resolve bad rebase and add in KV test for change of GET for KVs (#5000)	6 years ago
John Cowen	7fc59af7e2	ui: Pass GET data and clean certain values for KV's ensuring consistency (#4991)	6 years ago
John Cowen	f7d2651ac3	ui: Maintain http headers as JSON-API meta for all API requests (#4946)	6 years ago
John Cowen	9ec7f3851b	UI: Use buttons instead of anchors where appropriate (#4939) ... Use buttons instead of anchors where appropriate	6 years ago
John Cowen	3780622df0	ui: Move intention source/destination menus use text from the template (#4938)	6 years ago
John Cowen	4368040a4a	UI: Move legacy ACLs, KVs and Intentions to use `form` functionality (#4936) ... Change legacy acls, kvs and intentions to use `form`s	6 years ago
John Cowen	104e6bac71	UI: Move legacy ACLs to use the new searchables/changeable-sets (#4933)	6 years ago
John Cowen	c532e53d9a	UI: dom usage refactoring (#4924) ... Move all the dom-things to use the dom service in tabular-collection, feedback-dialog, list-collection and node show. Move get-component-factory into utils/dom and use dom.root() in a few more places This includes an additional `dom.components` method which gives you a list of components matching the selector instead of just one.	6 years ago
John Cowen	d46b059673	UI: CSS Refactor (#4919) ... - Adds full set of svg icons as CSS/Sass variables to the source - Starts picking out some frame-grays, whilst commenting in possibles - Remove color prefixing The prefixes `ui-` and `brand-` for colors hav been removed. This makes colors slightly easier to type. In order to differentiate between brand colors and 'normal' colors, normal colors are named as 'true colors' i.e. blue, red, green etc etc whereas the brand colors used a more premium sounding name such as 'steel' for vault gray, 'magenta' for consul, 'cobalt' for vagrant etc etc.	6 years ago
John Cowen	d6c1b9ed3f	ui: Move ACL policy and token repos to use the RepositoryService (#4867)	6 years ago
John Cowen	c9fae76b7d	ui: Refactors the code-mirror linting/restrict legacy tokens to HCL (#4866)	6 years ago
John Cowen	65ef2969c7	ui: Async Search (#4859) ... This does several things to make improving the search experience easier moving forwards: 1. Separate searching off from filtering. 'Searching' can be thought of as specifically 'text searching' whilst filtering is more of a boolean/flag search. 2. Decouple the actual searching functionality to almost pure, isolated / unit testable units and unit test. (I still import embers get which, once I upgrade to 3.5, I shouldn't need) 3. Searching rules are now configurable from the outside, i.e. not wrapped in Controllers or Components. 4. General searching itself now can use an asynchronous approach based on events. This prepares for future possibilities of handing off the searching to a web worker or elsewhere, which should aid in large scale searching and prepares the way for other searching methods. 5. Adds the possibility of have multiple searches in one template/route/page. Additionally, this adds a WithSearching mixin to aid linking the searching to ember in an ember-like way in a single place. Plus a WithListeners mixin to aid with cleaning up of event listeners on Controller/Component destruction. Post-initial work I slightly changed the API of create listeners: Returning the handler from a `remover` means you can re-add it again if you want to, this avoids having to save a reference to the handler elsewhere to do the same. The `remove` method itself now returns an array of handlers, again you might want to use these again or something, and its also more useful then just returning an empty array. The more I look at this the more I doubt that you'll ever use `remove` to remove individual handlers, you may aswell just use the `remover` returned from add. I've added some comments to reflect this, but they'll likely be removed once I'm absolutely sure of this. I also added some comments for WithSearching to explain possible further work re: moving `searchParams` so it can be `hung` off the controller object	6 years ago
John Cowen	ae71d6ce96	ui: Custom version of ember-block-slots compatible with ember 3 (#5245) ... The original version of ember-block-slots doesn't support ember 3 and it seems like development has stalled on the original version. This adds a modified version as an in-repo-addon that is compatible with ember 3.	6 years ago
John Cowen	a35fe7c5ba	ui: Removes delete button form pages that show your current token (#5241) ... Tokens can no longer delete themselves see: https://github.com/hashicorp/consul/pull/5210 ...so we remove the button to allow you to do that from the UI	6 years ago
John Cowen	c8386ec0cc	UI: [BUGFIX] Decode/encode urls (#5206) ... In 858b05fc31 (diff-46ef88aa04507fb9b039344277531584) we removed encoding values in pathnames as we thought they were eventually being encoded by `ember`. It looks like this isn't the case. Turns out sometimes they are encoded sometimes they aren't. It's complicated. If at all possible refer to the PR https://github.com/hashicorp/consul/pull/5206. It's related to the difference between `dynamic` routes and `wildcard` routes. Partly related to this is a decision on whether we urlencode the slashes within service names or not. Whilst historically we haven't done this, we feel its a good time to change this behaviour, so we'll also be changing services to use dynamic routes instead of wildcard routes. So service links will then look like /ui/dc-1/services/application%2Fservice rather than /ui/dc-1/services/application/service Here, we define our routes in a declarative format (for the moment at least JSON) outside of Router.map, and loop through this within Router.map to set all our routes using the standard this.route method. We essentially configure our Router from the outside. As this configuration is now done declaratively outside of Router.map we can also make this data available to href-to and paramsFor, allowing us to detect wildcard routes and therefore apply urlencoding/decoding. Where I mention 'conditionally' below, this is detection is what is used for the decision. We conditionally add url encoding to the `{{href-to}}` helper/addon. The reasoning here is, if we are asking for a 'href/url' then whatever we receive back should always be urlencoded. We've done this by reusing as much code from the original `ember-href-to` addon as possible, after this change every call to the `{{href-to}}` helper will be urlencoded. As all links using `{{href-to}}` are now properly urlencoded. We also need to decode them in the correct place 'on the other end', so.. We also override the default `Route.paramsFor` method to conditionally decode all params before passing them to the `Route.model` hook. Lastly (the revert), as we almost consistently use url params to construct API calls, we make sure we re-encode any slugs that have been passed in by the user/developer. The original API for the `createURL` function was to allow you to pass values that didn't need encoding, values that **did** need encoding, followed by query params (which again require url encoding) All in all this should make the entire ember app url encode/decode safe.	6 years ago
John Cowen	66c139ceae	UI: Text change and clarity Node Health > Health Checks (#5115) ... Text change Node Health > Health Checks Also adds an info icon and tooltip to Health Checks column header	6 years ago
Jihoon Chung	d5e28bda56	ui: Fix typo in acl-migration guide link (#5135)	6 years ago
John Cowen	8433b26b78	ui: Correctly escape an inline svg icon (#5032)	6 years ago
John Cowen	7ecbb63102	ui: Add AWS external-source icon (#5030)	6 years ago
John Cowen	9c11109db4	ui: If a service has no external-source, don't show the icon (#4996)	6 years ago
John Cowen	c6db97b666	UI: Removes success notification on faking a success response for `self` (#4906) ... In order to continue supporting the legacy ACL system, we replace the 500 error from a non-existent `self` endpoint with a response of a `null` `AccessorID` - which makes sense (a null AccessorID means old API) We then redirect the user to the old ACL pages which then gives a 403 if their token was wrong which then redirects them back to the login page. Due to the multiple redirects and not wanting to test the validity of the token before redirecting (thus calling the same API endpoint twice), it is not straightforwards to turn the 'faked' response from the `self` endpoint into an error (flash messages are 'lost' through multiple redirects). In order to make this a slightly better experience, you can now return a `false` during execution of an action requiring success/failure feedback, this essentially skips the notification, so if the action is 'successful' but you don't want to show the notification, you can. This resolves showing a successful notification when the `self` endpoint response is faked. The last part of the puzzle is to make sure that the global 403 catching error in the application Route also produces an erroneous notification. Please note this can only happen with a ui client using the new ACL system when communicating with a cluster using the old ACL system, and only when you enter the wrong token. Lastly, further acceptance tests have been added around this This commit also adds functionality to avoid any possible double notification messages, to avoid UI overlapping	6 years ago
John Cowen	7ddafc45d9	ui: Make empty Rules ('') take priority over a `Legacy: true` (#4899) ... Even if an old style token has a Legacy of true, yet it has an empty set of Rules, treat the token as a new style token, as its essentially the same	6 years ago
John Cowen	f65f001675	UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) ... In some circumstances a consul 1.4 client could be running in an un-upgraded 1.3 or lower cluster. Currently this gives a 500 error on the new ACL token endpoint. Here we catch this specific 500 error/message and set the users AccessorID to null. Elsewhere in the frontend we use this fact (AccessorID being null) to decide whether to present the legacy or the new ACL UI to the user. Also: - Re-adds in most of the old style ACL acceptance tests, now that we are keeping the old style UI - Restricts code editors to HCL only mode for all `Rules` editing (legacy/'half legacy'/new style) - Adds a [Stop using] button to the old style ACL rows so its possible to logout. - Updates copy and documentation links for the upgrade notices	6 years ago
John Cowen	de6644675d	ui: Brings the new ACLs into line with the new repo folder structure (#4857) ... This PR updates the folder structure and naming of the new ACLs, the same as #4694 .	6 years ago
John Cowen	f1246801b1	ui: Some trivial test additions, support env var passing of port numbers (#4728) ... 1. Unskip some trivial tests that were being tested higher up 2. Istanbul ignore some code for coverage. 1. Things that I didn't write and need to 100% follow 2. The source code checking test that has Istanbul code injected into it 3. Add a few simple test cases 4. Support passing port numbers through to `ember serve` and `ember test` for use cases that would benefit from being able to configure the ports things are served over but still use `yarn run` thus reusing the `yarn run` config in `package.json`	6 years ago
John Cowen	14aa90e309	ui: Move repo services to repository/ folder and standardize naming (#4694) ... Repositories are a class of services to help with CRUD actions, most of the functionality is reused across various Models. This creates a new repository service that centralizes all this reused functionality. Inheritance via ember `Service.extend` is used as opposed to decorating via Mixins. 1. Move all repository services (and their tests) to a services/repository folder 2. Standardize on a singular name format 'node vs nodes' 3. Create a new 'repository' service to centralize functionality. This should be extended by 'repository' services	6 years ago
John Cowen	d98c1242dc	ui: Adds multi syntax linting to the code editor (#4814)	6 years ago
John Cowen	7d89e519a2	UI: New ACLs (#4789) ... UI to accompany the new ACLs APIs	6 years ago
John Cowen	297788408b	ui: Fix freetext searching within the nodes page (#4819) ... Essentially this was missing a call to `super`. The error unfortuantely didn't arise in the tests as it only errors when the node list has 4 items are more (the 4 columns), and the acceptence tests by change were only filling the page with 3 nodes for test purposes. I've bumped the amount of nodes up to 4 in the tests, which then causes the tests to fail, made the fix by adding the `super` call, and the tests now pass. I also tested the UI/text searching on a 10,000 node system, and everything now works as expected.	6 years ago
John Cowen	5f39bfd161	ui: Improve layout of node cards on large and small screens (#4761) ... 1. The grid based unhealthy cards are now clamped to only four wide maximum. This means that on larger screen the cards are much wider meaning you can view more information. Grid gutters are also clamped at a certain ideal width screen, remaining responsive for anything below this. 2. The healthy node columns are finally responsive following the same column rules as unhealthy nodes	6 years ago
John Cowen	461db096ed	ui: Add truncation to the `.Address` (#4760)	6 years ago
John Cowen	b75731aaec	ui: Cope with service names that contain slashes (#4756)	6 years ago
John Cowen	3410f5955a	ui: Reduce the breakpoint at which the smaller footer kicks in (#4723)	6 years ago
John Cowen	8ba1c549a9	ui: Move the text encoding polyfill to a a proper detecting polyfill (#4767)	6 years ago
John Cowen	9da8ad8f3d	UI: Package upgrades (#4740) ... Upgrade all patch and minor upgradeable packages, also uses `only` in ember-cli-build to reduce the included helpers from certain helper packages. Make some major version upgrades for some dev tools - husky - lint-staged - ember-cli-yadda - ember-cli-sass (also moved from node-sass to dart-sass) Minor tweak: spotted css file (instead of scss file), rename The move to `dart-sass`: dart-sass has been the primary implementation of sass for ~6 months and will receive updates earlier than libsass (ruby-sass itself is now deprecated) Other benefits include not having to recompile (via `npm rebuild` or similar) when switching platforms and an 'almost' javascript based solution. This update also alters some media queries that, whilst wouldn't compile anymore with either an updated libsass or dart-sass, where probably a little over complicated anyway, I've therefore made them similar to other breakpoints that made sense.	6 years ago
John Cowen	99c51c9f86	UI: Reduce in-development deprecations (also use toLocaleString) (#4677) ... Various ember addons produced deprecation messages, some in the browser console and some in terminal. Upgrading and replacing some of these has reduced this. Upgrades: - ember-collection - ember-computed-style Replacements: - ember-pluralize replaced with ember-inflector - ember-cli-format-number replaced with custom helper using standard `toLocaleString` Removing ember-cli-format-number also meant some further changes related to decimal places in the tomography graph, done using `toFixed` The ExternalSources background-images have also now been escaped correctly preventing in-development `console` warnings. The only deprecation warnings are now from ember-block-slots, only in terminal, making for a better development experience overall, especially now we have an empty browser console Also adds a `callIfType` 'helper util' which is a util specifically for helpers (it conforms to a helper argument signature) to be expanded upon later.	6 years ago
John Cowen	96508e556b	ui: Layout fix. Small padding additions to tables (#4701) ... 1. The 'Services' header need to be knocked ot the right slightly to line up properly with the service name when there are no external source icons. 2. Add a single space between ServiceName and ServiceID on the Node > [Services] tab table.	6 years ago
John Cowen	ece09e300d	UI: Tooltips and feedback-dialogs are the same thing - merge (#4678)	6 years ago
John Cowen	d0405ba8b9	UI: CSS Additions (mainly %frames) (#4623) ... * Move almost everything to use %frames * Fix pill styles of ACL types * Remove horizontal scrollbars from dom recycling scroller component * Make text areas look ok in Firefox * Remove ember-bulma-css * New form elements, break out %toggle * %button design tweaks * %form-element design tweaks * Better hashicorp logo * Small screen CSS improvements (#4624) 1. Reduce header size when there are no breadcrumbs 2. Make the filters toggleable, closed by default 3. Reduce the size of the footer on small screens 4. Hide all non-primary columns for forms 5. Slightly change the layout of various items, mainly buttons within forms 6. Make some confirmation dialogs work vertically on small screens. Guessing we might be better just using native confirmations on small screens	6 years ago
John Cowen	028875a732	UI: Set the CODE view as the default view for editing KV's (#4651) ... Sets the code toggle on the KV edit/create page to be on by default, we figured most people probably prefer this view. Also, previously we forced the KV toggle back to a default setting for every time you visited a KV form page. We've now changed this so that the KV code toggle button acts as a 'global' toggle. So whatever you set it as will be the same for every KV for the lifetime of your 'ember session' If we are to keep this, then consider saving this into localStorage settings or similar, added some thoughts in comments re: this as it's very likely to happen.	6 years ago
John Cowen	f54fd21946	ui: [BUGFIX] Intentions were showing the wrong notification on creation (#4658) ... The error notification was being shown on creation of an intention. This was as a result of #4572 and/or #4572 and has not been included in a release. This includes a fix, plus tests to try to prevent any further regression.	6 years ago
John Cowen	0757a08684	ui: Adds a `default` view helper for providing a default value (#4650) ... If the first value passed to the helper is an empty string or undefined then return the second value	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640) ... 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago
John Cowen	981882d5ff	UI: Bugfix. Remove split view code editor (#4615) ... When adding an auto resizing (heightwise) code editor, the ivy-codemirror plugin seems to do this using more nested divs. This div had a horizontal scroller but couldn't be seen on some platforms (with hidden scrollbars). This commit makes the code editor slightly more usable and more visually correct by removing the scroll bar in this div to stop producing the 'split view look', yet keeping the horizontal scroller at the bottom of the code editor for when you enter code that is wider than the area. A max-width has also been added here to prevent the text area from growing off the side of the page. Another improvement to the code editor here is the addition of a nicer color for hightlighting text selection so its at least visible. Lastly, there was a way you could get the bottom horizontal scrollbar to overlay the code in the editor. This makes sure there is always some space at the bottom of the editor to make sure the code won't be obscured	6 years ago
John Cowen	e5f300dd21	UI: Bugfix. Move to a different TextEncoder/Decoder (#4613) ... 1. The previously used TextEncoder/Decoder (used as a polyfill for browsers that don't have a native version) didn't expose an encoder via CommonJS. Use a different polyfill that exposes both a decoder and an encoder. 2. The feature detection itself was flawed. This does a less error prone detection that ensures native encoding/decoding where available and polyfilled encoding/decoding where not available.	6 years ago
John Cowen	5e987965fa	UI: Bugfix. Fix code toggle in Safari (#4608) ... I'd mistakenly changed the checkbox event to listen to oninput, which works in Chrome and Firefox. Changed this back to onchange as it should be.	6 years ago
John Cowen	40e71f1b91	UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) ... * Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.	6 years ago
John Cowen	b41cad6fdf	UI: CSS refactor (#4430) + Fullscreen Layout (#4435) ... * Begin refactoring CSS into component folders. Moved most components into layout/skin folders, left out a couple of ones I want to think about more. * Adjust grays based on recent Structure changes * Switch to fullscreen layout for lists and detail, left aligned forms (#4435) * Specifically use the 'actions_close' label, not just the :last-child (actions-group) * Replace some non-var-ed colours in vaults code skin, plus prefixing (black and white)	6 years ago
John Cowen	7bb35c4c78	UI: Repo layer integration tests (#4454) (#4563) ... ui: Repo layer integration tests for methods that touch the API Includes a `repo` test helper to make repetitive tasks easier, plus a injectable reporter for sending performance metrics to a centralized metrics system Also noticed somewhere in the ember models that I'd like to improve, but left for the moment to make sure I concentrate on one task at a time, more or less: The tests currently asserts against the existing JSON tree, which doesn't seem to be a very nice tree. The work at hand here is to refactor what is there, so test for the not nice tree to ensure we don't get any regression, and add a skipped test so I can come back here later	6 years ago
John Cowen	1b3d566a7a	UI: Begin unskipping some more trivial tests (#4574) ... WIP Unskip some lower level trivial tests. This is the beginning of work to unskip some of the more trivial tests that I'd skipped a while back (if the thing they are testing broke, they would have failed higher up in other acceptance tests). I'd rather keep the tests, as they do test things in a more isolated manner, and the plan was to always come back and work to unskip them time allowing. I didn't get to far into this work in progress here, but I'd rather merge what I've done all the same and come back at a later date and continue.	6 years ago
John Cowen	4ebd70e6cd	UI: Fixes healthy node listing resize on large portrait screens (#4564) ... 1. Split the resizing functionality of into a separate mixin to be shared across components 2. Add basic integration tests to prove that everything is getting called through out the lifetime of the app. I decided against unit testing as there isn't really any isolated logic to be tested, more checking that things are being called in the correct order etc i.e. the integration is correct. Adds assertion to with-resizing so its obvious to override `resize`	6 years ago
John Cowen	fde41467cf	ui: Adds bottom breathing space on the bottom of forms (#4433)	6 years ago
John Cowen	12811c0844	UI - Refactor Adapter.handleResponse (#4398) ... * Add some tests to check the correct GET API endpoints are called * Refactor adapters 1. Add integration tests for `urlFor...` and majority `handleResponse` methods 2. Refactor out `handleResponse` a little more into single/batch/boolean methods 3. Move setting of the `Datacenter` property into the `handleResponse` method, basically the same place that the uid is being set using the dc parsed form the URL 4. Add some Errors for if you don't pass ids to certain `urlFor` methods	6 years ago
John Cowen	0663bdbe90	Merge pull request #4410 from hashicorp/bugfix/gh-4175-service-ip ... UI - Bugfix: Show Service IP not the Node IP	6 years ago
John Cowen	e7a3235afc	Use `some` for the tags search instead of munging and searching	6 years ago
John Cowen	d510e1e6d3	Add basic searching by tags using the freetext search near-term	6 years ago
John Cowen	1d31bef0a4	Show the Service.IP address instead of the Node.IP address in detail	6 years ago
John Cowen	7202f6e771	Merge pull request #4387 from hashicorp/feature/ui-service-ids ... UI - Show/search by service ids	6 years ago
John Cowen	56d2052345	Merge pull request #4373 from hashicorp/bugfix/gh-4324-kv-trailing-slashes ... UI Bugfix - kv trailing slashes	6 years ago
John Cowen	310a038f87	Show Service.ID's throughout the app, allow searching by Service.ID ... 1. In the Services > Services detail page for both healthy and unhealthy nodes, also add searching by Service.ID here 2. In the Nodes > Node detail > [Services] tab only if its different from the Service name, add searching by Service.ID here	6 years ago
John Cowen	4179afae06	Instead of rewriting the API call, use ember to rewrite the URL ... We now essentially do 2 redirects if you hit a `folder/` 1. If you visit `/ui/dc1/kv/folder/`, `consul` will redirect you to `/ui/dc1/kv/folder` 2. Once redirected to `/ui/dc1/kv/folder` via a 301, use ember/history API to redirect you back to `/ui/dc1/kv/folder/`. Bit long winded, but achieves what we want without having to get stuck into `consul` itself to remove the 301 for the UI	6 years ago
John Cowen	887d4e9dde	If we are indexing or foldering then its going to be folder-like ... ...therefore add a trailing slash to the API call	6 years ago
John Cowen	fb91d05eb4	Don't assume the last item in the healthcheck listing is passing	6 years ago
John Cowen	25477761f7	Merge pull request #4343 from hashicorp/bugfix/gh-4336-update-empty-kv ... UI - Bugfix: Saving empty key/value pairs	6 years ago
John Cowen	c01fb37c46	Don't clone prev, there's no need	6 years ago
John Cowen	67402b3d26	Tests and comments regarding the previous 2 commits	6 years ago
John Cowen	b29546e578	Looking into atob functionality, consequence of Value: null ... The Consul API can pass through `Value: null` which does not get cast to a string by ember-data. This snowballs into problems with `atob` which then tried to decode `null`. There are 2 problems here. 1. `Value` should never be `null` - I've added a removeNull function to shallowly loop though props and remove properties that are `null`, for the moment this is only on single KV JSON responses - therefore `Value` will never be `null` which is the root of the problem 2. `atob` doesn't quite follow the `window.atob` API in that the `window.atob` API casts everything down to a string first, therefore it will try to decode `null` > `'null'` > `crazy unicode thing`. - I've commented in a fix for this, but whilst this shouldn't be causing anymore problems in our UI (now that `Value` is never `null`), I'll uncomment it in another future release. Tests are already written for it which more closely follow `window.atob` but skipped for now (next commit)	6 years ago
John Cowen	6a407a044e	Remove validation for presence of KV values	6 years ago
John Cowen	f85369c375	Add some navigation testing for back buttons and create buttons	6 years ago
John Cowen	649d777714	Acceptance test for using tokens from listing and detail pages	6 years ago
John Cowen	701d6a3a72	Move deleting to a top level feature	6 years ago
John Cowen	e0f7cdb128	Start purifying page objects	6 years ago
John Cowen	e3ce2a8beb	Lock Session invalidation acceptance test	6 years ago
John Cowen	ed286585e9	Add some low hanging intention tests, basically add intentions to others ... 1. There are various things tests that can just have intentions added into them, like filters and such like, add intentions to these 2. Start thinking about being able to negate steps easily, which will lead on to a cleanup of the steps	6 years ago
John Cowen	87a0ad9483	Merge pull request #4331 from hashicorp/feature/hedge-empty-node-ids ... Hedge for when consul sends nodes with an empty ID	6 years ago
John Cowen	b445df39bb	Use html5 oninput instead of onkeyup for native textual inputs ... This enables people to enter things using the mouse to paste for example, plus possible other things. As an aside it also answers my query regarding `fillIn` for testing, nothing needs to be actually _typed_ anymore! Doh	6 years ago
John Cowen	6398fb02c7	Ensure we catch empty ID's for single nodes also ... I don't think this would have a large effect on the UI whichever but best to make sure	6 years ago
John Cowen	a47a0b617f	Hedge for when consul sends nodes with an empty ID	6 years ago
John Cowen	8e7e224f3f	Encode all the hexcodes	7 years ago
mkeeler	6813a99081	Merge remote-tracking branch 'connect/f-connect'	7 years ago
John Cowen	5ac19b164e	Change the appearance of `*` for intention listings ... 1. Use 'All Services (*)' as opposed to '*' 2. Set 'Destination' in teh same bold font as 'Source' 3. Ensure you can search for all services by using '*' or 'All Services (*)'	7 years ago
John Cowen	9f8b87cdda	Check for NOT connect-proxy	7 years ago
John Cowen	cc3d578271	Filter Source and Destination menus by Kind	7 years ago
John Cowen	d61a09ea28	Fix linting typo, caused the selection of future services to break	7 years ago
John Cowen	f600d8fcc9	Move intentions menu item to after ACLs	7 years ago
John Cowen	b0ff68cd7d	Lint	7 years ago
John Cowen	e736b546f8	Icons in the filter bar	7 years ago
John Cowen	f4218b4bea	Validate all the things, all the time	7 years ago
John Cowen	ee3a32d771	More detailed error messages for duplicate intentions	7 years ago
John Cowen	ea3e4a720a	Only offer to create a future service if the name doesn't already exist	7 years ago
John Cowen	50507b34a5	Make sure future services are available when editing intentions	7 years ago
John Cowen	5575455053	Add support for specifying future services and wildcards	7 years ago
John Cowen	55bc45832e	Tie up real endpoints	7 years ago
John Cowen	24f6155efc	Switch to single selects rather than inputs	7 years ago
John Cowen	148621d98e	Have a look at power select for select elements	7 years ago
John Cowen	8023bb9b03	Add intentions actions mixin	7 years ago
John Cowen	9d6b9b7717	Remove SourceType for the moment	7 years ago
John Cowen	b38e5df630	WIP: First draft intentions ... 1. Listing, filtering by action and searching by source name and destination name 2. Edit/Create page, edits ping the API double fine, need to work through creates and deletes 3. Currently uses a `Precedence` intention keyname that doesn't yet exist in the real API	7 years ago
John Cowen	c3e92a236f	WIP: Logger	7 years ago
John Cowen	61e3fa3244	Make sure the dc menu is as useful as possible when things go wrong ... 1. Check the dc's model for both dcs list and the requested dc. 2. If the dc model doesn't exist use and empty array for dcs and a fake dc with the Name 'Error' as we can't even trust what is in the `paramsFor`	7 years ago
John Cowen	fd60f225ec	Merge branch 'master' into feature/ui-node-ports-for-service	7 years ago
John Cowen	b41d19c3c0	Merge pull request #4251 from hashicorp/bugfix/ui-null-tokens ... Ensure a blank/empty token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	30402b51b1	Merge pull request #4253 from hashicorp/feature/ui-clearer-tags ... UI - Clearer tags	7 years ago
John Cowen	3450aa81da	Merge pull request #4259 from hashicorp/feature/failing-ttl-test ... [BUGFIX] UI - Make sure lock session TTLs are shown	7 years ago
John Cowen	2e293f2697	Add a beforeModel hook at dc/index to auto transition to services	7 years ago
John Cowen	abf77b3c74	Merge remote-tracking branch 'shilov/master' into feature/failing-ttl-test	7 years ago
John Cowen	1881ec4824	Add a failing test to show that lock session TTL's are not shown	7 years ago
John Cowen	3f0560d098	Add missing scss file	7 years ago
John Cowen	0ad1d562db	Use the pill styling elsewhere... ... TODO: Probably change the %tag to %pill now I've remembered the word I was looking for!	7 years ago
John Cowen	0f6214d0ce	Make sure token is set to blank if nothing is typed in settings	7 years ago
John Cowen	d2d501a4a4	Add a reusable %tag and use it for the ACL 'tags' ready to use elsewhere	7 years ago
John Cowen	76017b69b5	Make sure the colon doesn't wrap with lots of tags	7 years ago
John Cowen	484f6ccaf2	Add port the service is running on for each node in the service view	7 years ago
John Cowen	8c5416ecaf	Ensure a blank token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	894667b87a	Merge pull request #4247 from hashicorp/feature/acl-sort-by-name ... UI - Sort ACL tokens by name	7 years ago
John Cowen	f960604bb5	Merge pull request #4242 from hashicorp/feature/ui-code-editor-autosizing ... Sets code editor height to be automatic (growable), with a reasonable min height	7 years ago
John Cowen	4d7f15ce34	Merge branch 'master' into bugfix/gh-4203-multi-tags	7 years ago
John Cowen	6949b22d5f	Sort ACL tokens by name	7 years ago
John Cowen	3c02e17fa7	Make sure the body background is white	7 years ago