ui: Move intention source/destination menus use text from the template (#4938)

ui-v2/app/controllers/dc/intentions/edit.js

@@ -1,7 +1,6 @@
 import Controller from '@ember/controller';
 import { inject as service } from '@ember/service';
 import { get, set } from '@ember/object';
-
 export default Controller.extend({
   dom: service('dom'),
   builder: service('form'),
@@ -32,8 +31,8 @@ export default Controller.extend({
     });
   },
   actions: {
-    createNewLabel: function(term) {
-      return `Use a future Consul Service called '${term}'`;
+    createNewLabel: function(template, term) {
+      return template.replace(/{{term}}/g, term);
     },
     isUnique: function(term) {
       return !get(this, 'items').findBy('Name', term);

ui-v2/app/templates/dc/intentions/-form.hbs

@@ -7,7 +7,7 @@
               searchField='Name'
               selected=SourceName
               searchPlaceholder='Type service name'
-              buildSuggestion=(action 'createNewLabel')
+              buildSuggestion=(action 'createNewLabel' "Use a future Consul Service called '{{term}}'")
               showCreateWhen=(action "isUnique")
               oncreate=(action 'change' 'SourceName')
               onchange=(action 'change' 'SourceName') as |service search|
@@ -27,7 +27,7 @@
               searchField='Name'
               selected=DestinationName
               searchPlaceholder='Type service name'
-              buildSuggestion=(action 'createNewLabel')
+              buildSuggestion=(action 'createNewLabel' "Use a future Consul Service called '{{term}}'")
               showCreateWhen=(action "isUnique")
               oncreate=(action 'change' 'DestinationName')
               onchange=(action 'change' 'DestinationName') as |service|