83 Commits (aa1519c9f716f1e1075cfd95de88206fa759fcab)

Author	SHA1	Message	Date
Frank Schroeder	8bb7792799	golint: Drop the unused value from range ... for i, _ := range foo -> for i := range foo	8 years ago
Frank Schroeder	eddb1af603	Remove duplicate constants ... This patch removes duplicate internal copies of constants in the structs package which are also defined in the api package. The api.KVOp type with all its values for the TXN endpoint and the api.HealthXXX constants are now used throughout the codebase. This resulted in some circular dependencies in the testutil package which have been resolved by copying code and constants and moving the WaitForLeader function into a separate testrpc package.	8 years ago
James Phillips	8940d1c3fe	Keeps the service and check tokens around for deregistration. ... We fixed a few related issues while we were in here. We now only let services register checks with a matching token, and we also close out service and check delete operations if the catalog deregister claims it doesn't know about the ID of the service or check being deleted.	8 years ago
James Phillips	6ca0173907	Adds catalog support for node IDs.	8 years ago
Kyle Havlovitz	52d6fd831e	Add support for setting node metadata fields	8 years ago
James Phillips	ca7a243b70	Adds ACL management support to the agent.	8 years ago
James Phillips	0139bbb963	Adds support for a new "acl_agent_token" which is used for internal ... catalog operations.	8 years ago
Kyle Havlovitz	b1760b223e	Improve logging when deregistering a nonexistent service (#2492) ... Log a warning instead of a success message when attempting to deregister a nonexistent service. In Consul 0.8 this can be changed to giving an error outright, but for now we can keep the idempotent delete behavior.	8 years ago
James Phillips	c8ce41f459	Cleans up state management for remote deletes from local state. ... Fixes #2125.	8 years ago
James Phillips	4a3d7db24f	Adds ability to deregister a service based on critical check state longer than a timeout.	8 years ago
Sean Chittenden	e9a2f5b40c	Chase casting types.CheckID to a string into the state_store. ... It turns out the indexer can only use strings as arguments when creating a query. Cast `types.CheckID` to a `string` before calling into `memdb`. Ideally the indexer would be smart enough to do this at compile-time, but I need to look into how to do this without reflection and the runtime package. For the time being statically cast `types.CheckID` to a `string` at the call sites.	9 years ago
Sean Chittenden	63adcbd5ef	Revert "Move `structs.CheckID` to a new top-level package, `types`." ... This reverts commit 2bbd52e3b44ff1b60939a8400264d534662d6d51.	9 years ago
Sean Chittenden	cbb945e76a	Move `structs.CheckID` to a new top-level package, `types`. ... Per discussion w/ @slackpad, move this type to its own top-level package	9 years ago
Sean Chittenden	f5ab25163e	Move `structs.CheckID` to a new top-level package, `types`. ... Per discussion w/ @slackpad, move this type to its own top-level package	9 years ago
Sean Chittenden	ddbe64a8c8	Float a type balloon. Some strings are square pegs in round holes. ... This experiment was brought about because of variable naming confusion where name and checkIDs were interchanged. Gave CheckID an Qualified Type Name and chased downstream changes.	9 years ago
James Phillips	f541acb0ec	Makes a detached copy of the tags when doing the override.	9 years ago
James Phillips	a885f1bdff	Tweaks comment about side effects.	9 years ago
James Phillips	ed86e5cc72	Adds a clone method to HealthCheck and uses that in local.go.	9 years ago
James Phillips	cfe0651208	Syncs a check's output with the catalog when output rate limiting isn't in effect.	9 years ago
James Phillips	56cbabff63	Adds a sanity check to the local node info compare.	9 years ago
James Phillips	4be2ab1a75	Moves tagged wan address to be managed by anti-entropy, not serf.	9 years ago
James Phillips	c60a526fde	Sets up config for more address tags down the road, renames struct members.	9 years ago
Evan Gilman	de8fd561d0	Use a map for additional node addresses	9 years ago
Evan Gilman	496cf5ae73	Implement `translate_wan_addrs` config option ... This knob tells consul whether it should prefer the WAN address (if set) when making service lookups in remote datacenters. This enables reachability for remote services which are behind a NAT.	9 years ago
James Phillips	ed8a71efd7	Store WanAddress during Service/Check sync	9 years ago
Sean Chittenden	7af6a94edb	Factor out duplicate functions into a lib package ... Consolidate code duplication and tests into a single lib package. Most of these functions were from various **/util.go functions that couldn't be imported due to cyclic imports. The consul/lib package is intended to be a terminal node in an import DAG and a place to stash various consul-only helper functions. Pulled in hashicorp/go-uuid instead of consolidating UUID access.	9 years ago
WangFenjin	29c0516d58	Fix typo	9 years ago
James Phillips	d06fc28a0a	Prevents agents from considering Raft information when doing sync checks.	9 years ago
Armon Dadgar	d137a5fa82	agent: remove an N^2 check. See #1265	9 years ago
James Phillips	0b05dbeb21	Merge pull request #1235 from wuub/master ... fix conflict between handleReload and antiEntropy critical sections	9 years ago
Wojciech Bederski	c4537ed26f	panic when unbalanced localState.Resume() is detected	9 years ago
Wojciech Bederski	b014c0f91b	make Pause()/Resume()/isPaused() behave more like a semaphore ... see: https://github.com/hashicorp/consul/issues/1173 #1173 Reasoning: somewhere during consul development Pause()/Resume() and PauseSync()/ResumeSync() were added to protect larger changes to agent's localState. A few of the places that it tries to protect are: - (a *Agent) AddService(...) # part of the method - (c *Command) handleReload(...) # almost the whole method - (l *localState) antiEntropy(...)# isPaused() prevents syncChanges() The main problem is, that in the middle of handleReload(...)'s critical section it indirectly (loadServices()) calls AddService(...). AddService() in turn calls Pause() to protect itself against syncChanges(). At the end of AddService() a defered call to Resume() is made. With the current implementation, this releases isPaused() "lock" in the middle of handleReload() allowing antiEntropy to kick in while configuration reload is still in progress. Specifically almost all services and probably all check are unloaded when syncChanges() is allowed to run. This in turn can causes massive service/check de-/re-registration, and since checks are by default registered in the critical state, a majority of services on a node can be marked as failing. It's made worse with automation, often calling `consul reload` in close proximity on many nodes in the cluster. This change basically turns Pause()/Resume() into P()/V() of a garden-variety semaphore. Allowing Pause() to be called multiple times, and releasing isPaused() only after all matching/defered Resumes() are called as well. TODO/NOTE: as with many semaphore implementations, it might be reasonable to panic() if l.paused ever becomes negative.	9 years ago
Shawn Cook	66fd8fb2a0	Rename EnableTagOverride and update formatting	9 years ago
Shawn Cook	d7ce0b3c6b	Remove debug lines	9 years ago
Shawn Cook	96785edd9a	Add EnableTagDrift logic to command/agent/local.go	9 years ago
Shawn Cook	6a835939b8	EnableTagDrift in NodeService struct	9 years ago
Ryan Uber	739d1fdf03	Merge pull request #891 from hashicorp/f-token ... ACL tokens for service/check registration	10 years ago
Ryan Uber	2b62f2f172	agent: use an additional parameter for passing tokens	10 years ago
Ryan Uber	35f5a65fb7	agent: more tests	10 years ago
Ryan Uber	442933650e	agent: safer read methods for tokens	10 years ago
Ryan Uber	1264f7edf3	agent: fix deadlock reading tokens from state	10 years ago
Ryan Uber	bebb5d9641	agent: add service/check token methods to reduce invasiveness	10 years ago
Ryan Uber	bfb27d18cd	agent: initial pass threading through tokens for services/checks	10 years ago
artushin	cc07734d6e	remove config	10 years ago
artushin	7b4720a957	use existing randomStagger	10 years ago
artushin	8decf5d394	adding check_update_stagger	10 years ago
Ryan Uber	60a6da213f	agent: handle nil node services in anti-entropy	10 years ago
Ryan Uber	7e170b047e	agent: fix anti-entropy check sync	10 years ago
Ryan Uber	a60f4adf95	agent: anti-entropy sync services/checks if they don't exist in the catalog	10 years ago
foostan	2df98c1824	Validation ServiceID/CheckID when deleting in deleteService() in local.go	10 years ago