251 Commits (9f58504f1c4e0dce5e43c72da6ae6dafa09f2849)

Author	SHA1	Message	Date
Paul Banks	dca1303d05	Connect Envoy Command (#4735) ... * Plumb xDS server and proxyxfg into the agent startup * Add `consul connect envoy` command to allow running Envoy as a connect sidecar. * Add test for help tabs; typos and style fixups from review	6 years ago
Paul Banks	e812f5516a	Add -sidecar-for and new /agent/service/:service_id endpoint (#4691) ... - A new endpoint `/v1/agent/service/:service_id` which is a generic way to look up the service for a single instance. The primary value here is that it: - **supports hash-based blocking** and so; - **replaces `/agent/connect/proxy/:proxy_id`** as the mechanism the built-in proxy uses to read its config. - It's not proxy specific and so works for any service. - It has a temporary shim to call through to the existing endpoint to preserve current managed proxy config defaulting behaviour until that is removed entirely (tested). - The built-in proxy now uses the new endpoint exclusively for it's config - The built-in proxy now has a `-sidecar-for` flag that allows the service ID of the _target_ service to be specified, on the condition that there is exactly one "sidecar" proxy (that is one that has `Proxy.DestinationServiceID` set) for the service registered. - Several fixes for edge cases for SidecarService - A fix for `Alias` checks - when running locally they didn't update their state until some external thing updated the target. If the target service has no checks registered as below, then the alias never made it past critical.	6 years ago
Paul Banks	1e7eace066	Add SidecarService Syntax sugar to Service Definition (#4686) ... * Added new Config for SidecarService in ServiceDefinitions. * WIP: all the code needed for SidecarService is written... none of it is tested other than config :). Need API updates too. * Test coverage for the new sidecarServiceFromNodeService method. * Test API registratrion with SidecarService * Recursive Key Translation 🤦 * Add tests for nested sidecar defintion arrays to ensure they are translated correctly * Use dedicated internal state rather than Service Meta for tracking sidecars for deregistration. Add tests for deregistration. * API struct for agent register. No other endpoint should be affected yet. * Additional test cases to cover updates to API registrations	6 years ago
Paul Banks	b06ddc9187	Rename proxy package (re-run of #4550) (#4638) ... * Rename agent/proxy package to reflect that it is limited to managed proxy processes Rationale: we have several other components of the agent that relate to Connect proxies for example the ProxyConfigManager component needed for Envoy work. Those things are pretty separate from the focus of this package so far which is only concerned with managing external proxy processes so it's nota good fit to put code for that in here, yet there is a naming clash if we have other packages related to proxy functionality that are not in the `agent/proxy` package. Happy to bikeshed the name. I started by calling it `managedproxy` but `managedproxy.Manager` is especially unpleasant. `proxyprocess` seems good in that it's more specific about purpose but less clearly connected with the concept of "managed proxies". The names in use are cleaner though e.g. `proxyprocess.Manager`. This rename was completed automatically using golang.org/x/tools/cmd/gomvpkg. Depends on #4541 * Fix missed windows tagged files	6 years ago
Paul Banks	88388d760d	Support Agent Caching for Service Discovery Results (#4541) ... * Add cache types for catalog/services and health/services and basic test that caching works * Support non-blocking cache types with Cache-Control semantics. * Update API docs to include caching info for every endpoint. * Comment updates per PR feedback. * Add note on caching to the 10,000 foot view on the architecture page to make the new data path more clear. * Document prepared query staleness quirk and force all background requests to AllowStale so we can spread service discovery load across servers.	6 years ago
Paul Banks	e8ba527f23	Add a Close method to cache that stops background goroutines. (#4746) ... In a real agent the `cache` instance is alive until the agent shuts down so this is not a real leak in production, however in out test suite, every testAgent that is started and stops leaks goroutines that never get cleaned up which accumulate consuming CPU and memory through subsequent test in the `agent` package which doesn't help our test flakiness. This adds a Close method that doesn't invalidate or clean up the cache, and still allows concurrent blocking queries to run (for up to 10 mins which might still affect tests). But at least it doesn't maintain them forever with background refresh and an expiry watcher routine. It would be nice to cancel any outstanding blocking requests as well when we close but that requires much more invasive surgery right into our RPC protocol since we don't have a way to cancel requests currently. Unscientifically this seems to make tests pass a bit quicker and more reliably locally but I can't really be sure of that!	6 years ago
Hans Hasselberg	8e235a72b4	Allow disabling the HTTP API again. (#4655) ... If you provide an invalid HTTP configuration consul will still start again instead of failing. But if you do so the build-in proxy won't be able to start which you might need for connect.	6 years ago
Pierre Souchay	2fe728c7bd	Ensure that Proxies ARE always cleaned up, event with DeregisterCriticalServiceAfter (#4649) ... This fixes https://github.com/hashicorp/consul/issues/4648	6 years ago
Matt Keeler	cc8327ed9a	Ensure that errors setting up the DNS servers get propagated back to the shell (#4598) ... Fixes: #4578 Prior to this fix if there was an error binding to ports for the DNS servers the error would be swallowed by the gated log writer and never output. This fix propagates the DNS server errors back to the shell with a multierror.	6 years ago
Matt Keeler	e81c85c051	Fix #4515: Segfault when serf_wan port was -1 but reconnect_time_wan was set (#4531) ... Fixes #4515 This just slightly refactors the logic to only attempt to set the serf wan reconnect timeout when the rest of the serf wan settings are configured - thus avoiding a segfault.	6 years ago
Matt Keeler	0e0227792b	Gossip tuneables (#4444) ... Expose a few gossip tuneables for both lan and wan interfaces gossip_nodes gossip_interval probe_timeout probe_interval retransmit_mult suspicion_mult	6 years ago
Mitchell Hashimoto	7fa6bb022f	Merge pull request #4320 from hashicorp/f-alias-check ... Add "Alias" Check Type	6 years ago
Matt Keeler	560c9c26f7	Use the agent logger instead of log module	6 years ago
Matt Keeler	3fe5f566f2	Persist proxies from config files ... Also change how loadProxies works. Now it will load all persisted proxies into a map, then when loading config file proxies will look up the previous proxy token in that map.	6 years ago
Matt Keeler	c891e264ca	Fix issue with choosing a client addr that is 0.0.0.0 or ::	6 years ago
Mitchell Hashimoto	d6ecd97d1d	agent: use the correct ACL token for alias checks	6 years ago
Mitchell Hashimoto	19ced12668	agent: alias checks have no interval	6 years ago
Mitchell Hashimoto	4a67beb734	agent: run alias checks	6 years ago
Paul Banks	9015cd62ab	Merge pull request #4381 from hashicorp/proxy-check-default ... Proxy check default	6 years ago
Matt Keeler	7572ca0f37	Merge pull request #4374 from hashicorp/feature/proxy-env-vars ... Setup managed proxy environment with API client env vars	6 years ago
Paul Banks	bb9a5c703b	Default managed proxy TCP check address sanely when proxy is bound to 0.0.0.0. ... This also provides a mechanism to configure custom address or disable the check entirely from managed proxy config.	6 years ago
Matt Keeler	c54b43bef3	PR Updates ... Proxy now doesn’t need to know anything about the api as we pass env vars to it instead of the api config.	6 years ago
Matt Keeler	3b6eef8ec6	Pass around an API Config object and convert to env vars for the managed proxy	6 years ago
Matt Keeler	962f6a1816	Remove https://prefix from TLSConfig.Address	6 years ago
mkeeler	6813a99081	Merge remote-tracking branch 'connect/f-connect'	7 years ago
Mitchell Hashimoto	a76f652fd2	agent: convert the proxy bind_port to int if it is a float	7 years ago
Paul Banks	17789d4fe3	register TCP check for managed proxies	7 years ago
Paul Banks	280f14d64c	Make proxy only listen after initial certs are fetched	7 years ago
Paul Banks	420ae3df69	Limit proxy telemetry config to only be visible with authenticated with a proxy token	7 years ago
Paul Banks	c6ef6a61c9	Refactor to use embedded struct.	7 years ago
Paul Banks	8aeb7bd206	Disable TestAgent proxy execution properly	7 years ago
Mitchell Hashimoto	a82726f0b8	agent: RemoveProxy also removes the proxy service	7 years ago
Mitchell Hashimoto	ed98d65c2b	agent/proxy: AllowRoot to disable executing managed proxies when root	7 years ago
Paul Banks	e57aa52ca6	Warn about killing proxies in dev mode	7 years ago
Paul Banks	d1c67d90bc	Fixs a few issues that stopped this working in real life but not caught by tests: ... - Dev mode assumed no persistence of services although proxy state is persisted which caused proxies to be killed on startup as their services were no longer registered. Fixed. - Didn't snapshot the ProxyID which meant that proxies were adopted OK from snapshot but failed to restart if they died since there was no proxyID in the ENV on restart - Dev mode with no persistence just kills all proxies on shutdown since it can't recover them later - Naming things	7 years ago
Paul Banks	85d6502ab3	Don't kill proxies on agent shutdown; backport manager close fix	7 years ago
Paul Banks	cdc7cfaa36	Abandon daemonize for simpler solution (preserving history): ... Reverts: - bdb274852ae469c89092d6050697c0ff97178465 - 2c689179c4f61c11f0016214c0fc127a0b813bfe - d62e25c4a7ab753914b6baccd66f88ffd10949a3 - c727ffbcc98e3e0bf41e1a7bdd40169bd2d22191 - 31b4d18933fd0acbe157e28d03ad59c2abf9a1fb - 85c3f8df3eabc00f490cd392213c3b928a85aa44	7 years ago
Paul Banks	8cf4b3a6eb	Sanity check that we are never trying to self-exec a test binary. Add daemonize bypass for TestAgent so that we don't have to jump through ridiculous self-execution hooks for every package that might possibly invoke a managed proxy	7 years ago
Paul Banks	2b377dc624	Run daemon processes as a detached child. ... This turns out to have a lot more subtelty than we accounted for. The test suite is especially prone to races now we can only poll the child and many extra levels of indirectoin are needed to correctly run daemon process without it becoming a Zombie. I ran this test suite in a loop with parallel enabled to verify for races (-race doesn't find any as they are logical inter-process ones not actual data races). I made it through ~50 runs before hitting an error due to timing which is much better than before. I want to go back and see if we can do better though. Just getting this up.	7 years ago
Paul Banks	e21723a891	Persist proxy state through agent restart	7 years ago
Mitchell Hashimoto	cd39f09693	agent: leaf endpoint accepts name, not service ID ... This change is important so that requests can made representing a service that may not be registered with the same local agent.	7 years ago
Paul Banks	a80559e439	Make invalid clusterID be fatal	7 years ago
Paul Banks	4aeab3897c	Fixed many tests after rebase. Some still failing and seem unrelated to any connect changes.	7 years ago
Mitchell Hashimoto	cfcd733609	agent/cache: implement refresh backoff	7 years ago
Mitchell Hashimoto	e54e69d11f	agent: verify local proxy tokens for CA leaf + tests	7 years ago
Mitchell Hashimoto	a099c27b07	agent: verify proxy token for ProxyConfig endpoint + tests	7 years ago
Mitchell Hashimoto	aaca1fbcf5	agent: increase timer for blocking cache endpoints	7 years ago
Mitchell Hashimoto	f5e7993249	agent: clarify why we Kill still	7 years ago
Mitchell Hashimoto	2809203408	agent: restore proxy snapshot but still Kill proxies	7 years ago
Mitchell Hashimoto	f5ccc65295	agent: only set the proxy manager data dir if its set	7 years ago
Mitchell Hashimoto	1e7f253b53	agent/proxy: write pid file whenever the daemon process changes	7 years ago
Mitchell Hashimoto	6cdacd1fd9	agent/proxy: send logs to the correct location for daemon proxies	7 years ago
Mitchell Hashimoto	171bf8d599	agent: clean up defaulting of proxy configuration ... This cleans up and unifies how proxy settings defaults are applied.	7 years ago
Mitchell Hashimoto	6ae95d754c	agent: use os.Executable	7 years ago
Mitchell Hashimoto	6539280f2a	agent: fix crash that could happen if proxy was nil on load	7 years ago
Mitchell Hashimoto	1a2b28602c	agent: start proxy manager	7 years ago
Mitchell Hashimoto	fcd2ab2338	agent/proxy: manager and basic tests, not great coverage yet coming soon	7 years ago
Mitchell Hashimoto	476ea7b04a	agent: start/stop proxies	7 years ago
Paul Banks	90c574ebaa	Wire up agent leaf endpoint to cache framework to support blocking.	7 years ago
Paul Banks	1b197d934a	Don't allow connect watches in agent/cli yet	7 years ago
Kyle Havlovitz	daa8dd1779	Add CA config to connect section of agent config	7 years ago
Mitchell Hashimoto	051f004683	agent: use helper/retry instead of timing related tests	7 years ago
Mitchell Hashimoto	bd3b8e042a	agent/cache: address PR feedback, lots of typos	7 years ago
Mitchell Hashimoto	6c01e402e0	agent: augment /v1/connect/authorize to cache intentions	7 years ago
Mitchell Hashimoto	6902d721d6	agent: initialize the cache and cache the CA roots	7 years ago
Paul Banks	8d09381b96	Super ugly hack to get TeamCity build to work for this PR without adding a vendor that is being added elsewhere and will conflict...	7 years ago
Paul Banks	d73f079d0f	Add X-Consul-ContentHash header; implement removing all proxies; add load/unload test.	7 years ago
Paul Banks	3e3f0e1f31	HTTP agent registration allows proxy to be defined.	7 years ago
Paul Banks	e6071051cf	Added connect proxy config and local agent state setup on boot.	7 years ago
Matt Keeler	40e6d9c720	Fixup a weird merge problem	7 years ago
Matt Keeler	08e26d10b8	Merge branch 'master' of github.com:hashicorp/consul into rpc-limiting ... # Conflicts: # agent/agent.go # agent/consul/client.go	7 years ago
Matt Keeler	65746b2f8f	Apply the limits to the clients rpcLimiter	7 years ago
Matt Keeler	88a8c5e968	Merge pull request #4156 from hashicorp/enterprise-coexistence ... Enterprise/Licensing Cleanup	7 years ago
Matt Keeler	1fbe828c35	Add RunWithConfig and put Run signature back to normal	7 years ago
Matt Keeler	8e0e239e42	Allow passing in a config to the watch plan to use when creating the API client ... This allows watches from consul agent config (rather than consul watch command) to be able to utilize HTTPs	7 years ago
Matt Keeler	b6e9abe926	Allow for easy enterprise/oss coexistence ... Uses struct/interface embedding with the embedded structs/interfaces being empty for oss. Also methods on the server/client types are defaulted to do nothing for OSS	7 years ago
Preetha Appan	d721da7b67	Also make snapshot interval configurable	7 years ago
Preetha Appan	66f31cd25a	Make raft snapshot commit threshold configurable	7 years ago
Kyle Havlovitz	b73323aa42	Remove the script field from checks in favor of args	7 years ago
Jared Wasinger	672a2a3577	agent: reload limits upon restart	7 years ago
runsisi	b082c8d3ab	minor fix for endpoints shutdown ... Signed-off-by: runsisi <runsisi@zte.com.cn>	7 years ago
Matt Keeler	ea6767d8bc	Merge pull request #3990 from hashicorp/b-gh-3854 ... Warn when node name isnt a valid DNS label	7 years ago
Preetha	3c96d64eaa	Merge pull request #3984 from hashicorp/f-allow-federation-disable ... Allows disabling WAN federation by setting serf WAN port to -1	7 years ago
Matt Keeler	ebc6f414ac	Formatting update	7 years ago
Preetha Appan	226cb2e95c	fix typo and remove comment	7 years ago
Matt Keeler	3facce6bfa	GH-3854: Warn when node name isnt a valid DNS label	7 years ago
Preetha Appan	d77ab91123	Allows disabling WAN federation by setting serf WAN port to -1	7 years ago
Guido Iaquinti	8cd11d5888	Add package name to log output	7 years ago
Josh Soref	94835a2715	Spelling (#3958) ... * spelling: another * spelling: autopilot * spelling: beginning * spelling: circonus * spelling: default * spelling: definition * spelling: distance * spelling: encountered * spelling: enterprise * spelling: expands * spelling: exits * spelling: formatting * spelling: health * spelling: hierarchy * spelling: imposed * spelling: independence * spelling: inspect * spelling: last * spelling: latest * spelling: client * spelling: message * spelling: minimum * spelling: notify * spelling: nonexistent * spelling: operator * spelling: payload * spelling: preceded * spelling: prepared * spelling: programmatically * spelling: required * spelling: reconcile * spelling: responses * spelling: request * spelling: response * spelling: results * spelling: retrieve * spelling: service * spelling: significantly * spelling: specifies * spelling: supported * spelling: synchronization * spelling: synchronous * spelling: themselves * spelling: unexpected * spelling: validations * spelling: value	7 years ago
James Phillips	533f65b7a6	Merge pull request #3845 from 42wim/tagfix ... Fix service tags not added to health check. Part two	7 years ago
James Phillips	e748c63fff	Merge pull request #3855 from hashicorp/pr-3782-slackpad ... Adds support for gRPC health checks.	7 years ago
James Phillips	5f31c8d8d3	Changes "TLS" to "GRPCUseTLS" since it only applies to GRPC checks.	7 years ago
Wim	ce771f1fb3	Fix service tags not added to health check. Part two	7 years ago
Veselkov Konstantin	5f38e1148a	fix refactoring	7 years ago
Veselkov Konstantin	7de57ba4de	remove golint warnings	7 years ago
Kyle Havlovitz	68ae92cb8c	Don't remove the files, just log an error	7 years ago
Kyle Havlovitz	4e325a6b8f	Add graceful handling of malformed persisted service/check files. ... Previously a change was made to make the file writing atomic, but that wasn't enough to cover something like an OS crash so we needed something here to handle the situation more gracefully. Fixes #1221.	7 years ago
Dmytro Kostiuchenko	1a10b08e82	Add gRPC health-check #3073	7 years ago
James Phillips	f491a55e47	Merge pull request #3642 from yfouquet/master ... [Fix] Service tags not added to health checks	7 years ago
James Phillips	2892f91d0b	Copies the autopilot settings from the runtime config. ... Fixes #3730	7 years ago