3075 Commits (68b13f4c70371017269be09bcb49a8b5ee691fee)

Author	SHA1	Message	Date
Daniel Nephin	8ac9d54ccc	state: rename connect constants	4 years ago
Daniel Nephin	0c34e474c5	state: rename table name constants to new pattern ... Using Apps Hungarian Notation for these constants makes the memdb queries more readable.	4 years ago
Pierre Souchay	7a024ed074	Streaming filter tags + case insensitive lookups for Service Names ... Will fix: * https://github.com/hashicorp/consul/issues/9695 * https://github.com/hashicorp/consul/issues/9702	4 years ago
Daniel Nephin	2d5b5afec1	state: Remove unnecessary entMeta arg to EnsureConfigEntry	4 years ago
freddygv	5ba14ad41d	Add trace logs to proxycfg state runner and xds srv	4 years ago
freddygv	37190c0d0d	Avoid potential deadlock using non-blocking send ... Deadlock scenario: 1. Due to scheduling, the state runner sends one snapshot into snapCh and then attempts to send a second. The first send succeeds because the channel is buffered, but the second blocks. 2. Separately, Manager.Watch is called by the xDS server after getting a discovery request from Envoy. This function acquires the manager lock and then blocks on receiving the CurrentSnapshot from the state runner. 3. Separately, there is a Manager goroutine that reads the snapshots from the channel in step 1. These reads are done to notify proxy watchers, but they require holding the manager lock. This goroutine goes to acquire that lock, but can't because it is held by step 2. Now, the goroutine from step 3 is waiting on the one from step 2 to release the lock. The goroutine from step 2 won't release the lock until the goroutine in step 1 advances. But the goroutine in step 1 is waiting for the one in step 3. Deadlock. By making this send non-blocking step 1 above can proceed. The coalesce timer will be reset and a new valid snapshot will be delivered after it elapses or when one is requested by xDS.	4 years ago
hashicorp-ci	6fa9a6a1d9	auto-updated agent/uiserver/bindata_assetfs.go from commit e0ff7080a	4 years ago
hashicorp-ci	90917400c6	auto-updated agent/uiserver/bindata_assetfs.go from commit 0b7d676dc	4 years ago
hashicorp-ci	a33ff40816	auto-updated agent/uiserver/bindata_assetfs.go from commit 3aef5cde2	4 years ago
Kyle Havlovitz	7dac583863	connect/ca: Allow ForceWithoutCrossSigning for all providers ... This allows setting ForceWithoutCrossSigning when reconfiguring the CA for any provider, in order to forcibly move to a new root in cases where the old provider isn't reachable or able to cross-sign for whatever reason.	4 years ago
hashicorp-ci	40c2a3d108	auto-updated agent/uiserver/bindata_assetfs.go from commit 3477b1de7	4 years ago
Daniel Nephin	5b4703f0e4	state: rename config-entries table const to match new pattern	4 years ago
Daniel Nephin	cd06b5728c	state: move config-entries table to new pattern	4 years ago
Daniel Nephin	e8931b868c	state: use indexID ... this change was already made to enterprise, so backporting it.	4 years ago
Daniel Nephin	1cccdc45c2	state: Move ACL schema indexes to match Ent ... and use constants for table and index names.	4 years ago
Daniel Nephin	727a402810	Merge pull request #9302 from hashicorp/dnephin/add-service-3 ... agent: remove ServiceManager.Start goroutine	4 years ago
Daniel Nephin	1dcafa51a4	config: make config.TestLoad_FullConfig use config.Load ... This commit makes a number of changes that should make TestLoad_FullConfig easier to work with, and make the test more like real world scenarios. * use separate files in testdata/ dir to store the config source. Separate files are much easier to edit because editors can syntax highlight json/hcl, and it makes strings easier to find. Previously trying to find strings would match strings used in other tests. * use the exported config.Load interface instead of internal NewBuilder and BuildAndValidate. * remove the tail config overrides, which are only necessary with nonZero works.	4 years ago
Daniel Nephin	a0dd45941b	config: Unexport Builder and NewBuilder ... This type and constructor are implementation details of config loading. All callers should use config.Load.	4 years ago
Daniel Nephin	32d36d0dd4	config: replace calls to config.NewBuilder with config.Load ... This is another incremental change to reduce config loading to a single small interface. All calls to NewBuilder can be replaced with Load.	4 years ago
Daniel Nephin	97a577502d	config: improve the interface of Load ... This commit reduces the interface to Load() a bit, in preparation for unexporting NewBuilder and having everything call Load. The three arguments are reduced to a single argument by moving the other two into the options struct. The three return values are reduced to two by moving the RuntimeConfig and Warnings into a LoadResult struct.	4 years ago
Daniel Nephin	27df0d9a78	Merge pull request #9252 from hashicorp/dnephin/config-unmethod ... config: remove Builder receiver from funcs that dont use it	4 years ago
Matt Keeler	f561462064	Upgrade raft-autopilot and wait for autopilot it to stop when revoking leadership (#9644) ... Fixes: 9626	4 years ago
hashicorp-ci	49b773233b	auto-updated agent/uiserver/bindata_assetfs.go from commit 25f989753	4 years ago
Hans Hasselberg	444cdeb8fb	Add flags to support CA generation for Connect (#9585)	4 years ago
hashicorp-ci	174878eb63	auto-updated agent/uiserver/bindata_assetfs.go from commit 92f0eb3bd	4 years ago
hashicorp-ci	5c7f815469	auto-updated agent/uiserver/bindata_assetfs.go from commit 82a62cd2e	4 years ago
Daniel Nephin	f36d77ee4a	Merge pull request #9301 from hashicorp/dnephin/add-service-2 ... agent: reduce AddService 2	4 years ago
R.B. Boyer	c608dc0d60	server: initialize mgw-wanfed to use local gateways more on startup (#9528) ... Fixes #9342	4 years ago
Daniel Nephin	8c45f2c1fe	agent: use the new lib/mutex for stateLock ... Previously the ServiceManager had to run a separate goroutine so that it could block on a channel send/receive instead of a lock. Using this mutex with TryLock allows us to cancel the lock when the serviceConfigWatch is stopped. Without this change removing the ServiceManager.Start goroutine would not be possible because when AddService is called it acquires the stateLock. While that lock is held, if there are existing watches for the service, the old watch will be stopped, and the goroutine holding the lock will attempt to wait for that watcher goroutine to exit. If the goroutine is handling an update (serviceConfigWatch.handleUpdate) then it can block on acquiring the stateLock and deadlock the agent. With this change the context is cancelled as and the goroutine will exit instead of waiting on the stateLock.	4 years ago
Daniel Nephin	4e42b8f1d4	agent: remove ServiceManager goroutine ... The ServiceManager.Start goroutine was used to serialize calls to agent.addServiceInternal. All the goroutines which sent events to the channel would block waiting for a response from that same goroutine, which is effectively the same as a synchronous call without any channels. This commit removes the goroutine and channels, and instead calls addServiceInternal directly. Since all of these goroutines will need to take the agent.stateLock, the mutex handles the serializing of calls.	4 years ago
Daniel Nephin	45b315060a	agent: Minor cosmetic changes in ServiceManager ... Also use the non-deprecated func in a test	4 years ago
Daniel Nephin	8b67231e8c	agent: update godoc for AddServiceRequest	4 years ago
Daniel Nephin	f34703fc63	agent: move checkStateSnapshot ... Move the field into the struct for addServiceLocked. Also don't require setting a default value, so that the callers can leave it as nil if they don't already have a snapshot.	4 years ago
Daniel Nephin	1495291054	agent: move two fields off of AddServiceRequest	4 years ago
Daniel Nephin	60c6a1c220	agent: Replace two fields on AddServiceRequest with a func field ... The two previous fields were mutually exclusive. They can be represented with a single function which provides the value.	4 years ago
Daniel Nephin	d0386ae025	agent: remove serviceRegiration type ... Replace with the existing AddServiceRequest struct. These structs are almost identical. Additionally, the only reason the serviceRegistration struct existed was to recreate an AddServiceRequest. By storing and re-using the AddServiceRequest we remove the need to translate into one type and back to the original type. We also remove the extra parameters to a function, because those values are already available from the AddServiceRequest field. Also a minor optimization to only call tokens.AgentToken() when necessary. Previous it was being called every time, but the value was being ignored if the AddServiceRequest had a token.	4 years ago
Daniel Nephin	5f9930a9be	agent: remove an a branch in the AddService flow ... Handle the decision to use ServiceManager in a single place. Instead of calling ServiceManager.AddService, then calling back into addServiceInternal, only call ServiceManager.AddService if we are going to use it. This change removes some small duplication and removes a branch from the AddService flow.	4 years ago
Daniel Nephin	4da0718c57	agent: use fields directly, not temp variables ... The temprorary variables make it much harder to trace where and how struct fields are used. If a field is only used a small number of times than refer to the field directly.	4 years ago
Daniel Nephin	5b6f806f4f	agent: addServiceIternalRequest ... Move fields that are only relevant for addServiceInternal onto a new struct and embed AddServiceRequest.	4 years ago
Daniel Nephin	3d39359bcb	agent: move deprecated AddServiceFromSource to a test file ... The method is only used in tests, and only exists for legacy calls. There was one other package which used this method in tests. Export the AddServiceRequest and a couple of its fields so the new function can be used in those tests.	4 years ago
Daniel Nephin	e44fd1cb92	agent: use a single method for Agent.AddService	4 years ago
Daniel Nephin	6757231b82	agent: rename AddService->AddServiceFromSource ... In preparation for extracting a single AddService func that accepts a request struct.	4 years ago
Daniel Nephin	48112e6298	Merge pull request #9420 from hashicorp/dnephin/reduce-duplicate-in-catalog-schema ... state: reduce interface for Enterprise schema	4 years ago
Chris Boulton	8a35df81c7	connect: add local_request_timeout_ms to configure local_app http timeouts (#9554)	4 years ago
R.B. Boyer	51e3ca6cbb	server: use the presense of stored federation state data as a sign that we already activated the federation state feature flag (#9519) ... This way we only have to wait for the serf barrier to pass once before we can make use of federation state APIs Without this patch every restart needs to re-compute the change.	4 years ago
hashicorp-ci	501fc855d3	auto-updated agent/uiserver/bindata_assetfs.go from commit 09d917618	4 years ago
hashicorp-ci	4584771bbf	auto-updated agent/uiserver/bindata_assetfs.go from commit 88d5e00f9	4 years ago
hashicorp-ci	8d440c532a	auto-updated agent/uiserver/bindata_assetfs.go from commit bb9573832	4 years ago
R.B. Boyer	03790a1f91	server: add OSS stubs supporting validation of source namespaces in service-intentions config entries (#9527)	4 years ago
R.B. Boyer	9ef3f20127	server: when wan federating via mesh gateways only do heuristic primary DC bypass on the leader (#9366) ... Fixes #9341	4 years ago
hashicorp-ci	27a5434cb0	auto-updated agent/uiserver/bindata_assetfs.go from commit 02772e46a	4 years ago
John Cowen	02772e46a2	Fix -ui-content-path without regex (#9569) ... * Add templating to inject JSON into an application/json script tag Plus an external script in order to pick it out and inject the values we need injecting into ember's environment meta tag. The UI still uses env style naming (CONSUL_*) but we uses the new style JSON/golang props behind the scenes. Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
hashicorp-ci	972fa320f8	auto-updated agent/uiserver/bindata_assetfs.go from commit ffb6680e7	4 years ago
John Cowen	aedd338e70	api: Ensure the internal/ui/gateway-service-nodes endpoint responds with an array (#9593) ... In some circumstances this endpoint will have no results in it (dues to ACLs, Namespaces, filtering or missing configuration). This ensures that the response is at least an empty array (`[]`) rather than `null`	4 years ago
Matt Keeler	4fa884ee3d	Fix flaky test by marking mock expectations as optional (#9596) ... These expectations are optional because in a slow CI environment the deadline to cancell the context might occur before the go routine reaches issuing the RPC. Either way we are successfully ensuring context cancellation is working.	4 years ago
hashicorp-ci	daa384b64d	auto-updated agent/uiserver/bindata_assetfs.go from commit 30014ff8f	4 years ago
Freddy	e50019b092	Update topology mapping Refs on all proxy instance deletions (#9589) ... * Insert new upstream/downstream mapping to persist new Refs * Avoid upserting mapping copy if it's a no-op * Add test with panic repro * Avoid deleting up/downstreams from inside memdb iterator * Avoid deleting gateway mappings from inside memdb iterator * Add CHANGELOG entry * Tweak changelog entry Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
Daniel Nephin	810424a61e	state: do not delete from inside an iteration ... Deleting from memdb inside an interation can cause a panic from Iterator.Next. This case is technically safe (for now) because the iterator is using the root radix tree not a modified one. However this could break at any time if someone adds an insert or delete to the coordinates table before this place in the function. It also sets a bad example, because generally deletes in an interator are not safe. So this commit uses the pattern we have in other places to move the deletes out of the iteration.	4 years ago
Matt Keeler	a4327305d1	Merge pull request #9570 from hashicorp/bugfix/9498	4 years ago
Matt Keeler	d9d4c492ab	Ensure that CA initialization does not block leader election. ... After fixing that bug I uncovered a couple more: Fix an issue where we might try to cross sign a cert when we never had a valid root. Fix a potential issue where reconfiguring the CA could cause either the Vault or AWS PCA CA providers to delete resources that are still required by the new incarnation of the CA.	4 years ago
hashicorp-ci	57256fa158	auto-updated agent/uiserver/bindata_assetfs.go from commit be694366a	4 years ago
hashicorp-ci	06a25d901f	auto-updated agent/uiserver/bindata_assetfs.go from commit 41a4a9f4f	4 years ago
Daniel Nephin	a6000e6ad8	state: add a regression test for state store schema ... To allow the index to be refactored without accidental changes. To update the expected value run: 'go test ./agent/consul/state -update'	4 years ago
Daniel Nephin	24312f8c96	state: reduce interface for Enterprise schema ... Using withEnterpriseSchema() we can apply any enterprise schema changes with a single shim, removing the need to duplicate all of the table definitions. Also move all the catalog schemas to a new file to shrink catalog.go a bit.	4 years ago
Daniel Nephin	cf4fa18af4	Merge pull request #8696 from hashicorp/dnephin/fix-load-limits ... agent/consul: make Client/Server config reloading more obvious	4 years ago
Daniel Nephin	964ab23280	Merge pull request #9436 from hashicorp/dnephin/fix-service-health-req-cache-key ... structs: fix caching of ServiceSpecificRequest when ingress=true	4 years ago
Daniel Nephin	e66af1a559	agent/consuk: Rename RPCRate -> RPCRateLimit ... so that the field name is consistent across config structs.	4 years ago
Daniel Nephin	5684223e36	agent/consul: make Client/Server config reloading more obvious ... I believe this commit also fixes a bug. Previously RPCMaxConnsPerClient was not being re-read from the RuntimeConfig, so passing it to Server.ReloadConfig was never changing the value. Also improve the test runtime by not doing a lot of unnecessary work.	4 years ago
Daniel Nephin	8fdc789ded	Merge pull request #9460 from hashicorp/dnephin/fix-data-races ... Fix a couple data races in tests	4 years ago
Daniel Nephin	29ce5ec575	structs: fix caching of ServiceSpecificRequest when ingress=true ... The field was not being included in the cache info key. This would result in a DNS request for web.service.consul returning the same result as web.ingress.consul, when those results should not be the same.	4 years ago
hashicorp-ci	408fee901a	auto-updated agent/uiserver/bindata_assetfs.go from commit 1e30503ec	4 years ago
kevinkengne	2e7e78999d	add completeness test for types with CacheInfo method (#9480) ... include all fields when fuzzing in tests split tests by struct type Ensure the new value for the field is different fuzzer.Fuzz could produce the same value again in some cases. Use a custom fuzz function for QueryOptions. That type is an embedded struct in the request types but only one of the fields is important to include in the cache key. Move enterpriseMetaField to an oss file so that we can change it in enterprise.	4 years ago
Chris Piraino	0712e03f33	Fix bug in usage metrics when multiple service instances are changed in a single transaction (#9440) ... * Fix bug in usage metrics that caused a negative count to occur There were a couple of instances were usage metrics would do the wrong thing and result in incorrect counts, causing the count to attempt to decrement below zero and return an error. The usage metrics did not account for various places where a single transaction could delete/update/add multiple service instances at once. We also remove the error when attempting to decrement below zero, and instead just make sure we do not accidentally underflow the unsigned integer. This is a more graceful failure than returning an error and not allowing a transaction to commit. * Add changelog	4 years ago
hashicorp-ci	7ff4763c8b	auto-updated agent/uiserver/bindata_assetfs.go from commit b86eea4fb	4 years ago
Daniel Nephin	e35d5c93c7	config: remove Builder receiver from funcs that dont use it ... This change allows us to re-use these functions in other places without the Builder, and makes it more explicit about which functions can warn/error and which can not.	4 years ago
Daniel Nephin	c500182105	config: Use golden for TestRuntimeConfig_Sanitize ... A golden file makes the expected value easier to work with. This change also removes a number of shims for enterprise and replaces them with a single one for the golden filename.	4 years ago
Pierre Souchay	7c1b69cbeb	Display a warning when rpc.enable_streaming = true is set on a client (#9530) ... * Display a warning when rpc.enable_streaming = true is set on a client This option has no effect when running as an agent * Added warning when server starts with use_streaming_backend but without rpc.enable_streaming * Added unit test	4 years ago
Chris Piraino	aabdccdfa0	Log replication warnings when no error suppression is defined (#9320) ... * Log replication warnings when no error suppression is defined * Add changelog file	4 years ago
Daniel Nephin	6f1f679457	Merge pull request #9250 from hashicorp/dnephin/config-tags-2 ... config: remove unnecessary json/hcl struct tags	4 years ago
Daniel Nephin	7b45d0baea	Merge pull request #9249 from hashicorp/dnephin/config-tags ... config: use fields to detect enterprise-only settings	4 years ago
Daniel Nephin	de7e1d7ca1	config: remove unnecessary json/hcl struct tags ... Using find/replace with regex json:"[^"]+" hcl:"[^"]+"	4 years ago
Daniel Nephin	724a281e1c	config: Use config fields to warn about enterprise settings ... It is no safe to assumes that the mapstructure keys will contain all the keys because some config can be specified with command line flags or literals. This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields.	4 years ago
Daniel Nephin	a9285ad76a	Merge pull request #9251 from hashicorp/dnephin/config-cleanup-flags-and-opts ... config: move testing shims and cleanup some defaults	4 years ago
Daniel Nephin	ce1deae3c8	config: use LiteralConfig for flag values	4 years ago
Daniel Nephin	a9734b69c5	config: remove t.Parallel and some unused fields from tests ... Use go-cmp for better diffs in tests	4 years ago
Daniel Nephin	2187808803	structs: add tests for String() methods ... To show that printing one of these IDs works properly now that the String() method receiver is no longer a pointer.	4 years ago
Daniel Nephin	d113f0e690	structs: Fix printing of IDs ... These types are used as values (not pointers) in other structs. Using a pointer receiver causes problems when the value is printed. fmt will not call the String method if it is passed a value and the String method has a pointer receiver. By using a value receiver the correct string is printed. Also remove some unused methods.	4 years ago
Daniel Nephin	a04cefaa28	Remove an unnecessary else	4 years ago
Daniel Nephin	4b8b2a4291	xds: remove Server.Initialize ... Requiring a call to initialize to set a single field is not really substantially different from having to set that field to a value.	4 years ago
Daniel Nephin	2e2ee41390	xds: Fix data race ... TestEnvoy.Close used e.stream.recvCh == nil to indicate the channel had already been closed, so that TestEnvoy.Close can be called multiple times. The recvCh was not protected by a lock, so setting it to nil caused a data race with any goroutine trying to read from the channel. Instead set the stream to nil. The stream is guarded by a lock, so it does not race. This change allows us to test the agent/xds package using -race.	4 years ago
Daniel Nephin	375aed5ed6	xds: Pass in logger ... small cleanup in tests	4 years ago
hashicorp-ci	a040495cd3	auto-updated agent/uiserver/bindata_assetfs.go from commit e893ba7ea	4 years ago
Daniel Nephin	d64425d2e4	Merge pull request #9213 from hashicorp/dnephin/resolve-tokens-take-2 ... acl: Remove some unused things and document delegate method	4 years ago
Pierre Souchay	994fe80358	Added testing of GRPC with TLS combinations ... This ensures that https://github.com/hashicorp/consul/issues/9474 will not reproduce.	4 years ago
Pierre Souchay	e2f2d4b0d7	[Streaming][bugfix] handle TLS signalisation when TLS is disabled on client side ... Tnis is an alternative to https://github.com/hashicorp/consul/pull/9494	4 years ago
R.B. Boyer	19baf4bc25	acl: use the presence of a management policy in the state store as a sign that we already migrated to v2 acls (#9505) ... This way we only have to wait for the serf barrier to pass once before we can upgrade to v2 acls. Without this patch every restart needs to re-compute the change, and potentially if a stray older node joins after a migration it might regress back to v1 mode which would be problematic.	4 years ago
hashicorp-ci	2e67ee728c	auto-updated agent/uiserver/bindata_assetfs.go from commit 1304dc882	4 years ago
Daniel Nephin	b0574c9839	Merge pull request #9067 from naemono/6074-allow-config-MaxHeaderBytes ... Adds option to configure HTTP Server's MaxHeaderBytes	4 years ago
hashicorp-ci	a30959d5ae	auto-updated agent/uiserver/bindata_assetfs.go from commit a42e844cc	4 years ago
hashicorp-ci	3925713767	auto-updated agent/uiserver/bindata_assetfs.go from commit 17438020f	4 years ago
Michael Montgomery	ba3fe0c875	Remove unneeded test	4 years ago
Matt Keeler	85e5da53d5	Special case the error returned when we have a Raft leader but are not tracking it in the ServerLookup (#9487) ... This can happen when one other node in the cluster such as a client is unable to communicate with the leader server and sees it as failed. When that happens its failing status eventually gets propagated to the other servers in the cluster and eventually this can result in RPCs returning “No cluster leader” error. That error is misleading and unhelpful for determing the root cause of the issue as its not raft stability but rather and client -> server networking issue. Therefore this commit will add a new error that will be returned in that case to differentiate between the two cases.	4 years ago
hashicorp-ci	a5bb8fc52e	auto-updated agent/uiserver/bindata_assetfs.go from commit 8c9d5ecc2	4 years ago
R.B. Boyer	d5d62d9e08	server: deletions of intentions by name using the intention API is now idempotent (#9278) ... Restoring a behavior inadvertently changed while fixing #9254	4 years ago
hashicorp-ci	e66f02541e	auto-updated agent/uiserver/bindata_assetfs.go from commit 8c0473a62	4 years ago
Michael Montgomery	e4f603dfae	Merge branch 'master' into 6074-allow-config-MaxHeaderBytes	4 years ago
Michael Montgomery	817903b925	Fixed failing tests ... Removed use of `NewTestAgent`, per review comment Removed CLI flag, per review comment Updated website documentation Added changelog entry	4 years ago
Daniel Nephin	71b82a7e5b	Maybe fix another data race in a test	4 years ago
Daniel Nephin	bae9125fc1	Fix one race caused by t.Parallel	4 years ago
hashicorp-ci	cacbff9a50	auto-updated agent/uiserver/bindata_assetfs.go from commit 99f102705	4 years ago
hashicorp-ci	9ca4e431f6	auto-updated agent/uiserver/bindata_assetfs.go from commit 25d6a1277	4 years ago
hashicorp-ci	9fc99f4ae0	auto-updated agent/uiserver/bindata_assetfs.go from commit c7d917777	4 years ago
hashicorp-ci	a05be282ad	auto-updated agent/uiserver/bindata_assetfs.go from commit 2e3a66efb	4 years ago
hashicorp-ci	1ecece3ee8	auto-updated agent/uiserver/bindata_assetfs.go from commit 635cf4dc9	4 years ago
hashicorp-ci	8e35646ba1	auto-updated agent/uiserver/bindata_assetfs.go from commit 66cc91c69	4 years ago
hashicorp-ci	744d467540	auto-updated agent/uiserver/bindata_assetfs.go from commit 0ca54c608	4 years ago
hashicorp-ci	c086f5eecb	auto-updated agent/uiserver/bindata_assetfs.go from commit 4404b4f44	4 years ago
hashicorp-ci	eb8c46c5bb	auto-updated agent/uiserver/bindata_assetfs.go from commit a919b60f5	4 years ago
hashicorp-ci	3fa218a4d2	auto-updated agent/uiserver/bindata_assetfs.go from commit e921b3cf9	4 years ago
hashicorp-ci	2cf057db55	auto-updated agent/uiserver/bindata_assetfs.go from commit 5e150d7f0	4 years ago
John Cowen	a9913b5b22	api: Ensure the internal/ui/service endpoint responds with an array (#9397) ... In some circumstances this endpoint will have no results in it (dues to ACLs, Namespaces or filtering). This ensures that the response is at least an empty array (`[]`) rather than `null`	4 years ago
hashicorp-ci	7830eb85f6	auto-updated agent/uiserver/bindata_assetfs.go from commit 9f0787197	4 years ago
hashicorp-ci	57899ba5ef	auto-updated agent/uiserver/bindata_assetfs.go from commit f111d6b3e	4 years ago
hashicorp-ci	35678670cd	auto-updated agent/uiserver/bindata_assetfs.go from commit 14d043e5f	4 years ago
hashicorp-ci	0c3db76c92	auto-updated agent/uiserver/bindata_assetfs.go from commit 4e419b9b3	4 years ago
Daniel Nephin	c15d5b0ed1	http: Check HTTPUseCache in a single place ... HTTPUseCache is only used is a gate for allowing QueryOptions.UseCache to be enabled. By moving it to the place where the query options are set, this behaviour is more obvious. Also remove parseInternal which was an alias for parse.	4 years ago
Daniel Nephin	cb3dbc92f9	Merge pull request #9340 from hashicorp/dnephin/skip-slow-tests-with-short ... testing: skip slow tests with -short	4 years ago
hashicorp-ci	2608e92763	auto-updated agent/uiserver/bindata_assetfs.go from commit 514270a41	4 years ago
hashicorp-ci	db175eaf38	auto-updated agent/uiserver/bindata_assetfs.go from commit 0f7c909f1	4 years ago
hashicorp-ci	7deddd82c8	auto-updated agent/uiserver/bindata_assetfs.go from commit 21e5a8f0f	4 years ago
R.B. Boyer	d921690bfe	acl: global tokens created by auth methods now correctly replicate to secondary datacenters (#9351) ... Previously the tokens would fail to insert into the secondary's state store because the AuthMethod field of the ACLToken did not point to a known auth method from the primary.	4 years ago
hashicorp-ci	673158416d	auto-updated agent/uiserver/bindata_assetfs.go from commit 9d8131907	4 years ago
hashicorp-ci	4dbc1b7b59	auto-updated agent/uiserver/bindata_assetfs.go from commit a78566e2d	4 years ago
hashicorp-ci	bb8e53bbf7	auto-updated agent/uiserver/bindata_assetfs.go from commit d6cb2b0d7	4 years ago
Kenia	27f6899ec8	Create consul version metric with version label (#9350) ... * create consul version metric with version label * agent/agent.go: add pre-release Version as well as label Co-Authored-By: Radha13 <kumari.radha3@gmail.com> * verion and pre-release version labels. * hyphen/- breaks prometheus * Add Prometheus gauge defintion for version metric * Add new metric to telemetry docs Co-authored-by: Radha Kumari <kumari.radha3@gmail.com> Co-authored-by: Aestek <thib.gilles@gmail.com> Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>	4 years ago
hashicorp-ci	bad0ada7cb	auto-updated agent/uiserver/bindata_assetfs.go from commit 27c74f714	4 years ago
hashicorp-ci	4387740f01	auto-updated agent/uiserver/bindata_assetfs.go from commit 613be01f4	4 years ago
hashicorp-ci	67f7511ea8	auto-updated agent/uiserver/bindata_assetfs.go from commit db5283ee2	4 years ago
hashicorp-ci	9a212f13b7	auto-updated agent/uiserver/bindata_assetfs.go from commit 3be03029f	4 years ago
Daniel Nephin	b9e60c0775	testing: skip slow tests with -short ... Add a skip condition to all tests slower than 100ms. This change was made using `gotestsum tool slowest` with data from the last 3 CI runs of master. See https://github.com/gotestyourself/gotestsum#finding-and-skipping-slow-tests With this change: ``` $ time go test -count=1 -short ./agent ok github.com/hashicorp/consul/agent 0.743s real 0m4.791s $ time go test -count=1 -short ./agent/consul ok github.com/hashicorp/consul/agent/consul 4.229s real 0m8.769s ```	4 years ago
hashicorp-ci	0d35351e2d	auto-updated agent/uiserver/bindata_assetfs.go from commit 4dfa7622d	4 years ago
hashicorp-ci	76d5d98b5e	auto-updated agent/uiserver/bindata_assetfs.go from commit adbd6c0c8	4 years ago
Kyle Havlovitz	88d669c0e0	connect: Fix a case where the active root would get unset even when there wasn't a new one	4 years ago
hashicorp-ci	de2b3a11dd	auto-updated agent/uiserver/bindata_assetfs.go from commit e23b5b003	4 years ago
hashicorp-ci	b08fb88a94	auto-updated agent/uiserver/bindata_assetfs.go from commit 9ac7bc180	4 years ago
hashicorp-ci	e49bf629f8	auto-updated agent/uiserver/bindata_assetfs.go from commit a5b9ada9a	4 years ago
hashicorp-ci	2eedfd57e7	auto-updated agent/uiserver/bindata_assetfs.go from commit cf38309f6	4 years ago
Kyle Havlovitz	c4eff420be	Merge pull request #9009 from hashicorp/update-secondary-ca ... connect: Fix an issue with updating CA config in a secondary datacenter	4 years ago
Kyle Havlovitz	781cae5809	Use a buffered channel for CA intermediate renew func	4 years ago
hashicorp-ci	4279a2d7d4	auto-updated agent/uiserver/bindata_assetfs.go from commit afe0f2614	4 years ago
hashicorp-ci	70666c22bb	auto-updated agent/uiserver/bindata_assetfs.go from commit b5abbf122	4 years ago
hashicorp-ci	9b16766ffe	auto-updated agent/uiserver/bindata_assetfs.go from commit d1ebe8c14	4 years ago
hashicorp-ci	2a78aefc5a	auto-updated agent/uiserver/bindata_assetfs.go from commit f46ef3e3f	4 years ago
hashicorp-ci	cb4c3b83b9	auto-updated agent/uiserver/bindata_assetfs.go from commit a59a2f860	4 years ago
hashicorp-ci	5f5ac36375	auto-updated agent/uiserver/bindata_assetfs.go from commit 9cf30e74e	4 years ago
Daniel Nephin	9f0f2bd589	Merge pull request #9284 from hashicorp/dnephin/agent-service-register ... local: mark service as InSync when added to local agent state	4 years ago
Daniel Nephin	33b81067f8	local: mark service and checks as InSync when added ... If the existing service and checks are the same as the new registration.	4 years ago
Hans Hasselberg	44674bcdf8	fix serf_wan documentation (#9289) ... WAN config is different than LAN config, source of truth is f72d2042a8/config.go (L315-L326) and now the docs are correct.	4 years ago
hashicorp-ci	a1644351bc	auto-updated agent/uiserver/bindata_assetfs.go from commit 408174f3b	4 years ago
Daniel Nephin	08b8a9276d	Merge pull request #9247 from pierresouchay/streaming_predictible_order_for_health ... [Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb	4 years ago
Pierre Souchay	76d95fd388	Applied suggestions from @dnephin ... * Renamed `cachedHealResultSorter` into `sortCheckServiceNodes` * Use `<` instead of `strings.Compare` * Single line comparison in unit test	4 years ago
R.B. Boyer	d2d1b05a4e	server: fix panic when deleting a non existent intention (#9254) ... * server: fix panic when deleting a non existent intention * add changelog * Always return an error when deleting non-existent ixn Co-authored-by: freddygv <gh@freddygv.xyz>	4 years ago
hashicorp-ci	9ccf12289a	auto-updated agent/uiserver/bindata_assetfs.go from commit 6f8b5acbe	4 years ago
hashicorp-ci	3f9d15959c	auto-updated agent/uiserver/bindata_assetfs.go from commit 9c3c7bcf3	4 years ago
Hans Hasselberg	57701695c3	add missing descriptions for metrics	4 years ago
Kit Patella	fcec25de40	add entries for missing fsm operations and mark duplicated metrics prefixes as deprecated	4 years ago
Daniel Nephin	a1e4b69527	config: remove unused const	4 years ago
Kyle Havlovitz	13c31ccfce	Clean up the logic in persistNewRootAndConfig	4 years ago
Daniel Nephin	78f767e78c	config: move testing shims to BuilderOpts ... And remove the devMode field from builder. This change helps make the Builder state more explicit by moving inputs to the BuilderOps struct, leaving only fields that can change during Builder.Build on the Builder struct.	4 years ago
Daniel Nephin	0a44906fe3	config: Use LiteralSource for some defaults ... Using the LiteralSource makes it much easier to find default values, because an IDE reports the location of a default. With an HCL string they are harder to discover. Also removes unnecessary mapstructure.Decodes of constant values.	4 years ago
Kit Patella	c6b29a8bba	Merge pull request #9245 from hashicorp/telemetry/fix-missing-and-stale-docs ... Telemetry/fix missing and stale docs	4 years ago
Pierre Souchay	45151090c1	[Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb ... This ensures the result is consitent with/witout streaming Will partially fix #9239	4 years ago
Michael Montgomery	585c84e9ff	Merge branch 'master' into 6074-allow-config-MaxHeaderBytes	4 years ago
Kyle Havlovitz	0bfda4481f	Add CA server delegate interface for testing	4 years ago
Kit Patella	5c09dc322e	add telemetry and definition help entries for missing catalog and acl metrics	4 years ago
R.B. Boyer	7c7a3e5165	command: when generating envoy bootstrap configs use the datacenter returned from the agent services endpoint (#9229) ... Fixes #9215	4 years ago
Kit Patella	9e54e897d7	remove stale entries and rename/define acl.resolveToken	4 years ago
hashicorp-ci	8368f65006	auto-updated agent/uiserver/bindata_assetfs.go from commit d913af2bb	4 years ago
Freddy	fd5928fa4e	Require operator:write to get Connect CA config (#9240) ... A vulnerability was identified in Consul and Consul Enterprise (“Consul”) such that operators with `operator:read` ACL permissions are able to read the Consul Connect CA configuration when explicitly configured with the `/v1/connect/ca/configuration` endpoint, including the private key. This allows the user to effectively privilege escalate by enabling the ability to mint certificates for any Consul Connect services. This would potentially allow them to masquerade (receive/send traffic) as any service in the mesh. -- This PR increases the permissions required to read the Connect CA's private key when it was configured via the `/connect/ca/configuration` endpoint. They are now `operator:write`.	4 years ago
hashicorp-ci	effe235562	auto-updated agent/uiserver/bindata_assetfs.go from commit 687ce1f9c	4 years ago
Daniel Nephin	671b8cf494	Merge pull request #9224 from hashicorp/dnephin/fix-multiple-http-listeners ... agent: fix bug with multiple listeners	4 years ago
Daniel Nephin	79963be559	Use freeport ... To prevent other tests which already use freeport from flaking when port 0 steals their reserved port.	4 years ago
hashicorp-ci	b8659f77c4	auto-updated agent/uiserver/bindata_assetfs.go from commit 591a96d5b	4 years ago
hashicorp-ci	cd003a14a5	auto-updated agent/uiserver/bindata_assetfs.go from commit 1edef424a	4 years ago
Daniel Nephin	738bf9efdc	agent: fix bug with multiple listeners ... Previously the listener was being passed to a closure in a loop without capturing the loop variable. The result is only the last listener is used, so the http/https servers only listen on one address. This problem is fixed by capturing the variable by passing it into a function.	4 years ago
hashicorp-ci	b2605d90d2	auto-updated agent/uiserver/bindata_assetfs.go from commit 664f1d9aa	4 years ago
Kyle Havlovitz	9be7c6401c	connect: update some function comments in CA manager	4 years ago
Daniel Nephin	3885835e8c	acl: remove a test-only method	4 years ago
Daniel Nephin	0ee86935f0	Remove two unused delegate methods	4 years ago
Daniel Nephin	839429eb40	Merge pull request #9160 from hashicorp/dnephin/go-test-race-in-to-out-list ... ci: change go-test-race package list to exclude list	4 years ago
Matt Keeler	66fd23d67f	Refactor to call non-voting servers read replicas (#9191) ... Co-authored-by: Kit Patella <kit@jepsen.io>	4 years ago
Kit Patella	d15b6fddd3	Merge pull request #9198 from hashicorp/mkcp/telemetry/add-all-metric-definitions ... Add metric definitions for all metrics known at Consul start	4 years ago
hashicorp-ci	56dbabf67b	auto-updated agent/uiserver/bindata_assetfs.go from commit fe728855e	4 years ago
Freddy	fe728855ed	Add DC and NS support for Envoy metrics (#9207) ... This PR updates the tags that we generate for Envoy stats. Several of these come with breaking changes, since we can't keep two stats prefixes for a filter.	4 years ago
Kit Patella	8e554ee74b	Merge branch 'mkcp/telemetry/add-all-metric-definitions' of ssh://github.com/hashicorp/consul into mkcp/telemetry/add-all-metric-definitions	4 years ago
Kit Patella	ad4cebc1d8	fix some tests that were broken from the TelemetryConfig change	4 years ago
Kit Patella	fc30f07cc7	linting: sort and group import	4 years ago
Kit Patella	2fe021f03c	update runtime_test to handle PrometheusOpts expiry field change	4 years ago
Matt Keeler	748d56b8ab	Prevent panic if autopilot health is requested prior to leader establishment finishing. (#9204)	4 years ago
Kit Patella	b81edac7bb	use the MetricsPrefix to set the service name and provide as slice literal to avoid bugs from append modifying its first arg	4 years ago
Kit Patella	5e0e4098c9	push prometheus sink definiitons into prometheus.PrometheusOpts	4 years ago
Daniel Nephin	b7367467f6	Merge pull request #9114 from hashicorp/dnephin/filtering-in-stream ... stream: improve naming of Payload methods	4 years ago
Kit Patella	15af5ead0b	trim help strings to save a few bytes	4 years ago
Kit Patella	3966ecb02f	merge master	4 years ago
hashicorp-ci	a54d1069b3	auto-updated agent/uiserver/bindata_assetfs.go from commit 959974e96	4 years ago
Kit Patella	5da2f1efa8	finish adding static server metrics	4 years ago
Kyle Havlovitz	16e95f1d7b	Reorganize some CA manager code for correctness/readability	4 years ago
Kyle Havlovitz	6fba82a4fa	connect: Add CAManager for synchronizing CA operations	4 years ago
Kyle Havlovitz	af34b26221	connect: Add logic for updating secondary DC intermediate on config set	4 years ago
R.B. Boyer	9eb262252a	server: intentions CRUD requires connect to be enabled (#9194) ... Fixes #9123	4 years ago
Kit Patella	06d59c03b9	add the service name in the agent rather than in the definitions themselves	4 years ago
R.B. Boyer	c7233ba871	server: remove config entry CAS in legacy intention API bridge code (#9151) ... Change so line-item intention edits via the API are handled via the state store instead of via CAS operations. Fixes #9143	4 years ago
R.B. Boyer	c52bc632df	server: skip deleted and deleting namespaces when migrating intentions to config entries (#9186)	4 years ago
Mike Morris	7af643ac37	ci: update to Go 1.15.4 and alpine:3.12 (#9036) ... * ci: stop building darwin/386 binaries Go 1.15 drops support for 32-bit binaries on Darwin https://golang.org/doc/go1.15#darwin * tls: ConnectionState::NegotiatedProtocolIsMutual is deprecated in Go 1.15, this value is always true * correct error messages that changed slightly * Completely regenerate some TLS test data Co-authored-by: R.B. Boyer <rb@hashicorp.com>	4 years ago
hashicorp-ci	fe6b888269	auto-updated agent/uiserver/bindata_assetfs.go from commit 1059a51a3	4 years ago
hashicorp-ci	40cef22c17	auto-updated agent/uiserver/bindata_assetfs.go from commit 78b704be8	4 years ago
R.B. Boyer	c003871c54	server: break up Intention.Apply monolithic method (#9007) ... The Intention.Apply RPC is quite large, so this PR attempts to break it down into smaller functions and dissolves the pre-config-entry approach to the breakdown as it only confused things.	4 years ago
Kit Patella	24a2471029	first pass on agent-configured prometheusDefs and adding defs for every consul metric	4 years ago
Daniel Nephin	a397ec85eb	Merge pull request #9162 from hashicorp/dnephin/fix-grpc-metrics ... grpc: fix metrics	4 years ago
hashicorp-ci	1cedf812e1	auto-updated agent/uiserver/bindata_assetfs.go from commit 6b2970402	4 years ago
R.B. Boyer	61eac21f1a	agent: return the default ACL policy to callers as a header (#9101) ... Header is: X-Consul-Default-ACL-Policy=<allow|deny> This is of particular utility when fetching matching intentions, as the fallthrough for a request that doesn't match any intentions is to enforce using the default acl policy.	4 years ago
hashicorp-ci	4016918434	auto-updated agent/uiserver/bindata_assetfs.go from commit 7243f1f4f	4 years ago
Daniel Nephin	b27457dac8	ci: go-test-race switch to exclude list ... Most packages should pass the race detector. An exclude list ensures that new packages are automatically tested with -race. Also fix a couple small test races to allow more packages to be tested. Returning readyCh requires a lock because it can be set to nil, and setting it to nil will race without the lock. Move the TestServer.Listening calls around so that they properly guard setting TestServer.l. Otherwise it races. Remove t.Parallel in a small package. The entire package tests run in a few seconds, so t.Parallel does very little. In auto-config, wait for the AutoConfig.run goroutine to stop before calling readPersistedAutoConfig. Without this change there was a data race on reading ac.config.	4 years ago
Daniel Nephin	1a137c29d6	grpc: fix grpc metrics ... defaultMetrics was being set at package import time, which meant that it received an instance of the original default. But lib/telemetry.InitTelemetry sets a new global when it is called. This resulted in the metrics being sent nowhere. This commit changes defaultMetrics to be a function, so it will return the global instance when called. Since it is called after InitTelemetry it will return the correct metrics instance.	4 years ago
Matt Keeler	7ef9b04f90	Add a CLI command for retrieving the autopilot configuration. (#9142)	4 years ago
hashicorp-ci	848571a73a	auto-updated agent/uiserver/bindata_assetfs.go from commit 6423a2c10	4 years ago
Matt Keeler	71da0209bf	Add a paramter in state store methods to indicate whether a resource insertion is from a snapshot restoration (#9156) ... The Catalog, Config Entry, KV and Session resources potentially re-validate the input as its coming in. We need to prevent snapshot restoration failures due to missing namespaces or namespaces that are being deleted in enterprise.	4 years ago
hashicorp-ci	37b1ab7f49	auto-updated agent/uiserver/bindata_assetfs.go from commit e1d977138	4 years ago
Daniel Nephin	3760e3d12d	Merge pull request #9149 from joel0/wrap-errors ... Use error wrapping to preserve error type info	4 years ago
Daniel Nephin	45a9dd59b5	Merge pull request #8976 from joel0/wrap-eof ... Wrap rpc error object	4 years ago
Joel May	f600285eb4	Use error wrapping to preserve error type info	4 years ago
hashicorp-ci	77451d944e	auto-updated agent/uiserver/bindata_assetfs.go from commit e18d8e299	4 years ago
hashicorp-ci	8f834c2d21	auto-updated agent/uiserver/bindata_assetfs.go from commit fb6202929	4 years ago
hashicorp-ci	031ab3f44f	auto-updated agent/uiserver/bindata_assetfs.go from commit c8e40ee0d	4 years ago
Matt Keeler	a3a653342b	Fix a bunch of linter warnings	4 years ago
Matt Keeler	c048e86bb2	Switch to using the external autopilot module	4 years ago
hashicorp-ci	7a2c6dfd62	auto-updated agent/uiserver/bindata_assetfs.go from commit 5c0ec13fb	4 years ago
hashicorp-ci	908574058e	auto-updated agent/uiserver/bindata_assetfs.go from commit d9672bca8	4 years ago
Mike Morris	75019baadd	chore: upgrade to gopsutil/v3 (#9118) ... * deps: update golang.org/x/sys * deps: update imports to gopsutil/v3 * chore: make update-vendor	4 years ago
Daniel Nephin	fb70c8bac2	stream: document that Payload must be immutable ... If they are sent to EventPublisher.Publish. Also document that PayloadEvents is expected to come from a subscription and that it is not immutable.	4 years ago
R.B. Boyer	8baf158ea8	Revert "Add namespace support for metrics (OSS) (#9117)" (#9124) ... This reverts commit 06b3b017d3.	4 years ago
hashicorp-ci	cf537ac2f5	auto-updated agent/uiserver/bindata_assetfs.go from commit 3a68686cc	4 years ago
hashicorp-ci	24bc8451d5	auto-updated agent/uiserver/bindata_assetfs.go from commit 848f72f66	4 years ago
Freddy	06b3b017d3	Add namespace support for metrics (OSS) (#9117)	4 years ago
Daniel Nephin	43af0ba7a3	stream: rename FilterByKey	4 years ago
Daniel Nephin	868cfe1eac	stream: Add HasReadPermission to Payload ... Required now that filter is a method on PayloadEvents instead of Event	4 years ago
Daniel Nephin	36202f7938	stream: move event filtering to PayloadEvents ... Removes the weirdness around PayloadEvents.FilterByKey	4 years ago
Daniel Nephin	79b5ca1ce6	stream: Remove unused method	4 years ago
R.B. Boyer	8e616a93c1	agent: sanitize ui metrics proxy header values on agent/self endpoint (#9104)	4 years ago
Daniel Nephin	a33c50ef0d	Merge pull request #9073 from hashicorp/dnephin/backport-streaming-namespaces ... streaming: backport namespace changes	4 years ago