555 Commits (5d4df54296299bb002069aed7c8b98f91eceec8f)

Author	SHA1	Message	Date
John Cowen	eb35d89893	ui: Run 2 separate test runs oss and ent (#7214) ... * ui: Make API integration tests aware of CONSUL_NSPACES_ENABLED * ui: Allow passing CONSUL_NSPACES_ENABLED in via the cli in ember * ui: Add more makefile targets/package scripts to switch NSPACEs on/off * ui: Ensure all acceptance tests continue to pass with NSPACEs on/off This required a little tweaking of the dictionary, at some point page-navigation and some of these little tweaks will no longer be required * ui: Try running CI frontend tests in two parellel runs oss/ent * ui: Use correct make target, use different names for the reports	5 years ago
John Cowen	9e186c7af8	ui: Fix for differences between uncompiled and compiled CSS (#7233) ... We noticed that this relative positioning is not even applied when the CSS is compiled/compressed. When looking via Web Inspector this style/selector doesn't even appear even though it is in the CSS source. This !important reduces the amount of selectors for this style rule, which fixes the error, so potentially this isn't a specificity thing.	5 years ago
John Cowen	ad3b5327d2	ui: Discovery chain improvements (#7222) ... * ui: remove the default word when describing routes * ui: Avoid mutating the chain and look for the default edges more safely * ui: Use not null check instead of a truthy check for showing disco-chain * ui: Upgrade consul-api-double for better disco-chain mocks/fixtures	5 years ago
John Cowen	279cd874cc	ui: Ensure KV flags are passed through to Consul on update (#7216) ... * ui: always pass KV flags through on update * ui: Integration test to prove the flags queryParams gets passed through * ui: Add Flags to the KV updating acceptance tests	5 years ago
Kenia	773b092a64	ui: Add ability to search nodes listing page with IP Address (#7204) ... * Update search field placeholder to display `Search` * Add an acceptance test to search node listings with node name and IP Address * Update and add unit tests for filter/search node listing with IP Address	5 years ago
Kenia	c706089c9f	ui: Hides the Routing tab for a service proxy (#7195) ... * Adds conditional in route to not make discovery-chain request if service kind is equal to `connect-proxy` or `mesh-gateway` * Adds conditional in template to not show Routing tab if `chain` returns as null * Creates a new acceptance test to test the Routing tab not being displayed for a service proxy * Adds `tabs` to the services/show page object	5 years ago
Kenia	b9e023dfe1	ui: Adds an acceptance test for hiding Blocking Queries (#7162) ... * Adds an acceptance test for hiding Blocking Queries * Creates a new scenario - If a user adds CONSUL_UI_DISABLE_REALTIME to localStorage, the Blocking Queries section is hidden. * Updates page assertion to accept functions and booleans as properties * ui: Fix "don't see" step to watch for the different pageObject error ember-cli-page object seems to throw a an error with a different message depending on how you call a function: currentPage()[property]() // message = 'Element not found' const prop = currentPage()[property]; prop() // message = 'Something about destructuring' This changes the step/test/assertion to ensure we check for both types of errors Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	5 years ago
John Cowen	d5b6f3095e	ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) (#7188) ... * ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) * ui: make a specific test-ci target as we are using --path dist --path dist looks for a previous build to test against, in CI this exists as we run a build first, but locally potentially this dist folder doesn't	5 years ago
John Cowen	f45880bffe	ui: Fix sticky nspace menu (#7164) ... * ui: Fix typo expanded > ariaExpanded * ui: Add the things we need to test this * ui: Add tests for testing the menu closes when clicked * ui: Ensure the aria-menu closes on route change	5 years ago
John Cowen	a8504802db	ui: Split splitter names in the discovery-chain (#7180) ... Previous to 1.7 splitter names didn't include the namespace name i.e. 'service-name' as of 1.7 they now include the namespace i.e. 'service-name.namespace' This commit take account of that	5 years ago
John Cowen	3eec5edadf	ui: Discovery-Chain: Cope with some edge case configs (#7174) ... * ui: Discovery-Chain: Cope with redirects that have failovers We found a few stranger configurations for discovery-chain, one of which was redirects that can then failover. We altered the parsing here to include 2 passes, one to organize the nodes into resolvers and children/subsets based on the nodes themselves, which includes adding the failovers to resolvers and subsets. We then do a second pass which can more reliably figure out whether a target is a redirect or a failover (target failovers don't have a corresponding node), this then adds the redirect children to the already exising resolver (from the first pass) and then checks if the redirect also has failovers and adds those if so. * ui: Check to see if we have a user configured default route or not ...if we don't add one so the visualization looks complete	5 years ago
John Cowen	ac60338269	ui: Add live updates/blocking queries to the Intention listing page (#7161) ... * ui: Enable blocking queries/live updates for intentions * ui: Add acceptance tests for intention blocking queries * ui: Add copy to explain that intentions are also now 'real time'	5 years ago
John Cowen	e568cded17	ui: Add node based configuration / environment testing (#7140) ... In an ember environment `config/environment.js` exports a JSON object whereas the file itself exports a function that receives a string of the environment name that would like returning. This is so ember can automatically provide you with an already configured object containing configuration values dependent on which environment you passed to `ember-cli` using `serve`, `build` or `test`. In order to bypass this so we can easily test what is returned for different environments, we've installed a lightweight functional test harness that is simple to use `substack/tape`, that can be run easily outside of ember. We've then written as simple test case using this to enable us to test/assert that different environments return the correct configuration values. Additionally we've added some yarn scripts/make targets (yarn run test-node / make test-node) to make this easy to run. We're yet to integrate this into CI.	5 years ago
John Cowen	d47f1ca2a9	ui: Fix wrapping service ids in the Node Detail > Services tab (#7149)	5 years ago
John Cowen	c6e72c3e46	ui: Fix positioning of active icon in the selected menu item (#7148)	5 years ago
Kenia	ff315c95fd	ui: Implements the ember-page-title addon to the UI (#7118) ... * Installs ember-page-title 5.x * Adds a page title to all template files that need one * Adds an assertion step to test the page titles	5 years ago
John Cowen	1ff8678df7	ui: Remove the Policy/Service Identity selector from nspaces (#7124) ... When editing Nspaces, although you can assign policies to a nspace using PolicyDefaults you cannot assign a Service Identity to a policy like you can when adding a policy to a token. This commit adds an extra attribute to our policy-form/policy-selector component so you can disable this setting. At a later date we may change this to have a conficgurable `<Slot />` instead. Simple acceptance tests is included here	5 years ago
John Cowen	db96603a19	ui: Change environment switch statement to correct env vars	5 years ago
John Cowen	327aac9fe9	ui: Acceptance test improvements to prepare for more NS tests (#6980) ... * ui: Acceptance test improvements to prepare for more NS tests * ui: Namespace acceptance testing (#7005) * Update api-double and consul-api-double for http.body * Adds places where we missed passing the nspace through * Hardcode nspace CRUD to use the default nspace for policies and roles * Alter test helpers to allow us to control nspaces from the outside * Amends to allow tests to account for namespace, move ns from queryParam 1. We decided to move how we pass the namespace value through to the backend when performing write actions (create, update). Previoulsy we were using the queryParam although using the post body is the preferred method to send the Namespace details through to the backend. 2. Other various amends to take into account testing across multiple namespaced scenarios * Enable nspace testing by default * Remove last few occurances of old style http assertions We had informally 'deprecated' our old style of http assertions that relied on the order of http calls (even though that order was not important for the assertion). Following on from our namespace work we removed the majority of the old occrances of these old style assertions. This commit removes the remaining few, and also then cleans up the assertions/http.js file to only include the ones we are using. This reduces our available step count further and prevents any confusion over the usage of the old types and the new types. * ui: Namespace CRUD acceptance tests (#7016) * Upgrade consul-api-double * Add all the things required for testing: 1. edit and index page objects 2. enable CONSUL_NSPACE_COUNT cookie setting 3. enable mutating HTTP response bodies based on URL * Add acceptance test for nspace edit/delete/list and searching	5 years ago
Kenia	b836a772fc	ui: Checks env CONSUL_UI_DISABLE_REALTIME to show/hide blocking queries toggle (#7099) ... Adds a conditional that checks env CONSUL_UI_DISABLE_REALTIME to show/hide the Blocking Queries toggle in the Settings page.	5 years ago
John Cowen	afafe677a3	ui: New Confirmation Dialogs (#7007) ... * ui: Change action-group to use new popup-menu component in intentions * ui: Slight amends to aria-menu to prevent scrolling * ui: Begin to use aria-menu/popover-menu for other elements * Use a simpler, hackier method to fix up zIndexing * ui: Implement new confirmation dialogs in other list views (#7080) This includes another amend to the popover-menu in order to allow mutiple confirmations/subpanels in the same popover menu. The functionality added here to allow this is likely to change in the future.	5 years ago
John Cowen	a65d941e76	ui: Improve configuration/env/feature flag usage (also add build time year detection) (#7072) ... * Add new getEnvironment util/function * Use new-ish `env` function in all the places * Clean up ember env file, add year detection from commit date	5 years ago
John Cowen	ac613993bb	ui: Keyboard navigation improvements (#7090) ... * ui: Improve keyboard access for some custom components * ui: Add some accessibility related metadata	5 years ago
John Cowen	e15d1466aa	ui: Discovery Chain Improvements (#7036) ... * Reorganize resolvers so its clearer what's happening * Use entire route definition for id * Clean up a tiny bit more, use guid for ids instead of JSON * ui: Externalize disco-chain utils and add initial unit testing * Add some click outside-ness for de-highlighting things	5 years ago
John Cowen	13eb536e24	ui: Use structure-icons as much as possible (#6851) ... * ui: Delete a bunch of CSS that we recently moved elsewhere * ui: Add some masking placeholders * Switch out hashicorp logo for one from structure-icons * Change copy-button to use new copy-action icon * Change secret-button to use new visibility-hide/show icons * New folder icon for KVs * Cleanup some of the icons we no longer use * Switch from %with-exit to standard-like %with-exit-icon * Move all chevrons to use structure-icons properly * Use star-fill as much as possible * Remove the remaining icons from icons/index plus the file itself	5 years ago
John Cowen	06d09d11f1	ui: Move slots to use attributes over positional params (#7032) ... * Change all instances of yield/block-slots to use attributes over positional arguments * Remove the ability to use yield/block-slots with positional params	5 years ago
John Cowen	99fae9d65a	ui: Make sure that the namespace is passed when changing a token via [Use] (#6973) ... * Pass the namespace parameter through to the repo when using a token * Refresh the namespace menu when somebody [Use]s a token	5 years ago
John Cowen	18bafaec35	ui: Cope with the possibility of receiving no namespaces (#6975)	5 years ago
John Cowen	b2c0c08e08	Ensure ember-data ids are created correct taking into account the nspace (#6974)	5 years ago
John Cowen	36728b961f	ui: Various amends for 1.7beta (#6965) ... * Remove empty init * Actually make the disco chain endpoint send the nspace, note: The backend doesn't support this as yet. * Tweak the font size of flash-messages ever so slightly * Make sure the nspace menu is kept up to date when creating a new one * Move comment to the correct place * Only refresh the namespace menu if you specifically created a nspace * Change FIXMEs to TODOs as we are happy for these to wait until later	5 years ago
John Cowen	aa680d5f0c	ui: Discovery Chain (#6746) ... * Add data layer for discovery chain (model/adapter/serializer/repo) * Add routing plus template for routing tab * Add extra deps - consul-api-double upgrade plus ngraph for graphing * Add discovery-chain and related components and helpers: 1. discovery-chain to orchestrate/view controller 2. route-card, splitter-card, resolver card to represent the 3 different node types. 3. route-match helper for easy formatting of route rules 4. dom-position to figure out where things are in order to draw lines 5. svg-curve, simple wrapper around svg's <path d=""> attribute format. 6. data-structs service. This isn't super required but we are using other data-structures provided by other third party npm modules in other yet to be merged PRs. All of these types of things will live here for easy access/injection/changability 7. Some additions to our css-var 'polyfill' for a couple of extra needed rules * Related CSS for discovery chain 1. We add a %card base component here, eventually this will go into our base folder and %stats-card will also use it for a base component. 2. New icon for failovers * ui: Discovery Chain Continued (#6939) 1. Add in the things we use for the animations 2 Use IntersectionObserver so we know when the tab is visible, otherwise the dom-position helper won't work as the dom elements don't have any display. 3. Add some base work for animations and use them a little 4. Try to detect if a resolver is a redirect. Right now this works for datacenters and namespaces, but it can't work for services and subsets - we are awaiting backend support for doing this properly. 5. Add a fake 'this service has no routes' route that says 'Default' 6. redirect icon 7. Add CSS.escape polyfill for Edge	5 years ago
John Cowen	7044aa52c8	ui: Namespace Support (#6639) ... Adds namespace support to the UI: 1. Namespace CRUD/management 2. Show Namespace in relevant areas (intentions, upstreams) 3. Main navigation bar improvements 4. Logic/integration to interact with a new `internal/acl/authorize` endpoint	5 years ago
John Cowen	f06c3adca5	ui: %form-element-textarea > %form-area-textinput typo (#6952)	5 years ago
John Cowen	74e2b95535	ui: Fixes styling of 'duplicate intention' error message (#6936)	5 years ago
John Cowen	ab461f6603	ui: Remove `writable` usage from policy and use the request instead (#6934)	5 years ago
John Cowen	520eb41393	ui: Use base fonts throughout the app (#6881) ... We've had a set of %placeholders in our base styles for quite a while but not butten the bullet to use them. This begins to use them. We had to make a small amount of tweaks to base whilst doing this, but its as we'd prefer there to be as few font placeholders as possible. We might/should be able to reduce these further at somepoint, or potentially rename them. We currently have six header fonts (or 4 header fonts/2 strong body fonts) and 3 body fonts. We also noticed an empty CSS file and deleted that while we were here. We also noticed that the bottom border of structure tabs was a pixel larger than ours so we tweaked that here also.	5 years ago
John Cowen	7f2a1e8a54	ui: Remove some javascript files we no longer use (#6853)	5 years ago
John Cowen	8017b5ab6e	ui: Ensure %app-content > %app-view-content rename is complete (#6843) ... In https://github.com/hashicorp/consul/pull/6575 we changed the name of %app-content to %app-view-content, but missed a few places that needed renaming, this corrects that.	5 years ago
John Cowen	e6ecb47765	ui: Expose checks (#6575) ... Adds visibility for `Expose.Checks` config setting for proxies. 1. Adds an 'Exposed Path' tab to the proxy detail page to show the user information on exposed paths. 2. If the users has exposed their healthchecks we also add this information to the Service detail page for this proxy (only for http2 and gRPC checks)	5 years ago
John Cowen	5a2fc5bffb	ui: CSS Upgrade (action-group,form-elements,sliding-toggle,breadcrumbs) (#6495) ... This includes an update of our CSS npm module. The majority of this is just moving files from one folder to another. 1. %breadrumbs: As well as moving we've added 'milestone' breadcrumbs 2. %checkbox-group: Moved 3. %radio-group: Moved 4. %sliding-toggle: Moved (used to be called just %toggle) 5. %form-elements: Moved and added a new %inline-alert for form field messaging (see Structure design system) 6. %action-group is now a composition of %menu-panel, %toggle-button, plus edits to existing style to bring the %action-groups inline with the dropdowns from Structure). %action-group also includes a composed %confirmation-alert that is yet to be include. This will be compiled out until we integrate it. We've also removed some of our old icon placeholders as the above work seased to use some of them. Now we done this I'd say all in all over half of our CSS components now use the CSS npm module. The CSS specific to Consul UI also uses much of this CSS module by way of helper placeholders such as our %frames.	5 years ago
John Cowen	f360137582	ui: Adds ember-data blueprints for Consul specific HTTP adapter etc (#6461) ... * ui: Adds ember-data blueprints for Consul specific HTTP adapter etc These are currently quite Consul specific, but we also overwrite the default model-test blueprint to keep the names consistent (dasherized) for easy test filtering. ``` ember generate [adapter|serializer|model|repository|route] <name> ```	5 years ago
John Cowen	77e789a4f4	ui: Add optional name="" attribute so you can name slots with it (#6740) ... Pretty soon we would like to move to XML/Angle Bracket style components. As they are XML-y it means you can't use positional parameters anymore (every 'argument' for the component requires it to use an XML-like attribute). This adds a `name=""` attribute to both block-slot and yield-slot components so we can use attributes to specify the name. We prefer using attributes from now on, whilst the positional parameter is still available yet deprecated so we can move over at whatever speed fits. We also did the same with the block params positional parameter. As a final note this entire in repo addon is a fork of `ember-block-slots`	5 years ago
John Cowen	28239e70d9	ui: Add missed calls to `_super` (#6595)	5 years ago
John Cowen	7910ab4ca6	ui: [dev] Adds express middleware, removes need to run api dev server (#6750) ... * ui: Adds some express middleware, removes need to run api dev server @hashicorp/api-double comes with a basic express based server to run the API double. This uses the express based server that ember-cli includes and uses to run your app instead. Eventually this will be moved to the @hashicorp/ember-cli-api-double addon instead. * Adds `make start-consul` to ease running a dev UI against Consul itself	5 years ago
John Cowen	e61dfe2307	ui: Upgrade tooling to node 10 now we are on a more recent ember (#6610) ... * ui: Upgrade tooling to node 10 now we are on a more recent ember * build: Also update the conatiner for building the UI We bump alpine here as 3.8 doesn't have node 10 by default whereas 3.9 does. Yarn is bumped to latest current version while we are here.	5 years ago
John Cowen	1678014132	ui: Remove `$radius-small` in favour of the `$decor-*` ones in `base` (#6605)	5 years ago
Matt Keeler	9d801d1dc2	ui: feature support templating for index.html (#6921)	5 years ago
John Cowen	5a88d4ebe1	ui: Explicitly remove properties that shouldn't be sent when saving (#6917)	5 years ago
John Cowen	f691a29240	Ensure AbortErrors have a zero status (#6839)	5 years ago
John Cowen	b3b32dc0f6	ui: UI Release Merge (ui-staging merge) (#6527) ... ## HTTPAdapter (#5637) ## Ember upgrade 2.18 > 3.12 (#6448) ### Proxies can no longer get away with not calling _super This means that we can't use create anymore to define dynamic methods. Therefore we dynamically make 2 extended Proxies on demand, and then create from those. Therefore we can call _super in the init method of the extended Proxies. ### We aren't allowed to reset a service anymore We never actually need to now anyway, this is a remnant of the refactor from browser based confirmations. We fix it as simply as possible here but will revisit and remove the old browser confirm functionality at a later date ### Revert classes to use ES5 style to workaround babel transp. probs Using a mixture of ES6 classes (and hence super) and arrow functions means that when babel transpiles the arrow functions down to ES5, a reference to this is moved before the call to super, hence causing a js error. Furthermore, we the testing environment no longer lets use use apply/call on the constructor. These errors only manifests during testing (only in the testing environment), the application itself runs fine with no problems without this change. Using ES5 style class definitions give us freedom to do all of the above without causing any errors, so we reverted these classes back to ES5 class definitions ### Skip test that seems to have changed due to a change in RSVP timing This test tests a usecase/area of the API that will probably never ever be used, it was more testing out the API. We've skipped the test for now as this doesn't affect the application itself, but left a note to come back here later to investigate further ### Remove enumerableContentDidChange Initial testing looks like we don't need to call this function anymore, the function no longer exists ### Rework Changeset.isSaving to take into account new ember APIs Setting/hanging a computedProperty of an instantiated object no longer works. Move to setting it on the prototype/class definition instead ### Change how we detect whether something requires listening New ember API's have changed how you can detect whether something is a computedProperty or not. It's not immediately clear if its even possible now. Therefore we change how we detect whether something should be listened to or not by just looking for presence of `addEventListener` ### Potentially temporary change of ci test scripts to ensure deps exist All our tooling scripts run through a Makefile (for people familiar with only using those), which then call yarn scripts which can be called independently (for people familar with only using yarn). The Makefile targets always check to make sure all the dependencies are installed before running anything that requires them (building, testing etc). The CI scripts/targets didn't follow this same route and called the yarn scripts directly (usually CI builds a cache of the dependencies first). For some reason this cache isn't doing what it usually does, and it looks as though, in CI, ember isn't installed. This commit makes the CI scripts consistently use the same method as all of the other tooling scripts (Makefile target > Install Deps if required > call yarn script). This should install the dependencies if for some reason the CI cache building doesn't complete/isn't successful. Potentially this commit may be reverted if, the root of the problem is elsewhere, although consistency is always good, so it might be a good idea to leave this commit as is even if we need to debug and fix things elsewhere. ### Make test-parallel consistent with the rest of the tooling scripts As we are here making changes for CI purposes (making test-ci consistent), we spotted that test-parallel is also inconsistent and also the README manual instructions won't work without `ember` installed globally. This commit makes everything consistent and changes the manual instructions to use the local ember instance that gets installed via yarn ### Re-wrangle catchable to fit with new ember 3.12 APIs In the upgrade from ember 3.8 > 3.12 the public interfaces for ComputedProperties have changed slightly. `meta` is no longer a public property of ComputedProperty but of a ComputedDecoratorImpl mixin instead. 7e4ba1096e/packages/%40ember/-internals/metal/lib/computed.ts (L725) There seems to be no way, by just using publically available methods, to replicate this behaviour so that we can create our own 'ComputedProperty` factory via injecting the ComputedProperty class as we did previously. 3f333bada1/ui-v2/app/utils/computed/factory.js (L1-L18) Instead we dynamically hang our `Catchable` `catch` method off the instantiated ComputedProperty. In doing it like this `ComputedProperty` has already has its `meta` method mixed in so we don't have to manually mix it in ourselves (which doesn't seem possible) This functionality is only used during our work in trying to ensure our EventSource/BlockingQuery work was as 'ember-like' as possible (i.e. using the traditional Route.model hooks and ember-like Controller properties). Our ongoing/upcoming work on a componentized approach to data a.k.a `<DataSource />` means we will be able to remove the majority of the code involved here now that it seems to be under an amount of flux in ember. ### Build bindata_assetfs.go with new UI changes	5 years ago
Dmitry Shemin	90d945590a	ui: [bugfix] Tag wrapping on detail pages (#6478) ... Makes sure that tags wrap on the detail pages for service and nodes whilst making sure they don't wrap on the listing pages.	5 years ago
John Cowen	20984e2a73	ui: re-remove the `Type` header on the service listing page (#6439) ... The `Type` column used for giving details on what type of a service each item is was removed in https://github.com/hashicorp/consul/pull/6075. As a result of keeping long running branches in sync, this change was partly reverted in an earlier PR (the type header was re-added) https://github.com/hashicorp/consul/pull/5913 following a rebase. This commit re-removes the `Type` table header (the `<th>`)	5 years ago
John Cowen	881dfa99a3	ui: Fix metaData test as result of new consul-api-double (#6436)	5 years ago
John Cowen	d1b7f92e5e	ui: Netlify previews (#6419) ... - Add netlify redirects file - Add netlify makefile target and commented config settings	5 years ago
John Cowen	2369c47033	ui: Adds a `sort-control` component for asc/desc sorting of columns etc (#6034) ... This adds the component but doesn't yet use it anywhere. No tests are added here as there isn't an awful lot to test.	5 years ago
John Cowen	24847b169e	ui: Leader icon for node listing view (#6265) ... - yarn upgrade consul-api-double which includes `status/leader` - add all the ember-data things required to call a new endpoint - Pass the new leader variable through to the template - use the new leader variable in the template to set a leader - add acceptance testing to verify leaders are highlighted - Change testing navigation/api requests to status/leader (on the node listing page, status/leader is now the last get request to be called). - Template whitespace commit (less indenting) - adds a test to to assert no errors happen with an unelected leader	5 years ago
John Cowen	ceebd53b81	ui: fix/replace magnifier icon (#6308)	5 years ago
John Cowen	44c2da3518	ui: add some additional env level URLs for easier linking (#6145) ... Right now we only use CONSUL_DOCS_URL, the others are for future usage	5 years ago
John Cowen	5debc74fa2	ui: Enable blocking queries by default (#6194) ... -Enable blocking queries by default -Change assertion to check for the last PUT request, not just any request for session destruction from a node page. Since we've now turned on blocking queries by default this means that a second GET request is made after the PUT request that we are asserting for but before the assertion itself, this meant the assertion failed. We double checked this by turning off blocking queries for this test using ``` And settings from yaml --- consul:client: blocking: 0 --- ``` which made the test pass again. As moving forwards blocking queries will be on by default, we didn't want to disable blocking queries for this test, so we now assert the last PUT request specifically. This means we continue to assert that the session has been destroyed but means we don't get into problems of ordering of requests here	5 years ago
John Cowen	e636a72ffd	ui: [Bugfix] - Sticky KV Sessions (#6166) ... Initialize session value to `null` to prevent stickiness from a session the previous KV	5 years ago
John Cowen	3a0d0833fc	ui: Upgrade ember-cli-api-double. Adds new staging env (#6136) ... ember-cli-api-double has been upgraded for 3 things: 1. Use the correct configuration flags 2. Automatically include the necessary files to enable the api doubles without requiring a server. This can be disabled to provide custom functionality (so we can stitch our BDD style testing in with this) 3. When used statically, read the cookies from the users browser to enable basic ad-hoc double editing (e.g. CONSUL_SERVICE_COUNT=100000) Once upgraded we've now moved the config to the correct place, added a new environment (staging) to use the static-style of doubles The test environment continues to use custom cookie setting and url checking so we disable this 'auto importing' by setting 'auto-import' to false for the configuration for the addon. We also added a couple of new package script targets to explicitly serve or build the UI with the entirely static UI.	5 years ago
John Cowen	a263bff6b9	ui: Change layout styling for healthcheckoutput, add CheckID (#6195)	5 years ago
John Cowen	dd91ce33d6	ui: Show the correct message when a session has been removed from a KV (#6167)	5 years ago
John Cowen	d01ef7225a	ui: Add `stats-card` component, integrate more `@hashicorp/structure-icons` (#6021) ... 1. Rebuild the heathchecked-resource component now we can copy and paste 2. As the above rebuild came with new icons, we also swapped out 'most' of the other areas where we were using these new icons, plus any icons that were effected by the new icon placeholders 3. Begin to remove more and more of the project specific icons (now replaced by the shared ones)	5 years ago
John Cowen	86208b4a70	ui: Add an additional 'more than 1 char' check for selection (#6022) ... We'd rather 'play it safe' for our selection detection (which avoids following links if you have some text selected). This commit adds an additional check of 'more than 1 character' to the 'isSelected' check. This is based on the fact that it's far quicker to type the character so why would a user select on character? This therefore caters for any fairly large (in the scheme of things) incidential mouse moves whilst clicking a link. Overall this is probably overkill	5 years ago
John Cowen	5c6fa1c458	ui: Be more exact with intent for table truncation (#6023) ... Truncation should only happen currently on table content if the tag within the td is the only child	5 years ago
John Cowen	876dd3b97d	ui: Ensure event sources are closed to the correct state when connecting (#6036) ... This fails the tests, but wouldn't produce an actual bug as the source is still set to closing, just 1 tick later.	5 years ago
John Cowen	9efe2b2ced	ui: removes `npm:` imports now we have standard importing (#6035)	5 years ago
John Cowen	62fa803d9f	ui: {{phrase-editor}} amends (#5991) ... 1. Re-focus the input element on phrase removal 2. Move all actions to `actions:` 3. Move to a form looking `value` rather than `items` 4. Move placeholder functionalit yinto the component 5. Force DDAU instead of two way binding with `slice` and `onchange` 6. Begin to deprecate the `searchable` interface	5 years ago
John Cowen	6d8a706b4d	ui: Adds the ability to frontend search instances by address (ip:port) (#5993)	5 years ago
John Cowen	01d1b3c139	ui: Small EventSource additions (#5978) ... 1. EventSources now pass themselves thorugh to the run function as a second argument. This enables the use of arrow functions along with the EventSources API `(configuration, source) => source.close()`. Order of arguments could potentially be switched at a later date. 2. BlockingEventSources now let you pass an 'event' through at instantation time. If you do this, the event will immediately be dispatched once the EventSource is opened. The usecase for this is for 'unfreezing' cached BlockingEvents. This makes it easier to provide a cache for BlockingEventSources by caching its data rather than the entire BlockingEventSource itself. ``` new BlockingEventSource( (config, source) => { /* something */ }, { cursor: 1024, // this would also come from a cache currentEvent: getFromSomeSortOfCache(eventSourceId) //this is the new bit } ); // more realistically new BlockingEventSource( (config, source) => { return data.findSomething(slug, config) }, getFromSomeSortOfCache(eventSourceId) ); ```	5 years ago
John Cowen	32387fdbcf	ui: Enable creating listeners using an object/hash (#5975) ... Makes listening to multiple events on one target slightly easier. Adding events can be rolled up into passing through an object, and the returned remove function removes all of the handlers in the object For example: ``` //this.listen... const remove = listeners.add( { 'message': handler, 'error': handler } ); remove(); // removes all listeners in the object ``` The entire API for listeners is now becoming slightly overloaded, so potentially we'd use this API always and remove the ability to use a string/function pair.	5 years ago
John Cowen	63a0582fa3	ui: Reduce mutation of html.classList (#5974) ... Throughout the app we mutate the value of the root node classList on navigation between separate pages (basically on URL change). Every template has a unique classList for example `template-service template-show` and `template-service template-list` etc etc. When navigating between 2 pages, both pages using the same template yet with different data, previoulsy we would entirely clear out the `html.classList` and then refill it again with eaxctly the same classes. This commit moves this to perform a diff previous to mutating the classList, and then potentially no classList mutating is needed when moving between 2 pages of the same template.	5 years ago
John Cowen	62e3c5605c	ui: Change vocab of ReopenableEventSource from 'reopen' to 'open' (#5973) ... You can potentially close an EventSource before its first tick by immediately setting the readyState to a non-open state. Therefore it never opens. Calling `open` will then open it. 'Open' fits better than 'reopen' when taking the above into account	5 years ago
John Cowen	0dfae99a1b	ui: Include yadda/gherkin dictionaries we use for acc testing (#5956) ... Currently these gherkin dictionaries are contained in `ember-cli-api-double`, which isn't the correct place for them. They belong with the steps themselves. This is also less complicated now we can require/import javascript using a standard approach Also runs an update of `ember-cli-api-double` which will be the last installation of version 1 of this module.	5 years ago
John Cowen	06b6aff8d0	ui: CSS Components Migration (#5913) ... Migrate roughly half of the base components into base Adds a target for easily formatting CSS Further CSS amends/migration (#5921) 1. tooltips within tables where a slightly bit troublesome due to a mix of `inline-flex`, `overflow` and the need for truncation. This refineds tooltips a slight bit more to work 'everywhere'. 2. We also move tooltip to use the correct color and min-width from structure, but we overwrite the min-width here until we get confirmation on widths/alignment of text within a tooltip. 3. Tiny fixes for breadcrumbs and toggle-buttons in tabular listings 4. Now we inline-flex our table cells, it means it is impossible to truncate text without wrapping it in another element. This wraps all Description like text in `<p>` tags. Generally the first column of text is already wrapped in an `<a>` tag. Other items such as consul tags and policy names etc get 'cutoff' rather than truncated. 5. We are now using all the icons from `@hashicorp/structure-icons`	5 years ago
John Cowen	2b30667fc7	ui: Adds ember-auto-import and replaces the 3 places where we used npm: (#5952) ... Also removes ember-browserify	5 years ago
John Cowen	df0cf11a0f	ui: Put some options in for event source runners (behind flags) (#5738)	5 years ago
John Cowen	82a2f206dc	ui: Ensure an EventSource isn't opened if closed before first tick (#5703) ... EventSources will wait for 1 tick before 'opening'. There is always the chance that the EventSource is '.close()'ed before that tick. We therefore check the 'readyState' before opening the EventSource	5 years ago
John Cowen	e609defd70	ui: Allow text selection of clickable elements and their contents (#5770) ... * ui: Allow text selection of clickable elements and their contents This commit disables a click on mousedown be removing the `href` attribute and moving it to a `data-href` attribute. On mouseup it will only move it back if there is no selection. This means that an anchor will only be followed on click _if_ there is no selection. This fixes the fact that whenever you select some copy within a clickable element it immediately throws you into the linked page when you release your mouse. Further notes: We use the `isCollapsed` property here which 'seems' to be classed as 'experimental' in one place where I researched it: https://developer.mozilla.org/en-US/docs/Web/API/Selection/isCollapsed Although in others it makes no mention of this 'experimental' e.g: - https://webplatform.github.io/docs/dom/Selection/isCollapsed/ - https://w3c.github.io/selection-api/#dom-selection-iscollapsed I may have gone a little overboard in feature detection for this, but I conscious of that fact that if `isCollapsed` doesn't exist at some point in the future (something that seems unlikely). The code here will have no effect on the UI. But I'd specifically like a second pair of eyes on that. * ui: Don't break right click, detects a secondary click on mousedown * ui: Put anchor selection capability behind an ENV var	5 years ago
John Cowen	42adafbd02	ui: Reconcile ember-data store when records are deleted via blocking (#5745) ... * ui: Reconciliate ember-data store when records are deleted via blocking Currently we are barely using the ember-data store/cache, but it will still cache records in the store even though technically we aren't using it. This adds a SyncTime to every record that uses blocking queries so we can delete older records from the ember-data cache to prevent them building up * ui: Add basic timestamp method we can access from tests, fixup tests Adds a timestamp method that we can access from within tests so we can test that the SyncTime is being set. There is probably a better way to do this, but this is also probably the simplest approach - we are also likely to revisit this at a later date	5 years ago
John Cowen	eccff12a9b	ui: Expands create-listeners API to allow recursive and functions (#5616) ... 1. Adds a Listeners class, which lets us... 2. Add Listeners recursively. So you can createListeners().add(createListeners()) 3. Also add the ability to `.add` as a plain function This moves the entire idea more towards a generic teardown utility	5 years ago
John Cowen	266c288fc0	ui: Adds readonly meta data to the serviceInstance and node detail pages (#6196)	5 years ago
Jack Pearkes	255653c6fb	Merge remote-tracking branch 'origin/master' into release/1-6	5 years ago
John Cowen	e262631900	ui: Force upgrades lodash and lodash submodules: (#6137) ... All related to: - https://github.com/lodash/lodash/pull/4336	5 years ago
John Cowen	2664a5efa5	ui: Forced upgrade handlebars from 4.0 to 4.1 (#6077) ... Force bumps [handelbars](https://github.com/wycats/handlebars.js) from 4.0 to 4.1.2 using `resolutions` - [Release Notes](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)	5 years ago
John Cowen	dcb9800442	ui: Gateway Addresses (#6075) ... - Removes 'type' icons (basically the proxy icon, not the text itself) - Add support for Mesh Gateways plus their addresses This adds a 'Mesh Gateway' type label to service and service instance pages, plus a new 'Addresses' tab if the service is a Mesh Gateway showing a table of addresses for the service - plus tests	5 years ago
Joel Kuzmarski	0598b66a80	Fix text and add feature test for copy button (#5958) ... `Copied IP Address!` > `Copied output!` Adds feature test for copy button	6 years ago
Sarah Christoff	d3d92d76f3	ui: modify content path (#5950) ... * Add ui-content-path flag * tests complete, regex validator on string, index.html updated * cleaning up debugging stuff * ui: Enable ember environment configuration to be set via the go binary at runtime (#5934) * ui: Only inject {{.ContentPath}} if we are makeing a prod build... ...otherwise we just use the current rootURL This gets injected into a <base /> node which solves the assets path problem but not the ember problem * ui: Pull out the <base href=""> value and inject it into ember env See previous commit: The <base href=""> value is 'sometimes' injected from go at index serve time. We pass this value down to ember by overwriting the ember config that is injected via a <meta> tag. This has to be done before ember bootup. Sometimes (during testing and development, basically not production) this is injected with the already existing value, in which case this essentially changes nothing. The code here is slightly abstracted away from our specific usage to make it easier for anyone else to use, and also make sure we can cope with using this same method to pass variables down from the CLI through to ember in the future. * ui: We can't use <base /> move everything to javascript (#5941) Unfortuantely we can't seem to be able to use <base> and rootURL together as URL paths will get doubled up (`ui/ui/`). This moves all the things that we need to interpolate with .ContentPath to the `startup` javascript so we can conditionally print out `{{.ContentPath}}` in lots of places (now we can't use base) * fixed when we serve index.html * ui: For writing a ContentPath, we also need to cope with testing... (#5945) ...and potentially more environments Testing has more additional things in a separate index.html in `tests/` This make the entire thing a little saner and uses just javascriopt template literals instead of a pseudo handbrake synatx for our templating of these files. Intead of just templating the entire file this way, we still only template `{{content-for 'head'}}` and `{{content-for 'body'}}` in this way to ensure we support other plugins/addons * build: Loosen up the regex for retrieving the CONSUL_VERSION (#5946) * build: Loosen up the regex for retrieving the CONSUL_VERSION 1. Previously the `sed` replacement was searching for the CONSUL_VERSION comment at the start of a line, it no longer does this to allow for indentation. 2. Both `grep` and `sed` where looking for the omment at the end of the line. We've removed this restriction here. We don't need to remove it right now, but if we ever put the comment followed by something here the searching would break. 3. Added `xargs` for trimming the resulting version string. We aren't using this already in the rest of the scripts, but we are pretty sure this is available on most systems. * ui: Fix erroneous variable, and also force an ember cache clean on build 1. We referenced a variable incorrectly here, this fixes that. 2. We also made sure that every `make` target clears ember's `tmp` cache to ensure that its not using any caches that have since been edited everytime we call a `make` target. * added docs, fixed encoding * fixed go fmt * Update agent/config/config.go Co-Authored-By: R.B. Boyer <public@richardboyer.net> * Completed Suggestions * run gofmt on http.go * fix testsanitize * fix fullconfig/hcl by setting correct 'want' * ran gofmt on agent/config/runtime_test.go * Update website/source/docs/agent/options.html.md Co-Authored-By: Hans Hasselberg <me@hans.io> * Update website/source/docs/agent/options.html.md Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com> * remove contentpath from redirectFS struct	6 years ago
John Cowen	a44541a91f	ui: Implements a testable clipboard {{copy-button}} (#5967) ... 1. Remove ember-cli-clipboard dependency 2. Provide a new copy-button component implementing the same interface as ^ but make the clipboard functionality injectable 3. Provide 2 implementations of a Clipboard. One using clipboard.js (as previously) and an additional local storage 'clipboard'. 4. add a BDD step to assert whats in the clipboard (the fake one) Main reason here is that `document.exec` must be called by a user interaction	6 years ago
John Cowen	e8722e6a35	ui: Normal proxies link to services, sidecars to instances (#5944) ... * ui: Normal proxies line to services, sidecars to instances Following on from https://github.com/hashicorp/consul/pull/5933 we noticed that 'normal' proxies should link to the service, rather than the service instance. Additionally proxy 'searching' within the repository should take into account the name of the node that the originating service is on (sidecar proxies are generally co-located) Added an additional test here to prove that a sidecar-proxy with the same service id but on a different node does not show the sidecar proxy link.	6 years ago
John Cowen	a41c13ae83	ui: Ensure Service Instance pages account for nodes (#5933) ... Include node name in the URL for service instances Integrate the node name slug into tests for service instance pages	6 years ago
John Cowen	cef378bc9b	ui: Upgrade js-yaml (#5926)	6 years ago
John Cowen	685b89bdec	ui: Adds ability to search by policy, role or service ident names (#5811)	6 years ago
John Cowen	174fcb557f	UI: Test readonly ServiceIdentity rules (#5865)	6 years ago
John Cowen	9013e53ebc	ui: Ensures nested policy forms are reset properly (#5838) ... 1. All {{ivy-codemirror}} components need 'refreshing' when they become visible via our own `didAppear` method on the `{{code-editor}}` component (also see:) - https://github.com/hashicorp/consul/pull/4190#discussion_r193270223 - 73db111db8 (r225264296) 2. On initial investigation, it looks like the component we are using for the code editor doesn't distinguish between setting its `value` programatically and a `keyup` event, i.e. an interaction from the user. We currently pretend that whenever its `value` changes, it is a `keyup` event. This means that when we reset the `value` to `""` programmatically for form resetting purposes, a 'pretend keyup' event would also be fired, which would in turn kick off the validation, which would fail and show an error message for empty values in other fields of the form - something that is perfectly valid if you haven't typed anything yet. We solved this by checking for `isPristine` on fields that are allowed to be empty before you have typed anything.	6 years ago
John Cowen	8306b2f251	ui: Replaces destroyRecord with unloadRecord for KV 404's (#5837) ... Just because Consul gives us a 404 this doesn't guarantee the KV doesn't exist, it doesn't even mean we don't have access to it. Furthermore we should never destroyRecord's without user interaction (therefore only via the repo.delete method). This switches destroyRecord to unloadRecord which performs the additional legwork to keep ember-data in sync with the actual truth. unloadRecord unloads the record from ember-data rather than sending an API delete request, which would have been the intent here.	6 years ago
John Cowen	75e221d256	ui: ACL Policies. Catch all server errors (#5836) ... Always show any server errors under Rules, not just invalid HCL	6 years ago
John Cowen	9ca416a7f5	ui: Upgrade fstream (#5912) ... Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/npm/fstream/releases) - [Commits](npm/fstream@v1.0.11...v1.0.12)	6 years ago
John Cowen	ee393e34fb	ui: Adds tick whilst editing the link template in the Settings area (#5820) ... 1. Amends our `base` animation placeholder to always reset transition-duration. This has no effect on other components that are already using this animation. 2. Adds a confirming class whenever a key is pressed, to show the green tick. Uses CSS via `transition-delay` for debouncing.	6 years ago
John Cowen	077d70ff44	ui: Previously we were passing through 'fake' events, revert to real.. (#5810) ... Previously we were creating a fake event and amending the name of the fake event, this meant that other `event.target` properties weren't being passed through (in this instance `checked`) this changes the approach to not use fake events, and allows you to overwrite the name that the form uses for `handleEvent`	6 years ago
John Cowen	793f0747c6	ui: Gives the minimal in-form token list use a maximum row size (#5807) ... This means its more straightforwards to calculate the height of the listing itself. This component is currently only used on the form pages for tokens and roles, should therefore be a restricted size.	6 years ago
John Cowen	7e2c66ad12	ui: fix production build only empty role modal (#5806) ... Adds the ability for multiple components to use the same dom buffer	6 years ago
John Cowen	727fddcae3	ui: Remove old 'default' template keyword, we now use '' for default (#5805)	6 years ago
John Cowen	249dcaf6cd	ui: Ensure room for non-hidden scrollbars (#5802)	6 years ago
John Cowen	614ac96fa6	ui: Make the proxy icon full size in service listings (#5799)	6 years ago
John Cowen	119bd02368	ui: Uses the default cursor instead of a pointer for upstream rows (#5785)	6 years ago
John Cowen	77ebad1b5e	ui: Make the Rules readonly when creating ServiceIdentities (#5784) ... Skipped test added for nagging for the moment	6 years ago
John Cowen	677e3d89e2	ui: Upgrades the indirect dependency on jQuery to ^3.4.0 (#5783)	6 years ago
John Cowen	a37d6aaac2	ui: Don't look for isDescriptor on null (related to null proxies) (#5782)	6 years ago
John Cowen	999426794f	ui: Adds {{Datacenter}} keyword for URL template interpolation (#5768) ... 1. Includes Datacenter variable for intperolation 2. Amends text on the Settings page to reflect new keyword 3. Adds further acceptance testing around the new dashboard buttons	6 years ago
John Cowen	71c0db4229	ui: URL encodes any varaibles interpolated into the template... (#5766) ... Encodes any variables passed in to be used for template interpolation, but importantly nothing else in the URL apart from the variables themselves. 'Generally' service names are reasonably URL safe, but we know of usecases using at least /s in service names.	6 years ago
John Cowen	e971d21716	ui: Fix CSS related to icons and h2 changes done in different PRs ... The way icons are positioned was changed to enable icons for policy names, and in a separate PR h2's where altered to provide a nicer looking settings page. Once these PR's where merged together they slighly effected each other. This commit tweaks the CSS to refine, but will be revisted at a later date	6 years ago
John Cowen	7eda188382	ui: Re-fix old erroneous link	6 years ago
John Cowen	d88b2d4150	ui: dashboard links (#5704) ... This PR adds a new {{template-anchor}} component. This component lets you specify a 'href template' in a handlebars like format instead of a normal string href. This template will be interpolated with the contents of a vars="" attribute. Also contains code to add an extra UI Setting to be able to store a template to be used for this anchor in localStorage	6 years ago
John Cowen	482426b13e	UI: ACL Roles (#5635) ... Adds support for ACL Roles and Service Identities CRUD, along with necessary changes to Tokens, and the CSS improvements required. Also includes refinements/improvements for easier testing of deeply nested components. 1. ember-data adapter/serializer/model triplet for Roles 2. repository, form/validations and searching filter for Roles 3. Moves potentially, repeated, or soon to to repeated functionality into a mixin (mainly for 'many policy' relationships) 4. A few styling tweaks for little edge cases around roles 5. Router additions, Route, Controller and templates for Roles Also see: * UI: ACL Roles cont. plus Service Identities (#5661 and #5720)	6 years ago
John Cowen	eeb7a858e2	ui: Search improvements (#5540) ... * ui: Replaces Service listing filterbar with a phrase-editor search (#5507) 1. New phrase-editor restricting search to whole phrases (acts on enter key). Allows removal of previously entered phrases 2. Searching now allows arrays of terms, multiple terms work via AND	6 years ago
John Cowen	cbbfaba6ac	ui: Adds easily accessible `env` for user settable 'debug' settings (#5668) ... This is a synchronous only 'debug' setting accessor, uses localStorage first and falls back to ember config.	6 years ago
John Cowen	21732d57a8	ui: Closes the proxy blocking query for the service instance on dereg (#5667) ... If a service instance show page is being viewed and the service instance is deregistered, this closes the blocking query for the proxy as well as the instance (the instances query will be clsed on the error) Also adds skipped tests to nag in future	6 years ago
John Cowen	e5d59f1dd3	ui: Fixes RTT display, by ensuring use of ember proxies in tomography (#5666) ... Previously the tomography wasn't using ember `get` so proxy updates (specifically here whilst receiving a blocking update) wasn't working. This adds `get` here until we update to newer `get`less ember and also refactors slightly removing `n` and using `distance.length` instead Skipped tests are adding here to nag us to come back here at some point.	6 years ago
John Cowen	6474cec99c	ui: Alter resizing for tabular-collection for sizing based on rows (#5586)	6 years ago
John Cowen	cbded4a10a	ui: Improvements to modal-dialog (#5585) ... 1. If the modal gets bigger than 80% of the viewport height a scrollbar will be shown. Currently there isn't anywhere it can get this big, but future work involves possible larger modals 2. Usually its difficult to figure out which was the 'unchecked' radio button using an onchange event. Luckily ember/handlebars changes its properties after the onchange event, so knowing that and using an extra data-checked attribute set via ember, we can figure out which radio button has been 'unchecked'. This means the logic for opening an closing modals becomes slightly easier	6 years ago
John Cowen	417d3030be	ui: Adds uid to tabular-details for/id's used in toggling for uniqueness (#5584)	6 years ago
John Cowen	255528aaa7	ui: Adds _super in places where it had been missed (mainly dom-buffer) (#5583)	6 years ago
John Cowen	a7c479e073	ui: Increases the pause between blocking queries to 2000ms (#5582) ... ...also: Temporarily overwrites native setTimeout and setInterval for e2e/acceptance testing similar to how XHR is overwritten for e2e/acceptance testing. This makes the blocking query acceptance tests run faster until we add a better burstable rate limiter for blocking queries.	6 years ago
John Cowen	4a9d259304	ui: Remove index.html from the docs URL so we just point to `/docs` (#5547)	6 years ago
John Cowen	a14a37a078	UI: Add support for blocking queries on the service instance detail page (#5487) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that. Also: Add support for blocking queries on the service instance detail page 1. Previous we could return undefined when a service instance has no proxy, but this means we have nothing to attach `meta` to. We've changed this to return an almost empty object, so with only a meta property. At first glance there doesn't seem to be any way to provide a proxy object to templates and be able to detect whether it is actually null or not so we instead change some conditional logic in the templates to detect the property we are using to generate the anchor. 2. Made a `pauseUntil` test helper function for steps where we wait for things. This helps for DRYness but also means if we can move away from setInterval to something else later, we can do it in one place 3. Whilst running into point 1 here, we managed to make the blocking queries eternally loop. Whilst this is due to an error in the code and shouldn't ever happen whilst in actual use, we've added an extra check so that we only recur/loop the blocking query if the previous response has a `meta.cursor` Adds support for blocking queries on the node detail page (#5489) 1. Moves data re-shaping for the templates variables into a repository so they are easily covered by blocking queries (into coordinatesRepo) 2. The node API returns a 404 as signal for deregistration, we also close the sessions and coordinates blocking queries when this happens	6 years ago
John Cowen	9daf8f53d9	ui: Adds blocking query support to the service detail page (#5479) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that.	6 years ago
John Cowen	e2df5de795	UI: Add blocking cursor validation and more straightforward throttle (#5470) ... More recommendations for blocking queries clients was added here: https://github.com/hashicorp/consul/pull/5358 This commit mainly adds cursor/index validation/correction based on these recommendations (plus tests) The recommendations also suggest that clients should include rate limiting. Because of this, we've moved the throttling out of Consul UI specific code and into Blocking Query specific code. Currently the 'rate limiting' in this commit only adds a sleep to every iteration of the loop, which is not the recommended approach, but the code here organizes the throttling functionality into something we can work with later to provide something more apt.	6 years ago
John Cowen	83cd4684c6	UI: Amends blocking queries text and toggle component in settings (#5467)	6 years ago
John Cowen	10c1f29ffa	ui: Add proxy icons to proxy services and instances where appropriate (#5463)	6 years ago
John Cowen	3d76540297	ui: Fix erroneous HTML that was being fixed by either browser/ember (#5530) ... The resulting DOM from this template was actually correct, we'd assume it was being fixed by the browser	6 years ago
John Cowen	5dd9cd2d2e	UI: Add forking based on service instance id existence (#5392) ... * ui: Add forking based on service instance id existence Proxies come in 2 flavours, 'normal' and sidecar. We know when a proxy is a sidecar proxy based on whether a DestinationServiceID is set. LocalServiceAddress and LocalServicePort are only relevant for sidecar proxies. This adds template logic to show different text depending on this information. Additionally adds test around connect proxies (#5418) 1. Adds page object for the instance detail page 2. Adds further scenario steps used in the tests 3. Adds acceptance testing around the instance detail page. Services with proxies and the sidecar proxies and proxies themselves 4. Adds datacenter column for upstreams 5. Fixes bug routing bug for decision as to whether to request proxy information or not	6 years ago
John Cowen	20e1a39aef	ui: remove call to super in setupController (#5383)	6 years ago
John Cowen	11ccea88e1	ui: Amend breakpoints for new numberless filter buttons (#5381)	6 years ago
John Cowen	18b0de2785	UI: Use custom block-slots for changeableset	6 years ago
John Cowen	8f35715e47	UI: Service Numbers (#5348) ... Add totals to some listing views, remove healthcheck totals 1. Adds markup to render totals for Services, Nodes, Intentions and v1 ACLs 2. Removes counts from healthcheck filters, and therefore simplify text, moving the copy to the templates 3. Alter test to reflect the fact that the text of the buttons are no static in the component template rather than a dynamic attribute	6 years ago
John Cowen	355f034822	UI: Service Instances (#5326) ... This gives more prominence to 'Service Instances' as opposed to 'Services'. It also begins to surface Connect related 'nouns' such as 'Proxies' and 'Upstreams' and begins to interconnect them giving more visibility to operators. Various smaller changes: 1. Move healthcheck-status component to healthcheck-output 2. Create a new healthcheck-status component for showing the number of checks plus its icon 3. Create a new healthcheck-info component to group multiple statuses plus a different view if there are no checks 4. Componentize tag-list	6 years ago
John Cowen	cfa4bc264e	UI: Add ember steps:list command for listing available steps (#5255) ... * ui: Add ember steps:list command for listing available steps 1. Adds `command` addon to house the new command 2. Start to organize out the steps themselves, bring a bit more order to things ready to dedupe and cleanup	6 years ago
John Cowen	cb0c5309c9	UI: Add EventSource ready for implementing blocking queries (#5070) ... - Maintain http headers as JSON-API meta for all API requests (#4946) - Add EventSource ready for implementing blocking queries - EventSource project implementation to enable blocking queries for service and node listings (#5267) - Add setting to enable/disable blocking queries (#5352)	6 years ago
John Cowen	f225da36f1	ui: Correctly rebase own token/no delete change	6 years ago
John Cowen	516610eb0b	ui: Adds XHR connection management to HTTP/1.1 installs (#5083) ... Adds xhr connection managment to http/1.1 installs This includes various things: 1. An object pool to 'acquire', 'release' and 'dispose' of objects, also a 'purge' to completely empty it 2. A `Request` data object, mainly for reasoning about the object better 3. A pseudo http 'client' which doens't actually control the request itself but does help to manage the connections An initializer is used to detect the script element of the consul-ui sourcecode which we use later to sniff the protocol that we are most likely using for API access	6 years ago
John Cowen	4d183ef743	ui: Adds 2 computed utilities, a factory and a purify (#5079) ... 1. The factory is taken from the ember source, but makes it more reusable 2. Purify converts conventional ember `computed` into a pure version This commit only adds new files that could be used further down the line	6 years ago
John Cowen	c71f718bc7	ui: Adds controller lifecycle `reset` hook (#5056)	6 years ago
John Cowen	2920f73ddd	ui: Adds `document` and `viewport` methods to the dom service (#5052) ... `window` and `document` are easily injected anyhow, but this primarily this keeps everything dom related in the same place. Included here are changes to make all ember related objects use the dom service `document` and `viewport` instead of just `document` and `window`. Quote from a previous PR (#4924) which explains the thinking around this: > Now I have all these things in the dom service, it would make sense to get window from there also. I was thinking of making a viewport method, which would be a nice word whether window was a browser window, an iframe (not really a window) like when ember testing, or anything else. To me the viewport is what we are actually talking about here.	6 years ago
John Cowen	ebfddaaace	ui: ember-data AbortError should have a `0` status (#5048)	6 years ago
John Cowen	bf50beff42	ui: Prefer `cursor` over `index`, add `configuration` option to repos (#5042)	6 years ago
John Cowen	338527cc2e	ui: Adds better error passthrough, disable/unauthorize properly on error (#5041) ... 1. Ensure any unexpected developer errors are passed through/shown 2. Previously when errors where returns/resolved the special isEnabled/isAuthorized would never get resolved. This was fine as they were set to false to start with anyway, but this resolves them again to false for completeness 3. Improved unit testing coverage	6 years ago
John Cowen	23a236ae95	ui: Adds warning flash messages (yellow with warning icon) (#5033)	6 years ago
John Cowen	acd121f988	ui: Rename extended Component variables, tweak some comments (#5021)	6 years ago
John Cowen	845081e871	ui: Resolve bad rebase and add in KV test for change of GET for KVs (#5000)	6 years ago
John Cowen	7fc59af7e2	ui: Pass GET data and clean certain values for KV's ensuring consistency (#4991)	6 years ago
John Cowen	7dc7d325dc	ui: Fixup tests to expect the new `meta` property on listings (#4990)	6 years ago
John Cowen	f7d2651ac3	ui: Maintain http headers as JSON-API meta for all API requests (#4946)	6 years ago
John Cowen	9ec7f3851b	UI: Use buttons instead of anchors where appropriate (#4939) ... Use buttons instead of anchors where appropriate	6 years ago
John Cowen	3780622df0	ui: Move intention source/destination menus use text from the template (#4938)	6 years ago
John Cowen	4368040a4a	UI: Move legacy ACLs, KVs and Intentions to use `form` functionality (#4936) ... Change legacy acls, kvs and intentions to use `form`s	6 years ago
John Cowen	104e6bac71	UI: Move legacy ACLs to use the new searchables/changeable-sets (#4933)	6 years ago
John Cowen	c532e53d9a	UI: dom usage refactoring (#4924) ... Move all the dom-things to use the dom service in tabular-collection, feedback-dialog, list-collection and node show. Move get-component-factory into utils/dom and use dom.root() in a few more places This includes an additional `dom.components` method which gives you a list of components matching the selector instead of just one.	6 years ago
John Cowen	d46b059673	UI: CSS Refactor (#4919) ... - Adds full set of svg icons as CSS/Sass variables to the source - Starts picking out some frame-grays, whilst commenting in possibles - Remove color prefixing The prefixes `ui-` and `brand-` for colors hav been removed. This makes colors slightly easier to type. In order to differentiate between brand colors and 'normal' colors, normal colors are named as 'true colors' i.e. blue, red, green etc etc whereas the brand colors used a more premium sounding name such as 'steel' for vault gray, 'magenta' for consul, 'cobalt' for vagrant etc etc.	6 years ago
John Cowen	3879487ab8	ui: Prefer using `notOk(actual)` instead of `ok(!actual)` in tests (#4925) ... And make sure its consistent throughout the app	6 years ago
John Cowen	d6c1b9ed3f	ui: Move ACL policy and token repos to use the RepositoryService (#4867)	6 years ago
John Cowen	c9fae76b7d	ui: Refactors the code-mirror linting/restrict legacy tokens to HCL (#4866)	6 years ago
John Cowen	65ef2969c7	ui: Async Search (#4859) ... This does several things to make improving the search experience easier moving forwards: 1. Separate searching off from filtering. 'Searching' can be thought of as specifically 'text searching' whilst filtering is more of a boolean/flag search. 2. Decouple the actual searching functionality to almost pure, isolated / unit testable units and unit test. (I still import embers get which, once I upgrade to 3.5, I shouldn't need) 3. Searching rules are now configurable from the outside, i.e. not wrapped in Controllers or Components. 4. General searching itself now can use an asynchronous approach based on events. This prepares for future possibilities of handing off the searching to a web worker or elsewhere, which should aid in large scale searching and prepares the way for other searching methods. 5. Adds the possibility of have multiple searches in one template/route/page. Additionally, this adds a WithSearching mixin to aid linking the searching to ember in an ember-like way in a single place. Plus a WithListeners mixin to aid with cleaning up of event listeners on Controller/Component destruction. Post-initial work I slightly changed the API of create listeners: Returning the handler from a `remover` means you can re-add it again if you want to, this avoids having to save a reference to the handler elsewhere to do the same. The `remove` method itself now returns an array of handlers, again you might want to use these again or something, and its also more useful then just returning an empty array. The more I look at this the more I doubt that you'll ever use `remove` to remove individual handlers, you may aswell just use the `remover` returned from add. I've added some comments to reflect this, but they'll likely be removed once I'm absolutely sure of this. I also added some comments for WithSearching to explain possible further work re: moving `searchParams` so it can be `hung` off the controller object	6 years ago
John Cowen	ae71d6ce96	ui: Custom version of ember-block-slots compatible with ember 3 (#5245) ... The original version of ember-block-slots doesn't support ember 3 and it seems like development has stalled on the original version. This adds a modified version as an in-repo-addon that is compatible with ember 3.	6 years ago
John Cowen	acee937f69	ui: Bump footer date (#5279)	6 years ago
John Cowen	a35fe7c5ba	ui: Removes delete button form pages that show your current token (#5241) ... Tokens can no longer delete themselves see: https://github.com/hashicorp/consul/pull/5210 ...so we remove the button to allow you to do that from the UI	6 years ago
John Cowen	c8386ec0cc	UI: [BUGFIX] Decode/encode urls (#5206) ... In 858b05fc31 (diff-46ef88aa04507fb9b039344277531584) we removed encoding values in pathnames as we thought they were eventually being encoded by `ember`. It looks like this isn't the case. Turns out sometimes they are encoded sometimes they aren't. It's complicated. If at all possible refer to the PR https://github.com/hashicorp/consul/pull/5206. It's related to the difference between `dynamic` routes and `wildcard` routes. Partly related to this is a decision on whether we urlencode the slashes within service names or not. Whilst historically we haven't done this, we feel its a good time to change this behaviour, so we'll also be changing services to use dynamic routes instead of wildcard routes. So service links will then look like /ui/dc-1/services/application%2Fservice rather than /ui/dc-1/services/application/service Here, we define our routes in a declarative format (for the moment at least JSON) outside of Router.map, and loop through this within Router.map to set all our routes using the standard this.route method. We essentially configure our Router from the outside. As this configuration is now done declaratively outside of Router.map we can also make this data available to href-to and paramsFor, allowing us to detect wildcard routes and therefore apply urlencoding/decoding. Where I mention 'conditionally' below, this is detection is what is used for the decision. We conditionally add url encoding to the `{{href-to}}` helper/addon. The reasoning here is, if we are asking for a 'href/url' then whatever we receive back should always be urlencoded. We've done this by reusing as much code from the original `ember-href-to` addon as possible, after this change every call to the `{{href-to}}` helper will be urlencoded. As all links using `{{href-to}}` are now properly urlencoded. We also need to decode them in the correct place 'on the other end', so.. We also override the default `Route.paramsFor` method to conditionally decode all params before passing them to the `Route.model` hook. Lastly (the revert), as we almost consistently use url params to construct API calls, we make sure we re-encode any slugs that have been passed in by the user/developer. The original API for the `createURL` function was to allow you to pass values that didn't need encoding, values that **did** need encoding, followed by query params (which again require url encoding) All in all this should make the entire ember app url encode/decode safe.	6 years ago
John Cowen	66c139ceae	UI: Text change and clarity Node Health > Health Checks (#5115) ... Text change Node Health > Health Checks Also adds an info icon and tooltip to Health Checks column header	6 years ago
Jihoon Chung	d5e28bda56	ui: Fix typo in acl-migration guide link (#5135)	6 years ago
Alvin Huang	5425a86058	add documentation on how to use ember-exam	6 years ago
Alvin Huang	f623b9817e	add test-parallel yarn command	6 years ago
Alvin Huang	c4a837c7b5	change env to test	6 years ago
Alvin Huang	3feb26f30d	adding build-ci yarn target	6 years ago
Alvin Huang	a92fa407d5	output XML test results	6 years ago
Alvin Huang	93490c600b	enable ember-exam	6 years ago
Alvin Huang	5b6ea377b4	update testem with newer conventions	6 years ago
Alvin Huang	45cf7dec4f	adding ember-exam package	6 years ago
Hans Hasselberg	0b4a879203	ui: serve /robots.txt when UI is enabled. (#5089) ... * serve /robots.txt * robots.txt: disallow everything	6 years ago
John Cowen	8433b26b78	ui: Correctly escape an inline svg icon (#5032)	6 years ago
John Cowen	7ecbb63102	ui: Add AWS external-source icon (#5030)	6 years ago
John Cowen	9c11109db4	ui: If a service has no external-source, don't show the icon (#4996)	6 years ago
John Cowen	e1fb21cd4c	ui: Adds the CONSUL_VERSION env var into the HTML source in a comment (#4993)	6 years ago
John Cowen	c6db97b666	UI: Removes success notification on faking a success response for `self` (#4906) ... In order to continue supporting the legacy ACL system, we replace the 500 error from a non-existent `self` endpoint with a response of a `null` `AccessorID` - which makes sense (a null AccessorID means old API) We then redirect the user to the old ACL pages which then gives a 403 if their token was wrong which then redirects them back to the login page. Due to the multiple redirects and not wanting to test the validity of the token before redirecting (thus calling the same API endpoint twice), it is not straightforwards to turn the 'faked' response from the `self` endpoint into an error (flash messages are 'lost' through multiple redirects). In order to make this a slightly better experience, you can now return a `false` during execution of an action requiring success/failure feedback, this essentially skips the notification, so if the action is 'successful' but you don't want to show the notification, you can. This resolves showing a successful notification when the `self` endpoint response is faked. The last part of the puzzle is to make sure that the global 403 catching error in the application Route also produces an erroneous notification. Please note this can only happen with a ui client using the new ACL system when communicating with a cluster using the old ACL system, and only when you enter the wrong token. Lastly, further acceptance tests have been added around this This commit also adds functionality to avoid any possible double notification messages, to avoid UI overlapping	6 years ago
John Cowen	7ddafc45d9	ui: Make empty Rules ('') take priority over a `Legacy: true` (#4899) ... Even if an old style token has a Legacy of true, yet it has an empty set of Rules, treat the token as a new style token, as its essentially the same	6 years ago
John Cowen	f65f001675	UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) ... In some circumstances a consul 1.4 client could be running in an un-upgraded 1.3 or lower cluster. Currently this gives a 500 error on the new ACL token endpoint. Here we catch this specific 500 error/message and set the users AccessorID to null. Elsewhere in the frontend we use this fact (AccessorID being null) to decide whether to present the legacy or the new ACL UI to the user. Also: - Re-adds in most of the old style ACL acceptance tests, now that we are keeping the old style UI - Restricts code editors to HCL only mode for all `Rules` editing (legacy/'half legacy'/new style) - Adds a [Stop using] button to the old style ACL rows so its possible to logout. - Updates copy and documentation links for the upgrade notices	6 years ago
John Cowen	de6644675d	ui: Brings the new ACLs into line with the new repo folder structure (#4857) ... This PR updates the folder structure and naming of the new ACLs, the same as #4694 .	6 years ago
John Cowen	f1246801b1	ui: Some trivial test additions, support env var passing of port numbers (#4728) ... 1. Unskip some trivial tests that were being tested higher up 2. Istanbul ignore some code for coverage. 1. Things that I didn't write and need to 100% follow 2. The source code checking test that has Istanbul code injected into it 3. Add a few simple test cases 4. Support passing port numbers through to `ember serve` and `ember test` for use cases that would benefit from being able to configure the ports things are served over but still use `yarn run` thus reusing the `yarn run` config in `package.json`	6 years ago
John Cowen	14aa90e309	ui: Move repo services to repository/ folder and standardize naming (#4694) ... Repositories are a class of services to help with CRUD actions, most of the functionality is reused across various Models. This creates a new repository service that centralizes all this reused functionality. Inheritance via ember `Service.extend` is used as opposed to decorating via Mixins. 1. Move all repository services (and their tests) to a services/repository folder 2. Standardize on a singular name format 'node vs nodes' 3. Create a new 'repository' service to centralize functionality. This should be extended by 'repository' services	6 years ago
John Cowen	d98c1242dc	ui: Adds multi syntax linting to the code editor (#4814)	6 years ago
John Cowen	7d89e519a2	UI: New ACLs (#4789) ... UI to accompany the new ACLs APIs	6 years ago
John Cowen	297788408b	ui: Fix freetext searching within the nodes page (#4819) ... Essentially this was missing a call to `super`. The error unfortuantely didn't arise in the tests as it only errors when the node list has 4 items are more (the 4 columns), and the acceptence tests by change were only filling the page with 3 nodes for test purposes. I've bumped the amount of nodes up to 4 in the tests, which then causes the tests to fail, made the fix by adding the `super` call, and the tests now pass. I also tested the UI/text searching on a 10,000 node system, and everything now works as expected.	6 years ago
John Cowen	5f39bfd161	ui: Improve layout of node cards on large and small screens (#4761) ... 1. The grid based unhealthy cards are now clamped to only four wide maximum. This means that on larger screen the cards are much wider meaning you can view more information. Grid gutters are also clamped at a certain ideal width screen, remaining responsive for anything below this. 2. The healthy node columns are finally responsive following the same column rules as unhealthy nodes	6 years ago
John Cowen	461db096ed	ui: Add truncation to the `.Address` (#4760)	6 years ago
John Cowen	b75731aaec	ui: Cope with service names that contain slashes (#4756)	6 years ago
John Cowen	3410f5955a	ui: Reduce the breakpoint at which the smaller footer kicks in (#4723)	6 years ago
John Cowen	8ba1c549a9	ui: Move the text encoding polyfill to a a proper detecting polyfill (#4767)	6 years ago
John Cowen	9da8ad8f3d	UI: Package upgrades (#4740) ... Upgrade all patch and minor upgradeable packages, also uses `only` in ember-cli-build to reduce the included helpers from certain helper packages. Make some major version upgrades for some dev tools - husky - lint-staged - ember-cli-yadda - ember-cli-sass (also moved from node-sass to dart-sass) Minor tweak: spotted css file (instead of scss file), rename The move to `dart-sass`: dart-sass has been the primary implementation of sass for ~6 months and will receive updates earlier than libsass (ruby-sass itself is now deprecated) Other benefits include not having to recompile (via `npm rebuild` or similar) when switching platforms and an 'almost' javascript based solution. This update also alters some media queries that, whilst wouldn't compile anymore with either an updated libsass or dart-sass, where probably a little over complicated anyway, I've therefore made them similar to other breakpoints that made sense.	6 years ago
John Cowen	99c51c9f86	UI: Reduce in-development deprecations (also use toLocaleString) (#4677) ... Various ember addons produced deprecation messages, some in the browser console and some in terminal. Upgrading and replacing some of these has reduced this. Upgrades: - ember-collection - ember-computed-style Replacements: - ember-pluralize replaced with ember-inflector - ember-cli-format-number replaced with custom helper using standard `toLocaleString` Removing ember-cli-format-number also meant some further changes related to decimal places in the tomography graph, done using `toFixed` The ExternalSources background-images have also now been escaped correctly preventing in-development `console` warnings. The only deprecation warnings are now from ember-block-slots, only in terminal, making for a better development experience overall, especially now we have an empty browser console Also adds a `callIfType` 'helper util' which is a util specifically for helpers (it conforms to a helper argument signature) to be expanded upon later.	6 years ago
John Cowen	96508e556b	ui: Layout fix. Small padding additions to tables (#4701) ... 1. The 'Services' header need to be knocked ot the right slightly to line up properly with the service name when there are no external source icons. 2. Add a single space between ServiceName and ServiceID on the Node > [Services] tab table.	6 years ago
John Cowen	ece09e300d	UI: Tooltips and feedback-dialogs are the same thing - merge (#4678)	6 years ago
John Cowen	d0405ba8b9	UI: CSS Additions (mainly %frames) (#4623) ... * Move almost everything to use %frames * Fix pill styles of ACL types * Remove horizontal scrollbars from dom recycling scroller component * Make text areas look ok in Firefox * Remove ember-bulma-css * New form elements, break out %toggle * %button design tweaks * %form-element design tweaks * Better hashicorp logo * Small screen CSS improvements (#4624) 1. Reduce header size when there are no breadcrumbs 2. Make the filters toggleable, closed by default 3. Reduce the size of the footer on small screens 4. Hide all non-primary columns for forms 5. Slightly change the layout of various items, mainly buttons within forms 6. Make some confirmation dialogs work vertically on small screens. Guessing we might be better just using native confirmations on small screens	6 years ago
John Cowen	89620b93c2	ui: Turn off the code editor whilst making an edit during testing (#4668) ... Having the code editor on removes the text area from the DOM, making it more difficult to enter text in the text editor during testing. This turns the code editor off whilst making edits during testing. No changes to UI code	6 years ago
John Cowen	eb218ab93f	ui: Test bugfix. Specifically set deny for intention creation (#4663) ... Make sure we speficially set and test for deny on testing intention creation	6 years ago
John Cowen	5bb38f6ab5	ui: Tests Bugfix. Reflect extra json property `ExternalSources` in mocks (#4662) ... The mocks where using randomly generated `ExternalSources` this change makes sure they are fixed so we can reliably test the values. No change to actual UI code	6 years ago
John Cowen	028875a732	UI: Set the CODE view as the default view for editing KV's (#4651) ... Sets the code toggle on the KV edit/create page to be on by default, we figured most people probably prefer this view. Also, previously we forced the KV toggle back to a default setting for every time you visited a KV form page. We've now changed this so that the KV code toggle button acts as a 'global' toggle. So whatever you set it as will be the same for every KV for the lifetime of your 'ember session' If we are to keep this, then consider saving this into localStorage settings or similar, added some thoughts in comments re: this as it's very likely to happen.	6 years ago
John Cowen	f54fd21946	ui: [BUGFIX] Intentions were showing the wrong notification on creation (#4658) ... The error notification was being shown on creation of an intention. This was as a result of #4572 and/or #4572 and has not been included in a release. This includes a fix, plus tests to try to prevent any further regression.	6 years ago
John Cowen	0757a08684	ui: Adds a `default` view helper for providing a default value (#4650) ... If the first value passed to the helper is an empty string or undefined then return the second value	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640) ... 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago
John Cowen	981882d5ff	UI: Bugfix. Remove split view code editor (#4615) ... When adding an auto resizing (heightwise) code editor, the ivy-codemirror plugin seems to do this using more nested divs. This div had a horizontal scroller but couldn't be seen on some platforms (with hidden scrollbars). This commit makes the code editor slightly more usable and more visually correct by removing the scroll bar in this div to stop producing the 'split view look', yet keeping the horizontal scroller at the bottom of the code editor for when you enter code that is wider than the area. A max-width has also been added here to prevent the text area from growing off the side of the page. Another improvement to the code editor here is the addition of a nicer color for hightlighting text selection so its at least visible. Lastly, there was a way you could get the bottom horizontal scrollbar to overlay the code in the editor. This makes sure there is always some space at the bottom of the editor to make sure the code won't be obscured	6 years ago
John Cowen	e5f300dd21	UI: Bugfix. Move to a different TextEncoder/Decoder (#4613) ... 1. The previously used TextEncoder/Decoder (used as a polyfill for browsers that don't have a native version) didn't expose an encoder via CommonJS. Use a different polyfill that exposes both a decoder and an encoder. 2. The feature detection itself was flawed. This does a less error prone detection that ensures native encoding/decoding where available and polyfilled encoding/decoding where not available.	6 years ago
John Cowen	5e987965fa	UI: Bugfix. Fix code toggle in Safari (#4608) ... I'd mistakenly changed the checkbox event to listen to oninput, which works in Chrome and Firefox. Changed this back to onchange as it should be.	6 years ago
John Cowen	40e71f1b91	UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) ... * Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.	6 years ago
John Cowen	b41cad6fdf	UI: CSS refactor (#4430) + Fullscreen Layout (#4435) ... * Begin refactoring CSS into component folders. Moved most components into layout/skin folders, left out a couple of ones I want to think about more. * Adjust grays based on recent Structure changes * Switch to fullscreen layout for lists and detail, left aligned forms (#4435) * Specifically use the 'actions_close' label, not just the :last-child (actions-group) * Replace some non-var-ed colours in vaults code skin, plus prefixing (black and white)	6 years ago
John Cowen	7bb35c4c78	UI: Repo layer integration tests (#4454) (#4563) ... ui: Repo layer integration tests for methods that touch the API Includes a `repo` test helper to make repetitive tasks easier, plus a injectable reporter for sending performance metrics to a centralized metrics system Also noticed somewhere in the ember models that I'd like to improve, but left for the moment to make sure I concentrate on one task at a time, more or less: The tests currently asserts against the existing JSON tree, which doesn't seem to be a very nice tree. The work at hand here is to refactor what is there, so test for the not nice tree to ensure we don't get any regression, and add a skipped test so I can come back here later	6 years ago
John Cowen	1b3d566a7a	UI: Begin unskipping some more trivial tests (#4574) ... WIP Unskip some lower level trivial tests. This is the beginning of work to unskip some of the more trivial tests that I'd skipped a while back (if the thing they are testing broke, they would have failed higher up in other acceptance tests). I'd rather keep the tests, as they do test things in a more isolated manner, and the plan was to always come back and work to unskip them time allowing. I didn't get to far into this work in progress here, but I'd rather merge what I've done all the same and come back at a later date and continue.	6 years ago
John Cowen	4ebd70e6cd	UI: Fixes healthy node listing resize on large portrait screens (#4564) ... 1. Split the resizing functionality of into a separate mixin to be shared across components 2. Add basic integration tests to prove that everything is getting called through out the lifetime of the app. I decided against unit testing as there isn't really any isolated logic to be tested, more checking that things are being called in the correct order etc i.e. the integration is correct. Adds assertion to with-resizing so its obvious to override `resize`	6 years ago
John Cowen	80a307cb9f	UI: Add conditional enterprise logo (#4432) ... Adds additional 'enterprise' text underneath the 'startup' logo if the ui is built with a CONSUL_BINARY_TYPE environment variable that doesn't equal `oss`.	6 years ago
John Cowen	fde41467cf	ui: Adds bottom breathing space on the bottom of forms (#4433)	6 years ago
John Cowen	12811c0844	UI - Refactor Adapter.handleResponse (#4398) ... * Add some tests to check the correct GET API endpoints are called * Refactor adapters 1. Add integration tests for `urlFor...` and majority `handleResponse` methods 2. Refactor out `handleResponse` a little more into single/batch/boolean methods 3. Move setting of the `Datacenter` property into the `handleResponse` method, basically the same place that the uid is being set using the dc parsed form the URL 4. Add some Errors for if you don't pass ids to certain `urlFor` methods	6 years ago
John Cowen	45d85542a9	UI - Non-prod CSS sourcemaps (#4418)	6 years ago
John Cowen	0663bdbe90	Merge pull request #4410 from hashicorp/bugfix/gh-4175-service-ip ... UI - Bugfix: Show Service IP not the Node IP	6 years ago
John Cowen	d4b548ad14	Merge pull request #4383 from hashicorp/feature/ui-tag-text-search ... UI - Tag Text Search	6 years ago
John Cowen	e7a3235afc	Use `some` for the tags search instead of munging and searching	6 years ago
John Cowen	09a885dadd	ADd some extra tests to pick up on searching by two joined tags	6 years ago
John Cowen	d510e1e6d3	Add basic searching by tags using the freetext search near-term	6 years ago
John Cowen	3c40abcbae	Acceptance test for searching service by tag	6 years ago
John Cowen	b924ff87df	Merge pull request #4349 from hashicorp/feature/remove-rm-api-double ... UI - Stop trying to remove consul-api-double we don't need to anymore	6 years ago
John Cowen	1d31bef0a4	Show the Service.IP address instead of the Node.IP address in detail	6 years ago
John Cowen	24c9037cae	Make the tests break by switching to a Service.IP	6 years ago
John Cowen	7202f6e771	Merge pull request #4387 from hashicorp/feature/ui-service-ids ... UI - Show/search by service ids	6 years ago
John Cowen	56d2052345	Merge pull request #4373 from hashicorp/bugfix/gh-4324-kv-trailing-slashes ... UI Bugfix - kv trailing slashes	6 years ago
John Cowen	ab914001c1	Bump consul-api-double	6 years ago
John Cowen	310a038f87	Show Service.ID's throughout the app, allow searching by Service.ID ... 1. In the Services > Services detail page for both healthy and unhealthy nodes, also add searching by Service.ID here 2. In the Nodes > Node detail > [Services] tab only if its different from the Service name, add searching by Service.ID here	6 years ago
John Cowen	40a270a492	Acceptance tests to search/look for service id's	6 years ago
John Cowen	4179afae06	Instead of rewriting the API call, use ember to rewrite the URL ... We now essentially do 2 redirects if you hit a `folder/` 1. If you visit `/ui/dc1/kv/folder/`, `consul` will redirect you to `/ui/dc1/kv/folder` 2. Once redirected to `/ui/dc1/kv/folder` via a 301, use ember/history API to redirect you back to `/ui/dc1/kv/folder/`. Bit long winded, but achieves what we want without having to get stuck into `consul` itself to remove the 301 for the UI	6 years ago
John Cowen	887d4e9dde	If we are indexing or foldering then its going to be folder-like ... ...therefore add a trailing slash to the API call	6 years ago
John Cowen	faf813fee2	Add tests that break when you request a folder without a trailing slash	6 years ago
John Cowen	f6cd162f75	Stop trying to remove consul-api-double we don't need to anymore	7 years ago
John Cowen	fb91d05eb4	Don't assume the last item in the healthcheck listing is passing	7 years ago
John Cowen	25477761f7	Merge pull request #4343 from hashicorp/bugfix/gh-4336-update-empty-kv ... UI - Bugfix: Saving empty key/value pairs	7 years ago
John Cowen	c01fb37c46	Don't clone prev, there's no need	7 years ago
John Cowen	a5fa27d718	Fix a couple of typos in the comments	7 years ago
John Cowen	67402b3d26	Tests and comments regarding the previous 2 commits	7 years ago
John Cowen	b29546e578	Looking into atob functionality, consequence of Value: null ... The Consul API can pass through `Value: null` which does not get cast to a string by ember-data. This snowballs into problems with `atob` which then tried to decode `null`. There are 2 problems here. 1. `Value` should never be `null` - I've added a removeNull function to shallowly loop though props and remove properties that are `null`, for the moment this is only on single KV JSON responses - therefore `Value` will never be `null` which is the root of the problem 2. `atob` doesn't quite follow the `window.atob` API in that the `window.atob` API casts everything down to a string first, therefore it will try to decode `null` > `'null'` > `crazy unicode thing`. - I've commented in a fix for this, but whilst this shouldn't be causing anymore problems in our UI (now that `Value` is never `null`), I'll uncomment it in another future release. Tests are already written for it which more closely follow `window.atob` but skipped for now (next commit)	7 years ago
John Cowen	6a407a044e	Remove validation for presence of KV values	7 years ago
John Cowen	83caa6a296	Add some more detail to the README pre-adding a CONTRIBUTING	7 years ago
John Cowen	7b8b3a012c	Upgrade consul-api-double for session destroy	7 years ago
John Cowen	15b627a517	Basic acceptance testing for navigating via cancel buttons	7 years ago
John Cowen	f85369c375	Add some navigation testing for back buttons and create buttons	7 years ago