1797 Commits (5020f97911849d13d36c3a35b2f3be54f3fa39ab)

Author	SHA1	Message	Date
Frank Schroeder	b1c5ee39a5	commands: move info command to separate pkg	7 years ago
Frank Schroeder	8a5836368e	commands: move rExec helper to bottom	7 years ago
Frank Schroeder	0ada23f92f	commands: move exec command to separate pkg	7 years ago
Frank Schroeder	85bfd8f339	commands: move event command to separate pkg	7 years ago
Frank Schroeder	d870c6289b	commands: move join command to separate pkg	7 years ago
Frank Schroeder	e0551b80a6	commands: move validate command to separate pkg	7 years ago
Frank Schroeder	cef6a80ae6	commands: move flag handling into flags pkg	7 years ago
Frank Schroeder	a49711b8bf	config: refactor commands to print help for flags (#3536) ... This patch refactors the commands that use the mitchellh/cli library to populate the command line flag set in both the Run() and the Help() method. Earlier versions of the mitchellh/cli library relied on the Run() method to populuate the flagset for generating the usage screen. This has changed in later versions and was previously solved with a small monkey patch to the library to restore the old behavior. However, this makes upgrading the library difficult since the patch has to be restored every time. This patch addresses this by moving the command line flags into an initFlags() method where appropriate and also moving all variables for the flags from the Run() method into the command itself. Fixes #3536	7 years ago
Ryan Slade	85e4aea9d1	Replace time.Now().Sub(x) with time.Since(x)	7 years ago
James Phillips	575d70aaa7	Cleans up some drift between the OSS and Enterprise trees.	7 years ago
Frank Schroeder	7bee8e644d	command: show full help text on usage	7 years ago
Frank Schroeder	bb13277ca1	command: do not merge flags in-place	7 years ago
Frank Schroeder	e769cd22f6	command: simplify duplicate code	7 years ago
Frank Schroeder	a364555121	command: drop hidden flags from base command	7 years ago
Frank Schroeder	bc78fa576a	command: drop unused hidden flags for 'validate'	7 years ago
Frank Schroeder	497d2702bf	command: drop legacy 'operator raft' tests	7 years ago
Frank Schroeder	4d604c5138	command: simplify 'operator raft' ... The cli library can handle subcommands. Therefore, most of the code is no longer necessary.	7 years ago
Frank Schroeder	3a7fb35fb0	command: don't show confusing error on usage output	7 years ago
Frank Schroeder	ce0d03c46a	command: drop deprecated 'configtest' command ... 'configtest' has been replaced with 'validate'	7 years ago
Kyle Havlovitz	adf29675f3	Merge pull request #3535 from hashicorp/metric-docs ... Update metric names and add a legacy config flag	7 years ago
Kyle Havlovitz	198ed6076d	Clean up subprocess handling and make shell use optional (#3509) ... * Clean up handling of subprocesses and make using a shell optional * Update docs for subprocess changes * Fix tests for new subprocess behavior * More cleanup of subprocesses * Minor adjustments and cleanup for subprocess logic * Makes the watch handler reload test use the new path. * Adds check tests for new args path, and updates existing tests to use new path. * Adds support for script args in Docker checks. * Fixes the sanitize unit test. * Adds panic for unknown watch type, and reverts back to Run(). * Adds shell option back to consul lock command. * Adds shell option back to consul exec command. * Adds shell back into consul watch command. * Refactors signal forwarding and makes Windows-friendly. * Adds a clarifying comment. * Changes error wording to a warning. * Scopes signals to interrupt and kill. This avoids us trying to send SIGCHILD to the dead process. * Adds an error for shell=false for consul exec. * Adds notes about the deprecated script and handler fields. * De-nests an if statement.	7 years ago
Kyle Havlovitz	c728564994	Update metric names and add a legacy config flag	7 years ago
Kyle Havlovitz	787787f904	Split BaseCommand http config into a separate function	7 years ago
Kyle Havlovitz	8b31eef467	Add base command option for hiding generated help for normal args	7 years ago
James Phillips	be92c6862d	Returns errors properly from the consul operator raft list-peers command.	7 years ago
Frank Schröder	e84c2b2edd	Metrics service prefix (#3498) ... * metrics: replace statsite_prefix with service_prefix The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293 * Updates docs and sorts telemetry section. * Renames to "metrics_prefix" to disambiguate with Consul services. * Updates the change log.	7 years ago
Preetha Appan	3c4a108769	Move Raft protocol version for list peers end point to server side, fix unit tests. This fixes #3449	7 years ago
preetapan	73951d8319	Merge pull request #3494 from hashicorp/enforce_json_extension ... Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	45646ac3f4	Bumps default Raft protocol to version 3. (#3477) ... * Changes default Raft protocol to 3. * Changes numPeers() to report only voters. This should have been there before, but it's more obvious that this is incorrect now that we default the Raft protocol to 3, which puts new servers in a read-only state while Autopilot waits for them to become healthy. * Fixes TestLeader_RollRaftServer. * Fixes TestOperator_RaftRemovePeerByAddress. * Fixes TestServer_*. Relaxed the check for a given number of voter peers and instead do a thorough check that all servers see each other in their Raft configurations. * Fixes TestACL_*. These now just check for Raft replication to be set up, and don't care about the number of voter peers. * Fixes TestOperator_Raft_ListPeers. * Fixes TestAutopilot_CleanupDeadServerPeriodic. * Fixes TestCatalog_ListNodes_ConsistentRead_Fail. * Fixes TestLeader_ChangeServerID and adjusts the conn pool to throw away sockets when it sees io.EOF. * Changes version to 1.0.0 in the options doc. * Makes metrics test more deterministic with autopilot metrics possible.	7 years ago
Preetha Appan	a286ad7533	Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
Frank Schröder	12216583a1	New config parser, HCL support, multiple bind addrs (#3480) ... * new config parser for agent This patch implements a new config parser for the consul agent which makes the following changes to the previous implementation: * add HCL support * all configuration fragments in tests and for default config are expressed as HCL fragments * HCL fragments can be provided on the command line so that they can eventually replace the command line flags. * HCL/JSON fragments are parsed into a temporary Config structure which can be merged using reflection (all values are pointers). The existing merge logic of overwrite for values and append for slices has been preserved. * A single builder process generates a typed runtime configuration for the agent. The new implementation is more strict and fails in the builder process if no valid runtime configuration can be generated. Therefore, additional validations in other parts of the code should be removed. The builder also pre-computes all required network addresses so that no address/port magic should be required where the configuration is used and should therefore be removed. * Upgrade github.com/hashicorp/hcl to support int64 * improve error messages * fix directory permission test * Fix rtt test * Fix ForceLeave test * Skip performance test for now until we know what to do * Update github.com/hashicorp/memberlist to update log prefix * Make memberlist use the default logger * improve config error handling * do not fail on non-existing data-dir * experiment with non-uniform timeouts to get a handle on stalled leader elections * Run tests for packages separately to eliminate the spurious port conflicts * refactor private address detection and unify approach for ipv4 and ipv6. Fixes #2825 * do not allow unix sockets for DNS * improve bind and advertise addr error handling * go through builder using test coverage * minimal update to the docs * more coverage tests fixed * more tests * fix makefile * cleanup * fix port conflicts with external port server 'porter' * stop test server on error * do not run api test that change global ENV concurrently with the other tests * Run remaining api tests concurrently * no need for retry with the port number service * monkey patch race condition in go-sockaddr until we understand why that fails * monkey patch hcl decoder race condidtion until we understand why that fails * monkey patch spurious errors in strings.EqualFold from here * add test for hcl decoder race condition. Run with go test -parallel 128 * Increase timeout again * cleanup * don't log port allocations by default * use base command arg parsing to format help output properly * handle -dc deprecation case in Build * switch autopilot.max_trailing_logs to int * remove duplicate test case * remove unused methods * remove comments about flag/config value inconsistencies * switch got and want around since the error message was misleading. * Removes a stray debug log. * Removes a stray newline in imports. * Fixes TestACL_Version8. * Runs go fmt. * Adds a default case for unknown address types. * Reoders and reformats some imports. * Adds some comments and fixes typos. * Reorders imports. * add unix socket support for dns later * drop all deprecated flags and arguments * fix wrong field name * remove stray node-id file * drop unnecessary patch section in test * drop duplicate test * add test for LeaveOnTerm and SkipLeaveOnInt in client mode * drop "bla" and add clarifying comment for the test * split up tests to support enterprise/non-enterprise tests * drop raft multiplier and derive values during build phase * sanitize runtime config reflectively and add test * detect invalid config fields * fix tests with invalid config fields * use different values for wan sanitiziation test * drop recursor in favor of recursors * allow dns_config.udp_answer_limit to be zero * make sure tests run on machines with multiple ips * Fix failing tests in a few more places by providing a bind address in the test * Gets rid of skipped TestAgent_CheckPerformanceSettings and adds case for builder. * Add porter to server_test.go to make tests there less flaky * go fmt	7 years ago
James Phillips	00605c0214	Shows the segment name in the keyring API and command output.	7 years ago
James Phillips	d12b172a5d	Remaps servers to "<all>" only when listing multiple segments.	7 years ago
James Phillips	1a117ba0a8	Makes the all segments query explict, and the default for `consul members`.	7 years ago
James Phillips	74d635e9c6	Simplifies members command to not fetch segments.	7 years ago
Kyle Havlovitz	f8261330f0	Remove duplicate error message	7 years ago
Kyle Havlovitz	62102a537e	Organize segments for a cleaner split between enterprise and OSS	7 years ago
Kyle Havlovitz	7e565d7338	Fix some inconsistencies with segment logic and comments	7 years ago
Kyle Havlovitz	21513b0393	Update coord display in ui to account for segments	7 years ago
Kyle Havlovitz	d129767657	Add agent.segment interpolation to prepared queries	7 years ago
Kyle Havlovitz	2ada0439d4	Add rpc_listener option to segment config	7 years ago
James Phillips	b1a15e0c3d	Adds open source side of network segments (feature is Enterprise-only).	7 years ago
Frank Schroeder	831d84c940	build: make tests independent of build tags ... When the metadata server is scanning the agents for potential servers it is parsing the version number which the agent provided when it joined. This version number has to conform to a certain format, i.e. 'n.n.n'. Without this version number properly set some tests fail with error messages that disguise the root cause. The default version number is currently set to 'unknown' in version/version.go which does not parse and triggers the tests to fail. The work around is to use a build tag 'consul' which will use the version number set in version_base.go instead which has the correct format and is set to the current release version. In addition, some parts of the code also require the version number to be of a certain value. Setting it to '0.0.0' for example makes some tests pass and others fail since they don't pass the semantic check. When using go build/install/test one has to remember to use '-tags consul' or tests will fail with non-obvious error messages. Using build tags makes the build process more complex and error prone since it prevents the use of the plain go toolchain and - at least in its current form - introduces subtle build and test issues. We should try to eliminate build tags for anything else but platform specific code. This patch removes all references to specific version numbers in the code and tests and sets the default version to '9.9.9' which is syntactically correct and passes the semantic check. This solves the issue of running go build/install/test without tags for the OSS build.	7 years ago
wuxin	d6729243eb	fix command/kv_import.go help text (#3387)	7 years ago
Frank Schröder	4b642fed2f	agent: honor deprecated flags for retry-join-{ec2,azure,gce} (#3384)	7 years ago
Frank Schroeder	1acff3533e	agent: move agent/consul/structs to agent/structs	7 years ago
Kyle Havlovitz	d5634fe2a8	Add support for labels/filters from go-metrics	7 years ago
Frank Schroeder	2fac427cd4	agent: use github.com/hashicorp/go-discover ... Replace the provider specific node discovery code with go-discover to support AWS, Azure and GCE. Fixes #3282	7 years ago
Preetha Appan	840749db7e	Fix comments, and remove redundant TestConfig init from a couple of unit tests	7 years ago
Preetha Appan	aa98aeb4b1	Moved handling advertise address to readConfig and out of the agent's constructor, plus unit test fixes	7 years ago
Preetha Appan	25acd1534a	Move go-socketaddr template parsing into config package to make it happen before creating a new agent. Also removed redundant parsetemplate calls from agent.go.	7 years ago
James Phillips	08a8d9f2a7	command/lock: Add -child-exitcode, return 2 on child error (#3329) ... * Exit 2 if -child-exit-code and the child returned with an error. * There is no platform independent way to check the exact return code of * the child, so on error always return 2. * Closes #947 * Closes #1503	7 years ago
Kyle Havlovitz	9268849d11	Add UpgradeVersionTag to autopilot get/set commands	7 years ago
James Phillips	1791d99a10	Adds new config to make script checks opt-in, updates documentation. (#3284)	7 years ago
James Phillips	86918be323	Sort tags so output is deterministic.	7 years ago
Seth Vargo	afd83a9705	Add catalog CLI functions (#3204)	7 years ago
Frank Schroeder	406dc2ead8	command: make TestExecCommandRun_CrossDC more resilient ... Wait after WAN join that both members see each other.	7 years ago
James Phillips	f1bded7c5e	Removes unneeded shutdown channel in config reading tests.	8 years ago
James Phillips	6977e40077	Fixes watch tracking during reloads and fixes address issue. (#3189) ... This patch fixes watch registration through the config file and a broken log line when the watch registration fails. It also plumbs all the watch loading through a common function and tweaks the unit test to create the watch before the reload.	8 years ago
James Phillips	380c8b957d	Changes host-based node IDs from opt-out to opt-in. (#3187)	8 years ago
Jared Wasinger	3cdde3c7ca	Warn when attempting to bootstrap an even number of nodes (#3158) ... * Warn when attempting to bootstrap an even number of nodes. Addresses #1282 * add more detailed warning for two server case	8 years ago
Frank Schroeder	ea5b0f2c7c	agent: fix 'consul leave' shutdown race (#2880) ... When the agent is triggered to shutdown via an external 'consul leave' command delivered via the HTTP API then the client expects to receive a response when the agent is down. This creates a race on when to shutdown the agent itself like the RPC server, the checks and the state and the external endpoints like DNS and HTTP. This patch splits the shutdown process into two parts: * shutdown the agent * shutdown the endpoints (http and dns) They can be executed multiple times, concurrently and in any order but should be executed first agent, then endpoints to provide consistent behavior across all use cases. Both calls have to be executed for a proper shutdown. This could be partially hidden in a single function but would introduce some magic that happens behind the scenes which one has to know of but isn't obvious. Fixes #2880	8 years ago
James Phillips	6b2ad20131	Moves flag slice helper into configutil.	8 years ago
James Phillips	902f1ce16f	Moves config util helpers into their own package. (#3165)	8 years ago
Kyle Havlovitz	5d99ee80ca	Add an option to disable keyring file (#3145) ... Also disables keyring file in dev mode.	8 years ago
Frank Schroeder	1c75cf1af5	pkg refactor ... command/agent/* -> agent/* command/consul/* -> agent/consul/* command/agent/command{,_test}.go -> command/agent{,_test}.go command/base/command.go -> command/base.go command/base/* -> command/* commands.go -> command/commands.go The script which did the refactor is: ( cd $GOPATH/src/github.com/hashicorp/consul git mv command/agent/command.go command/agent.go git mv command/agent/command_test.go command/agent_test.go git mv command/agent/flag_slice_value{,_test}.go command/ git mv command/agent . git mv command/base/command.go command/base.go git mv command/base/config_util{,_test}.go command/ git mv commands.go command/ git mv consul agent rmdir command/base/ gsed -i -e 's|package agent|package command|' command/agent{,_test}.go gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go gsed -i -e 's|package main|package command|' command/commands.go gsed -i -e 's|base.Command|BaseCommand|' command/commands.go gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go gsed -i -e 's|base\.||' command/commands.go gsed -i -e 's|command\.||' command/commands.go gsed -i -e 's|command|c|' main.go gsed -i -e 's|range Commands|range command.Commands|' main.go gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go gsed -i -e 's|base.Command|BaseCommand|' command/*.go gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go gsed -i -e 's|base\.||' command/*_test.go gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go # fix imports f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f goimports -w $f f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f goimports -w $f goimports -w command/*.go main.go )	8 years ago
Frank Schroeder	9ceef2b32e	test: move discover tests	8 years ago
Frank Schroeder	d2ee591fbf	use 'c' as command receiver for simple commands	8 years ago
Frank Schroeder	902f4caff2	agent: move watch plans into agent	8 years ago
preetapan	2de032125b	Fixed regression with dns server start condition (#3137)	8 years ago
Seth Vargo	89f16984f9	Simplify	8 years ago
Seth Vargo	ee1b5d5024	Update comment	8 years ago
Seth Vargo	532f8d1435	Parse values given to ?passing in the API ... This PR fixes GH-2212 in the most backwards-compatible way I can think of. If the user does not pass a value for `?passing`, it's assumed to be true, which mirrors the current behavior. However, if the user passes any value for passing, that value is parsed as a bool using strconv. It's important to note that this is technically a breaking change. Previously using `?passing=false` would return only passing nodes. While this behavior is obviously incorrect, it was the previous behavior. We should call this out very clearly in the CHANGELOG.	8 years ago
James Phillips	86713c1b8a	Opens up timing bound on flaky test.	8 years ago
James Phillips	66ec9c7a7d	Fixes HTTP header compare by including standard headers.	8 years ago
Frank Schroeder	b5f8d6f9fd	agent: fix time.Duration parsing ... The duration can be passed as a string, a float64 or a time.Duration and this patch handles this properly.	8 years ago
Frank Schroeder	39d33c2fdc	agent: log events and exit code to the log file ... This patch logs the signals, events, errors and the exit code to the log file instead of printing it on the console. This should provide a more complete picture for debugging.	8 years ago
Frank Schroeder	4a223111d2	log: use prefix [ERR] instead of [ERROR]	8 years ago
James Phillips	fa8a26ad54	Updates static assets to latest.	8 years ago
James Phillips	a09eed585e	Merge pull request #3121 from hashicorp/increase-graceful-timeout ... agent: increase graceful shutdown timeout	8 years ago
Frank Schroeder	fe69de3bba	agent: increase graceful shutdown timeout ... When triggering a leave through an INT/TERM signal the hard-coded timeout of 5 seconds is too short to complete the leave successfully. Therefore, the agent always times out. This value should probably configurable.	8 years ago
Frank Schroeder	46c055d57b	agent: log differnt shutdown stages ... Log the different code paths during shutdown.	8 years ago
Frank Schröder	825f72f5ef	agent: support custom header and method for http checks (#3106) ... This patch adds support for custom headers and method for HTTP checks. Fixes #2474 Fixes #2657 Fixes #3106	8 years ago
Frank Schroeder	94b39557e8	test: refactor TestDecodeConfig test ... This patch refactors the multiple tests for DecodeConfig into a single table-driven test that tests most fields individually.	8 years ago
Frank Schroeder	325f82972a	test: Fix TestAgent_Reload ... This test was still referring to cmd.agent which has been removed.	8 years ago
James Phillips	240413f5d6	Merge pull request #3105 from hashicorp/test-stability ... Tweaks things for better test stability.	8 years ago
Frank Schroeder	51e0e158f1	agent: fix graceful http server shutdown	8 years ago
Frank Schroeder	ae711c3b04	agent: cleanup run method	8 years ago
Frank Schroeder	b203ffab29	agent: move registerWatches out of the run method	8 years ago
Frank Schroeder	11245e53a7	agent: move telemetry out of the run method	8 years ago
Frank Schroeder	84f5e8c3ab	agent: move update check out of the run method	8 years ago
Frank Schroeder	96d8035adc	agent: simplify signal handling	8 years ago
Frank Schroeder	34fd31b7b1	agent: move config reloading into the agent	8 years ago
Frank Schroeder	aa1519c9f7	agent: move parseMetaPair to config and export	8 years ago
Frank Schroeder	cb98754cd6	agent: remove agent from command ... Decouple command and agent a bit more.	8 years ago
Frank Schroeder	d977aa1fe7	agent: move retry join into agent	8 years ago
Frank Schroeder	55a513da2e	agent: add GossipEncrypted function ... Remove dead code and expose a GossipEncrypted() method on the agent instead of accessing the internal delegate.	8 years ago
James Phillips	b0b5df579f	Cleans up an unrelated vet error.	8 years ago
James Phillips	b4b5036dfb	Adds back the port shuffle on agent start retries.	8 years ago
Frank Schroeder	375825f34c	Do not recurse when the service address is a local cname ... Fixes #2795	8 years ago
Frank Schroeder	9956bc9b47	agent: LastContact cannot be negative (#3067) ... The X-Consul-LastContact header cannot be negative. Fixes #3067	8 years ago
Frank Schroeder	db15cd847a	test: replace one more BoolFalse with agent.Bool()	8 years ago
Frank Schroeder	dcc68f0f85	test: we will not use dev mode for testing for now	8 years ago
Frank Schroeder	f89ae9f7e7	test: stagger retry attempts of TestAgent.Start	8 years ago
Frank Schroeder	bdfed817ee	test: make TestAgent setup reusable ... Pick the random ports only once and try starting with them a number of times so that the configuration can be re-used. This is because the ports are written into the data files and a subsequent agent reading the files needs to have the same ports. For the same reason we do not remove the data directory on every attempt since this makes it impossible to re-read the data files.	8 years ago
Frank Schroeder	4034d0ac0b	agent: use agent logger for consul client and deps	8 years ago
Frank Schroeder	c1e6a77c75	test: start secondary agents also via TestAgent	8 years ago
Frank Schroeder	a9451d596f	agent: set tcpKeepAliveListener when there is no error	8 years ago
Frank Schroeder	345666bdb6	test: use test name as log prefix	8 years ago
Frank Schroeder	d6c7404b34	agent: simplify shutdown timeout logging ... Note that we are currently timing out every time. This still needs to be investigated.	8 years ago
Frank Schroeder	30ba712857	agent: set proto to http since we are logging it now	8 years ago
Frank Schroeder	ceda18366f	test: Use Bool() instead of &BoolTrue/False since	8 years ago
Frank Schroeder	ec729693d7	Address review comments	8 years ago
Frank Schroeder	26200929c1	agent: start HTTPS only if there is a cert and key	8 years ago
Frank Schroeder	b6c69ebf5d	agent: refactor DNS and HTTP server ... * refactor DNS server to be ready for multiple bind addresses * drop tcpKeepAliveListener since it is default for the HTTP servers * add startup timeout watcher for HTTP servers identical to DNS server	8 years ago
Frank Schroeder	aa92adcdd5	test: increase sleep time for test	8 years ago
Frank Schroeder	f498f24032	test: allow tests to control anti-entropy syncs	8 years ago
Frank Schroeder	eea16e1640	test: run mock dns recursors on random ports	8 years ago
Frank Schroeder	6148910399	test: skip tests that use cmd.Run until signal handling is fixed	8 years ago
Frank Schroeder	56cf015117	test: add test for starting/stopping lots of agents	8 years ago
Frank Schroeder	7c5892a196	test: use UniqueID prefix for check tests to unify log output	8 years ago
Frank Schroeder	0a31094e06	test: improve TestAgent ... * don't use retry to try restarting the agent this caused some issues when the startup would fail in a separate go routine * clear out the data directory on every retry since the ports are stored in the raft data files * set a unique id for every agent to allow for tracking of concurrent output	8 years ago
Frank Schroeder	10540f8d5f	agent: fix logging ... * use agent logger for consul/serf/raft/dns/agent/... * support optional id for concurrent tests	8 years ago
Frank Schroeder	fe777852cd	test: call t.Fatal() from main go routine	8 years ago
Frank Schroeder	3e39f04527	dns: do not log socket close during shutdown	8 years ago
Frank Schroeder	1df74e36bd	agent: print more useful shutdown message	8 years ago
Frank Schroeder	2e14c09447	test: start sync after agent start	8 years ago
Frank Schroeder	5b5566d916	test: add test name to output	8 years ago
Frank Schroeder	28ed8f1847	test: perform blocking query on agent	8 years ago
Frank Schroeder	ebc0c80f08	test: parallelize dns test	8 years ago
Frank Schroeder	72c214b908	test: fix failing test	8 years ago
Frank Schroeder	c5f565ee1a	test: remove output to stdout	8 years ago
Frank Schroeder	8f943542b0	test: use cli.NewMockUi instead of new(cli.MockUi) ... Use the constructor function to prevent a nil panic if there was no write to the output buffers.	8 years ago
Frank Schroeder	0325a42089	test: fix data race with endpoints	8 years ago
Frank Schroeder	e16589c079	agent: shutdown delegate if created ... When the TestAgent shuts down a half-started agent the delegate may not have been created at this point.	8 years ago
Frank Schroeder	632f837c98	agent: shutdown dns servers on error	8 years ago
Frank Schroeder	8c1a668481	test: Shutdown half-started agent before retrying	8 years ago
Frank Schroeder	584693482d	test: fix data race in MockNotify ... 42 -> 32 data races	8 years ago
Frank Schroeder	9509ab463c	test: run command tests in parallel	8 years ago
Frank Schroeder	3658d4d428	test: address pull request comments	8 years ago
Frank Schroeder	0f912c8aad	test: remove ACL options from default test config	8 years ago
Frank Schroeder	bc47972696	test: allocate ports in blocks of 10	8 years ago
Frank Schroeder	53c1c86ab3	test: refactor command tests to use TestAgent	8 years ago
Frank Schroeder	24eec373de	test: retry a bit more often	8 years ago
Frank Schroeder	659d7dbbde	agent: rename *Config vars to 'cfg'	8 years ago
Frank Schroeder	e86d34685f	agent: rename *Command vars to 'cmd' ... 'c' is ambigious and it conflicts with 'config'.	8 years ago
Frank Schroeder	141efd9588	test: rename *Config vars to 'cfg' ... 'c' is ambigous since Command also uses this and we want to use 'config' as a package name.	8 years ago
Frank Schroeder	06677708cf	test: use less aggressive retry for agent startup	8 years ago
Frank Schroeder	47501309ae	test: use system temp dir for TestAgent	8 years ago
Frank Schroeder	0c905a0df8	test: a.config -> a.Config	8 years ago
Frank Schroeder	0be63d7060	test: refactor httpTest with TestAgent	8 years ago
Frank Schroeder	308f9929b3	test: run agent tests in parallel ... This brings down the test run from 108 sec to 15 sec. There is an occasional port conflict because of the nature the next port is chosen. So far it seems rare enough to live with it.	8 years ago
Frank Schroeder	23a6ff383c	agent: refactor tests for TestAgent ... Refactored tests that use * makeAgentXXX * makeDNSServerXXX * makeHTTPServerXXX	8 years ago
Frank Schroeder	b5b3aa1376	agent: add TestAgent to replace other mechanisms ... TestAgent will replace the following mechanisms to start test agents in subsequent requests: * makeAgentXXX * makeDNSServerXXX * makeHTTPServerXXX * testServer * httpTest	8 years ago
Frank Schroeder	3865f14a25	agent: simplify agent creation ... This patch creates an agent with just a config struct and allows for other fields to be set as required.	8 years ago
Frank Schroeder	82650f73e3	agent: move http/dns endpoints into agent ... Move the HTTP and DNS endpoints into the agent and control their lifespan via the agent. This removes the requirement to manage HTTP and DNS servers indpendent of the agent since the agent is mostly useless without an endpoint and the endpoints without the agent.	8 years ago
Frank Schroeder	74be791f9b	agent: fix comment	8 years ago
Frank Schroeder	b42916e1ff	agent: simplify socket address helper	8 years ago
Frank Schroeder	c44e41a741	agent: replace goto with local function	8 years ago
Frank Schroeder	327401e7ee	agent: inline uiDir field ... uiDir can be inlined as agent.config.UIDir	8 years ago
Frank Schroeder	8f381d62f6	agent: drop logOutput parameter ... agent.logOutput is identical to logOutput	8 years ago
Frank Schroeder	c47db2c922	agent: drop config argument ... agent.config and config are identical.	8 years ago
Kyle Havlovitz	62f72f104c	Add settings for upshifting to encrypted gossip (#3079)	8 years ago
James Phillips	385c9522b3	Removes obsolete agent API documentation.	8 years ago
Frank Schroeder	91c5c9a2d0	doc: update comments and run goimports	8 years ago
Michael Leow	deb206b7d7	agent: add RetryJoin support for Azure ... Pull #2978 from leowmjw/develop Resolves #2978	8 years ago
James Phillips	9aa232ea2e	Merge pull request #2901 from deckarep/consul-ensure-exit-non-zero-on-timeout ... Ensure to exit with a non-zero status code when a timeout and all jobs are not completed.	8 years ago
Frank Schroeder	8ad66f4bea	agent: support custom check id and name ... This patch adds support for a custom check id and name when registering a service. This is achieved by adding a CheckID and a Name field to the CheckType structure which is used to register checks with a service and when returning health check definitions. CheckDefinition is a superset of CheckType which duplicates some of the fields of CheckType. This patch decouples these two structures by removing the embedding of CheckType in CheckDefinition. Fixes #3047	8 years ago
Frank Schroeder	ad40a855bd	agent: move isAddrANY to separate package	8 years ago
Frank Schroeder	e2c37b47ee	agent: Replace client/server with delegate interface ... This patch adds a new internal interface clientServer which defines the common methods of consul.Client and consul.Server. This allows to replace the following code if a.server != nil { a.server.do() } else { a.client.do() } with a.delegate.do() In case a specific type is required a type check can be performed: if srv, ok := a.delegate.(*consul.Server); ok { srv.doSrv() }	8 years ago
Frank Schroeder	41f01a0cfc	agent: allow "::" as IPv6 bind address ... Fixes #2285	8 years ago
Frank Schroeder	65b5c51ec7	test: add helper for ioutil.TempDir/TempFile ... This creates a simplified helper for temporary directories and files. All path names are prefixed with the name of the current test. All files and directories are stored either in /tmp/consul-test or /tmp if the former could not be created. Using the system temp dir breaks some tests on macOS where the unix socket path becomes too long.	8 years ago
Frank Schroeder	3d54fe51ba	test: lower wait time for some tests	8 years ago
Frank Schroeder	98f6e3b7c5	test: suppress osx firewall warning ... macOS displays a firewall warning dialog when an unsigned application is trying to bind to a non-loopback address. This patch updates some test configurations to ensure binding to a loopback address where possible to suppress these warnings.	8 years ago
Frank Schroeder	3522a41bad	test: include test name in temp file/dir ... This helps identifying hanging tests by looking at the process list.	8 years ago
Frank Schroeder	db3599762f	test: drop unused code	8 years ago
Frank Schroeder	914a83cae0	agent: use bind address as src unless INADDR_ANY ... Use the bind address as source address for outgoing RPC connections unless it is INADDR_ANY. The current code uses the advertise address which will not work in certain environments where the advertise address is not routable in the network of the agent, e.g. NAT environment, container... After all, that is the purpose of the advertise address. See #2822	8 years ago
Frank Schroeder	e6c6f8cedd	agent: use helper for INADDR_ANY	8 years ago
Kyle Havlovitz	5bab68b9bb	Add a path for transitioning to TLS on an existing cluster (#3001) ... Fixes #1705	8 years ago
Frank Schroeder	6eba69fbfe	agent: drop atlas/scada code	8 years ago
Frank Schroeder	5328609d59	test: refactor TestAgent_Leave_ACLDeny to use only one server	8 years ago
Frank Schroeder	a60f508880	test: use isPermissionDenied	8 years ago
Frank Schroeder	66bc2cbabc	test: replace blocks and comments with sub-tests	8 years ago
Frank Schroeder	d711b9bba0	test: inline request body encoding	8 years ago
Frank Schroeder	82cb9c50ad	test: add helper for permission denied check	8 years ago
Frank Schroeder	1e89692cc1	test: drop error check on http.NewRequest ... Most URLs are static so the error check is redundant. The subsequent test wouldn't work if the url is wrong.	8 years ago
Frank Schroeder	6fa76fd90f	agent: Disallow :: or [::] as advertise or advertise-wan address	8 years ago
Frank Schroeder	8ad52ee9b5	agent: Disallow :: and [::] as service address	8 years ago
Frank Schroeder	e365ef12cf	agent: Disallow 0.0.0.0 as advertise or advertise-wan address ... Fixes #2961	8 years ago
Frank Schroeder	73a31b9bfe	agent: Disallow 0.0.0.0 as service address ... Fixes #2961	8 years ago
James Phillips	33a7b8e401	Tweaks some tests that were having a hard time in Travis CI and ... bumps up the default retry time.	8 years ago
James Phillips	efff41a8b2	Updates built-in static assets for web UI.	8 years ago
Frank Schroeder	2794db5aac	test: Fix badly formatted retry.Run tests	8 years ago
Frank Schroeder	9c86d5c764	test: convert remaining WaitForResult tests	8 years ago
James Phillips	ddfa57765c	retry: Removes the description parameter.	8 years ago
James Phillips	2de1cd5a4a	test: Turns off ACLs for catalog and health WAN translation tests. ... Since this was doing registration to a foreign DC, it needs extra time for the route to the ACL datacenter to be set up. ACLs aren't part of this test, so by disabling them we make this more reliable and converge faster than if we had added a retry.	8 years ago
James Phillips	888fa5cad6	test: Moves a variable closer to where it's used.	8 years ago
James Phillips	0daacfe5e5	test: Turns down server health interval for faster convergence. ... This fixes the autopilot tests.	8 years ago
Frank Schroeder	21a82a0a16	test: Refactor WaitForResult tests with retry ... Refactor tests that use testutil.WaitForResult to use retry. Since this requires refactoring the test functions in general this patch also shows the use of the github.com/pascaldekloe/goe/verify library which provides a good mechanism for comparing nested data structures. Instead of just converting the tests from testutil.WaitForResult to retry the tests that performing a nested comparison of data structures are converted to the verify library at the same time.	8 years ago
Frank Schroeder	f39c604cd7	Fix imports	8 years ago
Frank Schroeder	8c2b261c61	Use bind address as source for outgoing connections (#2822) ... This patch configures consul to use the bind address as the source address for outgoing connections. Fixes #2822	8 years ago
Frank Schroeder	fb83790cb9	Do not modify config after creation II ... Move code for finding the advertise address via a template into consulConfig() so that the config object is not modified after creation.	8 years ago
Frank Schroeder	a235986a28	Do not modify config after creation ... Make sure the RPCAdvertise address is always set so that the configuration does not have to be modified after creation.	8 years ago
Frank Schroeder	a226edd4a9	Move GCE discovery code to command/agent/config_gce.go	8 years ago
Frank Schroeder	7f73f14260	Move AWS discovery code to command/agent/config_aws.go	8 years ago
Frank Schroeder	78fc19c48c	Move verifyUniqueListeners to command/agent/config.go	8 years ago
Frank Schroeder	d34ba3e823	Cleanup agent config	8 years ago
Damon Buckwalter	98407322a6	Itty bitty typo	8 years ago
James Phillips	6382f95898	Updates static assets to pick up #2712.	8 years ago
Kyle Havlovitz	cd56a5ebdd	Add separate option for verifying incoming HTTPS traffic (#2974) ... * Add separate option for verifying incoming HTTPS traffic	8 years ago
Frank Schroeder	84d6ac2d51	api: Return empty list instead of nil	8 years ago
Frank Schroeder	9685bdcd0b	api: Add ServiceTags to Health state endpoint (#153) ... This patch adds the ServiceTags to the /v1/health/state/<state> endpoint. Fixes #153	8 years ago
Frank Schroeder	7075695627	Faster dev server startup ... This patch reduces the timeouts for the development server so that it starts up almost instantly.	8 years ago
Frank Schroeder	48fa2962eb	Revert "test: Run command/agent tests in parallel" ... This reverts commit 17be40a733.	8 years ago
Frank Schroeder	0cb4295182	test: Do not run RetryJoin tests in parallel ... I am suspecting port conflicts with the agents that are started. This needs further investigation.	8 years ago
Frank Schroeder	7281b4291a	test: Speedup session renew tests	8 years ago
Frank Schroeder	37c180a920	test: Speedup Retry*Join tests	8 years ago
Frank Schroeder	17be40a733	test: Run command/agent tests in parallel	8 years ago
Kyle Havlovitz	b70e419aeb	Add TLS cipher suite options and CA path support (#2963) ... This patch adds options to configure the available TLS cipher suites and adds support for a path for multiple CA certificates. Fixes #2959	8 years ago
James Phillips	59c4128deb	Updates compiled static assets.	8 years ago
Frank Schroeder	3403cd4372	golint: Fix existing comments ... This needs more work.	8 years ago
Frank Schroeder	3e00e36f41	golint: Untangle if blocks with return in else	8 years ago
Frank Schroeder	d7e23857ad	golint: No stutter	8 years ago
Frank Schroeder	cf3ec1cf5c	golint: Rename fields and structs	8 years ago
Frank Schroeder	5a3961f31f	golint: Replace a += 1 with a++	8 years ago
Frank Schroeder	6688a510e1	golint: Consistent receiver name ... Ensure the receiver name is consistent	8 years ago
Frank Schroeder	8bb7792799	golint: Drop the unused value from range ... for i, _ := range foo -> for i := range foo	8 years ago
Frank Schroeder	eddb1af603	Remove duplicate constants ... This patch removes duplicate internal copies of constants in the structs package which are also defined in the api package. The api.KVOp type with all its values for the TXN endpoint and the api.HealthXXX constants are now used throughout the codebase. This resulted in some circular dependencies in the testutil package which have been resolved by copying code and constants and moving the WaitForLeader function into a separate testrpc package.	8 years ago
Frank Schroeder	ee5b06a231	Use fmt.Fprint/Fprintf/Fprintln ... Used the following rewrite rules: gofmt -w -r 'resp.Write([]byte(fmt.Sprintf(a, b, c, d))) -> fmt.Fprintf(resp, a, b, c, d)' *.go gofmt -w -r 'resp.Write([]byte(fmt.Sprintf(a, b, c))) -> fmt.Fprintf(resp, a, b, c)' *.go gofmt -w -r 'resp.Write([]byte(fmt.Sprintf(a, b))) -> fmt.Fprintf(resp, a, b)' *.go gofmt -w -r 'resp.Write([]byte(fmt.Sprintf(a))) -> fmt.Fprint(resp, a)' *.go gofmt -w -r 'resp.Write([]byte(a + "\n")) -> fmt.Fprintln(resp, a)' *.go gofmt -w -r 'resp.Write([]byte(a)) -> fmt.Fprint(resp, a)' *.go	8 years ago
Kyle Havlovitz	f25cac4c8f	Show raft protocol in list-peers command (#2929)	8 years ago
Kyle Havlovitz	29a4a42f17	Fix help text on client cert/key options	8 years ago
mckennajones	a489f2b734	Added check to see if ui and ui-dir flags are both specified	8 years ago
Kyle Havlovitz	b1d98522ee	Fix help text for -ca-path	8 years ago
Kyle Havlovitz	ae6bf56ee1	Add tls client options to api/cli	8 years ago
James Phillips	fb089e2bbb	Merge pull request #2842 from vaLski/supress_sigpipe_logging ... Supress signal logging on SIGPIPE. Should address #2768	8 years ago
James Phillips	4de270326e	Updates static assets to pick up #2899.	8 years ago
James Phillips	2843da5cd9	Merge pull request #2904 from hashicorp/non-host-id ... Adds a new -disable-host-node-id option to help when testing with containers.	8 years ago
James Phillips	fa04c24978	Adds a new -disable-host-node-id option to help when testing with containers. ... Fixes #2877.	8 years ago
Ralph Caraveo	7ab576891e	Ensure to exit with a non-zero status code when a timeout occurs and we don't complete all the jobs.	8 years ago
Ralph Caraveo	87f1a1a3ee	Fixed spelling for consul kv get command --help comments.	8 years ago
Alex Dadgar	7f6d95f1c9	Hash host ID so its stable and well distributed ... This PR takes the host ID and runs it through a hash so that it is well distributed. This makes it so that machines that report similar host IDs are easily distinguished. Instances of similar IDs occur on EC2 where the ID is prefixed and on motherboards created in the same batch.	8 years ago
James Phillips	86870ae51d	Merge pull request #2854 from hashicorp/remote-exec ... Changes `disable_remote_exec` default to true so remote exec is opt-in.	8 years ago
Kyle Havlovitz	da9c825592	Add CLI/API endpoints for removing peer by ID	8 years ago
James Phillips	7e2dcb61bf	Changes `disable_remote_exec` default to true so remote exec is opt-in.	8 years ago
James Phillips	11ee9a9e72	Disables agent-level enforcement on Consul agents unless acl_datacenter is set.	8 years ago
vaLentin chernoZemski	1e5163d241	Supress signal logging on SIGPIPE. Should address #2768 ... When consul-template is communicating with consul and the job is done, consul thread receives SIGPIPE. This cause the logs to be filled "Caught signal: broken pipe" and they does not bring any usefull info with them. Skipping those.	8 years ago
James Phillips	59a599a14b	Cleans up a stray mark and fixes unit tests. ... Ended up removing the leader_test.go server address change test as part of this. The join was failing becase we were using a new node name with the new logic here, but realized this was hitting some of the memberlist conflict logic and not working as we expected. We need some additional work to fully support address changes, so removed the test for now.	8 years ago
James Phillips	7ce7d157da	Fixes up some broken unit tests.	8 years ago
James Phillips	8940d1c3fe	Keeps the service and check tokens around for deregistration. ... We fixed a few related issues while we were in here. We now only let services register checks with a matching token, and we also close out service and check delete operations if the catalog deregister claims it doesn't know about the ID of the service or check being deleted.	8 years ago
James Phillips	4d3f3ea8d2	Changes verson 8 ACLs to opt-out.	8 years ago