55 Commits (19c3e262a6674b2e66a4ead415740aaf26509fb7)

Author	SHA1	Message	Date
Armon Dadgar	d137a5fa82	agent: remove an N^2 check. See #1265	9 years ago
James Phillips	0b05dbeb21	Merge pull request #1235 from wuub/master ... fix conflict between handleReload and antiEntropy critical sections	9 years ago
Wojciech Bederski	c4537ed26f	panic when unbalanced localState.Resume() is detected	9 years ago
Wojciech Bederski	b014c0f91b	make Pause()/Resume()/isPaused() behave more like a semaphore ... see: https://github.com/hashicorp/consul/issues/1173 #1173 Reasoning: somewhere during consul development Pause()/Resume() and PauseSync()/ResumeSync() were added to protect larger changes to agent's localState. A few of the places that it tries to protect are: - (a *Agent) AddService(...) # part of the method - (c *Command) handleReload(...) # almost the whole method - (l *localState) antiEntropy(...)# isPaused() prevents syncChanges() The main problem is, that in the middle of handleReload(...)'s critical section it indirectly (loadServices()) calls AddService(...). AddService() in turn calls Pause() to protect itself against syncChanges(). At the end of AddService() a defered call to Resume() is made. With the current implementation, this releases isPaused() "lock" in the middle of handleReload() allowing antiEntropy to kick in while configuration reload is still in progress. Specifically almost all services and probably all check are unloaded when syncChanges() is allowed to run. This in turn can causes massive service/check de-/re-registration, and since checks are by default registered in the critical state, a majority of services on a node can be marked as failing. It's made worse with automation, often calling `consul reload` in close proximity on many nodes in the cluster. This change basically turns Pause()/Resume() into P()/V() of a garden-variety semaphore. Allowing Pause() to be called multiple times, and releasing isPaused() only after all matching/defered Resumes() are called as well. TODO/NOTE: as with many semaphore implementations, it might be reasonable to panic() if l.paused ever becomes negative.	9 years ago
Shawn Cook	66fd8fb2a0	Rename EnableTagOverride and update formatting	9 years ago
Shawn Cook	d7ce0b3c6b	Remove debug lines	9 years ago
Shawn Cook	96785edd9a	Add EnableTagDrift logic to command/agent/local.go	9 years ago
Shawn Cook	6a835939b8	EnableTagDrift in NodeService struct	9 years ago
Ryan Uber	739d1fdf03	Merge pull request #891 from hashicorp/f-token ... ACL tokens for service/check registration	10 years ago
Ryan Uber	2b62f2f172	agent: use an additional parameter for passing tokens	10 years ago
Ryan Uber	35f5a65fb7	agent: more tests	10 years ago
Ryan Uber	442933650e	agent: safer read methods for tokens	10 years ago
Ryan Uber	1264f7edf3	agent: fix deadlock reading tokens from state	10 years ago
Ryan Uber	bebb5d9641	agent: add service/check token methods to reduce invasiveness	10 years ago
Ryan Uber	bfb27d18cd	agent: initial pass threading through tokens for services/checks	10 years ago
artushin	cc07734d6e	remove config	10 years ago
artushin	7b4720a957	use existing randomStagger	10 years ago
artushin	8decf5d394	adding check_update_stagger	10 years ago
Ryan Uber	60a6da213f	agent: handle nil node services in anti-entropy	10 years ago
Ryan Uber	7e170b047e	agent: fix anti-entropy check sync	10 years ago
Ryan Uber	a60f4adf95	agent: anti-entropy sync services/checks if they don't exist in the catalog	10 years ago
foostan	2df98c1824	Validation ServiceID/CheckID when deleting in deleteService() in local.go	10 years ago
Ryan Uber	46d5dcfc17	agent: comments for new anti-entropy functionality	10 years ago
Ryan Uber	a4039aaa4d	agent: simplify anti-entropy of services with multiple checks, add tests	10 years ago
Ryan Uber	0c31e5851c	agent: only send service with check sync if it is out of sync	10 years ago
Ryan Uber	949ddefbc8	agent: refactor syncChecks	10 years ago
Ryan Uber	674be58e55	agent: support multiple checks per service	10 years ago
Veres Lajos	3b1068387a	typofixes - https://github.com/vlajos/misspell_fixer	10 years ago
Armon Dadgar	5887242db2	agent: Handle service ACLs when doing anti-entropy	10 years ago
Ryan Uber	cfca160cd5	formatting	10 years ago
Ryan Uber	aa6ffc90f0	agent: remove special case of consul service, adjust tests	10 years ago
Armon Dadgar	8c9ab7ba58	agent: Cleanup handling of defer checks	11 years ago
Armon Dadgar	a88c36bdc1	agent: Prevent anti-entropy from doing early sync of check output	11 years ago
Armon Dadgar	8a0b86df10	agent: leave inSync until the defer runs	11 years ago
Armon Dadgar	500bb3931b	agent: Defer sync based on CheckUpdateInterval	11 years ago
Armon Dadgar	a5f05fa902	agent: Ensure we don't retry too often	11 years ago
Armon Dadgar	cc51bf6926	agent: Adding debug log messages	11 years ago
Armon Dadgar	903789aee4	agent: Adding random stagger to anti-entropy. Fixes #72.	11 years ago
Armon Dadgar	018482dc4c	Store check output in dedicated field. Fixes #59.	11 years ago
Armon Dadgar	d7d30f5cf5	agent: Simplify the local state sync	11 years ago
Armon Dadgar	3cf1a64f87	agent: Handle API changes	11 years ago
Armon Dadgar	4f3adcfdda	agent: simplify a select block	11 years ago
Armon Dadgar	e12e5f7f68	agent: adding ability to reload services and checks	11 years ago
Armon Dadgar	c1637b4978	agent: Adding server up callback to make state sync faster	11 years ago
Armon Dadgar	f8bd1a1ac3	agent: Adding support to edge trigger consul server coming up for state sync	11 years ago
Armon Dadgar	01b1104175	agent: adding ability to pause syncing	11 years ago
Armon Dadgar	c58c53f448	agent: RPC changes and blocking query support	11 years ago
Armon Dadgar	66b232f53e	agent: syncCheck provides the relevant check to prevent a race condition	11 years ago
Armon Dadgar	410a0de0c8	Seperate localState from Agent	11 years ago
Armon Dadgar	7aa278e2ef	Allow setting the health check notes	11 years ago