14240 Commits (0f8cdfaeffaf01c9d060eeba6ef98c63b7efc42b)

 

All Branches   

Search

Author	SHA1	Message	Date
R.B. Boyer	0f8cdfaeff	dev: adding a make target to regenerate envoy golden files (#10158)	4 years ago
R.B. Boyer	abc1dc0fe9	connect: update supported envoy versions to 1.18.2, 1.17.2, 1.16.3, and 1.15.4 (#10101) ... The only thing that needed fixing up pertained to this section of the 1.18.x release notes: > grpc_stats: the default value for stats_for_all_methods is switched from true to false, in order to avoid possible memory exhaustion due to an untrusted downstream sending a large number of unique method names. The previous default value was deprecated in version 1.14.0. This only changes the behavior when the value is not set. The previous behavior can be used by setting the value to true. This behavior change by be overridden by setting runtime feature envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default. For now to maintain status-quo I'm explicitly setting `stats_for_all_methods=true` in all versions to avoid relying upon the default. Additionally the naming of the emitted metrics for these gRPC requests changed slightly so the integration test assertions for `case-grpc` needed adjusting.	4 years ago
R.B. Boyer	85a718da63	xds: ensure that all envoyproxy/go-control-plane protobuf symbols are linked into the final binary (#10131) ... This ensures that if someone does include some extension Consul does not currently make use of, that extension is actually usable. Without linking these envoy protobufs into the main binary it can't round trip the escape hatches to send them down to envoy. Whenenver the go-control-plane library is upgraded next we just have to re-run 'make envoy-library'.	4 years ago
R.B. Boyer	71d45a3460	Support Incremental xDS mode (#9855) ... This adds support for the Incremental xDS protocol when using xDS v3. This is best reviewed commit-by-commit and will not be squashed when merged. Union of all commit messages follows to give an overarching summary: xds: exclusively support incremental xDS when using xDS v3 Attempts to use SoTW via v3 will fail, much like attempts to use incremental via v2 will fail. Work around a strange older envoy behavior involving empty CDS responses over incremental xDS. xds: various cleanups and refactors that don't strictly concern the addition of incremental xDS support Dissolve the connectionInfo struct in favor of per-connection ResourceGenerators instead. Do a better job of ensuring the xds code uses a well configured logger that accurately describes the connected client. xds: pull out checkStreamACLs method in advance of a later commit xds: rewrite SoTW xDS protocol tests to use protobufs rather than hand-rolled json strings In the test we very lightly reuse some of the more boring protobuf construction helper code that is also technically under test. The important thing of the protocol tests is testing the protocol. The actual inputs and outputs are largely already handled by the xds golden output tests now so these protocol tests don't have to do double-duty. This also updates the SoTW protocol test to exclusively use xDS v2 which is the only variant of SoTW that will be supported in Consul 1.10. xds: default xds.Server.AuthCheckFrequency at use-time instead of construction-time	4 years ago
Tara Tufano	e345ef6086	make h2ping changelog entry conform with changelog template (#10111) ... LGTM!	4 years ago
Luigi Tagliamonte	5220699696	Improve doc: add note about address validation (#10123) ... * Update website/content/docs/discovery/services.mdx with address field behavior. Co-authored-by: Jono Sosulska <42216911+jsosulska@users.noreply.github.com> Co-authored-by: Jono Sosulska <42216911+jsosulska@users.noreply.github.com>	4 years ago
Iryna Shustava	8dffb89131	Implement traffic redirection exclusion based on proxy config and user-provided values (#10134) ... * Use proxy outbound port from TransparentProxyConfig if provided * If -proxy-id is provided to the redirect-traffic command, exclude any listener ports from inbound traffic redirection. This includes envoy_prometheus_bind_addr, envoy_stats_bind_addr, and the ListenerPort from the Expose configuration. * Allow users to provide additional inbound and outbound ports, outbound CIDRs and additional user IDs to be excluded from traffic redirection. This affects both the traffic-redirect command and the iptables SDK package.	4 years ago
hc-github-team-consul-core	cbabf82587	auto-updated agent/uiserver/bindata_assetfs.go from commit 5d89ba031	4 years ago
John Cowen	5d89ba0313	ui: Add a max height and scroll to the intention perm header lists (#10128)	4 years ago
Freddy	701b49f772	Rename cluster config files to mesh as well (#10148)	4 years ago
Freddy	078c40425f	Rename "cluster" config entry to "mesh" (#10127) ... This config entry is being renamed primarily because in k8s the name cluster could be confusing given that the config entry applies across federated datacenters. Additionally, this config entry will only apply to Consul as a service mesh, so the more generic "cluster" name is not needed.	4 years ago
Daniel Nephin	e19aef45cb	Merge pull request #10146 from hashicorp/dnephin/connect-proxy-test-deadlock ... connect/proxy: fix a few problems with tests	4 years ago
Daniel Nephin	9b344b3300	Merge pull request #10112 from hashicorp/dnephin/remove-streaming-from-cache ... streaming: replace agent/cache with submatview.Store	4 years ago
Daniel Nephin	d18a03b07f	connect/proxy: fix a number of problems with Listener ... We noticed that TestUpstreamListener would deadlock sometimes when run with the race detector. While debugging this issue I found and fixed the following problems. 1. the net.Listener was not being closed properly when Listener.Stop was called. This caused the Listener.Serve goroutine to run forever. Fixed by storing a reference to net.Listener and closing it properly when Listener.Stop is called. 2. call connWG.Add in the correct place. WaitGroup.Add must be called before starting a goroutine, not from inside the goroutine. 3. Set metrics config EnableRuntimeMetrics to `false` so that we don't start a background goroutine in each test for no reason. There is no way to shutdown this goroutine, and it was an added distraction while debugging these timeouts. 5. two tests were calling require.NoError from a goroutine. require.NoError calls t.FailNow, which MUST be called from the main test goroutine. Instead use t.Errorf, which can be called from other goroutines and will still fail the test. 6. `assertCurrentGaugeValue` wass breaking out of a for loop, which would cause the `RWMutex.RUnlock` to be missed. Fixed by calling unlock before `break`. The core issue of a deadlock was fixed by https://github.com/armon/go-metrics/pull/124.	4 years ago
Jamie Finnigan	8fc62cb87f	remove Codecov from CI runs (#10145)	4 years ago
Kenia	f9a4b6d050	ui: Add TProxy Mode notice banner to service instance Upstreams tab (#10136)	4 years ago
Daniel Nephin	146e1d3878	connect/proxy: remove t.Parallel from tests ... These tests run in under 10ms, t.Parallel provides no value and makes debuging failures more difficult.	4 years ago
Daniel Nephin	3a27fce2ad	submatview: fix godoc and comment typos ... Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
Kenia	0c9555ec0e	ui: Update not-defined intention popover and banner (#10133)	4 years ago
Kenia	7caa47da56	ui: Update conditional for topology empty state (#10124)	4 years ago
Kenia	ce98d08d12	ui: Fix empty SVG height to prevent service mesh from breaking when there are no upstreams (#10122)	4 years ago
hc-github-team-consul-core	4ad37c326e	auto-updated agent/uiserver/bindata_assetfs.go from commit 345765f76	4 years ago
John Cowen	345765f766	ui: Adds human formatting to nanosecond based session durations (#10062) ... * ui: Adds human formatting to nanosecond based session durations	4 years ago
Daniel Nephin	31cd58084f	Add changelog	4 years ago
Daniel Nephin	11398892b3	submatview: avoid sorting results unnecessarily ... Previous getFromView would call view.Result when the result may not have been returned (because the index is updated past the minIndex. This would allocate a slice and sort it for no reason, because the values would never be returned. Fix this by re-ordering the operations in getFromView. The test changes in this commit were an attempt to cover the case where an update is received but the index does not exceed the minIndex.	4 years ago
Daniel Nephin	23e1cd6f93	submatview: only return materializer from getEntry ... Also rename it to readEntry now that it doesn't return the entire entry. Based on feedback in PR review, the full entry is not used by the caller, and accessing the fields wouldn't be safe outside the lock, so it is safer to return only the Materializer	4 years ago
Daniel Nephin	46b7d0b573	submatview: godoc	4 years ago
Daniel Nephin	d9537411b8	rpcclient/health: convert tests to the new submatview.Store interface ... Also fixes a minor data race in Materializer. Capture the error before releasing the lock.	4 years ago
Daniel Nephin	79a54f208e	agent: fix data race in tests caused by grpc log init ... grpclog.SetLoggerV2 is meant to be called only once before any gRPC requests are received, but each test that uses TestAgent will call NewBaseDeps again. Use a sync.Once to prevent the grpc logging from being re-initialized by each test. This will mean that a test can't use a fake logger to capture logs from the gRPC server.	4 years ago
Daniel Nephin	dacf50038d	submatview: fix two flaky tests ... These tests can flake when we get a notification for an earlier event. Retry the read from update channel a few times to make sure we get the event we expect.	4 years ago
Daniel Nephin	a2986ebb9c	sdk/retry: support ending the iteration early ... I've found this feature to be very useful in https://pkg.go.dev/gotest.tools/v3/poll#WaitOn I have encountered a few cases where I wanted that same support, so this commit adds it.	4 years ago
Daniel Nephin	034c5c5f8c	sdk/retry: remove the need to pass args to NextOr	4 years ago
Daniel Nephin	c932833acb	rpcclient:health: fix a data race and flake in tests ... Split the TestStreamingClient into the two logical components the real client uses. This allows us to test multiple clients properly. Previously writing of ctx from multiple Subscribe calls was showing a data race. Once this was fixed a test started to fail because the request had to be made with a greater index, so that the store.Get call did not return immediately.	4 years ago
Daniel Nephin	5fa0dea63a	rpcclient/health: fix data race in a test ... The idleTTL was being written and read concurrently. Instead move the idleTTL to a struct field so that when one test patches the TTL it does not impact others. The background goroutines for the store can outlive a test because context cancellation is async.	4 years ago
Daniel Nephin	10ec9c2be3	rpcclient: close the grpc.ClientConn on shutdown	4 years ago
Daniel Nephin	e229b877d8	health: create health.Client in Agent.New	4 years ago
Daniel Nephin	a16c377ca7	rpcclient/health: move all backend routing logic to client	4 years ago
Daniel Nephin	0558586dbd	health: use blocking queries for near query parameter	4 years ago
Daniel Nephin	2a26085b2c	connect: do not set QuerySource.Node ... Setting this field to a value is equivalent to using the 'near' query paramter. The intent is to sort the results by proximity to the node requesting them. However with connect we send the results to envoy, which doesn't care about the order, so setting this field is increasing the work performed for no gain. It is necessary to unset this field now because we would like connect to use streaming, but streaming does not support sorting by proximity.	4 years ago
Daniel Nephin	4fb2ba9de7	submatview: move error return to NewMaterializer ... So that we don't have to create views ahead of time, when we will never use that view.	4 years ago
Daniel Nephin	55a677b7d1	rpcclient/health: integrate submatview.Store into rpcclient/health	4 years ago
Daniel Nephin	6f29fa0de8	rpcclient: move streaming cache tests	4 years ago
Daniel Nephin	6ebb0f8b74	submatview: test Store.Run	4 years ago
Daniel Nephin	9854c424eb	submatview: test store with Get and Notify calls together	4 years ago
Daniel Nephin	c1063999fc	submatview: more test cases for Store.Get ... And simplify the return value by using a Result type.	4 years ago
Daniel Nephin	832f1a2847	submatview: reduce the getFromView implementation ... Remove View.Result error return value, it was always nil, and seems like it will likely always remain nill since it is simply reading a stored value. Also replace some cache types with local types.	4 years ago
Daniel Nephin	1d9d7d0aa5	submatview: track requests instead of notifiers ... And only start expiration time when the last request ends. This makes tracking expiry simpler, and ensures that no entry can be expired while there are active requests.	4 years ago
Daniel Nephin	7d13465c7b	submatview: set up expiry of materializers	4 years ago
Daniel Nephin	c574108354	submatview: setup testing structure	4 years ago
Daniel Nephin	ddddbdb990	submatview: rough outline of the Get and Notify methods.	4 years ago